René's URL Explorer Experiment


Title: fix(elements): update the view of an `OnPush` component when inputs change by gkalpak · Pull Request #39452 · angular/angular · GitHub

Open Graph Title: fix(elements): update the view of an `OnPush` component when inputs change by gkalpak · Pull Request #39452 · angular/angular

X Title: fix(elements): update the view of an `OnPush` component when inputs change by gkalpak · Pull Request #39452 · angular/angular

Description: As with regular Angular components, Angular elements are expected to have their views update when inputs change. Previously, Angular Elements views where not update if the underlying component used the OnPush change detection strategy. This commit fixes this by calling markForCheck() on the component view's ChangeDetectorRef. NOTE: This is similar to how @angular/upgrade does it: angular/packages/upgrade/src/common/src/downgrade_component_adapter.ts Line 146 in 3236ae0 this.viewChangeDetector.markForCheck(); . Fixes #38948. This PR also contains some commit the fix/improve the elements tests (both unit and e2e tests). See individual commits for more details.

Open Graph Description: As with regular Angular components, Angular elements are expected to have their views update when inputs change. Previously, Angular Elements views where not update if the underlying component used...

X Description: As with regular Angular components, Angular elements are expected to have their views update when inputs change. Previously, Angular Elements views where not update if the underlying component used...

Opengraph URL: https://github.com/angular/angular/pull/39452

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:928a46f5-b785-3605-8406-3d8077fb5380
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idED32:96DDF:D99FD0:1149368:6B010200
html-safe-noncecaa0f36c65f8e739afa57ed88ca538dac27334582c2ac2d88c915ffafd21cc67
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDMyOjk2RERGOkQ5OUZEMDoxMTQ5MzY4OjZCMDEwMjAwIiwidmlzaXRvcl9pZCI6IjU3NjU3MTc1MzIzMzQ0OTQ3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccfea5b93dd401a9b9dd97bbe5cf03b8c0e7b310d0d00c2bc8c7a6023dc7da6ab
hovercard-subject-tagpull_request:510830363
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/39452/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altAs with regular Angular components, Angular elements are expected to have their views update when inputs change. Previously, Angular Elements views where not update if the underlying component used...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/39452/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39452%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39452%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/39452/files
Reloadhttps://github.com/angular/angular/pull/39452/files
Reloadhttps://github.com/angular/angular/pull/39452/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-elements-cd-OnPushhttps://github.com/gkalpak/angular/tree/fix-elements-cd-OnPush
Conversation 20 https://github.com/angular/angular/pull/39452
Commits 6 https://github.com/angular/angular/pull/39452/commits
Checks 0 https://github.com/angular/angular/pull/39452/checks
Files changed https://github.com/angular/angular/pull/39452/files
Please reload this pagehttps://github.com/angular/angular/pull/39452/files
fix(elements): update the view of an OnPush component when inputs change https://github.com/angular/angular/pull/39452/files#top
Show all changes 6 commits https://github.com/angular/angular/pull/39452/files
85134ab test(elements): fix typo in test description (`even if when` --> `eve… gkalpak Nov 4, 2020 https://github.com/angular/angular/pull/39452/commits/85134ab0b7710c9c2e8526bb5019eadf3fe3cf7f
5b2a685 test(elements): simplify creation of `FakeComponentFactory#componentRef` gkalpak Nov 4, 2020 https://github.com/angular/angular/pull/39452/commits/5b2a685bb644284c11be8ef269fbfc69d0f98731
09124f0 test(elements): fix `ComponentNgElementStrategy` test for components … gkalpak Nov 4, 2020 https://github.com/angular/angular/pull/39452/commits/09124f0a8a2079817bbbda6e75e3967448e5baa1
cbb0adc test(elements): add integration tests for Angular Elements using `Sha… gkalpak Nov 4, 2020 https://github.com/angular/angular/pull/39452/commits/cbb0adcfcd51ec5024cd72335c9be80008aee1d3
ebc7028 fix(elements): update the view of an `OnPush` component when inputs c… gkalpak Nov 4, 2020 https://github.com/angular/angular/pull/39452/commits/ebc7028d77fe65548aee5643103b64774ffc4cb8
ad13d8b fixup! fix(elements): update the view of an `OnPush` component when i… gkalpak Nov 4, 2020 https://github.com/angular/angular/pull/39452/commits/ad13d8be29efe56d1d7ad25f21984a854c910c06
Clear filters https://github.com/angular/angular/pull/39452/files
Please reload this pagehttps://github.com/angular/angular/pull/39452/files
Please reload this pagehttps://github.com/angular/angular/pull/39452/files
aio-payloads.json https://github.com/angular/angular/pull/39452/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
app.e2e-spec.ts https://github.com/angular/angular/pull/39452/files#diff-bd3c9ea55ee526a553bc66d7045de128bd8af4256a7d4021f8e04cbb4d556f17
app.ts https://github.com/angular/angular/pull/39452/files#diff-8b3b515a0f4b90e05c01b505e03d7d3604ec2ba51d21eeae92e9bc98e4d3382f
elements.ts https://github.com/angular/angular/pull/39452/files#diff-2f3427bcd8ffb10857ba92d3953f0f1c82d8acc450211a5048acfb0b1fb93c0a
hello-world.html https://github.com/angular/angular/pull/39452/files#diff-033a149c27e8fe4e33f40a1aa305b6a20c90ee7c39b9ed3e80200be0c27b9e90
main.ts https://github.com/angular/angular/pull/39452/files#diff-7349229e3ae08bac12e4ff938624b5874c1101357ef2db365b75c5f4c7b04e11
component-factory-strategy.ts https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
component-factory-strategy_spec.ts https://github.com/angular/angular/pull/39452/files#diff-6d1310555f071b36cc7d0d0252cd276db348308ab47a339aed82ba149e3fd1ce
create-custom-element_spec.ts https://github.com/angular/angular/pull/39452/files#diff-925ba1e98dda46b62eb16a77f04ed6fda9260888435d03405f767d9995518501
goldens/size-tracking/aio-payloads.jsonhttps://github.com/angular/angular/pull/39452/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
View file https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/goldens/size-tracking/aio-payloads.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39452/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39452/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
gkalpakhttps://github.com/gkalpak
Nov 4, 2020https://github.com/angular/angular/pull/39452/files#r517578009
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
448645https://app.circleci.com/pipelines/github/angular/angular/24192/workflows/1f86d952-a813-4e00-8aba-11c2420c18dc/jobs/850932
448922https://app.circleci.com/pipelines/github/angular/angular/24189/workflows/03d37062-e9d7-401e-a563-7a386db54994/jobs/850877
Please reload this pagehttps://github.com/angular/angular/pull/39452/files
https://github.com/angular/angular/pull/39452/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
gkalpakhttps://github.com/gkalpak
Nov 4, 2020https://github.com/angular/angular/pull/39452/files#r517578751
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
431922https://app.circleci.com/pipelines/github/angular/angular/24192/workflows/1f86d952-a813-4e00-8aba-11c2420c18dc/jobs/850934
432199https://app.circleci.com/pipelines/github/angular/angular/24189/workflows/03d37062-e9d7-401e-a563-7a386db54994/jobs/850878
Please reload this pagehttps://github.com/angular/angular/pull/39452/files
https://github.com/angular/angular/pull/39452/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
integration/ng_elements/e2e/app.e2e-spec.tshttps://github.com/angular/angular/pull/39452/files#diff-bd3c9ea55ee526a553bc66d7045de128bd8af4256a7d4021f8e04cbb4d556f17
View file https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/integration/ng_elements/e2e/app.e2e-spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39452/{{ revealButtonHref }}
integration/ng_elements/src/app.tshttps://github.com/angular/angular/pull/39452/files#diff-8b3b515a0f4b90e05c01b505e03d7d3604ec2ba51d21eeae92e9bc98e4d3382f
View file https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/integration/ng_elements/src/app.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39452/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39452/files#diff-8b3b515a0f4b90e05c01b505e03d7d3604ec2ba51d21eeae92e9bc98e4d3382f
https://github.com/angular/angular/pull/39452/files#diff-8b3b515a0f4b90e05c01b505e03d7d3604ec2ba51d21eeae92e9bc98e4d3382f
integration/ng_elements/src/elements.tshttps://github.com/angular/angular/pull/39452/files#diff-2f3427bcd8ffb10857ba92d3953f0f1c82d8acc450211a5048acfb0b1fb93c0a
View file https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/integration/ng_elements/src/elements.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39452/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39452/files#diff-2f3427bcd8ffb10857ba92d3953f0f1c82d8acc450211a5048acfb0b1fb93c0a
integration/ng_elements/src/hello-world.htmlhttps://github.com/angular/angular/pull/39452/files#diff-033a149c27e8fe4e33f40a1aa305b6a20c90ee7c39b9ed3e80200be0c27b9e90
View file https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/integration/ng_elements/src/hello-world.html
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39452/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39452/files#diff-033a149c27e8fe4e33f40a1aa305b6a20c90ee7c39b9ed3e80200be0c27b9e90
integration/ng_elements/src/main.tshttps://github.com/angular/angular/pull/39452/files#diff-7349229e3ae08bac12e4ff938624b5874c1101357ef2db365b75c5f4c7b04e11
View file https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/integration/ng_elements/src/main.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39452/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39452/files#diff-7349229e3ae08bac12e4ff938624b5874c1101357ef2db365b75c5f4c7b04e11
packages/elements/src/component-factory-strategy.tshttps://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
View file https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/packages/elements/src/component-factory-strategy.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/39452/{{ revealButtonHref }}
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9
Please reload this pagehttps://github.com/angular/angular/pull/39452/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.