| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:928a46f5-b785-3605-8406-3d8077fb5380 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ED32:96DDF:D99FD0:1149368:6B010200 |
| html-safe-nonce | caa0f36c65f8e739afa57ed88ca538dac27334582c2ac2d88c915ffafd21cc67 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDMyOjk2RERGOkQ5OUZEMDoxMTQ5MzY4OjZCMDEwMjAwIiwidmlzaXRvcl9pZCI6IjU3NjU3MTc1MzIzMzQ0OTQ3MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cfea5b93dd401a9b9dd97bbe5cf03b8c0e7b310d0d00c2bc8c7a6023dc7da6ab |
| hovercard-subject-tag | pull_request:510830363 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/39452/files |
| twitter:image | https://avatars.githubusercontent.com/u/8604205?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8604205?s=400&v=4 |
| og:image:alt | As with regular Angular components, Angular elements are expected to have their views update when inputs change.
Previously, Angular Elements views where not update if the underlying component used... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/39452/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39452%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39452%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/39452/files |
| Reload | https://github.com/angular/angular/pull/39452/files |
| Reload | https://github.com/angular/angular/pull/39452/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-elements-cd-OnPush | https://github.com/gkalpak/angular/tree/fix-elements-cd-OnPush |
|
Conversation
20
| https://github.com/angular/angular/pull/39452 |
|
Commits
6
| https://github.com/angular/angular/pull/39452/commits |
|
Checks
0
| https://github.com/angular/angular/pull/39452/checks |
|
Files changed
| https://github.com/angular/angular/pull/39452/files |
| Please reload this page | https://github.com/angular/angular/pull/39452/files |
|
fix(elements): update the view of an OnPush component when inputs change
| https://github.com/angular/angular/pull/39452/files#top |
|
Show all changes
6 commits
| https://github.com/angular/angular/pull/39452/files |
|
85134ab
test(elements): fix typo in test description (`even if when` --> `eve…
gkalpak Nov 4, 2020
| https://github.com/angular/angular/pull/39452/commits/85134ab0b7710c9c2e8526bb5019eadf3fe3cf7f |
|
5b2a685
test(elements): simplify creation of `FakeComponentFactory#componentRef`
gkalpak Nov 4, 2020
| https://github.com/angular/angular/pull/39452/commits/5b2a685bb644284c11be8ef269fbfc69d0f98731 |
|
09124f0
test(elements): fix `ComponentNgElementStrategy` test for components …
gkalpak Nov 4, 2020
| https://github.com/angular/angular/pull/39452/commits/09124f0a8a2079817bbbda6e75e3967448e5baa1 |
|
cbb0adc
test(elements): add integration tests for Angular Elements using `Sha…
gkalpak Nov 4, 2020
| https://github.com/angular/angular/pull/39452/commits/cbb0adcfcd51ec5024cd72335c9be80008aee1d3 |
|
ebc7028
fix(elements): update the view of an `OnPush` component when inputs c…
gkalpak Nov 4, 2020
| https://github.com/angular/angular/pull/39452/commits/ebc7028d77fe65548aee5643103b64774ffc4cb8 |
|
ad13d8b
fixup! fix(elements): update the view of an `OnPush` component when i…
gkalpak Nov 4, 2020
| https://github.com/angular/angular/pull/39452/commits/ad13d8be29efe56d1d7ad25f21984a854c910c06 |
|
Clear filters
| https://github.com/angular/angular/pull/39452/files |
| Please reload this page | https://github.com/angular/angular/pull/39452/files |
| Please reload this page | https://github.com/angular/angular/pull/39452/files |
|
aio-payloads.json
| https://github.com/angular/angular/pull/39452/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858 |
|
app.e2e-spec.ts
| https://github.com/angular/angular/pull/39452/files#diff-bd3c9ea55ee526a553bc66d7045de128bd8af4256a7d4021f8e04cbb4d556f17 |
|
app.ts
| https://github.com/angular/angular/pull/39452/files#diff-8b3b515a0f4b90e05c01b505e03d7d3604ec2ba51d21eeae92e9bc98e4d3382f |
|
elements.ts
| https://github.com/angular/angular/pull/39452/files#diff-2f3427bcd8ffb10857ba92d3953f0f1c82d8acc450211a5048acfb0b1fb93c0a |
|
hello-world.html
| https://github.com/angular/angular/pull/39452/files#diff-033a149c27e8fe4e33f40a1aa305b6a20c90ee7c39b9ed3e80200be0c27b9e90 |
|
main.ts
| https://github.com/angular/angular/pull/39452/files#diff-7349229e3ae08bac12e4ff938624b5874c1101357ef2db365b75c5f4c7b04e11 |
|
component-factory-strategy.ts
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
component-factory-strategy_spec.ts
| https://github.com/angular/angular/pull/39452/files#diff-6d1310555f071b36cc7d0d0252cd276db348308ab47a339aed82ba149e3fd1ce |
|
create-custom-element_spec.ts
| https://github.com/angular/angular/pull/39452/files#diff-925ba1e98dda46b62eb16a77f04ed6fda9260888435d03405f767d9995518501 |
| goldens/size-tracking/aio-payloads.json | https://github.com/angular/angular/pull/39452/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858 |
|
View file
| https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/goldens/size-tracking/aio-payloads.json |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/39452/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/39452/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858 |
| gkalpak | https://github.com/gkalpak |
| Nov 4, 2020 | https://github.com/angular/angular/pull/39452/files#r517578009 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 448645 | https://app.circleci.com/pipelines/github/angular/angular/24192/workflows/1f86d952-a813-4e00-8aba-11c2420c18dc/jobs/850932 |
| 448922 | https://app.circleci.com/pipelines/github/angular/angular/24189/workflows/03d37062-e9d7-401e-a563-7a386db54994/jobs/850877 |
| Please reload this page | https://github.com/angular/angular/pull/39452/files |
|
| https://github.com/angular/angular/pull/39452/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858 |
| gkalpak | https://github.com/gkalpak |
| Nov 4, 2020 | https://github.com/angular/angular/pull/39452/files#r517578751 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 431922 | https://app.circleci.com/pipelines/github/angular/angular/24192/workflows/1f86d952-a813-4e00-8aba-11c2420c18dc/jobs/850934 |
| 432199 | https://app.circleci.com/pipelines/github/angular/angular/24189/workflows/03d37062-e9d7-401e-a563-7a386db54994/jobs/850878 |
| Please reload this page | https://github.com/angular/angular/pull/39452/files |
|
| https://github.com/angular/angular/pull/39452/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858 |
| integration/ng_elements/e2e/app.e2e-spec.ts | https://github.com/angular/angular/pull/39452/files#diff-bd3c9ea55ee526a553bc66d7045de128bd8af4256a7d4021f8e04cbb4d556f17 |
|
View file
| https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/integration/ng_elements/e2e/app.e2e-spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/39452/{{ revealButtonHref }} |
| integration/ng_elements/src/app.ts | https://github.com/angular/angular/pull/39452/files#diff-8b3b515a0f4b90e05c01b505e03d7d3604ec2ba51d21eeae92e9bc98e4d3382f |
|
View file
| https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/integration/ng_elements/src/app.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/39452/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/39452/files#diff-8b3b515a0f4b90e05c01b505e03d7d3604ec2ba51d21eeae92e9bc98e4d3382f |
|
| https://github.com/angular/angular/pull/39452/files#diff-8b3b515a0f4b90e05c01b505e03d7d3604ec2ba51d21eeae92e9bc98e4d3382f |
| integration/ng_elements/src/elements.ts | https://github.com/angular/angular/pull/39452/files#diff-2f3427bcd8ffb10857ba92d3953f0f1c82d8acc450211a5048acfb0b1fb93c0a |
|
View file
| https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/integration/ng_elements/src/elements.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/39452/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/39452/files#diff-2f3427bcd8ffb10857ba92d3953f0f1c82d8acc450211a5048acfb0b1fb93c0a |
| integration/ng_elements/src/hello-world.html | https://github.com/angular/angular/pull/39452/files#diff-033a149c27e8fe4e33f40a1aa305b6a20c90ee7c39b9ed3e80200be0c27b9e90 |
|
View file
| https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/integration/ng_elements/src/hello-world.html |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/39452/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/39452/files#diff-033a149c27e8fe4e33f40a1aa305b6a20c90ee7c39b9ed3e80200be0c27b9e90 |
| integration/ng_elements/src/main.ts | https://github.com/angular/angular/pull/39452/files#diff-7349229e3ae08bac12e4ff938624b5874c1101357ef2db365b75c5f4c7b04e11 |
|
View file
| https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/integration/ng_elements/src/main.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/39452/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/39452/files#diff-7349229e3ae08bac12e4ff938624b5874c1101357ef2db365b75c5f4c7b04e11 |
| packages/elements/src/component-factory-strategy.ts | https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
View file
| https://github.com/gkalpak/angular/blob/ad13d8be29efe56d1d7ad25f21984a854c910c06/packages/elements/src/component-factory-strategy.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/39452/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
|
| https://github.com/angular/angular/pull/39452/files#diff-7bcc24b51955f1d99c62d70e833c71b0d92e5ec667c767c8caca9730cc78c1f9 |
| Please reload this page | https://github.com/angular/angular/pull/39452/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |