| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:678caeb5-6c6b-04c9-44d9-77b3344a6509 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9DDC:1087D4:BE1BDC:FEACCB:6B00F9A9 |
| html-safe-nonce | 8cc25ffb69ca8eb424fcfc518985bab53e3376ac0ab6109c9bba56b145969407 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5RERDOjEwODdENDpCRTFCREM6RkVBQ0NCOjZCMDBGOUE5IiwidmlzaXRvcl9pZCI6Ijc4NDE3Njg3NTQxNjkwNTE1NjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | f136c75d3f41ffb458bbe7da8a091cafb799452a9bc1c3936f3c0d983b63e9ec |
| hovercard-subject-tag | pull_request:510830363 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/39452/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/74d2fdb2a626d919ac9bfbdc2dee9d62bfa33ffd0f49217f78d26f71e71c1150/angular/angular/pull/39452 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/74d2fdb2a626d919ac9bfbdc2dee9d62bfa33ffd0f49217f78d26f71e71c1150/angular/angular/pull/39452 |
| og:image:alt | As with regular Angular components, Angular elements are expected to have their views update when inputs change.
Previously, Angular Elements views where not update if the underlying component used... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/39452#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39452 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39452 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/39452 |
| Reload | https://github.com/angular/angular/pull/39452 |
| Reload | https://github.com/angular/angular/pull/39452 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-elements-cd-OnPush | https://github.com/gkalpak/angular/tree/fix-elements-cd-OnPush |
| Conversation | https://github.com/angular/angular/pull/39452 |
| Commits6 (6) | https://github.com/angular/angular/pull/39452/commits |
| Checks | https://github.com/angular/angular/pull/39452/checks |
| Files changed | https://github.com/angular/angular/pull/39452/files |
| fix(elements): update the view of an OnPush component when inputs change | https://github.com/angular/angular/pull/39452#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:fix-elements-cd-OnPush | https://github.com/gkalpak/angular/tree/fix-elements-cd-OnPush |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Oct 27, 2020 | https://github.com/angular/angular/pull/39452#issue-730543715 |
| angular/packages/upgrade/src/common/src/downgrade_component_adapter.ts | https://github.com/angular/angular/blob/3236ae0ee118d0734c90fa9f3767435396213470/packages/upgrade/src/common/src/downgrade_component_adapter.ts#L146 |
| 3236ae0 | https://github.com/angular/angular/commit/3236ae0ee118d0734c90fa9f3767435396213470 |
| #38948 | https://github.com/angular/angular/issues/38948 |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
action: discuss
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20discuss%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
area: elements
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22 |
| Oct 27, 2020 | https://github.com/angular/angular/pull/39452#event-3926498059 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Oct 27, 2020 | https://github.com/angular/angular/pull/39452#event-3926498256 |
| https://github.com/apps/google-cla |
| google-cla | https://github.com/apps/google-cla |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Oct 27, 2020 | https://github.com/angular/angular/pull/39452#event-3926498855 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 27, 2020 | https://github.com/angular/angular/pull/39452#issuecomment-717320446 |
| https://pr39452-02a11b6.ngbuilds.io/ | https://pr39452-02a11b6.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/02a11b6cc86717e4ba4fae10464d218eb7d7258b..44dc9301b097b71172570a8e9ecd19556e30a5e1 |
| 02a11b6 | https://github.com/angular/angular/commit/02a11b6cc86717e4ba4fae10464d218eb7d7258b |
| 44dc930 | https://github.com/angular/angular/commit/44dc9301b097b71172570a8e9ecd19556e30a5e1 |
|
Compare
| https://github.com/angular/angular/compare/02a11b6cc86717e4ba4fae10464d218eb7d7258b..44dc9301b097b71172570a8e9ecd19556e30a5e1 |
| October 27, 2020 15:26 | https://github.com/angular/angular/pull/39452#event-3926574227 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Oct 27, 2020
| https://github.com/angular/angular/pull/39452#ref-issue-707356883 |
|
Angular/elements OnPush input changes does not trigger change detection
#38948
| https://github.com/angular/angular/issues/38948 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 27, 2020 | https://github.com/angular/angular/pull/39452#issuecomment-717329182 |
| https://pr39452-44dc930.ngbuilds.io/ | https://pr39452-44dc930.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/44dc9301b097b71172570a8e9ecd19556e30a5e1..ed44a83fed319a40cd0d48365136135860d746e5 |
| 44dc930 | https://github.com/angular/angular/commit/44dc9301b097b71172570a8e9ecd19556e30a5e1 |
| ed44a83 | https://github.com/angular/angular/commit/ed44a83fed319a40cd0d48365136135860d746e5 |
|
Compare
| https://github.com/angular/angular/compare/44dc9301b097b71172570a8e9ecd19556e30a5e1..ed44a83fed319a40cd0d48365136135860d746e5 |
| October 27, 2020 16:26 | https://github.com/angular/angular/pull/39452#event-3926912222 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 27, 2020 | https://github.com/angular/angular/pull/39452#issuecomment-717369348 |
| https://pr39452-ed44a83.ngbuilds.io/ | https://pr39452-ed44a83.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Oct 27, 2020
| https://github.com/angular/angular/pull/39452#pullrequestreview-517921588 |
|
View reviewed changes
| https://github.com/angular/angular/pull/39452/files |
| goldens/size-tracking/aio-payloads.json | https://github.com/angular/angular/pull/39452/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858 |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Oct 27, 2020
| https://github.com/angular/angular/pull/39452#pullrequestreview-517922870 |
|
View reviewed changes
| https://github.com/angular/angular/pull/39452/files |
| goldens/size-tracking/aio-payloads.json | https://github.com/angular/angular/pull/39452/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858 |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| October 27, 2020 17:24 | https://github.com/angular/angular/pull/39452#event-3927199584 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| josephperrott | https://github.com/josephperrott |
| October 27, 2020 17:24 | https://github.com/angular/angular/pull/39452#event-3927200441 |
| https://github.com/josephperrott |
| josephperrott | https://github.com/josephperrott |
|
Oct 27, 2020
| https://github.com/angular/angular/pull/39452#pullrequestreview-517972675 |
|
View reviewed changes
| https://github.com/angular/angular/pull/39452/files |
| josephperrott | https://github.com/josephperrott |
| https://github.com/angular/angular/pull/39452#pullrequestreview-517972675 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| alxhub | https://github.com/alxhub |
| atscott | https://github.com/atscott |
| jelbourn | https://github.com/jelbourn |
| petebacondarwin | https://github.com/petebacondarwin |
| October 27, 2020 17:33 | https://github.com/angular/angular/pull/39452#event-3927241687 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Oct 27, 2020
| https://github.com/angular/angular/pull/39452#pullrequestreview-518128097 |
|
View reviewed changes
| https://github.com/angular/angular/pull/39452/files |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/39452#pullrequestreview-518128097 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| IgorMinar | https://github.com/IgorMinar |
| October 27, 2020 20:47 | https://github.com/angular/angular/pull/39452#event-3928088622 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/ed44a83fed319a40cd0d48365136135860d746e5..68ab8211f2bdb32ae1ff8167ae3f01f0f20dc74d |
| ed44a83 | https://github.com/angular/angular/commit/ed44a83fed319a40cd0d48365136135860d746e5 |
| 68ab821 | https://github.com/angular/angular/commit/68ab8211f2bdb32ae1ff8167ae3f01f0f20dc74d |
|
Compare
| https://github.com/angular/angular/compare/ed44a83fed319a40cd0d48365136135860d746e5..68ab8211f2bdb32ae1ff8167ae3f01f0f20dc74d |
| October 27, 2020 21:03 | https://github.com/angular/angular/pull/39452#event-3928155673 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Oct 27, 2020
| https://github.com/angular/angular/pull/39452#pullrequestreview-518140678 |
|
View reviewed changes
| https://github.com/angular/angular/pull/39452/files |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/39452#pullrequestreview-518140678 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| packages/elements/test/component-factory-strategy_spec.ts | https://github.com/angular/angular/pull/39452/files#diff-6d1310555f071b36cc7d0d0252cd276db348308ab47a339aed82ba149e3fd1ce |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Oct 27, 2020 | https://github.com/angular/angular/pull/39452#issuecomment-717543920 |
| https://pr39452-68ab821.ngbuilds.io/ | https://pr39452-68ab821.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/dd1ee409415b10a9786fdcbcb84f0a83358eee98..ad13d8be29efe56d1d7ad25f21984a854c910c06 |
| dd1ee40 | https://github.com/angular/angular/commit/dd1ee409415b10a9786fdcbcb84f0a83358eee98 |
| ad13d8b | https://github.com/angular/angular/commit/ad13d8be29efe56d1d7ad25f21984a854c910c06 |
|
Compare
| https://github.com/angular/angular/compare/dd1ee409415b10a9786fdcbcb84f0a83358eee98..ad13d8be29efe56d1d7ad25f21984a854c910c06 |
| November 4, 2020 19:19 | https://github.com/angular/angular/pull/39452#event-3959113274 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Nov 4, 2020
| https://github.com/angular/angular/pull/39452#pullrequestreview-523667202 |
|
View reviewed changes
| https://github.com/angular/angular/pull/39452/files/ad13d8be29efe56d1d7ad25f21984a854c910c06 |
| goldens/size-tracking/aio-payloads.json | https://github.com/angular/angular/pull/39452/files/ad13d8be29efe56d1d7ad25f21984a854c910c06#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858 |
| gkalpak | https://github.com/gkalpak |
| Nov 4, 2020 | https://github.com/angular/angular/pull/39452#discussion_r517578009 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 448645 | https://app.circleci.com/pipelines/github/angular/angular/24192/workflows/1f86d952-a813-4e00-8aba-11c2420c18dc/jobs/850932 |
| 448922 | https://app.circleci.com/pipelines/github/angular/angular/24189/workflows/03d37062-e9d7-401e-a563-7a386db54994/jobs/850877 |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Nov 4, 2020
| https://github.com/angular/angular/pull/39452#pullrequestreview-523668190 |
|
View reviewed changes
| https://github.com/angular/angular/pull/39452/files/ad13d8be29efe56d1d7ad25f21984a854c910c06 |
| goldens/size-tracking/aio-payloads.json | https://github.com/angular/angular/pull/39452/files/ad13d8be29efe56d1d7ad25f21984a854c910c06#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858 |
| gkalpak | https://github.com/gkalpak |
| Nov 4, 2020 | https://github.com/angular/angular/pull/39452#discussion_r517578751 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| 431922 | https://app.circleci.com/pipelines/github/angular/angular/24192/workflows/1f86d952-a813-4e00-8aba-11c2420c18dc/jobs/850934 |
| 432199 | https://app.circleci.com/pipelines/github/angular/angular/24189/workflows/03d37062-e9d7-401e-a563-7a386db54994/jobs/850878 |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: discuss
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20discuss%22 |
| Nov 4, 2020 | https://github.com/angular/angular/pull/39452#event-3959135534 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Nov 4, 2020 | https://github.com/angular/angular/pull/39452#issuecomment-721929778 |
| ad13d8b | https://github.com/angular/angular/commit/ad13d8be29efe56d1d7ad25f21984a854c910c06 |
| https://pr39452-ad13d8b.ngbuilds.io/ | https://pr39452-ad13d8b.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: rerun CI at HEAD
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20rerun%20CI%20at%20HEAD%22 |
| Nov 4, 2020 | https://github.com/angular/angular/pull/39452#event-3959412545 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
|
action: rerun CI at HEAD
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20rerun%20CI%20at%20HEAD%22 |
| Nov 4, 2020 | https://github.com/angular/angular/pull/39452#event-3959412667 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
| Nov 5, 2020 | https://github.com/angular/angular/pull/39452#event-3962559278 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Nov 5, 2020 | https://github.com/angular/angular/pull/39452#issuecomment-722544252 |
| global presubmit | https://test.corp.google.com/ui#id=OCL:340874556:BASE:340874705:1604599375421:32d7e440 |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| mhevery | https://github.com/mhevery |
|
Nov 6, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-0319fc7 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| test(elements): fix typo in test description (even if when --> `eve… | https://github.com/angular/angular/commit/0319fc7656898881767ba4193d7b66f54c262a55 |
| 0319fc7 | https://github.com/angular/angular/commit/0319fc7656898881767ba4193d7b66f54c262a55 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| mhevery | https://github.com/mhevery |
|
Nov 6, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-62457ca |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| test(elements): simplify creation of `FakeComponentFactory#componentR… | https://github.com/angular/angular/commit/62457ca88bc75026a652678f50c2acfa8c85de3f |
| 62457ca | https://github.com/angular/angular/commit/62457ca88bc75026a652678f50c2acfa8c85de3f |
| #39452 | https://github.com/angular/angular/pull/39452 |
| https://jasmine.github.io/api/3.5/jasmine.html#.createSpyObj | https://jasmine.github.io/api/3.5/jasmine.html#.createSpyObj |
| #39452 | https://github.com/angular/angular/pull/39452 |
| mhevery | https://github.com/mhevery |
|
Nov 6, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-ce7d5c4 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| test(elements): fix ComponentNgElementStrategy test for components … | https://github.com/angular/angular/commit/ce7d5c4829f706a3e10d397fbd2f6c7c4b2d6472 |
| ce7d5c4 | https://github.com/angular/angular/commit/ce7d5c4829f706a3e10d397fbd2f6c7c4b2d6472 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| mhevery | https://github.com/mhevery |
|
Nov 6, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-ff925af |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| test(elements): add integration tests for Angular Elements using `Sha… | https://github.com/angular/angular/commit/ff925af90811376574c9ebb2408abeeeb978cef1 |
| ff925af | https://github.com/angular/angular/commit/ff925af90811376574c9ebb2408abeeeb978cef1 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| mhevery | https://github.com/mhevery |
|
Nov 6, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-dd28855 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| fix(elements): update the view of an OnPush component when inputs c… | https://github.com/angular/angular/commit/dd28855455bad294282ed1c4e0bc55b7fca0f9b9 |
| dd28855 | https://github.com/angular/angular/commit/dd28855455bad294282ed1c4e0bc55b7fca0f9b9 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| https://github.com/angular/angular/blob/3236ae0ee118d0734c90fa9f3767435396213470/packages/upgrade/src/common/src/downgrade_component_adapter.ts#L146 | https://github.com/angular/angular/blob/3236ae0ee118d0734c90fa9f3767435396213470/packages/upgrade/src/common/src/downgrade_component_adapter.ts#L146 |
| #38948 | https://github.com/angular/angular/issues/38948 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| 5540fc7 | https://github.com/angular/angular/commit/5540fc718ab2b9924f4ee8397229d439c5bab6d0 |
| Nov 6, 2020 | https://github.com/angular/angular/pull/39452#event-3968248229 |
| mhevery | https://github.com/mhevery |
|
Nov 6, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-f606872 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| test(elements): simplify creation of `FakeComponentFactory#componentR… | https://github.com/angular/angular/commit/f60687220b9f73cc3bfe183456408533e5f3f7e3 |
| f606872 | https://github.com/angular/angular/commit/f60687220b9f73cc3bfe183456408533e5f3f7e3 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| https://jasmine.github.io/api/3.5/jasmine.html#.createSpyObj | https://jasmine.github.io/api/3.5/jasmine.html#.createSpyObj |
| #39452 | https://github.com/angular/angular/pull/39452 |
| mhevery | https://github.com/mhevery |
|
Nov 6, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-9cd2741 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| test(elements): fix ComponentNgElementStrategy test for components … | https://github.com/angular/angular/commit/9cd2741d6c005602910f39f5cdbc7dc5a746ce2e |
| 9cd2741 | https://github.com/angular/angular/commit/9cd2741d6c005602910f39f5cdbc7dc5a746ce2e |
| #39452 | https://github.com/angular/angular/pull/39452 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| mhevery | https://github.com/mhevery |
|
Nov 6, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-c190780 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| test(elements): add integration tests for Angular Elements using `Sha… | https://github.com/angular/angular/commit/c1907809a8ea294e7d6d27856364a499a5b7e725 |
| c190780 | https://github.com/angular/angular/commit/c1907809a8ea294e7d6d27856364a499a5b7e725 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| mhevery | https://github.com/mhevery |
|
Nov 6, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-bdce769 |
|
| https://github.com/gkalpak |
|
| https://github.com/mhevery |
| fix(elements): update the view of an OnPush component when inputs c… | https://github.com/angular/angular/commit/bdce7698fc2a49d31d90ae15a4f5629d00dd3085 |
| bdce769 | https://github.com/angular/angular/commit/bdce7698fc2a49d31d90ae15a4f5629d00dd3085 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| https://github.com/angular/angular/blob/3236ae0ee118d0734c90fa9f3767435396213470/packages/upgrade/src/common/src/downgrade_component_adapter.ts#L146 | https://github.com/angular/angular/blob/3236ae0ee118d0734c90fa9f3767435396213470/packages/upgrade/src/common/src/downgrade_component_adapter.ts#L146 |
| #38948 | https://github.com/angular/angular/issues/38948 |
| #39452 | https://github.com/angular/angular/pull/39452 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| November 7, 2020 13:48 | https://github.com/angular/angular/pull/39452#event-3969911509 |
| gkalpak | https://github.com/gkalpak |
|
Nov 7, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-54c3d86 |
|
| https://github.com/gkalpak |
| test(elements): fix typo in test description (even if when --> `eve… | https://github.com/gkalpak/angular/commit/54c3d8620a40098f644dbf2865fb382193ca5e9b |
| 54c3d86 | https://github.com/gkalpak/angular/commit/54c3d8620a40098f644dbf2865fb382193ca5e9b |
| angular#39452 | https://github.com/angular/angular/pull/39452 |
| angular#39452 | https://github.com/angular/angular/pull/39452 |
| gkalpak | https://github.com/gkalpak |
|
Nov 7, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-f3148b6 |
|
| https://github.com/gkalpak |
| test(elements): simplify creation of `FakeComponentFactory#componentR… | https://github.com/gkalpak/angular/commit/f3148b64efebe3407015a0615402c2fbca4a7407 |
| f3148b6 | https://github.com/gkalpak/angular/commit/f3148b64efebe3407015a0615402c2fbca4a7407 |
| angular#39452 | https://github.com/angular/angular/pull/39452 |
| https://jasmine.github.io/api/3.5/jasmine.html#.createSpyObj | https://jasmine.github.io/api/3.5/jasmine.html#.createSpyObj |
| angular#39452 | https://github.com/angular/angular/pull/39452 |
| gkalpak | https://github.com/gkalpak |
|
Nov 7, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-e797be9 |
|
| https://github.com/gkalpak |
| test(elements): fix ComponentNgElementStrategy test for components … | https://github.com/gkalpak/angular/commit/e797be92b8be9a8e3a892e67055aaf84de0e95bd |
| e797be9 | https://github.com/gkalpak/angular/commit/e797be92b8be9a8e3a892e67055aaf84de0e95bd |
| angular#39452 | https://github.com/angular/angular/pull/39452 |
| angular#39452 | https://github.com/angular/angular/pull/39452 |
| gkalpak | https://github.com/gkalpak |
|
Nov 7, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-d993145 |
|
| https://github.com/gkalpak |
| test(elements): add integration tests for Angular Elements using `Sha… | https://github.com/gkalpak/angular/commit/d99314588602d5649b94a8257d7cd9ebb07f6054 |
| d993145 | https://github.com/gkalpak/angular/commit/d99314588602d5649b94a8257d7cd9ebb07f6054 |
| angular#39452 | https://github.com/angular/angular/pull/39452 |
| angular#39452 | https://github.com/angular/angular/pull/39452 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Nov 7, 2020
| https://github.com/angular/angular/pull/39452#ref-pullrequest-738252042 |
|
10.2.x fix elements cd on push
#39598
| https://github.com/angular/angular/pull/39598 |
| gkalpak | https://github.com/gkalpak |
|
Nov 7, 2020
| https://github.com/angular/angular/pull/39452#ref-commit-6c8ff36 |
|
| https://github.com/gkalpak |
| fix(elements): update the view of an OnPush component when inputs c… | https://github.com/gkalpak/angular/commit/6c8ff361440b20564e1782c242b068e7f5ee0666 |
| 6c8ff36 | https://github.com/gkalpak/angular/commit/6c8ff361440b20564e1782c242b068e7f5ee0666 |
| angular#39452 | https://github.com/angular/angular/pull/39452 |
| https://github.com/angular/angular/blob/3236ae0ee118d0734c90fa9f3767435396213470/packages/upgrade/src/common/src/downgrade_component_adapter.ts#L146 | https://github.com/angular/angular/blob/3236ae0ee118d0734c90fa9f3767435396213470/packages/upgrade/src/common/src/downgrade_component_adapter.ts#L146 |
| angular#38948 | https://github.com/angular/angular/issues/38948 |
| angular#39452 | https://github.com/angular/angular/pull/39452 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Dec 8, 2020 | https://github.com/angular/angular/pull/39452#issuecomment-740744563 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Dec 8, 2020 | https://github.com/angular/angular/pull/39452#event-4085650216 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F39452 |
|
| https://github.com/atscott |
|
atscott
| https://github.com/atscott |
|
| https://github.com/angular/angular/pull/39452/files/68ab8211f2bdb32ae1ff8167ae3f01f0f20dc74d |
|
| https://github.com/josephperrott |
|
josephperrott
| https://github.com/josephperrott |
|
| https://github.com/angular/angular/pull/39452/files/ed44a83fed319a40cd0d48365136135860d746e5 |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/39452/files/ed44a83fed319a40cd0d48365136135860d746e5 |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/angular/angular/pull/39452/files/68ab8211f2bdb32ae1ff8167ae3f01f0f20dc74d |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
|
area: elements
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
Angular/elements OnPush input changes does not trigger change detection
| https://github.com/angular/angular/issues/38948 |
| Please reload this page | https://github.com/angular/angular/pull/39452 |
|
| https://github.com/gkalpak |
|
| https://github.com/mary-poppins |
|
| https://github.com/atscott |
|
| https://github.com/petebacondarwin |
|
| https://github.com/IgorMinar |
|
| https://github.com/josephperrott |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |