René's URL Explorer Experiment


Title: feat(common): add historyGo method to Location service by aahmedayed · Pull Request #38890 · angular/angular · GitHub

Open Graph Title: feat(common): add historyGo method to Location service by aahmedayed · Pull Request #38890 · angular/angular

X Title: feat(common): add historyGo method to Location service by aahmedayed · Pull Request #38890 · angular/angular

Description: Add new method historyGo, that will let the user navigate to a specific page from session history identified by its relative position to the current page. We add some tests to location_spec.ts to validate the behavior of the historyGo and forward methods. Add more tests for location_spec to test location.historyGo(0), location.historyGo(), location.historyGo(100) and location.historyGo(-100). We also add new tests for Integration spec to validate the navigation when we using location#historyGo. Update the main-es2015 size limits of aio-local-viewengine in aio-payloads file. Update the historyGo function docs Link for the history API documentation for History#go PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A What is the new behavior? Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: Add new method historyGo, that will let the user navigate to a specific page from session history identified by its relative position to the current page. We add some tests to location_spec.ts to v...

X Description: Add new method historyGo, that will let the user navigate to a specific page from session history identified by its relative position to the current page. We add some tests to location_spec.ts to v...

Opengraph URL: https://github.com/angular/angular/pull/38890

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:23c4ff29-671f-2dc4-f404-53bd21808bde
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC22:2E124E:E4025B:123683D:6B010C46
html-safe-noncef53cfba82e91f99923eb679b547e9d71530fb864a153c42554de74fb9a1bb694
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzIyOjJFMTI0RTpFNDAyNUI6MTIzNjgzRDo2QjAxMEM0NiIsInZpc2l0b3JfaWQiOiI0NTgwNjY3NTkwMzE3MjQ3NTU4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac09054039180f6effb88478ce5f4d162717c62423211407050740b7888442e867
hovercard-subject-tagpull_request:488845987
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/38890/files
twitter:imagehttps://avatars.githubusercontent.com/u/16021173?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/16021173?s=400&v=4
og:image:altAdd new method historyGo, that will let the user navigate to a specific page from session history identified by its relative position to the current page. We add some tests to location_spec.ts to v...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/38890/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38890%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38890%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/38890/files
Reloadhttps://github.com/angular/angular/pull/38890/files
Reloadhttps://github.com/angular/angular/pull/38890/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
aahmedayedhttps://github.com/aahmedayed
angular:masterhttps://github.com/angular/angular/tree/master
aahmedayed:add-go-and-goto-methodeshttps://github.com/aahmedayed/angular/tree/add-go-and-goto-methodes
Conversation 75 https://github.com/angular/angular/pull/38890
Commits 1 https://github.com/angular/angular/pull/38890/commits
Checks 0 https://github.com/angular/angular/pull/38890/checks
Files changed https://github.com/angular/angular/pull/38890/files
Please reload this pagehttps://github.com/angular/angular/pull/38890/files
feat(common): add historyGo method to Location service https://github.com/angular/angular/pull/38890/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/38890/files
dae6f19 feat(common): add `historyGo` method to `Location` service aahmedayed Sep 17, 2020 https://github.com/angular/angular/pull/38890/commits/dae6f19076f00acb7e8b90a4d1765b7420cc967e
Clear filters https://github.com/angular/angular/pull/38890/files
Please reload this pagehttps://github.com/angular/angular/pull/38890/files
Please reload this pagehttps://github.com/angular/angular/pull/38890/files
common.d.ts https://github.com/angular/angular/pull/38890/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
testing.d.ts https://github.com/angular/angular/pull/38890/files#diff-bd9add0e9d34e744382852a14013a7884dd81b67cd2fb8621691576ef9d744da
integration-payloads.json https://github.com/angular/angular/pull/38890/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
hash_location_strategy.ts https://github.com/angular/angular/pull/38890/files#diff-d51e56df6878cef431452722dc0c9ee79b459c5783407ae7bc9863c004a521ea
location.ts https://github.com/angular/angular/pull/38890/files#diff-8a3ef5745f522b08ce333b6bcfb0ed5f8c7fb6ed7ffe06a458b6b437257457ad
location_strategy.ts https://github.com/angular/angular/pull/38890/files#diff-b29e6d118397deca67da99bc72df1e16a332033a8a77e712359a557f8b512ea0
platform_location.ts https://github.com/angular/angular/pull/38890/files#diff-2df340e6601d13bd56954ec5e5d990b0dcb3ae64d62655544a49bc6ca8aaf178
location_spec.ts https://github.com/angular/angular/pull/38890/files#diff-0d46fd646db2e778c2bf6cf9b8b170c55c70c0ae756a008a77be154ed42aedde
location_mock.ts https://github.com/angular/angular/pull/38890/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
mock_platform_location.ts https://github.com/angular/angular/pull/38890/files#diff-fa29c7afa4686ae7c85bb6f489f39e1965e4dedc301216df6caf373266fb743f
integration.spec.ts https://github.com/angular/angular/pull/38890/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
goldens/public-api/common/common.d.tshttps://github.com/angular/angular/pull/38890/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
View file https://github.com/aahmedayed/angular/blob/dae6f19076f00acb7e8b90a4d1765b7420cc967e/goldens/public-api/common/common.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38890/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38890/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
https://github.com/angular/angular/pull/38890/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
https://github.com/angular/angular/pull/38890/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
https://github.com/angular/angular/pull/38890/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
https://github.com/angular/angular/pull/38890/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
https://github.com/angular/angular/pull/38890/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
https://github.com/angular/angular/pull/38890/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
https://github.com/angular/angular/pull/38890/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
https://github.com/angular/angular/pull/38890/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
https://github.com/angular/angular/pull/38890/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
goldens/public-api/common/testing/testing.d.tshttps://github.com/angular/angular/pull/38890/files#diff-bd9add0e9d34e744382852a14013a7884dd81b67cd2fb8621691576ef9d744da
View file https://github.com/aahmedayed/angular/blob/dae6f19076f00acb7e8b90a4d1765b7420cc967e/goldens/public-api/common/testing/testing.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38890/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38890/files#diff-bd9add0e9d34e744382852a14013a7884dd81b67cd2fb8621691576ef9d744da
https://github.com/angular/angular/pull/38890/files#diff-bd9add0e9d34e744382852a14013a7884dd81b67cd2fb8621691576ef9d744da
https://github.com/angular/angular/pull/38890/files#diff-bd9add0e9d34e744382852a14013a7884dd81b67cd2fb8621691576ef9d744da
goldens/size-tracking/integration-payloads.jsonhttps://github.com/angular/angular/pull/38890/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
View file https://github.com/aahmedayed/angular/blob/dae6f19076f00acb7e8b90a4d1765b7420cc967e/goldens/size-tracking/integration-payloads.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38890/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38890/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/38890/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
packages/common/src/location/hash_location_strategy.tshttps://github.com/angular/angular/pull/38890/files#diff-d51e56df6878cef431452722dc0c9ee79b459c5783407ae7bc9863c004a521ea
View file https://github.com/aahmedayed/angular/blob/dae6f19076f00acb7e8b90a4d1765b7420cc967e/packages/common/src/location/hash_location_strategy.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38890/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38890/files#diff-d51e56df6878cef431452722dc0c9ee79b459c5783407ae7bc9863c004a521ea
packages/common/src/location/location.tshttps://github.com/angular/angular/pull/38890/files#diff-8a3ef5745f522b08ce333b6bcfb0ed5f8c7fb6ed7ffe06a458b6b437257457ad
View file https://github.com/aahmedayed/angular/blob/dae6f19076f00acb7e8b90a4d1765b7420cc967e/packages/common/src/location/location.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38890/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38890/files#diff-8a3ef5745f522b08ce333b6bcfb0ed5f8c7fb6ed7ffe06a458b6b437257457ad
https://github.com/angular/angular/pull/38890/files#diff-8a3ef5745f522b08ce333b6bcfb0ed5f8c7fb6ed7ffe06a458b6b437257457ad
packages/common/src/location/location_strategy.tshttps://github.com/angular/angular/pull/38890/files#diff-b29e6d118397deca67da99bc72df1e16a332033a8a77e712359a557f8b512ea0
View file https://github.com/aahmedayed/angular/blob/dae6f19076f00acb7e8b90a4d1765b7420cc967e/packages/common/src/location/location_strategy.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38890/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38890/files#diff-b29e6d118397deca67da99bc72df1e16a332033a8a77e712359a557f8b512ea0
https://github.com/angular/angular/pull/38890/files#diff-b29e6d118397deca67da99bc72df1e16a332033a8a77e712359a557f8b512ea0
https://github.com/angular/angular/pull/38890/files#diff-b29e6d118397deca67da99bc72df1e16a332033a8a77e712359a557f8b512ea0
packages/common/src/location/platform_location.tshttps://github.com/angular/angular/pull/38890/files#diff-2df340e6601d13bd56954ec5e5d990b0dcb3ae64d62655544a49bc6ca8aaf178
View file https://github.com/aahmedayed/angular/blob/dae6f19076f00acb7e8b90a4d1765b7420cc967e/packages/common/src/location/platform_location.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38890/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38890/files#diff-2df340e6601d13bd56954ec5e5d990b0dcb3ae64d62655544a49bc6ca8aaf178
https://github.com/angular/angular/pull/38890/files#diff-2df340e6601d13bd56954ec5e5d990b0dcb3ae64d62655544a49bc6ca8aaf178
https://github.com/angular/angular/pull/38890/files#diff-2df340e6601d13bd56954ec5e5d990b0dcb3ae64d62655544a49bc6ca8aaf178
https://github.com/angular/angular/pull/38890/files#diff-2df340e6601d13bd56954ec5e5d990b0dcb3ae64d62655544a49bc6ca8aaf178
packages/common/test/location/location_spec.tshttps://github.com/angular/angular/pull/38890/files#diff-0d46fd646db2e778c2bf6cf9b8b170c55c70c0ae756a008a77be154ed42aedde
View file https://github.com/aahmedayed/angular/blob/dae6f19076f00acb7e8b90a4d1765b7420cc967e/packages/common/test/location/location_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38890/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38890/files#diff-0d46fd646db2e778c2bf6cf9b8b170c55c70c0ae756a008a77be154ed42aedde
Please reload this pagehttps://github.com/angular/angular/pull/38890/files
https://github.com/angular/angular/pull/38890/files#diff-0d46fd646db2e778c2bf6cf9b8b170c55c70c0ae756a008a77be154ed42aedde
packages/common/testing/src/location_mock.tshttps://github.com/angular/angular/pull/38890/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
View file https://github.com/aahmedayed/angular/blob/dae6f19076f00acb7e8b90a4d1765b7420cc967e/packages/common/testing/src/location_mock.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38890/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38890/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
Please reload this pagehttps://github.com/angular/angular/pull/38890/files
https://github.com/angular/angular/pull/38890/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
packages/common/testing/src/mock_platform_location.tshttps://github.com/angular/angular/pull/38890/files#diff-fa29c7afa4686ae7c85bb6f489f39e1965e4dedc301216df6caf373266fb743f
View file https://github.com/aahmedayed/angular/blob/dae6f19076f00acb7e8b90a4d1765b7420cc967e/packages/common/testing/src/mock_platform_location.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38890/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38890/files#diff-fa29c7afa4686ae7c85bb6f489f39e1965e4dedc301216df6caf373266fb743f
https://github.com/angular/angular/pull/38890/files#diff-fa29c7afa4686ae7c85bb6f489f39e1965e4dedc301216df6caf373266fb743f
https://github.com/angular/angular/pull/38890/files#diff-fa29c7afa4686ae7c85bb6f489f39e1965e4dedc301216df6caf373266fb743f
https://github.com/angular/angular/pull/38890/files#diff-fa29c7afa4686ae7c85bb6f489f39e1965e4dedc301216df6caf373266fb743f
https://github.com/angular/angular/pull/38890/files#diff-fa29c7afa4686ae7c85bb6f489f39e1965e4dedc301216df6caf373266fb743f
packages/router/test/integration.spec.tshttps://github.com/angular/angular/pull/38890/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
View file https://github.com/aahmedayed/angular/blob/dae6f19076f00acb7e8b90a4d1765b7420cc967e/packages/router/test/integration.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38890/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38890/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com/angular/angular/pull/38890/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.