René's URL Explorer Experiment


Title: refactor(router): compute correct history restoration when navigation is cancelled by aahmedayed · Pull Request #38884 · angular/angular · GitHub

Open Graph Title: refactor(router): compute correct history restoration when navigation is cancelled by aahmedayed · Pull Request #38884 · angular/angular

X Title: refactor(router): compute correct history restoration when navigation is cancelled by aahmedayed · Pull Request #38884 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: We can’t determine whether the user actually meant the back or the forward using the popstate event (triggered by a browser back/forward) so we instead need to store information on the state and co...

X Description: We can’t determine whether the user actually meant the back or the forward using the popstate event (triggered by a browser back/forward) so we instead need to store information on the state and co...

Opengraph URL: https://github.com/angular/angular/pull/38884

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:e6b2e041-d62f-1d72-3aab-97bdf93de46d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id93CA:363D8E:D04D96:10BAF79:6B00EEA8
html-safe-nonce2dd5d3db4af0c35889aa5fec97c9fbae964d055349c73c0c57f0d9e9dd980c50
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0NBOjM2M0Q4RTpEMDREOTY6MTBCQUY3OTo2QjAwRUVBOCIsInZpc2l0b3JfaWQiOiIxNDAyNDI2MDIyMTY2NTg5MDk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca4f197cba5e25f8da3b8aaa9e3962aa4229bfa8a902bcc333d8a1abebe6db70b
hovercard-subject-tagpull_request:488744500
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/38884/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/03bb33fcebf9144f78671ff884a9592c6d14a90f6beb2b7e8b6ebd7ed71a2266/angular/angular/pull/38884
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/03bb33fcebf9144f78671ff884a9592c6d14a90f6beb2b7e8b6ebd7ed71a2266/angular/angular/pull/38884
og:image:altWe can’t determine whether the user actually meant the back or the forward using the popstate event (triggered by a browser back/forward) so we instead need to store information on the state and co...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameaahmedayed
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/38884#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38884
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38884
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/38884
Reloadhttps://github.com/angular/angular/pull/38884
Reloadhttps://github.com/angular/angular/pull/38884
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
aahmedayedhttps://github.com/aahmedayed
angular:masterhttps://github.com/angular/angular/tree/master
aahmedayed:fix-deactivation-guard-breaks-routing-historyhttps://github.com/aahmedayed/angular/tree/fix-deactivation-guard-breaks-routing-history
Conversationhttps://github.com/angular/angular/pull/38884
Commits1 (1)https://github.com/angular/angular/pull/38884/commits
Checkshttps://github.com/angular/angular/pull/38884/checks
Files changedhttps://github.com/angular/angular/pull/38884/files
refactor(router): compute correct history restoration when navigation is cancelledhttps://github.com/angular/angular/pull/38884#top
aahmedayedhttps://github.com/aahmedayed
angular:masterhttps://github.com/angular/angular/tree/master
aahmedayed:fix-deactivation-guard-breaks-routing-historyhttps://github.com/aahmedayed/angular/tree/fix-deactivation-guard-breaks-routing-history
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
Sep 17, 2020https://github.com/angular/angular/pull/38884#issue-703681858
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Sep 17, 2020https://github.com/angular/angular/pull/38884#event-3778551668
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
atscotthttps://github.com/atscott
kyliauhttps://github.com/kyliau
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
September 17, 2020 15:16https://github.com/angular/angular/pull/38884#event-3778552104
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
force-pushedhttps://github.com/angular/angular/compare/e2b10a5c5d0bf73a987b9af5576cf125aa4f81c5..add1b7495a8e531582b196fc4c9ef270b45ca13d
e2b10a5https://github.com/angular/angular/commit/e2b10a5c5d0bf73a987b9af5576cf125aa4f81c5
add1b74https://github.com/angular/angular/commit/add1b7495a8e531582b196fc4c9ef270b45ca13d
Compare https://github.com/angular/angular/compare/e2b10a5c5d0bf73a987b9af5576cf125aa4f81c5..add1b7495a8e531582b196fc4c9ef270b45ca13d
September 17, 2020 15:49https://github.com/angular/angular/pull/38884#event-3778702341
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 17, 2020 https://github.com/angular/angular/pull/38884#pullrequestreview-490734282
View reviewed changes https://github.com/angular/angular/pull/38884/files
atscotthttps://github.com/atscott
https://github.com/angular/angular/pull/38884#pullrequestreview-490734282
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@aahmedayedhttps://github.com/aahmedayed
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/common/src/location/location.tshttps://github.com/angular/angular/pull/38884/files#diff-8a3ef5745f522b08ce333b6bcfb0ed5f8c7fb6ed7ffe06a458b6b437257457ad
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/common/testing/src/location_mock.tshttps://github.com/angular/angular/pull/38884/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/common/src/location/location_strategy.tshttps://github.com/angular/angular/pull/38884/files#diff-b29e6d118397deca67da99bc72df1e16a332033a8a77e712359a557f8b512ea0
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/common/src/location/platform_location.tshttps://github.com/angular/angular/pull/38884/files#diff-2df340e6601d13bd56954ec5e5d990b0dcb3ae64d62655544a49bc6ca8aaf178
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
Sep 17, 2020https://github.com/angular/angular/pull/38884#issuecomment-694367299
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
Sep 17, 2020https://github.com/angular/angular/pull/38884#issuecomment-694413747
Please reload this pagehttps://github.com/angular/angular/pull/38884
@atscotthttps://github.com/atscott
#38890https://github.com/angular/angular/pull/38890
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 21, 2020 https://github.com/angular/angular/pull/38884#pullrequestreview-492850448
View reviewed changes https://github.com/angular/angular/pull/38884/files
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
force-pushedhttps://github.com/angular/angular/compare/6e7416aa009ef1fe5409da61e592d6e875a6ba31..894f5d03afc848e2ce66ab95bea3d038f9027eca
6e7416ahttps://github.com/angular/angular/commit/6e7416aa009ef1fe5409da61e592d6e875a6ba31
894f5d0https://github.com/angular/angular/commit/894f5d03afc848e2ce66ab95bea3d038f9027eca
Compare https://github.com/angular/angular/compare/6e7416aa009ef1fe5409da61e592d6e875a6ba31..894f5d03afc848e2ce66ab95bea3d038f9027eca
September 23, 2020 15:30https://github.com/angular/angular/pull/38884#event-3798741264
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
atscotthttps://github.com/atscott
September 23, 2020 17:57https://github.com/angular/angular/pull/38884#event-3799368026
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
Sep 23, 2020https://github.com/angular/angular/pull/38884#issuecomment-697939339
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 23, 2020 https://github.com/angular/angular/pull/38884#pullrequestreview-495101646
View reviewed changes https://github.com/angular/angular/pull/38884/files
atscotthttps://github.com/atscott
https://github.com/angular/angular/pull/38884#pullrequestreview-495101646
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
breaking changes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22
Sep 23, 2020https://github.com/angular/angular/pull/38884#event-3800797930
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Sep 23, 2020https://github.com/angular/angular/pull/38884#event-3800797965
https://github.com/atscott
atscotthttps://github.com/atscott
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Sep 23, 2020https://github.com/angular/angular/pull/38884#event-3800798060
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 23, 2020https://github.com/angular/angular/pull/38884#issuecomment-698030735
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 24, 2020 https://github.com/angular/angular/pull/38884#pullrequestreview-495140720
View reviewed changes https://github.com/angular/angular/pull/38884/files
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
Sep 24, 2020 https://github.com/angular/angular/pull/38884#pullrequestreview-495767600
View reviewed changes https://github.com/angular/angular/pull/38884/files
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
force-pushedhttps://github.com/angular/angular/compare/4a1fb9135f6ec23dfd655b492acfdd7df637fa88..524762eb2b349d700aac7e9b54370769fb5e71a3
4a1fb91https://github.com/angular/angular/commit/4a1fb9135f6ec23dfd655b492acfdd7df637fa88
524762ehttps://github.com/angular/angular/commit/524762eb2b349d700aac7e9b54370769fb5e71a3
Compare https://github.com/angular/angular/compare/4a1fb9135f6ec23dfd655b492acfdd7df637fa88..524762eb2b349d700aac7e9b54370769fb5e71a3
September 27, 2020 09:59https://github.com/angular/angular/pull/38884#event-3811528019
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
May 5, 2021https://github.com/angular/angular/pull/38884#issuecomment-832475256
Please reload this pagehttps://github.com/angular/angular/pull/38884
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
May 6, 2021https://github.com/angular/angular/pull/38884#issuecomment-833706575
@aahmedayedhttps://github.com/aahmedayed
this TODOhttps://github.com/angular/angular/blob/5c9bd237e34c38ae03a4defd5776aba56deec131/packages/common/src/location/location.ts#L92-L93
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
May 6, 2021 https://github.com/angular/angular/pull/38884#pullrequestreview-653720923
View reviewed changes https://github.com/angular/angular/pull/38884/files
atscotthttps://github.com/atscott
https://github.com/angular/angular/pull/38884#pullrequestreview-653720923
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/events.tshttps://github.com/angular/angular/pull/38884/files#diff-991b8e5f7c3c284db843e5ef591d298033f030a5a39c23998958a2814b631a57
atscotthttps://github.com/atscott
May 6, 2021https://github.com/angular/angular/pull/38884#discussion_r627645621
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/38884
atscotthttps://github.com/atscott
Jun 3, 2021https://github.com/angular/angular/pull/38884#discussion_r644980165
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
atscotthttps://github.com/atscott
May 6, 2021https://github.com/angular/angular/pull/38884#discussion_r627672547
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/38884
atscotthttps://github.com/atscott
Jun 7, 2021https://github.com/angular/angular/pull/38884#discussion_r646784759
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router_module.tshttps://github.com/angular/angular/pull/38884/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/test/integration.spec.tshttps://github.com/angular/angular/pull/38884/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/common/testing/src/location_mock.tshttps://github.com/angular/angular/pull/38884/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/test/integration.spec.tshttps://github.com/angular/angular/pull/38884/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/test/integration.spec.tshttps://github.com/angular/angular/pull/38884/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
May 11, 2021https://github.com/angular/angular/pull/38884#issuecomment-838732513
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
May 25, 2021https://github.com/angular/angular/pull/38884#issuecomment-847976678
@aahmedayedhttps://github.com/aahmedayed
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
May 25, 2021https://github.com/angular/angular/pull/38884#issuecomment-848040662
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
Jun 1, 2021https://github.com/angular/angular/pull/38884#issuecomment-852250285
Please reload this pagehttps://github.com/angular/angular/pull/38884
@atscotthttps://github.com/atscott
#38884 (comment)https://github.com/angular/angular/pull/38884#discussion_r627654160
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
Jun 1, 2021 https://github.com/angular/angular/pull/38884#pullrequestreview-673428703
View reviewed changes https://github.com/angular/angular/pull/38884/files
atscotthttps://github.com/atscott
https://github.com/angular/angular/pull/38884#pullrequestreview-673428703
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@aahmedayedhttps://github.com/aahmedayed
#41730https://github.com/angular/angular/pull/41730
Please reload this pagehttps://github.com/angular/angular/pull/38884
goldens/public-api/router/router.d.tshttps://github.com/angular/angular/pull/38884/files#diff-40893fa41164e57dc34328c6fd52ef0b58818e47eccc5b821f24795f9e43c586
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
Jun 1, 2021https://github.com/angular/angular/pull/38884#issuecomment-852415252
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
Jun 1, 2021https://github.com/angular/angular/pull/38884#issuecomment-852418974
@aahmedayedhttps://github.com/aahmedayed
#38884https://github.com/angular/angular/pull/38884
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
Jun 1, 2021https://github.com/angular/angular/pull/38884#issuecomment-852422744
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
Jun 2, 2021https://github.com/angular/angular/pull/38884#issuecomment-853121357
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
Jun 3, 2021 https://github.com/angular/angular/pull/38884#pullrequestreview-675531567
View reviewed changes https://github.com/angular/angular/pull/38884/files
atscotthttps://github.com/atscott
https://github.com/angular/angular/pull/38884#pullrequestreview-675531567
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/events.tshttps://github.com/angular/angular/pull/38884/files#diff-991b8e5f7c3c284db843e5ef591d298033f030a5a39c23998958a2814b631a57
atscotthttps://github.com/atscott
Jun 3, 2021https://github.com/angular/angular/pull/38884#discussion_r644980165
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
goldens/size-tracking/integration-payloads.jsonhttps://github.com/angular/angular/pull/38884/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
Jun 4, 2021https://github.com/angular/angular/pull/38884#issuecomment-855036070
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
Jun 7, 2021 https://github.com/angular/angular/pull/38884#pullrequestreview-677672948
View reviewed changes https://github.com/angular/angular/pull/38884/files
atscotthttps://github.com/atscott
https://github.com/angular/angular/pull/38884#pullrequestreview-677672948
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
atscotthttps://github.com/atscott
Jun 7, 2021https://github.com/angular/angular/pull/38884#discussion_r646784759
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
Jun 7, 2021 https://github.com/angular/angular/pull/38884#pullrequestreview-677677432
View reviewed changes https://github.com/angular/angular/pull/38884/files
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 7, 2021https://github.com/angular/angular/pull/38884#issuecomment-856114369
Presubmithttp://test/OCL:377944420:BASE:377944453:1623085980672:2741e6d
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/jessicajaniuk
jessicajaniukhttps://github.com/jessicajaniuk
Jun 7, 2021 https://github.com/angular/angular/pull/38884#pullrequestreview-677790216
View reviewed changes https://github.com/angular/angular/pull/38884/files
jessicajaniukhttps://github.com/jessicajaniuk
https://github.com/angular/angular/pull/38884#pullrequestreview-677790216
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 7, 2021 https://github.com/angular/angular/pull/38884#pullrequestreview-677781193
View reviewed changes https://github.com/angular/angular/pull/38884/files
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
packages/router/src/router.tshttps://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
Jun 9, 2021https://github.com/angular/angular/pull/38884#issuecomment-858141648
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
https://github.com/atscott
refactor(router): compute correct history restoration when navigation…https://github.com/angular/angular/pull/38884/commits/d0be56fe39bee0feba24c94d8a3fdb8e58fb11bc
d0be56fhttps://github.com/angular/angular/pull/38884/commits/d0be56fe39bee0feba24c94d8a3fdb8e58fb11bc
angular#13586https://github.com/angular/angular/issues/13586
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 9, 2021 https://github.com/angular/angular/pull/38884#pullrequestreview-680213496
View reviewed changes https://github.com/angular/angular/pull/38884/files/d0be56fe39bee0feba24c94d8a3fdb8e58fb11bc
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/38884#pullrequestreview-680213496
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@aahmedayedhttps://github.com/aahmedayed
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
Jun 9, 2021https://github.com/angular/angular/pull/38884#issuecomment-858157936
presubmithttp://test/OCL:337182271:BASE:378521808:1623279962617:aee1229f
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
Jun 9, 2021https://github.com/angular/angular/pull/38884#issuecomment-858176074
@AndrewKushnirhttps://github.com/AndrewKushnir
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
Jun 18, 2021https://github.com/angular/angular/pull/38884#issuecomment-863767152
@aahmedayedhttps://github.com/aahmedayed
herehttps://github.com/angular/angular/blob/983c540191b5d838e19863c1e722170be6ea42e3/packages/router/src/router.ts#L894-L929
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
Jul 1, 2021 https://github.com/angular/angular/pull/38884#ref-issue-196702796
Deactivation Guard breaks the routing history #13586 https://github.com/angular/angular/issues/13586
https://github.com/atscott
atscotthttps://github.com/atscott
Jul 2, 2021https://github.com/angular/angular/pull/38884#issuecomment-873218807
Please reload this pagehttps://github.com/angular/angular/pull/38884
@aahmedayedhttps://github.com/aahmedayed
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/atscott
atscotthttps://github.com/atscott
Jul 2, 2021 https://github.com/angular/angular/pull/38884#ref-pullrequest-936050690
refactor(router): Adjust behavior for computed navigation restoration #42751 https://github.com/angular/angular/pull/42751
https://github.com/aahmedayed
aahmedayedhttps://github.com/aahmedayed
Jul 8, 2021https://github.com/angular/angular/pull/38884#issuecomment-876702129
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Aug 8, 2021https://github.com/angular/angular/pull/38884#issuecomment-894818887
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38884
https://github.com/atscott
atscott https://github.com/atscott
https://github.com/angular/angular/pull/38884/files/674246067f2b8dab6a42fe63da73b6e09d420bc0
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/38884/files/d0be56fe39bee0feba24c94d8a3fdb8e58fb11bc
https://github.com/jessicajaniuk
jessicajaniuk https://github.com/jessicajaniuk
https://github.com/angular/angular/pull/38884/files/674246067f2b8dab6a42fe63da73b6e09d420bc0
https://github.com/IgorMinar
IgorMinar https://github.com/IgorMinar
https://github.com/angular/angular/pull/38884/files/906e8307df13e8e3cc1b56c7e186340f5690b058
Please reload this pagehttps://github.com/angular/angular/pull/38884
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Backlog https://github.com/angular/angular/milestone/82
Please reload this pagehttps://github.com/angular/angular/pull/38884
https://github.com/aahmedayed
https://github.com/atscott
https://github.com/AndrewKushnir
https://github.com/IgorMinar
https://github.com/jessicajaniuk
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.