| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:e6b2e041-d62f-1d72-3aab-97bdf93de46d |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 93CA:363D8E:D04D96:10BAF79:6B00EEA8 |
| html-safe-nonce | 2dd5d3db4af0c35889aa5fec97c9fbae964d055349c73c0c57f0d9e9dd980c50 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0NBOjM2M0Q4RTpEMDREOTY6MTBCQUY3OTo2QjAwRUVBOCIsInZpc2l0b3JfaWQiOiIxNDAyNDI2MDIyMTY2NTg5MDk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a4f197cba5e25f8da3b8aaa9e3962aa4229bfa8a902bcc333d8a1abebe6db70b |
| hovercard-subject-tag | pull_request:488744500 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/38884/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/03bb33fcebf9144f78671ff884a9592c6d14a90f6beb2b7e8b6ebd7ed71a2266/angular/angular/pull/38884 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/03bb33fcebf9144f78671ff884a9592c6d14a90f6beb2b7e8b6ebd7ed71a2266/angular/angular/pull/38884 |
| og:image:alt | We can’t determine whether the user actually meant the back or
the forward using the popstate event (triggered by a browser
back/forward)
so we instead need to store information on the state and co... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | aahmedayed |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/38884#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38884 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38884 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/38884 |
| Reload | https://github.com/angular/angular/pull/38884 |
| Reload | https://github.com/angular/angular/pull/38884 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests140 (140) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| aahmedayed | https://github.com/aahmedayed |
| angular:master | https://github.com/angular/angular/tree/master |
| aahmedayed:fix-deactivation-guard-breaks-routing-history | https://github.com/aahmedayed/angular/tree/fix-deactivation-guard-breaks-routing-history |
| Conversation | https://github.com/angular/angular/pull/38884 |
| Commits1 (1) | https://github.com/angular/angular/pull/38884/commits |
| Checks | https://github.com/angular/angular/pull/38884/checks |
| Files changed | https://github.com/angular/angular/pull/38884/files |
| refactor(router): compute correct history restoration when navigation is cancelled | https://github.com/angular/angular/pull/38884#top |
| aahmedayed | https://github.com/aahmedayed |
| angular:master | https://github.com/angular/angular/tree/master |
| aahmedayed:fix-deactivation-guard-breaks-routing-history | https://github.com/aahmedayed/angular/tree/fix-deactivation-guard-breaks-routing-history |
|
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| Sep 17, 2020 | https://github.com/angular/angular/pull/38884#issue-703681858 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Sep 17, 2020 | https://github.com/angular/angular/pull/38884#event-3778551668 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| atscott | https://github.com/atscott |
| kyliau | https://github.com/kyliau |
| pkozlowski-opensource | https://github.com/pkozlowski-opensource |
| September 17, 2020 15:16 | https://github.com/angular/angular/pull/38884#event-3778552104 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| force-pushed | https://github.com/angular/angular/compare/e2b10a5c5d0bf73a987b9af5576cf125aa4f81c5..add1b7495a8e531582b196fc4c9ef270b45ca13d |
| e2b10a5 | https://github.com/angular/angular/commit/e2b10a5c5d0bf73a987b9af5576cf125aa4f81c5 |
| add1b74 | https://github.com/angular/angular/commit/add1b7495a8e531582b196fc4c9ef270b45ca13d |
|
Compare
| https://github.com/angular/angular/compare/e2b10a5c5d0bf73a987b9af5576cf125aa4f81c5..add1b7495a8e531582b196fc4c9ef270b45ca13d |
| September 17, 2020 15:49 | https://github.com/angular/angular/pull/38884#event-3778702341 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Sep 17, 2020
| https://github.com/angular/angular/pull/38884#pullrequestreview-490734282 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38884/files |
| atscott | https://github.com/atscott |
| https://github.com/angular/angular/pull/38884#pullrequestreview-490734282 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @aahmedayed | https://github.com/aahmedayed |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/common/src/location/location.ts | https://github.com/angular/angular/pull/38884/files#diff-8a3ef5745f522b08ce333b6bcfb0ed5f8c7fb6ed7ffe06a458b6b437257457ad |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/common/testing/src/location_mock.ts | https://github.com/angular/angular/pull/38884/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/common/src/location/location_strategy.ts | https://github.com/angular/angular/pull/38884/files#diff-b29e6d118397deca67da99bc72df1e16a332033a8a77e712359a557f8b512ea0 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/common/src/location/platform_location.ts | https://github.com/angular/angular/pull/38884/files#diff-2df340e6601d13bd56954ec5e5d990b0dcb3ae64d62655544a49bc6ca8aaf178 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| Sep 17, 2020 | https://github.com/angular/angular/pull/38884#issuecomment-694367299 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| Sep 17, 2020 | https://github.com/angular/angular/pull/38884#issuecomment-694413747 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| @atscott | https://github.com/atscott |
| #38890 | https://github.com/angular/angular/pull/38890 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Sep 21, 2020
| https://github.com/angular/angular/pull/38884#pullrequestreview-492850448 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38884/files |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| force-pushed | https://github.com/angular/angular/compare/6e7416aa009ef1fe5409da61e592d6e875a6ba31..894f5d03afc848e2ce66ab95bea3d038f9027eca |
| 6e7416a | https://github.com/angular/angular/commit/6e7416aa009ef1fe5409da61e592d6e875a6ba31 |
| 894f5d0 | https://github.com/angular/angular/commit/894f5d03afc848e2ce66ab95bea3d038f9027eca |
|
Compare
| https://github.com/angular/angular/compare/6e7416aa009ef1fe5409da61e592d6e875a6ba31..894f5d03afc848e2ce66ab95bea3d038f9027eca |
| September 23, 2020 15:30 | https://github.com/angular/angular/pull/38884#event-3798741264 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| atscott | https://github.com/atscott |
| September 23, 2020 17:57 | https://github.com/angular/angular/pull/38884#event-3799368026 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| Sep 23, 2020 | https://github.com/angular/angular/pull/38884#issuecomment-697939339 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Sep 23, 2020
| https://github.com/angular/angular/pull/38884#pullrequestreview-495101646 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38884/files |
| atscott | https://github.com/atscott |
| https://github.com/angular/angular/pull/38884#pullrequestreview-495101646 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
| Sep 23, 2020 | https://github.com/angular/angular/pull/38884#event-3800797930 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Sep 23, 2020 | https://github.com/angular/angular/pull/38884#event-3800797965 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Sep 23, 2020 | https://github.com/angular/angular/pull/38884#event-3800798060 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Sep 23, 2020 | https://github.com/angular/angular/pull/38884#issuecomment-698030735 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Sep 24, 2020
| https://github.com/angular/angular/pull/38884#pullrequestreview-495140720 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38884/files |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Sep 24, 2020
| https://github.com/angular/angular/pull/38884#pullrequestreview-495767600 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38884/files |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| force-pushed | https://github.com/angular/angular/compare/4a1fb9135f6ec23dfd655b492acfdd7df637fa88..524762eb2b349d700aac7e9b54370769fb5e71a3 |
| 4a1fb91 | https://github.com/angular/angular/commit/4a1fb9135f6ec23dfd655b492acfdd7df637fa88 |
| 524762e | https://github.com/angular/angular/commit/524762eb2b349d700aac7e9b54370769fb5e71a3 |
|
Compare
| https://github.com/angular/angular/compare/4a1fb9135f6ec23dfd655b492acfdd7df637fa88..524762eb2b349d700aac7e9b54370769fb5e71a3 |
| September 27, 2020 09:59 | https://github.com/angular/angular/pull/38884#event-3811528019 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| May 5, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-832475256 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| May 6, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-833706575 |
| @aahmedayed | https://github.com/aahmedayed |
| this TODO | https://github.com/angular/angular/blob/5c9bd237e34c38ae03a4defd5776aba56deec131/packages/common/src/location/location.ts#L92-L93 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
May 6, 2021
| https://github.com/angular/angular/pull/38884#pullrequestreview-653720923 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38884/files |
| atscott | https://github.com/atscott |
| https://github.com/angular/angular/pull/38884#pullrequestreview-653720923 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/events.ts | https://github.com/angular/angular/pull/38884/files#diff-991b8e5f7c3c284db843e5ef591d298033f030a5a39c23998958a2814b631a57 |
| atscott | https://github.com/atscott |
| May 6, 2021 | https://github.com/angular/angular/pull/38884#discussion_r627645621 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| atscott | https://github.com/atscott |
| Jun 3, 2021 | https://github.com/angular/angular/pull/38884#discussion_r644980165 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| atscott | https://github.com/atscott |
| May 6, 2021 | https://github.com/angular/angular/pull/38884#discussion_r627672547 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| atscott | https://github.com/atscott |
| Jun 7, 2021 | https://github.com/angular/angular/pull/38884#discussion_r646784759 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router_module.ts | https://github.com/angular/angular/pull/38884/files#diff-99eedd01338ea4afb9b0f1533729b9c06a95b92cc68b12b786d44ebadba8be03 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/test/integration.spec.ts | https://github.com/angular/angular/pull/38884/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/common/testing/src/location_mock.ts | https://github.com/angular/angular/pull/38884/files#diff-54abfadc56a22c64b11703de3c45db943383f6f03d12250446b0467acc356850 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/test/integration.spec.ts | https://github.com/angular/angular/pull/38884/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/test/integration.spec.ts | https://github.com/angular/angular/pull/38884/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| May 11, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-838732513 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| May 25, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-847976678 |
| @aahmedayed | https://github.com/aahmedayed |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| May 25, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-848040662 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| Jun 1, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-852250285 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| @atscott | https://github.com/atscott |
| #38884 (comment) | https://github.com/angular/angular/pull/38884#discussion_r627654160 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Jun 1, 2021
| https://github.com/angular/angular/pull/38884#pullrequestreview-673428703 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38884/files |
| atscott | https://github.com/atscott |
| https://github.com/angular/angular/pull/38884#pullrequestreview-673428703 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @aahmedayed | https://github.com/aahmedayed |
| #41730 | https://github.com/angular/angular/pull/41730 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| goldens/public-api/router/router.d.ts | https://github.com/angular/angular/pull/38884/files#diff-40893fa41164e57dc34328c6fd52ef0b58818e47eccc5b821f24795f9e43c586 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| Jun 1, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-852415252 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Jun 1, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-852418974 |
| @aahmedayed | https://github.com/aahmedayed |
| #38884 | https://github.com/angular/angular/pull/38884 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| Jun 1, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-852422744 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| Jun 2, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-853121357 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Jun 3, 2021
| https://github.com/angular/angular/pull/38884#pullrequestreview-675531567 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38884/files |
| atscott | https://github.com/atscott |
| https://github.com/angular/angular/pull/38884#pullrequestreview-675531567 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/events.ts | https://github.com/angular/angular/pull/38884/files#diff-991b8e5f7c3c284db843e5ef591d298033f030a5a39c23998958a2814b631a57 |
| atscott | https://github.com/atscott |
| Jun 3, 2021 | https://github.com/angular/angular/pull/38884#discussion_r644980165 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| goldens/size-tracking/integration-payloads.json | https://github.com/angular/angular/pull/38884/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| Jun 4, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-855036070 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Jun 7, 2021
| https://github.com/angular/angular/pull/38884#pullrequestreview-677672948 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38884/files |
| atscott | https://github.com/atscott |
| https://github.com/angular/angular/pull/38884#pullrequestreview-677672948 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| atscott | https://github.com/atscott |
| Jun 7, 2021 | https://github.com/angular/angular/pull/38884#discussion_r646784759 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Jun 7, 2021
| https://github.com/angular/angular/pull/38884#pullrequestreview-677677432 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38884/files |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Jun 7, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-856114369 |
| Presubmit | http://test/OCL:377944420:BASE:377944453:1623085980672:2741e6d |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/jessicajaniuk |
| jessicajaniuk | https://github.com/jessicajaniuk |
|
Jun 7, 2021
| https://github.com/angular/angular/pull/38884#pullrequestreview-677790216 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38884/files |
| jessicajaniuk | https://github.com/jessicajaniuk |
| https://github.com/angular/angular/pull/38884#pullrequestreview-677790216 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jun 7, 2021
| https://github.com/angular/angular/pull/38884#pullrequestreview-677781193 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38884/files |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| packages/router/src/router.ts | https://github.com/angular/angular/pull/38884/files#diff-03cb1ea13f0b5890eb24ce6fef7a42eed85429da0a90cdb48ab06b58c30cb1c1 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| Jun 9, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-858141648 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
|
| https://github.com/aahmedayed |
|
| https://github.com/atscott |
| refactor(router): compute correct history restoration when navigation… | https://github.com/angular/angular/pull/38884/commits/d0be56fe39bee0feba24c94d8a3fdb8e58fb11bc |
| d0be56f | https://github.com/angular/angular/pull/38884/commits/d0be56fe39bee0feba24c94d8a3fdb8e58fb11bc |
| angular#13586 | https://github.com/angular/angular/issues/13586 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Jun 9, 2021
| https://github.com/angular/angular/pull/38884#pullrequestreview-680213496 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38884/files/d0be56fe39bee0feba24c94d8a3fdb8e58fb11bc |
| AndrewKushnir | https://github.com/AndrewKushnir |
| https://github.com/angular/angular/pull/38884#pullrequestreview-680213496 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @aahmedayed | https://github.com/aahmedayed |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Jun 9, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-858157936 |
| presubmit | http://test/OCL:337182271:BASE:378521808:1623279962617:aee1229f |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| Jun 9, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-858176074 |
| @AndrewKushnir | https://github.com/AndrewKushnir |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Jun 18, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-863767152 |
| @aahmedayed | https://github.com/aahmedayed |
| here | https://github.com/angular/angular/blob/983c540191b5d838e19863c1e722170be6ea42e3/packages/router/src/router.ts#L894-L929 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Jul 1, 2021
| https://github.com/angular/angular/pull/38884#ref-issue-196702796 |
|
Deactivation Guard breaks the routing history
#13586
| https://github.com/angular/angular/issues/13586 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
| Jul 2, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-873218807 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| @aahmedayed | https://github.com/aahmedayed |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/atscott |
| atscott | https://github.com/atscott |
|
Jul 2, 2021
| https://github.com/angular/angular/pull/38884#ref-pullrequest-936050690 |
|
refactor(router): Adjust behavior for computed navigation restoration
#42751
| https://github.com/angular/angular/pull/42751 |
| https://github.com/aahmedayed |
| aahmedayed | https://github.com/aahmedayed |
| Jul 8, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-876702129 |
| @atscott | https://github.com/atscott |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Aug 8, 2021 | https://github.com/angular/angular/pull/38884#issuecomment-894818887 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38884 |
|
| https://github.com/atscott |
|
atscott
| https://github.com/atscott |
|
| https://github.com/angular/angular/pull/38884/files/674246067f2b8dab6a42fe63da73b6e09d420bc0 |
|
| https://github.com/AndrewKushnir |
|
AndrewKushnir
| https://github.com/AndrewKushnir |
|
| https://github.com/angular/angular/pull/38884/files/d0be56fe39bee0feba24c94d8a3fdb8e58fb11bc |
|
| https://github.com/jessicajaniuk |
|
jessicajaniuk
| https://github.com/jessicajaniuk |
|
| https://github.com/angular/angular/pull/38884/files/674246067f2b8dab6a42fe63da73b6e09d420bc0 |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/angular/angular/pull/38884/files/906e8307df13e8e3cc1b56c7e186340f5690b058 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: router
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
Backlog
| https://github.com/angular/angular/milestone/82 |
| Please reload this page | https://github.com/angular/angular/pull/38884 |
|
| https://github.com/aahmedayed |
|
| https://github.com/atscott |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/IgorMinar |
|
| https://github.com/jessicajaniuk |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |