René's URL Explorer Experiment


Title: Small fixes while updating to TS 1.6 by mhegazy · Pull Request #3865 · angular/angular · GitHub

Open Graph Title: Small fixes while updating to TS 1.6 by mhegazy · Pull Request #3865 · angular/angular

X Title: Small fixes while updating to TS 1.6 by mhegazy · Pull Request #3865 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Trying TS1.6 on latest from master and ran into a few compiler errors. here are the fixes. This should work just fine for 1.5, but would make migrating to 1.6 error-free.

X Description: Trying TS1.6 on latest from master and ran into a few compiler errors. here are the fixes. This should work just fine for 1.5, but would make migrating to 1.6 error-free.

Opengraph URL: https://github.com/angular/angular/pull/3865

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7c5ca72e-4f2e-c585-6eba-e47e37680510
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA01E:30460E:5B98A1F:77065E0:6A5DA563
html-safe-nonce6cae58b1ecf12a16dd31aa905c1fa79a6571fcb5fcb64c43642aecd475e7b001
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMDFFOjMwNDYwRTo1Qjk4QTFGOjc3MDY1RTA6NkE1REE1NjMiLCJ2aXNpdG9yX2lkIjoiNDM3MDQwMDIyOTMxMDk2NTA5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac9de4285586e7e1dddf3a6dbc356887007d2f1ee86f8204046cf16aeab756efc0
hovercard-subject-tagpull_request:43539177
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/3865/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5cf9fe90872a7348a2a499b6a764868a60faeadcc149dcff2776f9a1c40e5653/angular/angular/pull/3865
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5cf9fe90872a7348a2a499b6a764868a60faeadcc149dcff2776f9a1c40e5653/angular/angular/pull/3865
og:image:altTrying TS1.6 on latest from master and ran into a few compiler errors. here are the fixes. This should work just fine for 1.5, but would make migrating to 1.6 error-free.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemhegazy
hostnamegithub.com
expected-hostnamegithub.com
None5290d7e14309ad1e76106a9c4237bd1041517e83ea182c8ab756752cb0c6940b
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9c975978430e9ad293956f2bbdaf153b1bd84a99
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/3865#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F3865
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F3865
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/3865
Reloadhttps://github.com/angular/angular/pull/3865
Reloadhttps://github.com/angular/angular/pull/3865
Please reload this pagehttps://github.com/angular/angular/pull/3865
angular https://github.com/angular
angularhttps://github.com/angular/angular
Notifications https://github.com/login?return_to=%2Fangular%2Fangular
Fork 27.4k https://github.com/login?return_to=%2Fangular%2Fangular
Star 101k https://github.com/login?return_to=%2Fangular%2Fangular
Code https://github.com/angular/angular
Issues 983 https://github.com/angular/angular/issues
Pull requests 176 https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects https://github.com/angular/angular/projects
Security and quality 24 https://github.com/angular/angular/security
Insights https://github.com/angular/angular/pulse
Code https://github.com/angular/angular
Issues https://github.com/angular/angular/issues
Pull requests https://github.com/angular/angular/pulls
Discussions https://github.com/angular/angular/discussions
Actions https://github.com/angular/angular/actions
Projects https://github.com/angular/angular/projects
Security and quality https://github.com/angular/angular/security
Insights https://github.com/angular/angular/pulse
mhegazyhttps://github.com/mhegazy
angular:masterhttps://github.com/angular/angular/tree/master
mhegazy:updateToTS1.6https://github.com/mhegazy/angular/tree/updateToTS1.6
Conversationhttps://github.com/angular/angular/pull/3865
Commits16 (16)https://github.com/angular/angular/pull/3865/commits
Checkshttps://github.com/angular/angular/pull/3865/checks
Files changedhttps://github.com/angular/angular/pull/3865/files
Small fixes while updating to TS 1.6https://github.com/angular/angular/pull/3865#top
mhegazyhttps://github.com/mhegazy
angular:masterhttps://github.com/angular/angular/tree/master
mhegazy:updateToTS1.6https://github.com/mhegazy/angular/tree/updateToTS1.6
https://github.com/mhegazy
mhegazyhttps://github.com/mhegazy
Aug 27, 2015https://github.com/angular/angular/pull/3865#issue-103548556
Please reload this pagehttps://github.com/angular/angular/pull/3865
mhegazyhttps://github.com/mhegazy
August 27, 2015 09:11https://github.com/angular/angular/pull/3865#commits-pushed-e8244e4
https://github.com/mhegazy
Fix declaration emit errors for unexported names used in exported dec…https://github.com/angular/angular/pull/3865/commits/e8244e4b1def3c15dbfa2db40845bd3fa5ad69dd
e8244e4https://github.com/angular/angular/pull/3865/commits/e8244e4b1def3c15dbfa2db40845bd3fa5ad69dd
https://github.com/mhegazy
Give list an explicit type to avoid getting any[] from the empty ar…https://github.com/angular/angular/pull/3865/commits/51e3a6dd5884ef1253a9bf95f8955338a6e50bb7
51e3a6dhttps://github.com/angular/angular/pull/3865/commits/51e3a6dd5884ef1253a9bf95f8955338a6e50bb7
https://github.com/mhegazy
Give Const a PropertyDecortator type as it is actually used as both c…https://github.com/angular/angular/pull/3865/commits/ef2ab2aadd5eb3f750c909eced9b528dc2499349
ef2ab2ahttps://github.com/angular/angular/pull/3865/commits/ef2ab2aadd5eb3f750c909eced9b528dc2499349
https://github.com/mhegazy
Cast to Promisehttps://github.com/angular/angular/pull/3865/commits/65e34c017314e6093769fb3da36b6ccb616fdc49
65e34c0https://github.com/angular/angular/pull/3865/commits/65e34c017314e6093769fb3da36b6ccb616fdc49
https://github.com/mhegazy
Add exclude propertyhttps://github.com/angular/angular/pull/3865/commits/551b0f18f2b1b9fed2bc292e840dcaef7450c903
551b0f1https://github.com/angular/angular/pull/3865/commits/551b0f18f2b1b9fed2bc292e840dcaef7450c903
https://github.com/mhegazy
Fix formattinghttps://github.com/angular/angular/pull/3865/commits/510c214e85225c5cca2a05a14d9b8572893e86b4
510c214https://github.com/angular/angular/pull/3865/commits/510c214e85225c5cca2a05a14d9b8572893e86b4
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Aug 27, 2015https://github.com/angular/angular/pull/3865#event-394219036
mhegazyhttps://github.com/mhegazy
August 27, 2015 17:45https://github.com/angular/angular/pull/3865#commits-pushed-091ee29
https://github.com/mhegazy
Add parens backhttps://github.com/angular/angular/pull/3865/commits/091ee2910d08740e3f78bcd863ffc58be6becae0
091ee29https://github.com/angular/angular/pull/3865/commits/091ee2910d08740e3f78bcd863ffc58be6becae0
https://github.com/mhegazy
Fix formattinghttps://github.com/angular/angular/pull/3865/commits/229e2a7f87c900022055853cadeecf986637183f
229e2a7https://github.com/angular/angular/pull/3865/commits/229e2a7f87c900022055853cadeecf986637183f
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Aug 28, 2015https://github.com/angular/angular/pull/3865#issuecomment-135633614
https://travis-ci.org/angular/angular/jobs/77609361#L718https://travis-ci.org/angular/angular/jobs/77609361#L718
Please reload this pagehttps://github.com/angular/angular/pull/3865
https://github.com/mhegazy
mhegazyhttps://github.com/mhegazy
Aug 28, 2015https://github.com/angular/angular/pull/3865#issuecomment-135824626
Please reload this pagehttps://github.com/angular/angular/pull/3865
mhegazyhttps://github.com/mhegazy
August 28, 2015 17:16https://github.com/angular/angular/pull/3865#commits-pushed-752592f
https://github.com/mhegazy
Revert "Cast to Promise", this should not be needed, the fix sho…https://github.com/angular/angular/pull/3865/commits/752592fcf1530448f9f8a6973ec74be471e618a7
752592fhttps://github.com/angular/angular/pull/3865/commits/752592fcf1530448f9f8a6973ec74be471e618a7
https://github.com/mhegazy
remove empty linehttps://github.com/angular/angular/pull/3865/commits/5d7f926f7bac22b09ef74904da2d470a71adb453
5d7f926https://github.com/angular/angular/pull/3865/commits/5d7f926f7bac22b09ef74904da2d470a71adb453
https://github.com/mhegazy
Merge branch 'master' into updateToTS1.6https://github.com/angular/angular/pull/3865/commits/1b2c9e9f179fde52df67b15a7992692e9070728d
1b2c9e9https://github.com/angular/angular/pull/3865/commits/1b2c9e9f179fde52df67b15a7992692e9070728d
https://github.com/mhegazy
mhegazyhttps://github.com/mhegazy
Sep 1, 2015https://github.com/angular/angular/pull/3865#issuecomment-136539034
@mheveryhttps://github.com/mhevery
Please reload this pagehttps://github.com/angular/angular/pull/3865
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Sep 1, 2015https://github.com/angular/angular/pull/3865#issuecomment-136564003
@Mlavalhttps://github.com/Mlaval
@mhegazyhttps://github.com/mhegazy
https://github.com/angular/angular/blob/master/DEVELOPER.mdhttps://github.com/angular/angular/blob/master/DEVELOPER.md
Please reload this pagehttps://github.com/angular/angular/pull/3865
https://github.com/marclaval
marclavalhttps://github.com/marclaval
Sep 1, 2015https://github.com/angular/angular/pull/3865#issuecomment-136755305
@mhegazyhttps://github.com/mhegazy
https://www.dartlang.org/downloads/archive/https://www.dartlang.org/downloads/archive/
@mheveryhttps://github.com/mhevery
Please reload this pagehttps://github.com/angular/angular/pull/3865
marclavalhttps://github.com/marclaval
Sep 1, 2015 https://github.com/angular/angular/pull/3865#ref-commit-85652d1
https://github.com/marclaval
chore(DEVELOPER.md): add details for configuring Dart on Windowshttps://github.com/angular/angular/commit/85652d1fcd36eb322689c7075509908d851fa220
85652d1https://github.com/angular/angular/commit/85652d1fcd36eb322689c7075509908d851fa220
#3865https://github.com/angular/angular/pull/3865
https://github.com/marclaval
marclavalhttps://github.com/marclaval
Sep 1, 2015 https://github.com/angular/angular/pull/3865#ref-pullrequest-104292576
chore(DEVELOPER.md): add details for configuring Dart on Windows #3939 https://github.com/angular/angular/pull/3939
https://github.com/mhegazy
mhegazyhttps://github.com/mhegazy
Sep 1, 2015https://github.com/angular/angular/pull/3865#issuecomment-136837685
@Mlavalhttps://github.com/Mlaval
@mheveryhttps://github.com/mhevery
Please reload this pagehttps://github.com/angular/angular/pull/3865
marclavalhttps://github.com/marclaval
Sep 11, 2015 https://github.com/angular/angular/pull/3865#ref-commit-9b009b3
https://github.com/marclaval
https://github.com/mhevery
chore(DEVELOPER.md): add details for configuring Dart on Windowshttps://github.com/angular/angular/commit/9b009b3159f6da9e2a9e110c3bfb5d16e296ff17
9b009b3https://github.com/angular/angular/commit/9b009b3159f6da9e2a9e110c3bfb5d16e296ff17
#3865https://github.com/angular/angular/pull/3865
#3939https://github.com/angular/angular/pull/3939
https://github.com/tbosch
tboschhttps://github.com/tbosch
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Sep 11, 2015https://github.com/angular/angular/pull/3865#event-407602200
https://github.com/tbosch
tboschhttps://github.com/tbosch
Sep 11, 2015https://github.com/angular/angular/pull/3865#issuecomment-139682627
Please reload this pagehttps://github.com/angular/angular/pull/3865
mhegazyhttps://github.com/mhegazy
September 15, 2015 17:05https://github.com/angular/angular/pull/3865#commits-pushed-bcefdd8
https://github.com/mhegazy
Revert "Cast to Promise"https://github.com/angular/angular/pull/3865/commits/bcefdd8e414b7b8227a5f4af9e99ae8798842b05
bcefdd8https://github.com/angular/angular/pull/3865/commits/bcefdd8e414b7b8227a5f4af9e99ae8798842b05
65e34c0https://github.com/mhegazy/angular/commit/65e34c017314e6093769fb3da36b6ccb616fdc49
https://github.com/mhegazy
Add definition to createClass in react.min.d.tshttps://github.com/angular/angular/pull/3865/commits/78bcef2a19e4fa1d2443e2a3f8fcf83d49dee347
78bcef2https://github.com/angular/angular/pull/3865/commits/78bcef2a19e4fa1d2443e2a3f8fcf83d49dee347
https://github.com/mhegazy
remove references to unexported member LifecycleEventhttps://github.com/angular/angular/pull/3865/commits/7cbeb7a92f9b66af31984c2ed9ba169fc2746712
7cbeb7ahttps://github.com/angular/angular/pull/3865/commits/7cbeb7a92f9b66af31984c2ed9ba169fc2746712
https://github.com/mhegazy
Fix declaration emit errors for unexported declarationshttps://github.com/angular/angular/pull/3865/commits/4632a5b6e50cbed02f6685a9c5b02f0e62f450c5
4632a5bhttps://github.com/angular/angular/pull/3865/commits/4632a5b6e50cbed02f6685a9c5b02f0e62f450c5
https://github.com/mhegazy
remove unexported import TIMEOUT_INTERVAL_FOR_SLOW_BROWSERShttps://github.com/angular/angular/pull/3865/commits/9975b5f24a3cc6bc0c14fe9a1e4278453c8bcfdd
9975b5fhttps://github.com/angular/angular/pull/3865/commits/9975b5f24a3cc6bc0c14fe9a1e4278453c8bcfdd
https://github.com/tbosch
tboschhttps://github.com/tbosch
Sep 28, 2015https://github.com/angular/angular/pull/3865#issuecomment-143897660
Please reload this pagehttps://github.com/angular/angular/pull/3865
https://github.com/tbosch
tboschhttps://github.com/tbosch
Sep 28, 2015https://github.com/angular/angular/pull/3865#event-421319537
https://github.com/mhegazy
mhegazyhttps://github.com/mhegazy
September 29, 2015 16:30https://github.com/angular/angular/pull/3865#event-422088206
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 7, 2019https://github.com/angular/angular/pull/3865#issuecomment-529078272
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/3865
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 7, 2019https://github.com/angular/angular/pull/3865#event-2616031635
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F3865
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Please reload this pagehttps://github.com/angular/angular/pull/3865
https://github.com/mhegazy
https://github.com/mhevery
https://github.com/marclaval
https://github.com/tbosch
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.