| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:f75e1ae8-1171-2edb-87af-d959a5a47a01 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DE30:2EF149:1C27BA:24CB58:6B0164E1 |
| html-safe-nonce | 91dac902f741610a25be6687a49cfc476735f77224acec46f6823b3a74ea04b8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTMwOjJFRjE0OToxQzI3QkE6MjRDQjU4OjZCMDE2NEUxIiwidmlzaXRvcl9pZCI6IjY0MjY2NDUwNjY3MTQwMTQ5NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1dff6fc3b51d723d1b75612acf0a0e7cb46ce073b4e011870139422692693b7b |
| hovercard-subject-tag | pull_request:470679768 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/38542/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/9d4cede68a852456f90ec9a8247d2774763317d8839b65356338b47d6f95dd40/angular/angular/pull/38542 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9d4cede68a852456f90ec9a8247d2774763317d8839b65356338b47d6f95dd40/angular/angular/pull/38542 |
| og:image:alt | We had a couple of places where we were assuming that if a particular symbol has a value, then it will exist at runtime. This is true in most cases, but it breaks down for const enums.
Fixes #38513. |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | crisbeto |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/38542#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38542 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38542 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/38542 |
| Reload | https://github.com/angular/angular/pull/38542 |
| Reload | https://github.com/angular/angular/pull/38542 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| crisbeto | https://github.com/crisbeto |
| angular:master | https://github.com/angular/angular/tree/master |
| crisbeto:38513/const-enum-references | https://github.com/crisbeto/angular/tree/38513/const-enum-references |
| Conversation | https://github.com/angular/angular/pull/38542 |
| Commits1 (1) | https://github.com/angular/angular/pull/38542/commits |
| Checks | https://github.com/angular/angular/pull/38542/checks |
| Files changed | https://github.com/angular/angular/pull/38542/files |
| fix(compiler-cli): adding references to const enums in runtime code | https://github.com/angular/angular/pull/38542#top |
| crisbeto | https://github.com/crisbeto |
| angular:master | https://github.com/angular/angular/tree/master |
| crisbeto:38513/const-enum-references | https://github.com/crisbeto/angular/tree/38513/const-enum-references |
|
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| Aug 20, 2020 | https://github.com/angular/angular/pull/38542#issue-682438715 |
| #38513 | https://github.com/angular/angular/issues/38513 |
| Please reload this page | https://github.com/angular/angular/pull/38542 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Aug 20, 2020 | https://github.com/angular/angular/pull/38542#event-3673630076 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| force-pushed | https://github.com/angular/angular/compare/a03950dab242af8e79faafd76e74fc82c0473dca..22f279f3fa2e5fedbc1abe31cf29c7c5d87a52ec |
| a03950d | https://github.com/angular/angular/commit/a03950dab242af8e79faafd76e74fc82c0473dca |
| 22f279f | https://github.com/angular/angular/commit/22f279f3fa2e5fedbc1abe31cf29c7c5d87a52ec |
|
Compare
| https://github.com/angular/angular/compare/a03950dab242af8e79faafd76e74fc82c0473dca..22f279f3fa2e5fedbc1abe31cf29c7c5d87a52ec |
| August 20, 2020 08:25 | https://github.com/angular/angular/pull/38542#event-3674161834 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
|
area: compiler
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
| Aug 20, 2020 | https://github.com/angular/angular/pull/38542#event-3674379836 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Aug 20, 2020 | https://github.com/angular/angular/pull/38542#event-3674379929 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| August 20, 2020 09:23 | https://github.com/angular/angular/pull/38542#event-3674380083 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| JoostK | https://github.com/JoostK |
| August 20, 2020 09:23 | https://github.com/angular/angular/pull/38542#event-3674380356 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| force-pushed | https://github.com/angular/angular/compare/8895caf6444e5e26f283f11beb69adfa61fe4ec7..da4fd06b9f250ae64cf277f198b32119f1c647f3 |
| 8895caf | https://github.com/angular/angular/commit/8895caf6444e5e26f283f11beb69adfa61fe4ec7 |
| da4fd06 | https://github.com/angular/angular/commit/da4fd06b9f250ae64cf277f198b32119f1c647f3 |
|
Compare
| https://github.com/angular/angular/compare/8895caf6444e5e26f283f11beb69adfa61fe4ec7..da4fd06b9f250ae64cf277f198b32119f1c647f3 |
| August 20, 2020 20:28 | https://github.com/angular/angular/pull/38542#event-3676986793 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Aug 20, 2020
| https://github.com/angular/angular/pull/38542#pullrequestreview-471964334 |
|
View reviewed changes
| https://github.com/angular/angular/pull/38542/files |
| JoostK | https://github.com/JoostK |
| https://github.com/angular/angular/pull/38542#pullrequestreview-471964334 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/38542 |
| packages/compiler-cli/test/ngtsc/ngtsc_spec.ts | https://github.com/angular/angular/pull/38542/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb |
| Please reload this page | https://github.com/angular/angular/pull/38542 |
|
| https://github.com/crisbeto |
| fix(compiler-cli): adding references to const enums in runtime code | https://github.com/angular/angular/pull/38542/commits/41b1fff200fff3fb74d7033131472fcf72a82b75 |
| 41b1fff | https://github.com/angular/angular/pull/38542/commits/41b1fff200fff3fb74d7033131472fcf72a82b75 |
| angular#38513 | https://github.com/angular/angular/issues/38513 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
| force-pushed | https://github.com/angular/angular/compare/da4fd06b9f250ae64cf277f198b32119f1c647f3..41b1fff200fff3fb74d7033131472fcf72a82b75 |
| da4fd06 | https://github.com/angular/angular/commit/da4fd06b9f250ae64cf277f198b32119f1c647f3 |
| 41b1fff | https://github.com/angular/angular/commit/41b1fff200fff3fb74d7033131472fcf72a82b75 |
|
Compare
| https://github.com/angular/angular/compare/da4fd06b9f250ae64cf277f198b32119f1c647f3..41b1fff200fff3fb74d7033131472fcf72a82b75 |
| August 20, 2020 21:21 | https://github.com/angular/angular/pull/38542#event-3677161089 |
| https://github.com/crisbeto |
| crisbeto | https://github.com/crisbeto |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Aug 20, 2020 | https://github.com/angular/angular/pull/38542#event-3677161650 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| Aug 21, 2020 | https://github.com/angular/angular/pull/38542#issuecomment-678425618 |
| Please reload this page | https://github.com/angular/angular/pull/38542 |
| presubmit | http://test/OCL:327842074:BASE:327842111:1598034064806:b5d4bf53 |
| Please reload this page | https://github.com/angular/angular/pull/38542 |
| https://github.com/mhevery |
| mhevery | https://github.com/mhevery |
| e7da404 | https://github.com/angular/angular/commit/e7da4040d64bc9055c183cc3ecbbb24eee82596f |
| Aug 21, 2020 | https://github.com/angular/angular/pull/38542#event-3680851746 |
| mhevery | https://github.com/mhevery |
|
Aug 21, 2020
| https://github.com/angular/angular/pull/38542#ref-commit-814b436 |
|
| https://github.com/crisbeto |
|
| https://github.com/mhevery |
| fix(compiler-cli): adding references to const enums in runtime code ( | https://github.com/angular/angular/commit/814b43647d04ececea6a74960e09a39eb2b17a2f |
| #… | https://github.com/angular/angular/pull/38542 |
| 814b436 | https://github.com/angular/angular/commit/814b43647d04ececea6a74960e09a39eb2b17a2f |
| …38542 | https://github.com/angular/angular/pull/38542 |
| #38513 | https://github.com/angular/angular/issues/38513 |
| #38542 | https://github.com/angular/angular/pull/38542 |
| subratpalhar92 | https://github.com/subratpalhar92 |
|
Aug 29, 2020
| https://github.com/angular/angular/pull/38542#ref-commit-a377d6e |
|
| https://github.com/crisbeto |
|
| https://github.com/subratpalhar92 |
| fix(compiler-cli): adding references to const enums in runtime code ( | https://github.com/SUBRATPALHAR-ALL-JAVASCRIPT/angular/commit/a377d6e15c6c77fabcdc181f750dc3678d3d44ac |
| a… | https://github.com/angular/angular/pull/38542 |
| a377d6e | https://github.com/SUBRATPALHAR-ALL-JAVASCRIPT/angular/commit/a377d6e15c6c77fabcdc181f750dc3678d3d44ac |
| …ngular#38542 | https://github.com/angular/angular/pull/38542 |
| angular#38513 | https://github.com/angular/angular/issues/38513 |
| angular#38542 | https://github.com/angular/angular/pull/38542 |
| subratpalhar92 | https://github.com/subratpalhar92 |
|
Aug 31, 2020
| https://github.com/angular/angular/pull/38542#ref-commit-17ef589 |
|
| https://github.com/subratpalhar92 |
| Revert "fix(compiler-cli): adding references to const enums in runtim… | https://github.com/SUBRATPALHAR-ALL-JAVASCRIPT/angular/commit/17ef589ed3edc9cdd236f41cb2e328d1b2c6202d |
| 17ef589 | https://github.com/SUBRATPALHAR-ALL-JAVASCRIPT/angular/commit/17ef589ed3edc9cdd236f41cb2e328d1b2c6202d |
| angular#38542 | https://github.com/angular/angular/pull/38542 |
| a377d6e | https://github.com/SUBRATPALHAR-ALL-JAVASCRIPT/angular/commit/a377d6e15c6c77fabcdc181f750dc3678d3d44ac |
| profanis | https://github.com/profanis |
|
Sep 5, 2020
| https://github.com/angular/angular/pull/38542#ref-commit-c421045 |
|
| https://github.com/crisbeto |
|
| https://github.com/profanis |
| fix(compiler-cli): adding references to const enums in runtime code ( | https://github.com/profanis/angular/commit/c42104597801458d53dab6f45c994ab0ce3151d6 |
| a… | https://github.com/angular/angular/pull/38542 |
| c421045 | https://github.com/profanis/angular/commit/c42104597801458d53dab6f45c994ab0ce3151d6 |
| …ngular#38542 | https://github.com/angular/angular/pull/38542 |
| angular#38513 | https://github.com/angular/angular/issues/38513 |
| angular#38542 | https://github.com/angular/angular/pull/38542 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 21, 2020 | https://github.com/angular/angular/pull/38542#issuecomment-696222438 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/38542 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Sep 21, 2020 | https://github.com/angular/angular/pull/38542#event-3789523374 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38542 |
|
| https://github.com/JoostK |
|
JoostK
| https://github.com/JoostK |
|
| https://github.com/angular/angular/pull/38542/files/da4fd06b9f250ae64cf277f198b32119f1c647f3 |
| Please reload this page | https://github.com/angular/angular/pull/38542 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: presubmit
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22 |
|
area: compiler
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
@Inject enum in constructor causes runtime error after building in JIT mode.
| https://github.com/angular/angular/issues/38513 |
| Please reload this page | https://github.com/angular/angular/pull/38542 |
|
| https://github.com/crisbeto |
|
| https://github.com/mhevery |
|
| https://github.com/JoostK |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |