René's URL Explorer Experiment


Title: fix(compiler-cli): adding references to const enums in runtime code by crisbeto · Pull Request #38542 · angular/angular · GitHub

Open Graph Title: fix(compiler-cli): adding references to const enums in runtime code by crisbeto · Pull Request #38542 · angular/angular

X Title: fix(compiler-cli): adding references to const enums in runtime code by crisbeto · Pull Request #38542 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: We had a couple of places where we were assuming that if a particular symbol has a value, then it will exist at runtime. This is true in most cases, but it breaks down for const enums. Fixes #38513.

X Description: We had a couple of places where we were assuming that if a particular symbol has a value, then it will exist at runtime. This is true in most cases, but it breaks down for const enums. Fixes #38513.

Opengraph URL: https://github.com/angular/angular/pull/38542

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f75e1ae8-1171-2edb-87af-d959a5a47a01
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDE30:2EF149:1C27BA:24CB58:6B0164E1
html-safe-nonce91dac902f741610a25be6687a49cfc476735f77224acec46f6823b3a74ea04b8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERTMwOjJFRjE0OToxQzI3QkE6MjRDQjU4OjZCMDE2NEUxIiwidmlzaXRvcl9pZCI6IjY0MjY2NDUwNjY3MTQwMTQ5NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1dff6fc3b51d723d1b75612acf0a0e7cb46ce073b4e011870139422692693b7b
hovercard-subject-tagpull_request:470679768
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/38542/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/9d4cede68a852456f90ec9a8247d2774763317d8839b65356338b47d6f95dd40/angular/angular/pull/38542
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9d4cede68a852456f90ec9a8247d2774763317d8839b65356338b47d6f95dd40/angular/angular/pull/38542
og:image:altWe had a couple of places where we were assuming that if a particular symbol has a value, then it will exist at runtime. This is true in most cases, but it breaks down for const enums. Fixes #38513.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamecrisbeto
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/38542#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38542
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38542
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/38542
Reloadhttps://github.com/angular/angular/pull/38542
Reloadhttps://github.com/angular/angular/pull/38542
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
crisbetohttps://github.com/crisbeto
angular:masterhttps://github.com/angular/angular/tree/master
crisbeto:38513/const-enum-referenceshttps://github.com/crisbeto/angular/tree/38513/const-enum-references
Conversationhttps://github.com/angular/angular/pull/38542
Commits1 (1)https://github.com/angular/angular/pull/38542/commits
Checkshttps://github.com/angular/angular/pull/38542/checks
Files changedhttps://github.com/angular/angular/pull/38542/files
fix(compiler-cli): adding references to const enums in runtime codehttps://github.com/angular/angular/pull/38542#top
crisbetohttps://github.com/crisbeto
angular:masterhttps://github.com/angular/angular/tree/master
crisbeto:38513/const-enum-referenceshttps://github.com/crisbeto/angular/tree/38513/const-enum-references
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
Aug 20, 2020https://github.com/angular/angular/pull/38542#issue-682438715
#38513https://github.com/angular/angular/issues/38513
Please reload this pagehttps://github.com/angular/angular/pull/38542
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Aug 20, 2020https://github.com/angular/angular/pull/38542#event-3673630076
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
force-pushedhttps://github.com/angular/angular/compare/a03950dab242af8e79faafd76e74fc82c0473dca..22f279f3fa2e5fedbc1abe31cf29c7c5d87a52ec
a03950dhttps://github.com/angular/angular/commit/a03950dab242af8e79faafd76e74fc82c0473dca
22f279fhttps://github.com/angular/angular/commit/22f279f3fa2e5fedbc1abe31cf29c7c5d87a52ec
Compare https://github.com/angular/angular/compare/a03950dab242af8e79faafd76e74fc82c0473dca..22f279f3fa2e5fedbc1abe31cf29c7c5d87a52ec
August 20, 2020 08:25https://github.com/angular/angular/pull/38542#event-3674161834
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Aug 20, 2020https://github.com/angular/angular/pull/38542#event-3674379836
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Aug 20, 2020https://github.com/angular/angular/pull/38542#event-3674379929
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
August 20, 2020 09:23https://github.com/angular/angular/pull/38542#event-3674380083
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
JoostKhttps://github.com/JoostK
August 20, 2020 09:23https://github.com/angular/angular/pull/38542#event-3674380356
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
force-pushedhttps://github.com/angular/angular/compare/8895caf6444e5e26f283f11beb69adfa61fe4ec7..da4fd06b9f250ae64cf277f198b32119f1c647f3
8895cafhttps://github.com/angular/angular/commit/8895caf6444e5e26f283f11beb69adfa61fe4ec7
da4fd06https://github.com/angular/angular/commit/da4fd06b9f250ae64cf277f198b32119f1c647f3
Compare https://github.com/angular/angular/compare/8895caf6444e5e26f283f11beb69adfa61fe4ec7..da4fd06b9f250ae64cf277f198b32119f1c647f3
August 20, 2020 20:28https://github.com/angular/angular/pull/38542#event-3676986793
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Aug 20, 2020 https://github.com/angular/angular/pull/38542#pullrequestreview-471964334
View reviewed changes https://github.com/angular/angular/pull/38542/files
JoostKhttps://github.com/JoostK
https://github.com/angular/angular/pull/38542#pullrequestreview-471964334
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/38542
packages/compiler-cli/test/ngtsc/ngtsc_spec.tshttps://github.com/angular/angular/pull/38542/files#diff-9b200a5c9335361ab911b28a6e5baa0a4487cf4f0c2fc5b1c10bc46829426abb
Please reload this pagehttps://github.com/angular/angular/pull/38542
https://github.com/crisbeto
fix(compiler-cli): adding references to const enums in runtime codehttps://github.com/angular/angular/pull/38542/commits/41b1fff200fff3fb74d7033131472fcf72a82b75
41b1fffhttps://github.com/angular/angular/pull/38542/commits/41b1fff200fff3fb74d7033131472fcf72a82b75
angular#38513https://github.com/angular/angular/issues/38513
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
force-pushedhttps://github.com/angular/angular/compare/da4fd06b9f250ae64cf277f198b32119f1c647f3..41b1fff200fff3fb74d7033131472fcf72a82b75
da4fd06https://github.com/angular/angular/commit/da4fd06b9f250ae64cf277f198b32119f1c647f3
41b1fffhttps://github.com/angular/angular/commit/41b1fff200fff3fb74d7033131472fcf72a82b75
Compare https://github.com/angular/angular/compare/da4fd06b9f250ae64cf277f198b32119f1c647f3..41b1fff200fff3fb74d7033131472fcf72a82b75
August 20, 2020 21:21https://github.com/angular/angular/pull/38542#event-3677161089
https://github.com/crisbeto
crisbetohttps://github.com/crisbeto
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Aug 20, 2020https://github.com/angular/angular/pull/38542#event-3677161650
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Aug 21, 2020https://github.com/angular/angular/pull/38542#issuecomment-678425618
Please reload this pagehttps://github.com/angular/angular/pull/38542
presubmithttp://test/OCL:327842074:BASE:327842111:1598034064806:b5d4bf53
Please reload this pagehttps://github.com/angular/angular/pull/38542
https://github.com/mhevery
mheveryhttps://github.com/mhevery
e7da404https://github.com/angular/angular/commit/e7da4040d64bc9055c183cc3ecbbb24eee82596f
Aug 21, 2020https://github.com/angular/angular/pull/38542#event-3680851746
mheveryhttps://github.com/mhevery
Aug 21, 2020 https://github.com/angular/angular/pull/38542#ref-commit-814b436
https://github.com/crisbeto
https://github.com/mhevery
fix(compiler-cli): adding references to const enums in runtime code (https://github.com/angular/angular/commit/814b43647d04ececea6a74960e09a39eb2b17a2f
#…https://github.com/angular/angular/pull/38542
814b436https://github.com/angular/angular/commit/814b43647d04ececea6a74960e09a39eb2b17a2f
…38542https://github.com/angular/angular/pull/38542
#38513https://github.com/angular/angular/issues/38513
#38542https://github.com/angular/angular/pull/38542
subratpalhar92https://github.com/subratpalhar92
Aug 29, 2020 https://github.com/angular/angular/pull/38542#ref-commit-a377d6e
https://github.com/crisbeto
https://github.com/subratpalhar92
fix(compiler-cli): adding references to const enums in runtime code (https://github.com/SUBRATPALHAR-ALL-JAVASCRIPT/angular/commit/a377d6e15c6c77fabcdc181f750dc3678d3d44ac
a…https://github.com/angular/angular/pull/38542
a377d6ehttps://github.com/SUBRATPALHAR-ALL-JAVASCRIPT/angular/commit/a377d6e15c6c77fabcdc181f750dc3678d3d44ac
…ngular#38542https://github.com/angular/angular/pull/38542
angular#38513https://github.com/angular/angular/issues/38513
angular#38542https://github.com/angular/angular/pull/38542
subratpalhar92https://github.com/subratpalhar92
Aug 31, 2020 https://github.com/angular/angular/pull/38542#ref-commit-17ef589
https://github.com/subratpalhar92
Revert "fix(compiler-cli): adding references to const enums in runtim…https://github.com/SUBRATPALHAR-ALL-JAVASCRIPT/angular/commit/17ef589ed3edc9cdd236f41cb2e328d1b2c6202d
17ef589https://github.com/SUBRATPALHAR-ALL-JAVASCRIPT/angular/commit/17ef589ed3edc9cdd236f41cb2e328d1b2c6202d
angular#38542https://github.com/angular/angular/pull/38542
a377d6ehttps://github.com/SUBRATPALHAR-ALL-JAVASCRIPT/angular/commit/a377d6e15c6c77fabcdc181f750dc3678d3d44ac
profanishttps://github.com/profanis
Sep 5, 2020 https://github.com/angular/angular/pull/38542#ref-commit-c421045
https://github.com/crisbeto
https://github.com/profanis
fix(compiler-cli): adding references to const enums in runtime code (https://github.com/profanis/angular/commit/c42104597801458d53dab6f45c994ab0ce3151d6
a…https://github.com/angular/angular/pull/38542
c421045https://github.com/profanis/angular/commit/c42104597801458d53dab6f45c994ab0ce3151d6
…ngular#38542https://github.com/angular/angular/pull/38542
angular#38513https://github.com/angular/angular/issues/38513
angular#38542https://github.com/angular/angular/pull/38542
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 21, 2020https://github.com/angular/angular/pull/38542#issuecomment-696222438
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/38542
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Sep 21, 2020https://github.com/angular/angular/pull/38542#event-3789523374
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38542
https://github.com/JoostK
JoostK https://github.com/JoostK
https://github.com/angular/angular/pull/38542/files/da4fd06b9f250ae64cf277f198b32119f1c647f3
Please reload this pagehttps://github.com/angular/angular/pull/38542
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
area: compiler https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
@Inject enum in constructor causes runtime error after building in JIT mode. https://github.com/angular/angular/issues/38513
Please reload this pagehttps://github.com/angular/angular/pull/38542
https://github.com/crisbeto
https://github.com/mhevery
https://github.com/JoostK
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.