René's URL Explorer Experiment


Title: refactor(forms): refactor common validators used in unit tests by benbraou · Pull Request #38020 · angular/angular · GitHub

Open Graph Title: refactor(forms): refactor common validators used in unit tests by benbraou · Pull Request #38020 · angular/angular

X Title: refactor(forms): refactor common validators used in unit tests by benbraou · Pull Request #38020 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? asyncValidator is duplicated across multiple form test files. Issue Number: N/A #37831 What is the new behavior? A util file is added to forms test package: it exposes simpleAsyncValidator, asyncValidator and asyncValidatorReturningObservable validators it refactors simpleAsyncValidator and asyncValidator to use common promise creation code it exposes currentStateOf allowing to get the validation state of a list of AbstractControl Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/38020

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8322a1d5-716b-e01e-4ba4-1bff220f8e83
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9416:33444D:1DD0942:27A2646:6B016E36
html-safe-nonce066fe3120a36e46fad1ac31274838e89e92cc29f7b3a166290f1d508439bdbdb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDE2OjMzNDQ0RDoxREQwOTQyOjI3QTI2NDY6NkIwMTZFMzYiLCJ2aXNpdG9yX2lkIjoiNDIxMTQ4Mzg2NjY4NDI4ODU2NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd12cc3426d804e729041cd50b22306ce0511ac161d1cedae5f67fe1d279a0975
hovercard-subject-tagpull_request:447972424
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/38020/files
twitter:imagehttps://avatars.githubusercontent.com/u/14368835?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/14368835?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/38020/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38020%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F38020%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/38020/files
Reloadhttps://github.com/angular/angular/pull/38020/files
Reloadhttps://github.com/angular/angular/pull/38020/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
benbraouhttps://github.com/benbraou
angular:masterhttps://github.com/angular/angular/tree/master
benbraou:issue37831https://github.com/benbraou/angular/tree/issue37831
Conversation 14 https://github.com/angular/angular/pull/38020
Commits 1 https://github.com/angular/angular/pull/38020/commits
Checks 0 https://github.com/angular/angular/pull/38020/checks
Files changed https://github.com/angular/angular/pull/38020/files
Please reload this pagehttps://github.com/angular/angular/pull/38020/files
refactor(forms): refactor common validators used in unit tests https://github.com/angular/angular/pull/38020/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/38020/files
78ad78d refactor(forms): refactor common validators used in unit tests benbraou Jul 12, 2020 https://github.com/angular/angular/pull/38020/commits/78ad78da79db42ff338fa481f4ca5325062faf90
Clear filters https://github.com/angular/angular/pull/38020/files
Please reload this pagehttps://github.com/angular/angular/pull/38020/files
Please reload this pagehttps://github.com/angular/angular/pull/38020/files
directives_spec.ts https://github.com/angular/angular/pull/38020/files#diff-2bd39b55c7ead50463904e7e8d121d5a351003b41857605da04c038909d5e457
form_array_spec.ts https://github.com/angular/angular/pull/38020/files#diff-b6aa4dfc3fbd622d82cf4df4b38d7dec7aef109704afc8841c42ed6f855e9a31
form_control_spec.ts https://github.com/angular/angular/pull/38020/files#diff-e94f8a568f970a765b8476b3eb23a785d95cc34a10223554b492ab989d848e40
form_group_spec.ts https://github.com/angular/angular/pull/38020/files#diff-c2ef6b8c8640ad612f7d5ccb48922532b3fccc682983581468c8ffd609ea409c
util.ts https://github.com/angular/angular/pull/38020/files#diff-81ee64c3612d743e490776adb548c2f369bc4c4adbb44f9c68886cb105aa37a3
packages/forms/test/directives_spec.tshttps://github.com/angular/angular/pull/38020/files#diff-2bd39b55c7ead50463904e7e8d121d5a351003b41857605da04c038909d5e457
View file https://github.com/benbraou/angular/blob/78ad78da79db42ff338fa481f4ca5325062faf90/packages/forms/test/directives_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38020/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38020/files#diff-2bd39b55c7ead50463904e7e8d121d5a351003b41857605da04c038909d5e457
https://github.com/angular/angular/pull/38020/files#diff-2bd39b55c7ead50463904e7e8d121d5a351003b41857605da04c038909d5e457
https://github.com/angular/angular/pull/38020/files#diff-2bd39b55c7ead50463904e7e8d121d5a351003b41857605da04c038909d5e457
packages/forms/test/form_array_spec.tshttps://github.com/angular/angular/pull/38020/files#diff-b6aa4dfc3fbd622d82cf4df4b38d7dec7aef109704afc8841c42ed6f855e9a31
View file https://github.com/benbraou/angular/blob/78ad78da79db42ff338fa481f4ca5325062faf90/packages/forms/test/form_array_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38020/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38020/files#diff-b6aa4dfc3fbd622d82cf4df4b38d7dec7aef109704afc8841c42ed6f855e9a31
https://github.com/angular/angular/pull/38020/files#diff-b6aa4dfc3fbd622d82cf4df4b38d7dec7aef109704afc8841c42ed6f855e9a31
packages/forms/test/form_control_spec.tshttps://github.com/angular/angular/pull/38020/files#diff-e94f8a568f970a765b8476b3eb23a785d95cc34a10223554b492ab989d848e40
View file https://github.com/benbraou/angular/blob/78ad78da79db42ff338fa481f4ca5325062faf90/packages/forms/test/form_control_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38020/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38020/files#diff-e94f8a568f970a765b8476b3eb23a785d95cc34a10223554b492ab989d848e40
https://github.com/angular/angular/pull/38020/files#diff-e94f8a568f970a765b8476b3eb23a785d95cc34a10223554b492ab989d848e40
packages/forms/test/form_group_spec.tshttps://github.com/angular/angular/pull/38020/files#diff-c2ef6b8c8640ad612f7d5ccb48922532b3fccc682983581468c8ffd609ea409c
View file https://github.com/benbraou/angular/blob/78ad78da79db42ff338fa481f4ca5325062faf90/packages/forms/test/form_group_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38020/{{ revealButtonHref }}
https://github.com/angular/angular/pull/38020/files#diff-c2ef6b8c8640ad612f7d5ccb48922532b3fccc682983581468c8ffd609ea409c
https://github.com/angular/angular/pull/38020/files#diff-c2ef6b8c8640ad612f7d5ccb48922532b3fccc682983581468c8ffd609ea409c
packages/forms/test/util.tshttps://github.com/angular/angular/pull/38020/files#diff-81ee64c3612d743e490776adb548c2f369bc4c4adbb44f9c68886cb105aa37a3
View file https://github.com/benbraou/angular/blob/78ad78da79db42ff338fa481f4ca5325062faf90/packages/forms/test/util.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/38020/{{ revealButtonHref }}
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.