René's URL Explorer Experiment


Title: fix(compiler): allow banana-in-a-box bindings to end with non-null assertion by JoostK · Pull Request #37809 · angular/angular · GitHub

Open Graph Title: fix(compiler): allow banana-in-a-box bindings to end with non-null assertion by JoostK · Pull Request #37809 · angular/angular

X Title: fix(compiler): allow banana-in-a-box bindings to end with non-null assertion by JoostK · Pull Request #37809 · angular/angular

Description: For two-way-bindings that use the banana-in-a-box syntax, the compiler synthesizes an event assignment expression from the primary expression. It is valid for the primary expression to be terminated by the non-null operator, however naive string substitution is used for the synthesized expression, such that the ! would immediately precede the = token, resulting in the valid != operator token. The expression would still parse correctly but it doesn't implement the proper semantics, resulting in incorrect runtime behavior. Changing the expression substitution to force a space between the primary expression and the assignment avoids this mistake, but it uncovers a new issue. The grammar does not allow for the LHS of an assignment to be the non-null operator, so the synthesized expression would fail to parse. To alleviate this, the synthesized expression is parsed with a special parser flag to allow for this syntax. Fixes #36551 Implementation note: it is up for debate whether extending the grammar to accept more expressions as LHS of an assignment would be desirable for regular output bindings. I choose not to change the grammar at this moment, as it seems like a change that needs to be introduced in at least a minor. Additionally, I feel like the whole expression substitution is a bit of a hack in the first place, so an alternative way of handling this case may be desirable in the future. To allow for this cleanup, I feel like it's best to wait for VE removal as the parser infrastructure is currently quite convoluted.

Open Graph Description: For two-way-bindings that use the banana-in-a-box syntax, the compiler synthesizes an event assignment expression from the primary expression. It is valid for the primary expression to be terminate...

X Description: For two-way-bindings that use the banana-in-a-box syntax, the compiler synthesizes an event assignment expression from the primary expression. It is valid for the primary expression to be terminate...

Opengraph URL: https://github.com/angular/angular/pull/37809

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0e500630-0eae-0586-28dd-67fa99d5c9bd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD4B4:2564D8:196FE23:218C2FA:6B0143B1
html-safe-nonce46d370f64dd177f61c80060792e99fb7a9c9852a7463029377af06537669b10d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENEI0OjI1NjREODoxOTZGRTIzOjIxOEMyRkE6NkIwMTQzQjEiLCJ2aXNpdG9yX2lkIjoiNzA3NjYxMzg4NzkzNTcyNjUxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacc56e4b13cc92cb2e1fa4c7ce4d4c0f10925d519141744009862777a281bba9c7
hovercard-subject-tagpull_request:441083111
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/37809/files
twitter:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
og:image:altFor two-way-bindings that use the banana-in-a-box syntax, the compiler synthesizes an event assignment expression from the primary expression. It is valid for the primary expression to be terminate...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/37809/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37809%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37809%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/37809/files
Reloadhttps://github.com/angular/angular/pull/37809/files
Reloadhttps://github.com/angular/angular/pull/37809/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:non-null-two-way-bindingshttps://github.com/JoostK/angular/tree/non-null-two-way-bindings
Conversation 27 https://github.com/angular/angular/pull/37809
Commits 1 https://github.com/angular/angular/pull/37809/commits
Checks 0 https://github.com/angular/angular/pull/37809/checks
Files changed https://github.com/angular/angular/pull/37809/files
Please reload this pagehttps://github.com/angular/angular/pull/37809/files
fix(compiler): allow banana-in-a-box bindings to end with non-null assertion https://github.com/angular/angular/pull/37809/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/37809/files
9751bcb fix(compiler): allow banana-in-a-box bindings to end with non-null as… JoostK Jun 28, 2020 https://github.com/angular/angular/pull/37809/commits/9751bcbe393118e5b98d4cbe3978d72f6ce3a162
Clear filters https://github.com/angular/angular/pull/37809/files
Please reload this pagehttps://github.com/angular/angular/pull/37809/files
Please reload this pagehttps://github.com/angular/angular/pull/37809/files
parser.ts https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
r3_template_transform.ts https://github.com/angular/angular/pull/37809/files#diff-bd2071834447626dd140448c977e33a8fae854b527a1dbdadc5d2be4108a48a3
binding_parser.ts https://github.com/angular/angular/pull/37809/files#diff-8c12a8195781e2ab595db7d5c8013d5da38a7a76fb1379a36aafb93a7c03e77c
parser_spec.ts https://github.com/angular/angular/pull/37809/files#diff-f6e4825f64f47f0d247895493187f52d7ace19fe0170df3d3bc5e8de9387f728
r3_template_transform_spec.ts https://github.com/angular/angular/pull/37809/files#diff-9f7ec17dd7b96d636aa27b38871ecf47e86afc5823046637d19bac1918409746
packages/compiler/src/expression_parser/parser.tshttps://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
View file https://github.com/JoostK/angular/blob/9751bcbe393118e5b98d4cbe3978d72f6ce3a162/packages/compiler/src/expression_parser/parser.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37809/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
AndrewKushnirhttps://github.com/AndrewKushnir
Nov 4, 2021https://github.com/angular/angular/pull/37809/files#r743178331
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/37809/files
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
AndrewKushnirhttps://github.com/AndrewKushnir
Nov 4, 2021https://github.com/angular/angular/pull/37809/files#r743179323
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/37809/files
https://github.com/angular/angular/pull/37809/files#diff-76d1ad8f871654a457a3f08658e35630716f5547fe21b3cd6d1144d82fd894d7
packages/compiler/src/render3/r3_template_transform.tshttps://github.com/angular/angular/pull/37809/files#diff-bd2071834447626dd140448c977e33a8fae854b527a1dbdadc5d2be4108a48a3
View file https://github.com/JoostK/angular/blob/9751bcbe393118e5b98d4cbe3978d72f6ce3a162/packages/compiler/src/render3/r3_template_transform.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37809/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37809/files#diff-bd2071834447626dd140448c977e33a8fae854b527a1dbdadc5d2be4108a48a3
https://github.com/angular/angular/pull/37809/files#diff-bd2071834447626dd140448c977e33a8fae854b527a1dbdadc5d2be4108a48a3
https://github.com/angular/angular/pull/37809/files#diff-bd2071834447626dd140448c977e33a8fae854b527a1dbdadc5d2be4108a48a3
https://github.com/angular/angular/pull/37809/files#diff-bd2071834447626dd140448c977e33a8fae854b527a1dbdadc5d2be4108a48a3
https://github.com/angular/angular/pull/37809/files#diff-bd2071834447626dd140448c977e33a8fae854b527a1dbdadc5d2be4108a48a3
https://github.com/angular/angular/pull/37809/files#diff-bd2071834447626dd140448c977e33a8fae854b527a1dbdadc5d2be4108a48a3
packages/compiler/src/template_parser/binding_parser.tshttps://github.com/angular/angular/pull/37809/files#diff-8c12a8195781e2ab595db7d5c8013d5da38a7a76fb1379a36aafb93a7c03e77c
View file https://github.com/JoostK/angular/blob/9751bcbe393118e5b98d4cbe3978d72f6ce3a162/packages/compiler/src/template_parser/binding_parser.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37809/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37809/files#diff-8c12a8195781e2ab595db7d5c8013d5da38a7a76fb1379a36aafb93a7c03e77c
https://github.com/angular/angular/pull/37809/files#diff-8c12a8195781e2ab595db7d5c8013d5da38a7a76fb1379a36aafb93a7c03e77c
https://github.com/angular/angular/pull/37809/files#diff-8c12a8195781e2ab595db7d5c8013d5da38a7a76fb1379a36aafb93a7c03e77c
https://github.com/angular/angular/pull/37809/files#diff-8c12a8195781e2ab595db7d5c8013d5da38a7a76fb1379a36aafb93a7c03e77c
https://github.com/angular/angular/pull/37809/files#diff-8c12a8195781e2ab595db7d5c8013d5da38a7a76fb1379a36aafb93a7c03e77c
https://github.com/angular/angular/pull/37809/files#diff-8c12a8195781e2ab595db7d5c8013d5da38a7a76fb1379a36aafb93a7c03e77c
https://github.com/angular/angular/pull/37809/files#diff-8c12a8195781e2ab595db7d5c8013d5da38a7a76fb1379a36aafb93a7c03e77c
packages/compiler/test/expression_parser/parser_spec.tshttps://github.com/angular/angular/pull/37809/files#diff-f6e4825f64f47f0d247895493187f52d7ace19fe0170df3d3bc5e8de9387f728
View file https://github.com/JoostK/angular/blob/9751bcbe393118e5b98d4cbe3978d72f6ce3a162/packages/compiler/test/expression_parser/parser_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37809/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37809/files#diff-f6e4825f64f47f0d247895493187f52d7ace19fe0170df3d3bc5e8de9387f728
https://github.com/angular/angular/pull/37809/files#diff-f6e4825f64f47f0d247895493187f52d7ace19fe0170df3d3bc5e8de9387f728
packages/compiler/test/render3/r3_template_transform_spec.tshttps://github.com/angular/angular/pull/37809/files#diff-9f7ec17dd7b96d636aa27b38871ecf47e86afc5823046637d19bac1918409746
View file https://github.com/JoostK/angular/blob/9751bcbe393118e5b98d4cbe3978d72f6ce3a162/packages/compiler/test/render3/r3_template_transform_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37809/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37809/files#diff-9f7ec17dd7b96d636aa27b38871ecf47e86afc5823046637d19bac1918409746
https://github.com/angular/angular/pull/37809/files#diff-9f7ec17dd7b96d636aa27b38871ecf47e86afc5823046637d19bac1918409746
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.