Title: fix(zone.js): defineProperty patch should not swallow error by JiaLiPassion · Pull Request #37582 · angular/angular · GitHub
Open Graph Title: fix(zone.js): defineProperty patch should not swallow error by JiaLiPassion · Pull Request #37582 · angular/angular
X Title: fix(zone.js): defineProperty patch should not swallow error by JiaLiPassion · Pull Request #37582 · angular/angular
Description: Close #37432 zone.js monkey patches the Object.defineProperty API long time ago angular/zone.js@383b479 to resolve issues in very old version of Chrome web which override the property of CustomElements, and this is not an issue any longer, so we may remove this monkey patch, since it may swallow the errors when the user want to define property on unconfigurable or frozen object properties. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A What is the new behavior? Does this PR introduce a breaking change? Yes No Since zone.js doesn't patch Object.defineProperty and not swallow the error when trying to define property on unconfigurable or undefined object, some application currently not throw error will begin to break. For example, in our saucelab test for IE and old firefox/chrome, before this PR, the code/spec are compiled to commonjs, and the js code will look like this. Object.defineProperty(exports, "__esModule", { value: true }) ... And the exports is undefined, It should throw error that trying to defineProperty on undefined, since zone.js monkey patch the Object.defineProperty and will catch the error and do nothing, so the test cases will continue to work. After this PR, zone.js will not do that any more, so the test cases will break. Other information
Open Graph Description: Close #37432 zone.js monkey patches the Object.defineProperty API long time ago angular/zone.js@383b479 to resolve issues in very old version of Chrome web which override the property of CustomElem...
X Description: Close #37432 zone.js monkey patches the Object.defineProperty API long time ago angular/zone.js@383b479 to resolve issues in very old version of Chrome web which override the property of CustomElem...
Opengraph URL: https://github.com/angular/angular/pull/37582
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1d821a06-195a-25fa-cefc-b2f00d4667a1 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8588:97D39:1392337:19C007F:6B02225C |
| html-safe-nonce | 019aaf28ac65f797d2daf0a7945a556dcf3d4846a1684ef0fb4ce370c2002d9f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTg4Ojk3RDM5OjEzOTIzMzc6MTlDMDA3Rjo2QjAyMjI1QyIsInZpc2l0b3JfaWQiOiI2MjcxMTg0Mjg0NDM5MTU5Mzg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | cd4eebb9f185f4cd0fd126ed3463d48d7bc35de10bff6d09c61f94111ec0b17c |
| hovercard-subject-tag | pull_request:434270124 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/37582/files |
| twitter:image | https://avatars.githubusercontent.com/u/1442575?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1442575?s=400&v=4 |
| og:image:alt | Close #37432 zone.js monkey patches the Object.defineProperty API long time ago angular/zone.js@383b479 to resolve issues in very old version of Chrome web which override the property of CustomElem... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 423dbb54c5e7bfecc838eb387c1435eb3d0e760d |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width