René's URL Explorer Experiment


Title: fix(zone.js): defineProperty patch should not swallow error by JiaLiPassion · Pull Request #37582 · angular/angular · GitHub

Open Graph Title: fix(zone.js): defineProperty patch should not swallow error by JiaLiPassion · Pull Request #37582 · angular/angular

X Title: fix(zone.js): defineProperty patch should not swallow error by JiaLiPassion · Pull Request #37582 · angular/angular

Description: Close #37432 zone.js monkey patches the Object.defineProperty API long time ago angular/zone.js@383b479 to resolve issues in very old version of Chrome web which override the property of CustomElements, and this is not an issue any longer, so we may remove this monkey patch, since it may swallow the errors when the user want to define property on unconfigurable or frozen object properties. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A What is the new behavior? Does this PR introduce a breaking change? Yes No Since zone.js doesn't patch Object.defineProperty and not swallow the error when trying to define property on unconfigurable or undefined object, some application currently not throw error will begin to break. For example, in our saucelab test for IE and old firefox/chrome, before this PR, the code/spec are compiled to commonjs, and the js code will look like this. Object.defineProperty(exports, "__esModule", { value: true }) ... And the exports is undefined, It should throw error that trying to defineProperty on undefined, since zone.js monkey patch the Object.defineProperty and will catch the error and do nothing, so the test cases will continue to work. After this PR, zone.js will not do that any more, so the test cases will break. Other information

Open Graph Description: Close #37432 zone.js monkey patches the Object.defineProperty API long time ago angular/zone.js@383b479 to resolve issues in very old version of Chrome web which override the property of CustomElem...

X Description: Close #37432 zone.js monkey patches the Object.defineProperty API long time ago angular/zone.js@383b479 to resolve issues in very old version of Chrome web which override the property of CustomElem...

Opengraph URL: https://github.com/angular/angular/pull/37582

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1d821a06-195a-25fa-cefc-b2f00d4667a1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8588:97D39:1392337:19C007F:6B02225C
html-safe-nonce019aaf28ac65f797d2daf0a7945a556dcf3d4846a1684ef0fb4ce370c2002d9f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NTg4Ojk3RDM5OjEzOTIzMzc6MTlDMDA3Rjo2QjAyMjI1QyIsInZpc2l0b3JfaWQiOiI2MjcxMTg0Mjg0NDM5MTU5Mzg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaccd4eebb9f185f4cd0fd126ed3463d48d7bc35de10bff6d09c61f94111ec0b17c
hovercard-subject-tagpull_request:434270124
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/37582/files
twitter:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
og:image:altClose #37432 zone.js monkey patches the Object.defineProperty API long time ago angular/zone.js@383b479 to resolve issues in very old version of Chrome web which override the property of CustomElem...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/37582/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37582%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37582%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/37582/files
Reloadhttps://github.com/angular/angular/pull/37582/files
Reloadhttps://github.com/angular/angular/pull/37582/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JiaLiPassionhttps://github.com/JiaLiPassion
angular:masterhttps://github.com/angular/angular/tree/master
JiaLiPassion:remove-define-propertyhttps://github.com/JiaLiPassion/angular/tree/remove-define-property
Conversation 38 https://github.com/angular/angular/pull/37582
Commits 2 https://github.com/angular/angular/pull/37582/commits
Checks 0 https://github.com/angular/angular/pull/37582/checks
Files changed https://github.com/angular/angular/pull/37582/files
Please reload this pagehttps://github.com/angular/angular/pull/37582/files
fix(zone.js): defineProperty patch should not swallow error https://github.com/angular/angular/pull/37582/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/37582/files
67e055a fix(zone.js): defineProperty patch should not swallow error JiaLiPassion Aug 31, 2020 https://github.com/angular/angular/pull/37582/commits/67e055afb741ee94d058f64a502e05ab9c306510
cfd6217 fix(zone.js): run tests in umd format JiaLiPassion Aug 31, 2020 https://github.com/angular/angular/pull/37582/commits/cfd6217920656c8ef3331baa83ffd8ceb7392239
Clear filters https://github.com/angular/angular/pull/37582/files
Please reload this pagehttps://github.com/angular/angular/pull/37582/files
Please reload this pagehttps://github.com/angular/angular/pull/37582/files
config.yml https://github.com/angular/angular/pull/37582/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47
define-property.ts https://github.com/angular/angular/pull/37582/files#diff-382e52347daeccbe7852e2ef748c4af8d3392f9d2012d6dffec87ceed2c2e18c
.circleci/config.ymlhttps://github.com/angular/angular/pull/37582/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47
View file https://github.com/JiaLiPassion/angular/blob/cfd6217920656c8ef3331baa83ffd8ceb7392239/.circleci/config.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37582/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37582/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47
Please reload this pagehttps://github.com/angular/angular/pull/37582/files
https://github.com/angular/angular/pull/37582/files#diff-78a8a19706dbd2a4425dd72bdab0502ed7a2cef16365ab7030a5a0588927bf47
packages/zone.js/lib/browser/define-property.tshttps://github.com/angular/angular/pull/37582/files#diff-382e52347daeccbe7852e2ef748c4af8d3392f9d2012d6dffec87ceed2c2e18c
View file https://github.com/JiaLiPassion/angular/blob/cfd6217920656c8ef3331baa83ffd8ceb7392239/packages/zone.js/lib/browser/define-property.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37582/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37582/files#diff-382e52347daeccbe7852e2ef748c4af8d3392f9d2012d6dffec87ceed2c2e18c
https://github.com/angular/angular/pull/37582/files#diff-382e52347daeccbe7852e2ef748c4af8d3392f9d2012d6dffec87ceed2c2e18c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.