René's URL Explorer Experiment


Title: style(ngcc): post-merge review tidy up by petebacondarwin · Pull Request #37461 · angular/angular · GitHub

Open Graph Title: style(ngcc): post-merge review tidy up by petebacondarwin · Pull Request #37461 · angular/angular

X Title: style(ngcc): post-merge review tidy up by petebacondarwin · Pull Request #37461 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This commit tidies up a few comments from a recent commit to help improve the clarity of the code.

X Description: This commit tidies up a few comments from a recent commit to help improve the clarity of the code.

Opengraph URL: https://github.com/angular/angular/pull/37461

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f99ee99e-f6ab-ebb3-72ec-50d90b79e95f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB01A:27E5CD:1A14AEF:216EEC1:6B013CDE
html-safe-nonce4781fdfad25bd92ccce76b7c2183782557f614d4d4749b6decb4d33d0065b967
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDFBOjI3RTVDRDoxQTE0QUVGOjIxNkVFQzE6NkIwMTNDREUiLCJ2aXNpdG9yX2lkIjoiODg1ODE1NDI4MzUyMzE5NDA3OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7010d9fce3ccdb7eedf2b2048a63846466b1bddf692929bc3678f7c5453a5b14
hovercard-subject-tagpull_request:428537769
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/37461/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a6c4711c2fc8bfca2123ea4bb3cd0da3ec9b8f0730748edb7473165745b02a63/angular/angular/pull/37461
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a6c4711c2fc8bfca2123ea4bb3cd0da3ec9b8f0730748edb7473165745b02a63/angular/angular/pull/37461
og:image:altThis commit tidies up a few comments from a recent commit to help improve the clarity of the code.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/37461#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37461
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37461
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/37461
Reloadhttps://github.com/angular/angular/pull/37461
Reloadhttps://github.com/angular/angular/pull/37461
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-program-based-entry-point-finder-fixeshttps://github.com/petebacondarwin/angular/tree/ngcc-program-based-entry-point-finder-fixes
Conversationhttps://github.com/angular/angular/pull/37461
Commits2 (2)https://github.com/angular/angular/pull/37461/commits
Checkshttps://github.com/angular/angular/pull/37461/checks
Files changedhttps://github.com/angular/angular/pull/37461/files
style(ngcc): post-merge review tidy uphttps://github.com/angular/angular/pull/37461#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-program-based-entry-point-finder-fixeshttps://github.com/petebacondarwin/angular/tree/ngcc-program-based-entry-point-finder-fixes
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jun 5, 2020https://github.com/angular/angular/pull/37461#issue-631700221
Please reload this pagehttps://github.com/angular/angular/pull/37461
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
refactoring https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Arefactoring
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
comp: ngcc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
Jun 5, 2020https://github.com/angular/angular/pull/37461#event-3411920101
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Jun 5, 2020https://github.com/angular/angular/pull/37461#event-3411920249
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Jun 5, 2020https://github.com/angular/angular/pull/37461#event-3411920293
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
gkalpakhttps://github.com/gkalpak
June 5, 2020 15:41https://github.com/angular/angular/pull/37461#event-3411920504
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Jun 5, 2020 https://github.com/angular/angular/pull/37461#ref-pullrequest-616872456
ngcc: implement a new program-based entry-point finder #37075 https://github.com/angular/angular/pull/37075
https://github.com/petebacondarwin
style(ngcc): post-merge review tidy uphttps://github.com/angular/angular/pull/37461/commits/2cae679bb21c3702da595168a210ae3b40fc8d0e
2cae679https://github.com/angular/angular/pull/37461/commits/2cae679bb21c3702da595168a210ae3b40fc8d0e
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/2ed6d195fa942fa433829856af163ea7c7492960..2cae679bb21c3702da595168a210ae3b40fc8d0e
2ed6d19https://github.com/angular/angular/commit/2ed6d195fa942fa433829856af163ea7c7492960
2cae679https://github.com/angular/angular/commit/2cae679bb21c3702da595168a210ae3b40fc8d0e
Compare https://github.com/angular/angular/compare/2ed6d195fa942fa433829856af163ea7c7492960..2cae679bb21c3702da595168a210ae3b40fc8d0e
June 5, 2020 17:10https://github.com/angular/angular/pull/37461#event-3412322272
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Jun 6, 2020 https://github.com/angular/angular/pull/37461#pullrequestreview-425487399
View reviewed changes https://github.com/angular/angular/pull/37461/files/2cae679bb21c3702da595168a210ae3b40fc8d0e
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/37461#pullrequestreview-425487399
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@petebacondarwinhttps://github.com/petebacondarwin
Please reload this pagehttps://github.com/angular/angular/pull/37461
packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.tshttps://github.com/angular/angular/pull/37461/files/2cae679bb21c3702da595168a210ae3b40fc8d0e#diff-9b8addb5171411d2aa92dafd3542748c85444bccbbe455249298dca6feae4a6c
Please reload this pagehttps://github.com/angular/angular/pull/37461
packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.tshttps://github.com/angular/angular/pull/37461/files/2cae679bb21c3702da595168a210ae3b40fc8d0e#diff-9b8addb5171411d2aa92dafd3542748c85444bccbbe455249298dca6feae4a6c
Please reload this pagehttps://github.com/angular/angular/pull/37461
packages/compiler-cli/ngcc/src/dependencies/esm_dependency_host.tshttps://github.com/angular/angular/pull/37461/files/2cae679bb21c3702da595168a210ae3b40fc8d0e#diff-9b8addb5171411d2aa92dafd3542748c85444bccbbe455249298dca6feae4a6c
Please reload this pagehttps://github.com/angular/angular/pull/37461
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jun 6, 2020https://github.com/angular/angular/pull/37461#event-3414616079
https://github.com/petebacondarwin
fixup! style(ngcc): post-merge review tidy uphttps://github.com/angular/angular/pull/37461/commits/c92d47acf15ac5c0d232eb00fc51776e9a5585b1
c92d47ahttps://github.com/angular/angular/pull/37461/commits/c92d47acf15ac5c0d232eb00fc51776e9a5585b1
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Jun 6, 2020https://github.com/angular/angular/pull/37461#event-3414637137
https://github.com/atscott
atscotthttps://github.com/atscott
5e64c2bhttps://github.com/angular/angular/commit/5e64c2b1df1653e3fc9a1f27d8c80191e0e65f92
Jun 8, 2020https://github.com/angular/angular/pull/37461#event-3420977818
atscotthttps://github.com/atscott
Jun 8, 2020 https://github.com/angular/angular/pull/37461#ref-commit-31b3888
https://github.com/petebacondarwin
https://github.com/atscott
style(ngcc): post-merge review tidy up (https://github.com/angular/angular/commit/31b3888a2f0d9a7943bbbc770c50b94917f580d3
#37461https://github.com/angular/angular/pull/37461
)https://github.com/angular/angular/commit/31b3888a2f0d9a7943bbbc770c50b94917f580d3
31b3888https://github.com/angular/angular/commit/31b3888a2f0d9a7943bbbc770c50b94917f580d3
#37461https://github.com/angular/angular/pull/37461
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
June 8, 2020 18:05https://github.com/angular/angular/pull/37461#event-3421365349
ngwattcoshttps://github.com/ngwattcos
Jun 25, 2020 https://github.com/angular/angular/pull/37461#ref-commit-f63d9dd
https://github.com/petebacondarwin
https://github.com/ngwattcos
style(ngcc): post-merge review tidy up (https://github.com/ngwattcos/angular/commit/f63d9dd3f94ff95eced270b9e958498c5b931b3c
angular#37461https://github.com/angular/angular/pull/37461
)https://github.com/ngwattcos/angular/commit/f63d9dd3f94ff95eced270b9e958498c5b931b3c
f63d9ddhttps://github.com/ngwattcos/angular/commit/f63d9dd3f94ff95eced270b9e958498c5b931b3c
angular#37461https://github.com/angular/angular/pull/37461
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jul 9, 2020https://github.com/angular/angular/pull/37461#issuecomment-656219407
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/37461
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jul 9, 2020https://github.com/angular/angular/pull/37461#event-3530459102
profanishttps://github.com/profanis
Sep 5, 2020 https://github.com/angular/angular/pull/37461#ref-commit-638fd55
https://github.com/petebacondarwin
https://github.com/profanis
style(ngcc): post-merge review tidy up (https://github.com/profanis/angular/commit/638fd55909866ef1beea014b8b6fd0eb73c061a2
angular#37461https://github.com/angular/angular/pull/37461
)https://github.com/profanis/angular/commit/638fd55909866ef1beea014b8b6fd0eb73c061a2
638fd55https://github.com/profanis/angular/commit/638fd55909866ef1beea014b8b6fd0eb73c061a2
angular#37461https://github.com/angular/angular/pull/37461
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37461
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/37461/files/c92d47acf15ac5c0d232eb00fc51776e9a5585b1
Please reload this pagehttps://github.com/angular/angular/pull/37461
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
refactoring https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Arefactoring
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/37461
https://github.com/petebacondarwin
https://github.com/gkalpak
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.