René's URL Explorer Experiment


Title: Disable the tsickle pass from ng_package/APF/ngc-wrapped by IgorMinar · Pull Request #37221 · angular/angular · GitHub

Open Graph Title: Disable the tsickle pass from ng_package/APF/ngc-wrapped by IgorMinar · Pull Request #37221 · angular/angular

X Title: Disable the tsickle pass from ng_package/APF/ngc-wrapped by IgorMinar · Pull Request #37221 · angular/angular

Description: As of TypeScript 3.9, the tsc emit is not compatible with Closure Compiler due to microsoft/TypeScript#32011. There is some hope that this will be fixed by a solution like the one proposed in microsoft/TypeScript#38374 but currently it's unclear if / when that will happen. Since the Closure support has been somewhat already broken, and the tsickle pass has been a source of headaches for some time for Angular packages, we are removing it for now while we rethink our strategy to make Angular Closure compatible outside of Google. This change has no effect on our Closure compatibility within Google which work well because all the code is compiled from sources and passed through tsickle. This change only disables the tsickle pass but doesn't remove it. A follow up PR should either remove all the traces of tscikle or re-enable the fixed version. BREAKING CHANGE: Angular npm packages no longer contain jsdoc comments to support Closure Compiler's advanced optimizations The support for Closure compiler in Angular packages has been experimental and broken for quite some time. As of TS3.9 Closure is unusable with the JavaScript emit. Please follow microsoft/TypeScript#38374 for more information and updates. If you used Closure compiler with Angular in the past, you will likely be better off consuming Angular packages built from sources directly rather than consuming the version we publish on npm which is primarily optimized for Webpack/Rollup + Terser build pipeline. As a temporary workaround you might consider using your current build pipeline with Closure flag --compilation_level=SIMPLE. This flag will ensure that your build pipeline produces buildable and runnable artifacts, at the cost of increased payload size due to advanced optimizations being disabled. If you were affected by this change, please help us understand your needs by leaving a comment on #37234.

Open Graph Description: As of TypeScript 3.9, the tsc emit is not compatible with Closure Compiler due to microsoft/TypeScript#32011. There is some hope that this will be fixed by a solution like the one proposed in micro...

X Description: As of TypeScript 3.9, the tsc emit is not compatible with Closure Compiler due to microsoft/TypeScript#32011. There is some hope that this will be fixed by a solution like the one proposed in micro...

Opengraph URL: https://github.com/angular/angular/pull/37221

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:17da9d9c-832c-0d03-90f7-2aa5463c1ca7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD776:1F65:14EC482:1A8FF1E:6B01896E
html-safe-nonce3b5e807e6f0deeb25f86076e0efd9bac570946d4b9be54a7db4d5ace2aef0c58
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENzc2OjFGNjU6MTRFQzQ4MjoxQThGRjFFOjZCMDE4OTZFIiwidmlzaXRvcl9pZCI6IjE1NTIwNjMwNzI1Nzg3ODg5NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd242ee0b516df7a2750e5da3de30fef29e871ba55a459cbecced6fa0e513d816
hovercard-subject-tagpull_request:420814041
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/37221/files
twitter:imagehttps://avatars.githubusercontent.com/u/216296?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/216296?s=400&v=4
og:image:altAs of TypeScript 3.9, the tsc emit is not compatible with Closure Compiler due to microsoft/TypeScript#32011. There is some hope that this will be fixed by a solution like the one proposed in micro...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/37221/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37221%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37221%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/37221/files
Reloadhttps://github.com/angular/angular/pull/37221/files
Reloadhttps://github.com/angular/angular/pull/37221/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
IgorMinarhttps://github.com/IgorMinar
angular:masterhttps://github.com/angular/angular/tree/master
IgorMinar:build/apf-no-tsicklehttps://github.com/IgorMinar/angular/tree/build/apf-no-tsickle
Conversation 23 https://github.com/angular/angular/pull/37221
Commits 1 https://github.com/angular/angular/pull/37221/commits
Checks 0 https://github.com/angular/angular/pull/37221/checks
Files changed https://github.com/angular/angular/pull/37221/files
Please reload this pagehttps://github.com/angular/angular/pull/37221/files
Disable the tsickle pass from ng_package/APF/ngc-wrapped https://github.com/angular/angular/pull/37221/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/37221/files
eb6cf23 fix(core): disable tsickle pass when producing APF packages IgorMinar May 20, 2020 https://github.com/angular/angular/pull/37221/commits/eb6cf2308ce453c62bd16c44a2bfb82e539a3ddb
Clear filters https://github.com/angular/angular/pull/37221/files
Please reload this pagehttps://github.com/angular/angular/pull/37221/files
Please reload this pagehttps://github.com/angular/angular/pull/37221/files
aio-payloads.json https://github.com/angular/angular/pull/37221/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
integration-payloads.json https://github.com/angular/angular/pull/37221/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
BUILD.bazel https://github.com/angular/angular/pull/37221/files#diff-4fa7c99a8727106a76a9209e3e20d31e0a2a124c4394d3c7d6d689c8cb8756b2
angular_integration_test.bzl https://github.com/angular/angular/pull/37221/files#diff-ea8fb035581ff3e98f9df8a991f42a14f6299cfee12a02c2abd18248c62a6f5e
closure.conf https://github.com/angular/angular/pull/37221/files#diff-f1346225100d9f773818a73fa0c4cab887a568ba18af0f86bb49f0d30223f8ac
package.json https://github.com/angular/angular/pull/37221/files#diff-5fba907848330589596a8fe90ab86335384d855da6bd5e07a9ac19cff5cb9d69
yarn.lock https://github.com/angular/angular/pull/37221/files#diff-4bf9b04cae349e2661a13e039b4a0af0589faad63864acf5f68713f7449c67c8
closure.conf https://github.com/angular/angular/pull/37221/files#diff-23af81708a46f8261873355bf1b65e49d73add41e5a86cac0d727c9f97549893
package.json https://github.com/angular/angular/pull/37221/files#diff-53763a1d0ff749f06e242887ce1eaa16976239faab9cb6ca5dbb9eef8b57a453
yarn.lock https://github.com/angular/angular/pull/37221/files#diff-4d9596efac9876ae4cc11310ba5da0bb50eb9db11138f0d20ca90adf38a8fd4a
closure.conf https://github.com/angular/angular/pull/37221/files#diff-ef76bc43e14347f6c9cb32953b713f7396d7b51cad10bb5ebd207321e99aae5a
package.json https://github.com/angular/angular/pull/37221/files#diff-ff98c7ab15db8ff460d733acaa2196e656805dfb8dd304f8921f31ae578a24c4
yarn.lock https://github.com/angular/angular/pull/37221/files#diff-1bd27bc59e284e02b1cd95489b3c35bec888c9394ae30a7d395a1a5d2dea2824
test.sh https://github.com/angular/angular/pull/37221/files#diff-54b4c35645c846047e48b8b463846c17ff9649900407cd6d565c563ace86ce63
esm2015.js https://github.com/angular/angular/pull/37221/files#diff-7dae43924de0bed73bbd70762e7554044a534e498945de935e79bf831a70af2d
esm2015.js https://github.com/angular/angular/pull/37221/files#diff-2030a160a839b6c080f8c13d981a3da5761900bd85305185cc07ab545ca9e13d
esm2015.js https://github.com/angular/angular/pull/37221/files#diff-8cc6d80710a22e2abf86ca7d5a93481cc0c77caaf6950934a78f011fc5c9f2dc
esm2015.js https://github.com/angular/angular/pull/37221/files#diff-dde00462fc0cbb0b868e403d5ae20ed5079ee6d6ea643bd1608c9be6464597be
esm2015.js https://github.com/angular/angular/pull/37221/files#diff-fb21b9c79ecc0622f008854ad3a1fd0c7ad8c056295db3753cd2eed325541b59
esm2015.js https://github.com/angular/angular/pull/37221/files#diff-ac40662619429b48e15f05787faf0a82a65217f22f96ac59ca6d101831c771cb
package.json https://github.com/angular/angular/pull/37221/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519
index.ts https://github.com/angular/angular/pull/37221/files#diff-9e21f38a25df432a8781199adbe30944a76200490dc74eebaf76cb4103e80bff
core_package.spec.ts https://github.com/angular/angular/pull/37221/files#diff-24af4eaf0d60baf23c81327aebf6a76a0a8d4f334871f48bbb9a5df297219ff6
example_package.golden https://github.com/angular/angular/pull/37221/files#diff-c133487c2884f979f75c0f634c6a714a2689d86b7da01cfd2c8a6cd1b9ffcc90
example_with_ts_library_package.golden https://github.com/angular/angular/pull/37221/files#diff-ffbbd4444d63eb244809e6236a50847daef5fcb608036e4156d7c2ce4931f4b9
ngcc_spec.ts https://github.com/angular/angular/pull/37221/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
BUILD.bazel https://github.com/angular/angular/pull/37221/files#diff-cd5507f504d52875511a065db827ce5cd6edf05699e4c99bc0e1cb0c2fa79b4e
BUILD.bazel https://github.com/angular/angular/pull/37221/files#diff-196248172961224e1851b54a320503d063beff02e20f23d1e1b7d0e7433a6b02
yarn.lock https://github.com/angular/angular/pull/37221/files#diff-51e4f558fae534656963876761c95b83b6ef5da5103c4adef6768219ed76c2de
goldens/size-tracking/aio-payloads.jsonhttps://github.com/angular/angular/pull/37221/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
View file https://github.com/IgorMinar/angular/blob/eb6cf2308ce453c62bd16c44a2bfb82e539a3ddb/goldens/size-tracking/aio-payloads.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37221/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37221/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
https://github.com/angular/angular/pull/37221/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
goldens/size-tracking/integration-payloads.jsonhttps://github.com/angular/angular/pull/37221/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
View file https://github.com/IgorMinar/angular/blob/eb6cf2308ce453c62bd16c44a2bfb82e539a3ddb/goldens/size-tracking/integration-payloads.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37221/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37221/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/37221/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/37221/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/37221/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/37221/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
integration/BUILD.bazelhttps://github.com/angular/angular/pull/37221/files#diff-4fa7c99a8727106a76a9209e3e20d31e0a2a124c4394d3c7d6d689c8cb8756b2
View file https://github.com/IgorMinar/angular/blob/eb6cf2308ce453c62bd16c44a2bfb82e539a3ddb/integration/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37221/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37221/files#diff-4fa7c99a8727106a76a9209e3e20d31e0a2a124c4394d3c7d6d689c8cb8756b2
https://github.com/angular/angular/pull/37221/files#diff-4fa7c99a8727106a76a9209e3e20d31e0a2a124c4394d3c7d6d689c8cb8756b2
integration/angular_integration_test.bzlhttps://github.com/angular/angular/pull/37221/files#diff-ea8fb035581ff3e98f9df8a991f42a14f6299cfee12a02c2abd18248c62a6f5e
View file https://github.com/IgorMinar/angular/blob/eb6cf2308ce453c62bd16c44a2bfb82e539a3ddb/integration/angular_integration_test.bzl
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37221/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37221/files#diff-ea8fb035581ff3e98f9df8a991f42a14f6299cfee12a02c2abd18248c62a6f5e
https://github.com/angular/angular/pull/37221/files#diff-ea8fb035581ff3e98f9df8a991f42a14f6299cfee12a02c2abd18248c62a6f5e
integration/hello_world__closure/closure.confhttps://github.com/angular/angular/pull/37221/files#diff-f1346225100d9f773818a73fa0c4cab887a568ba18af0f86bb49f0d30223f8ac
View file https://github.com/IgorMinar/angular/blob/eb6cf2308ce453c62bd16c44a2bfb82e539a3ddb/integration/hello_world__closure/closure.conf
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37221/{{ revealButtonHref }}
integration/hello_world__closure/package.jsonhttps://github.com/angular/angular/pull/37221/files#diff-5fba907848330589596a8fe90ab86335384d855da6bd5e07a9ac19cff5cb9d69
View file https://github.com/IgorMinar/angular/blob/eb6cf2308ce453c62bd16c44a2bfb82e539a3ddb/integration/hello_world__closure/package.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37221/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37221/files#diff-5fba907848330589596a8fe90ab86335384d855da6bd5e07a9ac19cff5cb9d69
https://github.com/angular/angular/pull/37221/files#diff-5fba907848330589596a8fe90ab86335384d855da6bd5e07a9ac19cff5cb9d69
https://github.com/angular/angular/pull/37221/files#diff-5fba907848330589596a8fe90ab86335384d855da6bd5e07a9ac19cff5cb9d69
Please reload this pagehttps://github.com/angular/angular/pull/37221/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.