René's URL Explorer Experiment


Title: fix(zone.js): zone patch rxjs should return null _unsubscribe correctly. by JiaLiPassion · Pull Request #37091 · angular/angular · GitHub

Open Graph Title: fix(zone.js): zone patch rxjs should return null _unsubscribe correctly. by JiaLiPassion · Pull Request #37091 · angular/angular

X Title: fix(zone.js): zone patch rxjs should return null _unsubscribe correctly. by JiaLiPassion · Pull Request #37091 · angular/angular

Description: Close #31684. In some rxjs operator, such as retryWhen, rxjs internally will set Subscription._unsubscribe method to null, and the current zone.js monkey patch didn't handle this case correctly, even rxjs set _unsubscribe to null, zone.js still return a function by finding the prototype chain. This PR fix this issue and the following test will pass. const errorGenerator = () => { return throwError(new Error('error emit')); }; const genericRetryStrategy = (finalizer: () => void) => (attempts: Observable) => attempts.pipe( mergeMap((error, i) => { const retryAttempt = i + 1; if (retryAttempt > 3) { return throwError(error); } return timer(retryAttempt * 1); }), finalize(() => finalizer())); errorGenerator() .pipe( retryWhen(genericRetryStrategy(() => { expect(log.length).toBe(3); done(); })), catchError(error => of(error))) .subscribe() PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe:

Open Graph Description: Close #31684. In some rxjs operator, such as retryWhen, rxjs internally will set Subscription._unsubscribe method to null, and the current zone.js monkey patch didn't handle this case correctly...

X Description: Close #31684. In some rxjs operator, such as retryWhen, rxjs internally will set Subscription._unsubscribe method to null, and the current zone.js monkey patch didn't handle this case corre...

Opengraph URL: https://github.com/angular/angular/pull/37091

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0cf0d79d-1faf-1646-cf23-dff531efe4ca
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE820:2DBB21:1AD330D:23B7FAC:6B015CE6
html-safe-nonce35e619adb257c63c7d088ad80f2774230d25e808de9e77a28df0c4044b602efb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODIwOjJEQkIyMToxQUQzMzBEOjIzQjdGQUM6NkIwMTVDRTYiLCJ2aXNpdG9yX2lkIjoiNzUzNzczMTg4OTA1MDc3MDY2MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac5c2e126b8dbe77cf405c64b69d2680515490e3a7b5cd46a327f5082024f18bd2
hovercard-subject-tagpull_request:417459176
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/37091/files
twitter:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
og:image:altClose #31684. In some rxjs operator, such as retryWhen, rxjs internally will set Subscription._unsubscribe method to null, and the current zone.js monkey patch didn't handle this case correctly...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/37091/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37091%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37091%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/37091/files
Reloadhttps://github.com/angular/angular/pull/37091/files
Reloadhttps://github.com/angular/angular/pull/37091/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JiaLiPassionhttps://github.com/JiaLiPassion
angular:masterhttps://github.com/angular/angular/tree/master
JiaLiPassion:zone-rxjs-unsubscribe-bughttps://github.com/JiaLiPassion/angular/tree/zone-rxjs-unsubscribe-bug
Conversation 3 https://github.com/angular/angular/pull/37091
Commits 1 https://github.com/angular/angular/pull/37091/commits
Checks 0 https://github.com/angular/angular/pull/37091/checks
Files changed https://github.com/angular/angular/pull/37091/files
Please reload this pagehttps://github.com/angular/angular/pull/37091/files
fix(zone.js): zone patch rxjs should return null _unsubscribe correctly. https://github.com/angular/angular/pull/37091/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/37091/files
965fb17 fix(zone.js): zone patch rxjs should return null _unsubscribe correctly. JiaLiPassion May 13, 2020 https://github.com/angular/angular/pull/37091/commits/965fb171611c43e877e713439f90da88b2f1f4c4
Clear filters https://github.com/angular/angular/pull/37091/files
Please reload this pagehttps://github.com/angular/angular/pull/37091/files
Please reload this pagehttps://github.com/angular/angular/pull/37091/files
rxjs.ts https://github.com/angular/angular/pull/37091/files#diff-f215f9172f4c8e66b910321246e3dee315fddefd32b4d286cfe8d4e039bdcd9a
rxjs.retry.spec.ts https://github.com/angular/angular/pull/37091/files#diff-1555705cda128743ec1164a4bcc082c4aea13d63be740453a7d3f31089d0d15f
rxjs.spec.ts https://github.com/angular/angular/pull/37091/files#diff-e6011ed659c9f7b8addb2512f93d978484c1d1df04cb078745fb4bb9f977e02b
packages/zone.js/lib/rxjs/rxjs.tshttps://github.com/angular/angular/pull/37091/files#diff-f215f9172f4c8e66b910321246e3dee315fddefd32b4d286cfe8d4e039bdcd9a
View file https://github.com/JiaLiPassion/angular/blob/965fb171611c43e877e713439f90da88b2f1f4c4/packages/zone.js/lib/rxjs/rxjs.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37091/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37091/files#diff-f215f9172f4c8e66b910321246e3dee315fddefd32b4d286cfe8d4e039bdcd9a
https://github.com/angular/angular/pull/37091/files#diff-f215f9172f4c8e66b910321246e3dee315fddefd32b4d286cfe8d4e039bdcd9a
https://github.com/angular/angular/pull/37091/files#diff-f215f9172f4c8e66b910321246e3dee315fddefd32b4d286cfe8d4e039bdcd9a
packages/zone.js/test/rxjs/rxjs.retry.spec.tshttps://github.com/angular/angular/pull/37091/files#diff-1555705cda128743ec1164a4bcc082c4aea13d63be740453a7d3f31089d0d15f
View file https://github.com/JiaLiPassion/angular/blob/965fb171611c43e877e713439f90da88b2f1f4c4/packages/zone.js/test/rxjs/rxjs.retry.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37091/{{ revealButtonHref }}
packages/zone.js/test/rxjs/rxjs.spec.tshttps://github.com/angular/angular/pull/37091/files#diff-e6011ed659c9f7b8addb2512f93d978484c1d1df04cb078745fb4bb9f977e02b
View file https://github.com/JiaLiPassion/angular/blob/965fb171611c43e877e713439f90da88b2f1f4c4/packages/zone.js/test/rxjs/rxjs.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/37091/{{ revealButtonHref }}
https://github.com/angular/angular/pull/37091/files#diff-e6011ed659c9f7b8addb2512f93d978484c1d1df04cb078745fb4bb9f977e02b
https://github.com/angular/angular/pull/37091/files#diff-e6011ed659c9f7b8addb2512f93d978484c1d1df04cb078745fb4bb9f977e02b
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.