René's URL Explorer Experiment


Title: fix(ngcc): correctly get config for packages in nested `node_modules/` by gkalpak · Pull Request #37040 · angular/angular · GitHub

Open Graph Title: fix(ngcc): correctly get config for packages in nested `node_modules/` by gkalpak · Pull Request #37040 · angular/angular

X Title: fix(ngcc): correctly get config for packages in nested `node_modules/` by gkalpak · Pull Request #37040 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Previously, ngcc would only be able to match an ngcc configuration to packages that were located inside the project's top-level node_modules/. However, if there are multiple versions of a packa...

X Description: Previously, ngcc would only be able to match an ngcc configuration to packages that were located inside the project's top-level node_modules/. However, if there are multiple versions of a p...

Opengraph URL: https://github.com/angular/angular/pull/37040

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:8b83d6fb-8699-79ee-f26a-565cbc1a140f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB28E:4279A:14BF838:1BE89AC:6B013CD0
html-safe-nonce5be4604b52567c49615132adc08332fcd2261768e06404d11f8d2803800d8e00
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMjhFOjQyNzlBOjE0QkY4Mzg6MUJFODlBQzo2QjAxM0NEMCIsInZpc2l0b3JfaWQiOiIyMTc5MzczODgwNzUyMjkxMDI0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac37fc14a200c17263ad41ce51b156606c534ee374b6cafbbc48d5136971984d19
hovercard-subject-tagpull_request:415767274
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/37040/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/234c61da781c2447bc8aecb1e968d35f8843e25c14eb87642a1b03adbd19a31b/angular/angular/pull/37040
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/234c61da781c2447bc8aecb1e968d35f8843e25c14eb87642a1b03adbd19a31b/angular/angular/pull/37040
og:image:altPreviously, ngcc would only be able to match an ngcc configuration to packages that were located inside the project's top-level node_modules/. However, if there are multiple versions of a packa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegkalpak
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/37040#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37040
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37040
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/37040
Reloadhttps://github.com/angular/angular/pull/37040
Reloadhttps://github.com/angular/angular/pull/37040
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-ngcc-nested-confighttps://github.com/gkalpak/angular/tree/fix-ngcc-nested-config
Conversationhttps://github.com/angular/angular/pull/37040
Commits11 (11)https://github.com/angular/angular/pull/37040/commits
Checkshttps://github.com/angular/angular/pull/37040/checks
Files changedhttps://github.com/angular/angular/pull/37040/files
fix(ngcc): correctly get config for packages in nested node_modules/https://github.com/angular/angular/pull/37040#top
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-ngcc-nested-confighttps://github.com/gkalpak/angular/tree/fix-ngcc-nested-config
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 10, 2020https://github.com/angular/angular/pull/37040#issue-615457252
Please reload this pagehttps://github.com/angular/angular/pull/37040
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
May 10, 2020https://github.com/angular/angular/pull/37040#event-3320611050
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
JoostKhttps://github.com/JoostK
devversionhttps://github.com/devversion
May 10, 2020 19:16https://github.com/angular/angular/pull/37040#event-3320611103
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
comp: ngcc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
May 10, 2020https://github.com/angular/angular/pull/37040#event-3320611357
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
May 10, 2020https://github.com/angular/angular/pull/37040#event-3320611371
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 10, 2020https://github.com/angular/angular/pull/37040#issuecomment-626376984
https://pr37040-ac92b5a.ngbuilds.io/https://pr37040-ac92b5a.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/37040
https://github.com/devversion
devversionhttps://github.com/devversion
May 11, 2020 https://github.com/angular/angular/pull/37040#pullrequestreview-408930110
View reviewed changes https://github.com/angular/angular/pull/37040/files
devversionhttps://github.com/devversion
https://github.com/angular/angular/pull/37040#pullrequestreview-408930110
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/37040
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
May 11, 2020 https://github.com/angular/angular/pull/37040#pullrequestreview-408774745
View reviewed changes https://github.com/angular/angular/pull/37040/files
petebacondarwinhttps://github.com/petebacondarwin
https://github.com/angular/angular/pull/37040#pullrequestreview-408774745
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/37040
packages/compiler-cli/ngcc/src/packages/configuration.tshttps://github.com/angular/angular/pull/37040/files#diff-cbae8b8edac9f8c18e87784e762ae2f5c985c6046773d4654b9bf552f0198883
Please reload this pagehttps://github.com/angular/angular/pull/37040
packages/compiler-cli/ngcc/src/packages/configuration.tshttps://github.com/angular/angular/pull/37040/files#diff-cbae8b8edac9f8c18e87784e762ae2f5c985c6046773d4654b9bf552f0198883
Please reload this pagehttps://github.com/angular/angular/pull/37040
packages/compiler-cli/ngcc/test/packages/configuration_spec.tshttps://github.com/angular/angular/pull/37040/files#diff-fe8ed2e04e89c354d96223da662b17383a6dc7b0c7ea4b464723d90a2c4b004a
Please reload this pagehttps://github.com/angular/angular/pull/37040
packages/compiler-cli/ngcc/src/packages/entry_point.tshttps://github.com/angular/angular/pull/37040/files#diff-e7a58b815a502d44590d88e8b3c7417ab24415b0d6536d2b6ee89e8ab18c50ed
Please reload this pagehttps://github.com/angular/angular/pull/37040
packages/compiler-cli/ngcc/src/packages/configuration.tshttps://github.com/angular/angular/pull/37040/files#diff-cbae8b8edac9f8c18e87784e762ae2f5c985c6046773d4654b9bf552f0198883
Please reload this pagehttps://github.com/angular/angular/pull/37040
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/ac92b5ac6c79f0a7cc2900b48bf8f6a3f5a85aaf..cae61809ed21380f1476df075eb066b3347467a2
ac92b5ahttps://github.com/angular/angular/commit/ac92b5ac6c79f0a7cc2900b48bf8f6a3f5a85aaf
cae6180https://github.com/angular/angular/commit/cae61809ed21380f1476df075eb066b3347467a2
Compare https://github.com/angular/angular/compare/ac92b5ac6c79f0a7cc2900b48bf8f6a3f5a85aaf..cae61809ed21380f1476df075eb066b3347467a2
May 13, 2020 19:44https://github.com/angular/angular/pull/37040#event-3333636517
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
May 13, 2020https://github.com/angular/angular/pull/37040#issuecomment-628209495
Please reload this pagehttps://github.com/angular/angular/pull/37040
@petebacondarwinhttps://github.com/petebacondarwin
Please reload this pagehttps://github.com/angular/angular/pull/37040
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 13, 2020https://github.com/angular/angular/pull/37040#issuecomment-628211212
https://pr37040-cae6180.ngbuilds.io/https://pr37040-cae6180.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/37040
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
May 15, 2020 https://github.com/angular/angular/pull/37040#ref-issue-618527159
Steps to silence the Entry Point warning - Multiple EntryPoints #37115 https://github.com/angular/angular/issues/37115
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
May 18, 2020https://github.com/angular/angular/pull/37040#event-3347933353
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/cae61809ed21380f1476df075eb066b3347467a2..577858a8d5e244d6d391bd55a8120bc9dbb74bdf
cae6180https://github.com/angular/angular/commit/cae61809ed21380f1476df075eb066b3347467a2
577858ahttps://github.com/angular/angular/commit/577858a8d5e244d6d391bd55a8120bc9dbb74bdf
Compare https://github.com/angular/angular/compare/cae61809ed21380f1476df075eb066b3347467a2..577858a8d5e244d6d391bd55a8120bc9dbb74bdf
May 20, 2020 09:25https://github.com/angular/angular/pull/37040#event-3355551718
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 20, 2020https://github.com/angular/angular/pull/37040#issuecomment-631362516
https://pr37040-577858a.ngbuilds.io/https://pr37040-577858a.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/37040
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/577858a8d5e244d6d391bd55a8120bc9dbb74bdf..dc697b0307edf368d85ec2f6be21c98939bb59f5
577858ahttps://github.com/angular/angular/commit/577858a8d5e244d6d391bd55a8120bc9dbb74bdf
dc697b0https://github.com/angular/angular/commit/dc697b0307edf368d85ec2f6be21c98939bb59f5
Compare https://github.com/angular/angular/compare/577858a8d5e244d6d391bd55a8120bc9dbb74bdf..dc697b0307edf368d85ec2f6be21c98939bb59f5
May 21, 2020 20:14https://github.com/angular/angular/pull/37040#event-3362148488
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 21, 2020https://github.com/angular/angular/pull/37040#issuecomment-632327108
https://pr37040-dc697b0.ngbuilds.io/https://pr37040-dc697b0.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/37040
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/b852fd77e1adc80bcbdc8e4df4ab96115fb99aaf..bd5b369ceb9edb8b487a6121c5b56fc8f7b8b8d5
b852fd7https://github.com/angular/angular/commit/b852fd77e1adc80bcbdc8e4df4ab96115fb99aaf
bd5b369https://github.com/angular/angular/commit/bd5b369ceb9edb8b487a6121c5b56fc8f7b8b8d5
Compare https://github.com/angular/angular/compare/b852fd77e1adc80bcbdc8e4df4ab96115fb99aaf..bd5b369ceb9edb8b487a6121c5b56fc8f7b8b8d5
May 22, 2020 17:42https://github.com/angular/angular/pull/37040#event-3365669828
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 22, 2020https://github.com/angular/angular/pull/37040#issuecomment-632828847
https://pr37040-bd5b369.ngbuilds.io/https://pr37040-bd5b369.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/37040
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/bd5b369ceb9edb8b487a6121c5b56fc8f7b8b8d5..2f1b8c83faafb70947fa77da475513bee60a1e26
bd5b369https://github.com/angular/angular/commit/bd5b369ceb9edb8b487a6121c5b56fc8f7b8b8d5
2f1b8c8https://github.com/angular/angular/commit/2f1b8c83faafb70947fa77da475513bee60a1e26
Compare https://github.com/angular/angular/compare/bd5b369ceb9edb8b487a6121c5b56fc8f7b8b8d5..2f1b8c83faafb70947fa77da475513bee60a1e26
May 22, 2020 18:50https://github.com/angular/angular/pull/37040#event-3365850212
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
May 22, 2020https://github.com/angular/angular/pull/37040#issuecomment-632861809
https://pr37040-2f1b8c8.ngbuilds.io/https://pr37040-2f1b8c8.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/37040
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
petebacondarwinhttps://github.com/petebacondarwin
May 22, 2020 19:18https://github.com/angular/angular/pull/37040#event-3365935367
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
May 22, 2020https://github.com/angular/angular/pull/37040#event-3365936070
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Jun 10, 2020https://github.com/angular/angular/pull/37040#event-3431639351
https://github.com/mhevery
mheveryhttps://github.com/mhevery
469d2b4https://github.com/angular/angular/commit/469d2b4640a07cb8f2f25119c7944695ba2c347d
Jun 12, 2020https://github.com/angular/angular/pull/37040#event-3436606128
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-ab9bc8a
https://github.com/gkalpak
https://github.com/mhevery
refactor(ngcc): clean up unused imports, unused regex parenthesis, ty…https://github.com/angular/angular/commit/ab9bc8a9ecc6a6a4ac27de7a56d901ed44430a10
ab9bc8ahttps://github.com/angular/angular/commit/ab9bc8a9ecc6a6a4ac27de7a56d901ed44430a10
#37040https://github.com/angular/angular/pull/37040
#37075https://github.com/angular/angular/pull/37075
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-e7a0e87
https://github.com/gkalpak
https://github.com/mhevery
fix(ngcc): correctly get config for sub-entry-points when primary ent…https://github.com/angular/angular/commit/e7a0e87c4120912117df0a7d89504d0ad2914693
e7a0e87https://github.com/angular/angular/commit/e7a0e87c4120912117df0a7d89504d0ad2914693
#37040https://github.com/angular/angular/pull/37040
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-8197557
https://github.com/gkalpak
https://github.com/mhevery
refactor(ngcc): rename EntryPoint#package to `EntryPoint#packagePat…https://github.com/angular/angular/commit/8197557fcfda6699321ea219a56f4ee396bd2ccf
8197557https://github.com/angular/angular/commit/8197557fcfda6699321ea219a56f4ee396bd2ccf
#37040https://github.com/angular/angular/pull/37040
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-fb10f62
https://github.com/gkalpak
https://github.com/mhevery
refactor(ngcc): refactor how info is retrieved from entry-point `pack…https://github.com/angular/angular/commit/fb10f62efcc7159ac1bedf833a2a9785162d8729
fb10f62https://github.com/angular/angular/commit/fb10f62efcc7159ac1bedf833a2a9785162d8729
#37040https://github.com/angular/angular/pull/37040
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-829ddf9
https://github.com/gkalpak
https://github.com/mhevery
fix(ngcc): correctly retrieve a package's version from its `package.j…https://github.com/angular/angular/commit/829ddf95e59aa507ffeaeb65101321407356a67f
829ddf9https://github.com/angular/angular/commit/829ddf95e59aa507ffeaeb65101321407356a67f
#37040https://github.com/angular/angular/pull/37040
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-8f3695e
https://github.com/gkalpak
https://github.com/mhevery
refactor(ngcc): addhttps://github.com/angular/angular/commit/8f3695e20ee59b38e303e4ceecb4cf4dd0faa6e8
packageNamehttps://github.com/angular/angular/commit/8f3695e20ee59b38e303e4ceecb4cf4dd0faa6e8
property tohttps://github.com/angular/angular/commit/8f3695e20ee59b38e303e4ceecb4cf4dd0faa6e8
EntryPointhttps://github.com/angular/angular/commit/8f3695e20ee59b38e303e4ceecb4cf4dd0faa6e8
interface (https://github.com/angular/angular/commit/8f3695e20ee59b38e303e4ceecb4cf4dd0faa6e8
#…https://github.com/angular/angular/pull/37040
8f3695ehttps://github.com/angular/angular/commit/8f3695e20ee59b38e303e4ceecb4cf4dd0faa6e8
…37040https://github.com/angular/angular/pull/37040
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-bf682d7
https://github.com/gkalpak
https://github.com/mhevery
fix(ngcc): correctly get config for packages in nested node_modules/ (https://github.com/angular/angular/commit/bf682d73d480376e9f6d549fda7f57563e4ef795
bf682d7https://github.com/angular/angular/commit/bf682d73d480376e9f6d549fda7f57563e4ef795
#37040https://github.com/angular/angular/pull/37040
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-780601d
https://github.com/gkalpak
https://github.com/mhevery
refactor(ngcc): fix typos in comments (https://github.com/angular/angular/commit/780601d27a265bd84ad217908270d0773c84015c
#37040https://github.com/angular/angular/pull/37040
)https://github.com/angular/angular/commit/780601d27a265bd84ad217908270d0773c84015c
780601dhttps://github.com/angular/angular/commit/780601d27a265bd84ad217908270d0773c84015c
#36944https://github.com/angular/angular/pull/36944
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-a32579a
https://github.com/gkalpak
https://github.com/mhevery
refactor(ngcc): clean up unused imports, unused regex parenthesis, ty…https://github.com/angular/angular/commit/a32579ae5b926426764a8965d89756a41eca8a2e
a32579ahttps://github.com/angular/angular/commit/a32579ae5b926426764a8965d89756a41eca8a2e
#37040https://github.com/angular/angular/pull/37040
#37075https://github.com/angular/angular/pull/37075
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-bf57776
https://github.com/gkalpak
https://github.com/mhevery
fix(ngcc): correctly get config for sub-entry-points when primary ent…https://github.com/angular/angular/commit/bf57776b5972dd8234771fa16a51259857988977
bf57776https://github.com/angular/angular/commit/bf57776b5972dd8234771fa16a51259857988977
#37040https://github.com/angular/angular/pull/37040
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-d471454
https://github.com/gkalpak
https://github.com/mhevery
refactor(ngcc): rename EntryPoint#package to `EntryPoint#packagePat…https://github.com/angular/angular/commit/d471454675f0f220d416de6ae971321c97053822
d471454https://github.com/angular/angular/commit/d471454675f0f220d416de6ae971321c97053822
#37040https://github.com/angular/angular/pull/37040
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-eabe3b4
https://github.com/gkalpak
https://github.com/mhevery
refactor(ngcc): refactor how info is retrieved from entry-point `pack…https://github.com/angular/angular/commit/eabe3b4c39767826c526d484600073cb33770c0f
eabe3b4https://github.com/angular/angular/commit/eabe3b4c39767826c526d484600073cb33770c0f
#37040https://github.com/angular/angular/pull/37040
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-11c0402
https://github.com/gkalpak
https://github.com/mhevery
fix(ngcc): correctly retrieve a package's version from its `package.j…https://github.com/angular/angular/commit/11c04027ab7a54e02c4efa97663a943a7a9b74a8
11c0402https://github.com/angular/angular/commit/11c04027ab7a54e02c4efa97663a943a7a9b74a8
#37040https://github.com/angular/angular/pull/37040
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-315a4cf
https://github.com/gkalpak
https://github.com/mhevery
refactor(ngcc): addhttps://github.com/angular/angular/commit/315a4cfcd46b751bd953a077f2cb90f0020ad54d
packageNamehttps://github.com/angular/angular/commit/315a4cfcd46b751bd953a077f2cb90f0020ad54d
property tohttps://github.com/angular/angular/commit/315a4cfcd46b751bd953a077f2cb90f0020ad54d
EntryPointhttps://github.com/angular/angular/commit/315a4cfcd46b751bd953a077f2cb90f0020ad54d
interface (https://github.com/angular/angular/commit/315a4cfcd46b751bd953a077f2cb90f0020ad54d
#…https://github.com/angular/angular/pull/37040
315a4cfhttps://github.com/angular/angular/commit/315a4cfcd46b751bd953a077f2cb90f0020ad54d
…37040https://github.com/angular/angular/pull/37040
#37040https://github.com/angular/angular/pull/37040
mheveryhttps://github.com/mhevery
Jun 12, 2020 https://github.com/angular/angular/pull/37040#ref-commit-9ade1c3
https://github.com/gkalpak
https://github.com/mhevery
fix(ngcc): correctly get config for packages in nested node_modules/ (https://github.com/angular/angular/commit/9ade1c3ea3f037623255ddeeeee33ab3d792bb0b
9ade1c3https://github.com/angular/angular/commit/9ade1c3ea3f037623255ddeeeee33ab3d792bb0b
#37040https://github.com/angular/angular/pull/37040
#37040https://github.com/angular/angular/pull/37040
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
June 12, 2020 13:55https://github.com/angular/angular/pull/37040#event-3438518325
ngwattcoshttps://github.com/ngwattcos
Jun 25, 2020 https://github.com/angular/angular/pull/37040#ref-commit-964367d
https://github.com/gkalpak
https://github.com/ngwattcos
refactor(ngcc): fix typos in comments (https://github.com/ngwattcos/angular/commit/964367de1089ed915f0331aca0041d65549cef46
angular#37040https://github.com/angular/angular/pull/37040
)https://github.com/ngwattcos/angular/commit/964367de1089ed915f0331aca0041d65549cef46
964367dhttps://github.com/ngwattcos/angular/commit/964367de1089ed915f0331aca0041d65549cef46
angular#36944https://github.com/angular/angular/pull/36944
angular#37040https://github.com/angular/angular/pull/37040
ngwattcoshttps://github.com/ngwattcos
Jun 25, 2020 https://github.com/angular/angular/pull/37040#ref-commit-0f6ffba
https://github.com/gkalpak
https://github.com/ngwattcos
refactor(ngcc): clean up unused imports, unused regex parenthesis, ty…https://github.com/ngwattcos/angular/commit/0f6ffbadf44ac9a7a81f8f71f1666506485a1866
0f6ffbahttps://github.com/ngwattcos/angular/commit/0f6ffbadf44ac9a7a81f8f71f1666506485a1866
angular#37040https://github.com/angular/angular/pull/37040
angular#37075https://github.com/angular/angular/pull/37075
angular#37040https://github.com/angular/angular/pull/37040
ngwattcoshttps://github.com/ngwattcos
Jun 25, 2020 https://github.com/angular/angular/pull/37040#ref-commit-f57648e
https://github.com/gkalpak
https://github.com/ngwattcos
fix(ngcc): correctly get config for sub-entry-points when primary ent…https://github.com/ngwattcos/angular/commit/f57648ebb065645b31d8b3989ff7011cd7d8825b
f57648ehttps://github.com/ngwattcos/angular/commit/f57648ebb065645b31d8b3989ff7011cd7d8825b
angular#37040https://github.com/angular/angular/pull/37040
angular#37040https://github.com/angular/angular/pull/37040
ngwattcoshttps://github.com/ngwattcos
Jun 25, 2020 https://github.com/angular/angular/pull/37040#ref-commit-e8581b0
https://github.com/gkalpak
https://github.com/ngwattcos
refactor(ngcc): rename EntryPoint#package to `EntryPoint#packagePat…https://github.com/ngwattcos/angular/commit/e8581b0c9993ff8d4e0453a565cfe2b3bb141fa6
e8581b0https://github.com/ngwattcos/angular/commit/e8581b0c9993ff8d4e0453a565cfe2b3bb141fa6
angular#37040https://github.com/angular/angular/pull/37040
angular#37040https://github.com/angular/angular/pull/37040
ngwattcoshttps://github.com/ngwattcos
Jun 25, 2020 https://github.com/angular/angular/pull/37040#ref-commit-bd92443
https://github.com/gkalpak
https://github.com/ngwattcos
refactor(ngcc): refactor how info is retrieved from entry-point `pack…https://github.com/ngwattcos/angular/commit/bd924438734dd647df3a8606d76720ce67c65d62
bd92443https://github.com/ngwattcos/angular/commit/bd924438734dd647df3a8606d76720ce67c65d62
angular#37040https://github.com/angular/angular/pull/37040
angular#37040https://github.com/angular/angular/pull/37040
ngwattcoshttps://github.com/ngwattcos
Jun 25, 2020 https://github.com/angular/angular/pull/37040#ref-commit-2d2e8fe
https://github.com/gkalpak
https://github.com/ngwattcos
fix(ngcc): correctly retrieve a package's version from its `package.j…https://github.com/ngwattcos/angular/commit/2d2e8feda45d5acb1a6c6c84ee36b0853ed3a407
2d2e8fehttps://github.com/ngwattcos/angular/commit/2d2e8feda45d5acb1a6c6c84ee36b0853ed3a407
angular#37040https://github.com/angular/angular/pull/37040
angular#37040https://github.com/angular/angular/pull/37040
ngwattcoshttps://github.com/ngwattcos
Jun 25, 2020 https://github.com/angular/angular/pull/37040#ref-commit-b108dd7
https://github.com/gkalpak
https://github.com/ngwattcos
refactor(ngcc): addhttps://github.com/ngwattcos/angular/commit/b108dd72ddff9df240be4dadf1a16542a0fdc21c
packageNamehttps://github.com/ngwattcos/angular/commit/b108dd72ddff9df240be4dadf1a16542a0fdc21c
property tohttps://github.com/ngwattcos/angular/commit/b108dd72ddff9df240be4dadf1a16542a0fdc21c
EntryPointhttps://github.com/ngwattcos/angular/commit/b108dd72ddff9df240be4dadf1a16542a0fdc21c
interface (https://github.com/ngwattcos/angular/commit/b108dd72ddff9df240be4dadf1a16542a0fdc21c
a…https://github.com/angular/angular/pull/37040
b108dd7https://github.com/ngwattcos/angular/commit/b108dd72ddff9df240be4dadf1a16542a0fdc21c
…ngular#37040https://github.com/angular/angular/pull/37040
angular#37040https://github.com/angular/angular/pull/37040
ngwattcoshttps://github.com/ngwattcos
Jun 25, 2020 https://github.com/angular/angular/pull/37040#ref-commit-bedc70e
https://github.com/gkalpak
https://github.com/ngwattcos
fix(ngcc): correctly get config for packages in nested node_modules/ (https://github.com/ngwattcos/angular/commit/bedc70e1122ce7e4b354a8067a0c59a768d02a34
bedc70ehttps://github.com/ngwattcos/angular/commit/bedc70e1122ce7e4b354a8067a0c59a768d02a34
angular#37040https://github.com/angular/angular/pull/37040
angular#37040https://github.com/angular/angular/pull/37040
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jul 13, 2020https://github.com/angular/angular/pull/37040#issuecomment-657652740
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/37040
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jul 13, 2020https://github.com/angular/angular/pull/37040#event-3540278453
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F37040
https://github.com/JoostK
JoostK https://github.com/JoostK
https://github.com/angular/angular/pull/37040/files/d56a0933bcb3c85e7e497a1b80df2834a04fc8ff
https://github.com/devversion
devversion https://github.com/devversion
https://github.com/angular/angular/pull/37040/files/ac92b5ac6c79f0a7cc2900b48bf8f6a3f5a85aaf
https://github.com/petebacondarwin
petebacondarwin https://github.com/petebacondarwin
https://github.com/angular/angular/pull/37040/files/d56a0933bcb3c85e7e497a1b80df2834a04fc8ff
Please reload this pagehttps://github.com/angular/angular/pull/37040
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/37040
https://github.com/gkalpak
https://github.com/mary-poppins
https://github.com/petebacondarwin
https://github.com/JoostK
https://github.com/devversion
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.