René's URL Explorer Experiment


Title: fix(zone.js): remove unused Promise overwritten logic by JiaLiPassion · Pull Request #36851 · angular/angular · GitHub

Open Graph Title: fix(zone.js): remove unused Promise overwritten logic by JiaLiPassion · Pull Request #36851 · angular/angular

X Title: fix(zone.js): remove unused Promise overwritten logic by JiaLiPassion · Pull Request #36851 · angular/angular

Description: In the early Zone.js versions (< 0.10.3), ZoneAwarePromise did not support Symbol.species, so when user used a 3rd party Promise such as es6-promise, and try to load the promise library after import of zone.js, the loading promise library will overwrite the patched Promise from zone.js and will break Promise semantics with respect to zone.js. Starting with zone.js 0.10.3, Symbol.species is supported therefore this will not longer be an issue. (#34533) Before 0.10.3, the logic in zone.js tried to handle the case in the wrong way. It did so by overriding the descriptor of global.Promise, to allow the 3rd party libraries to override native Promise instead of ZoneAwarePromise. This is not the correct solution, and since the Promise.species is now supported, the 3rd party solution of overriding global.Promise is no longer needed. PR removes the wrong work around logic. (This will improve the bundle size.) PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A What is the new behavior? Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: In the early Zone.js versions (< 0.10.3), ZoneAwarePromise did not support Symbol.species, so when user used a 3rd party Promise such as es6-promise, and try to load the promise library after im...

X Description: In the early Zone.js versions (&lt; 0.10.3), ZoneAwarePromise did not support Symbol.species, so when user used a 3rd party Promise such as es6-promise, and try to load the promise library afte...

Opengraph URL: https://github.com/angular/angular/pull/36851

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:b37eed2c-44ac-259d-0797-44035fe9c12b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDC0:87955:52E32E:6D840E:6B017990
html-safe-nonce35bf00cbf0859cefb09a00af5ad4ea14567d30018a2382cbb1c448ecab4b719f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREMwOjg3OTU1OjUyRTMyRTo2RDg0MEU6NkIwMTc5OTAiLCJ2aXNpdG9yX2lkIjoiMzk5MjgwNzk4OTQ5Mjc2MDQ4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1f9f7c87b75a2f030006028cb191c0101a9a5548cb4a98c0c457ca3fc07ecbdf
hovercard-subject-tagpull_request:410558622
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/36851/files
twitter:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
og:image:altIn the early Zone.js versions (< 0.10.3), ZoneAwarePromise did not support Symbol.species, so when user used a 3rd party Promise such as es6-promise, and try to load the promise library after im...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/36851/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36851%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36851%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36851/files
Reloadhttps://github.com/angular/angular/pull/36851/files
Reloadhttps://github.com/angular/angular/pull/36851/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JiaLiPassionhttps://github.com/JiaLiPassion
angular:masterhttps://github.com/angular/angular/tree/master
JiaLiPassion:remove-promise-setterhttps://github.com/JiaLiPassion/angular/tree/remove-promise-setter
Conversation 6 https://github.com/angular/angular/pull/36851
Commits 1 https://github.com/angular/angular/pull/36851/commits
Checks 0 https://github.com/angular/angular/pull/36851/checks
Files changed https://github.com/angular/angular/pull/36851/files
Please reload this pagehttps://github.com/angular/angular/pull/36851/files
fix(zone.js): remove unused Promise overwritten logic https://github.com/angular/angular/pull/36851/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/36851/files
218fc59 fix(zone.js): remove unused Promise overwritten setter logic JiaLiPassion Apr 29, 2020 https://github.com/angular/angular/pull/36851/commits/218fc59a6f7378287a4eda99ade796c4ee731ee8
Clear filters https://github.com/angular/angular/pull/36851/files
Please reload this pagehttps://github.com/angular/angular/pull/36851/files
Please reload this pagehttps://github.com/angular/angular/pull/36851/files
integration-payloads.json https://github.com/angular/angular/pull/36851/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
promise.ts https://github.com/angular/angular/pull/36851/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
bluebird.ts https://github.com/angular/angular/pull/36851/files#diff-80aa734ead79ba16ef98ced6ed6ecbc9b589cc05de5688cd4f9bd32fe37e6b35
zone.ts https://github.com/angular/angular/pull/36851/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
zone.spec.ts https://github.com/angular/angular/pull/36851/files#diff-36d5935bfbc3a97ae7c085407062841f0b48ab3f80d21b918b3ee031d90a6bd8
goldens/size-tracking/integration-payloads.jsonhttps://github.com/angular/angular/pull/36851/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
View file https://github.com/JiaLiPassion/angular/blob/218fc59a6f7378287a4eda99ade796c4ee731ee8/goldens/size-tracking/integration-payloads.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36851/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36851/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/36851/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/36851/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
packages/zone.js/lib/common/promise.tshttps://github.com/angular/angular/pull/36851/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
View file https://github.com/JiaLiPassion/angular/blob/218fc59a6f7378287a4eda99ade796c4ee731ee8/packages/zone.js/lib/common/promise.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36851/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36851/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/36851/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
packages/zone.js/lib/extra/bluebird.tshttps://github.com/angular/angular/pull/36851/files#diff-80aa734ead79ba16ef98ced6ed6ecbc9b589cc05de5688cd4f9bd32fe37e6b35
View file https://github.com/JiaLiPassion/angular/blob/218fc59a6f7378287a4eda99ade796c4ee731ee8/packages/zone.js/lib/extra/bluebird.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36851/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36851/files#diff-80aa734ead79ba16ef98ced6ed6ecbc9b589cc05de5688cd4f9bd32fe37e6b35
packages/zone.js/lib/zone.tshttps://github.com/angular/angular/pull/36851/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
View file https://github.com/JiaLiPassion/angular/blob/218fc59a6f7378287a4eda99ade796c4ee731ee8/packages/zone.js/lib/zone.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36851/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36851/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
https://github.com/angular/angular/pull/36851/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
https://github.com/angular/angular/pull/36851/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
https://github.com/angular/angular/pull/36851/files#diff-b8a975bbd3ad12c45b52345202504e6bc4127f1926834d43213f9718bcf6c6b9
packages/zone.js/test/common/zone.spec.tshttps://github.com/angular/angular/pull/36851/files#diff-36d5935bfbc3a97ae7c085407062841f0b48ab3f80d21b918b3ee031d90a6bd8
View file https://github.com/JiaLiPassion/angular/blob/218fc59a6f7378287a4eda99ade796c4ee731ee8/packages/zone.js/test/common/zone.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36851/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36851/files#diff-36d5935bfbc3a97ae7c085407062841f0b48ab3f80d21b918b3ee031d90a6bd8
https://github.com/angular/angular/pull/36851/files#diff-36d5935bfbc3a97ae7c085407062841f0b48ab3f80d21b918b3ee031d90a6bd8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.