René's URL Explorer Experiment


Title: test(language-service): do not invalidate @angular/core by kyliau · Pull Request #36845 · angular/angular · GitHub

Open Graph Title: test(language-service): do not invalidate @angular/core by kyliau · Pull Request #36845 · angular/angular

X Title: test(language-service): do not invalidate @angular/core by kyliau · Pull Request #36845 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Fix typo and add test cases for #36783 PR closes angular/vscode-ng-language-service#713 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our gu...

X Description: Fix typo and add test cases for #36783 PR closes angular/vscode-ng-language-service#713 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our gu...

Opengraph URL: https://github.com/angular/angular/pull/36845

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:7bb5ccb6-f2c8-b870-0174-2f47e612ae8f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD1CE:B53AF:11D744A:17C2DB1:6B011D28
html-safe-nonce064fcc9e8053791166fe891489ec97ff105e2ad68aa0172bc3fcf5458b4dcc64
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMUNFOkI1M0FGOjExRDc0NEE6MTdDMkRCMTo2QjAxMUQyOCIsInZpc2l0b3JfaWQiOiIyNTg3NDI0MjAyMjYwODE1MTQ0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca38098d6a8e28e848fa12d807b0be878897ea6ebce570b8bbb95634acaf269aa
hovercard-subject-tagpull_request:410383204
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/36845/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d4e7059ed05104e3c91af6125ef96ed21425f303c0ec6b3da596db0c8a0bae53/angular/angular/pull/36845
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d4e7059ed05104e3c91af6125ef96ed21425f303c0ec6b3da596db0c8a0bae53/angular/angular/pull/36845
og:image:altFix typo and add test cases for #36783 PR closes angular/vscode-ng-language-service#713 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our gu...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamekyliau
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/36845#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36845
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36845
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36845
Reloadhttps://github.com/angular/angular/pull/36845
Reloadhttps://github.com/angular/angular/pull/36845
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
kyliauhttps://github.com/kyliau
angular:masterhttps://github.com/angular/angular/tree/master
kyliau:typohttps://github.com/kyliau/angular/tree/typo
Conversationhttps://github.com/angular/angular/pull/36845
Commits1 (1)https://github.com/angular/angular/pull/36845/commits
Checkshttps://github.com/angular/angular/pull/36845/checks
Files changedhttps://github.com/angular/angular/pull/36845/files
test(language-service): do not invalidate @angular/corehttps://github.com/angular/angular/pull/36845#top
kyliauhttps://github.com/kyliau
angular:masterhttps://github.com/angular/angular/tree/master
kyliau:typohttps://github.com/kyliau/angular/tree/typo
https://github.com/kyliau
kyliauhttps://github.com/kyliau
Apr 28, 2020https://github.com/angular/angular/pull/36845#issue-608642814
#36783https://github.com/angular/angular/pull/36783
angular/vscode-ng-language-service#713https://github.com/angular/vscode-ng-language-service/issues/713
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Please reload this pagehttps://github.com/angular/angular/pull/36845
https://github.com/kyliau
kyliauhttps://github.com/kyliau
ayazhafizhttps://github.com/ayazhafiz
April 28, 2020 21:59https://github.com/angular/angular/pull/36845#event-3282289394
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Apr 28, 2020https://github.com/angular/angular/pull/36845#event-3282289550
https://github.com/kyliau
kyliauhttps://github.com/kyliau
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Apr 28, 2020https://github.com/angular/angular/pull/36845#event-3282289852
https://github.com/kyliau
kyliauhttps://github.com/kyliau
force-pushedhttps://github.com/angular/angular/compare/d88ec5fd679b550fa03a0b92189572cf3e28f73f..8fa80eb578438e5ed48641cfe9b254ff06263821
d88ec5fhttps://github.com/angular/angular/commit/d88ec5fd679b550fa03a0b92189572cf3e28f73f
8fa80ebhttps://github.com/angular/angular/commit/8fa80eb578438e5ed48641cfe9b254ff06263821
Compare https://github.com/angular/angular/compare/d88ec5fd679b550fa03a0b92189572cf3e28f73f..8fa80eb578438e5ed48641cfe9b254ff06263821
April 28, 2020 22:00https://github.com/angular/angular/pull/36845#event-3282292853
https://github.com/kyliau
kyliauhttps://github.com/kyliau
area: language-service https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20language-service%22
Apr 28, 2020https://github.com/angular/angular/pull/36845#event-3282295446
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Apr 28, 2020https://github.com/angular/angular/pull/36845#event-3282295543
https://github.com/ayazhafiz
ayazhafizhttps://github.com/ayazhafiz
Apr 28, 2020 https://github.com/angular/angular/pull/36845#pullrequestreview-402257495
View reviewed changes https://github.com/angular/angular/pull/36845/files
packages/language-service/src/typescript_host.tshttps://github.com/angular/angular/pull/36845/files#diff-942abc889df97c56104bd3154ddaa0d6924e79bc3ac5ac9d55d7d28a832959fe
Please reload this pagehttps://github.com/angular/angular/pull/36845
https://github.com/kyliau
kyliauhttps://github.com/kyliau
force-pushedhttps://github.com/angular/angular/compare/c18d1afc716c9fd49dbd8064579ea7d21a702d60..182a33f849df361470ecab0553380255bddee009
c18d1afhttps://github.com/angular/angular/commit/c18d1afc716c9fd49dbd8064579ea7d21a702d60
182a33fhttps://github.com/angular/angular/commit/182a33f849df361470ecab0553380255bddee009
Compare https://github.com/angular/angular/compare/c18d1afc716c9fd49dbd8064579ea7d21a702d60..182a33f849df361470ecab0553380255bddee009
April 28, 2020 22:45https://github.com/angular/angular/pull/36845#event-3282402118
https://github.com/googlebot
googlebothttps://github.com/googlebot
Apr 28, 2020https://github.com/angular/angular/pull/36845#issuecomment-620894275
Go herehttps://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36845
Please reload this pagehttps://github.com/angular/angular/pull/36845
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Apr 28, 2020https://github.com/angular/angular/pull/36845#event-3282402341
https://github.com/kyliau
kyliauhttps://github.com/kyliau
force-pushedhttps://github.com/angular/angular/compare/182a33f849df361470ecab0553380255bddee009..68b06436711e9f134681e9a2eeedd5695388e91d
182a33fhttps://github.com/angular/angular/commit/182a33f849df361470ecab0553380255bddee009
68b0643https://github.com/angular/angular/commit/68b06436711e9f134681e9a2eeedd5695388e91d
Compare https://github.com/angular/angular/compare/182a33f849df361470ecab0553380255bddee009..68b06436711e9f134681e9a2eeedd5695388e91d
April 28, 2020 22:46https://github.com/angular/angular/pull/36845#event-3282402732
https://github.com/googlebot
googlebothttps://github.com/googlebot
Apr 28, 2020https://github.com/angular/angular/pull/36845#issuecomment-620894356
Go herehttps://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36845
Please reload this pagehttps://github.com/angular/angular/pull/36845
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
cla: no https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22
Apr 28, 2020https://github.com/angular/angular/pull/36845#event-3282402917
https://github.com/ayazhafiz
ayazhafizhttps://github.com/ayazhafiz
Apr 28, 2020 https://github.com/angular/angular/pull/36845#pullrequestreview-402264914
View reviewed changes https://github.com/angular/angular/pull/36845/files
https://github.com/kyliau
kyliauhttps://github.com/kyliau
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Apr 28, 2020https://github.com/angular/angular/pull/36845#event-3282406911
https://github.com/kyliau
kyliauhttps://github.com/kyliau
force-pushedhttps://github.com/angular/angular/compare/68b06436711e9f134681e9a2eeedd5695388e91d..693269eeb825cc1a3d3a022655b3e364edb30eb3
68b0643https://github.com/angular/angular/commit/68b06436711e9f134681e9a2eeedd5695388e91d
693269ehttps://github.com/angular/angular/commit/693269eeb825cc1a3d3a022655b3e364edb30eb3
Compare https://github.com/angular/angular/compare/68b06436711e9f134681e9a2eeedd5695388e91d..693269eeb825cc1a3d3a022655b3e364edb30eb3
April 28, 2020 22:48https://github.com/angular/angular/pull/36845#event-3282408849
https://github.com/ivanwonder
ivanwonderhttps://github.com/ivanwonder
Apr 29, 2020 https://github.com/angular/angular/pull/36845#pullrequestreview-402320067
View reviewed changes https://github.com/angular/angular/pull/36845/files
packages/language-service/test/typescript_host_spec.tshttps://github.com/angular/angular/pull/36845/files#diff-fe0e93533e851eb04546b1bb0de70cb8f4078e4ea01bf0d207189735b7365b88
Please reload this pagehttps://github.com/angular/angular/pull/36845
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Apr 29, 2020https://github.com/angular/angular/pull/36845#event-3285185524
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Apr 29, 2020https://github.com/angular/angular/pull/36845#issuecomment-621289417
@kyliauhttps://github.com/kyliau
@ivanwonderhttps://github.com/ivanwonder
Please reload this pagehttps://github.com/angular/angular/pull/36845
test(language-service): do not invalidate @angular/corehttps://github.com/angular/angular/pull/36845/commits/c4ca3e82ce42856c3b2216af52e795ee17f1bd16
c4ca3e8https://github.com/angular/angular/pull/36845/commits/c4ca3e82ce42856c3b2216af52e795ee17f1bd16
angular#36783https://github.com/angular/angular/pull/36783
angular/vscode-ng-language-service#713https://github.com/angular/vscode-ng-language-service/issues/713
https://github.com/kyliau
kyliauhttps://github.com/kyliau
force-pushedhttps://github.com/angular/angular/compare/693269eeb825cc1a3d3a022655b3e364edb30eb3..c4ca3e82ce42856c3b2216af52e795ee17f1bd16
693269ehttps://github.com/angular/angular/commit/693269eeb825cc1a3d3a022655b3e364edb30eb3
c4ca3e8https://github.com/angular/angular/commit/c4ca3e82ce42856c3b2216af52e795ee17f1bd16
Compare https://github.com/angular/angular/compare/693269eeb825cc1a3d3a022655b3e364edb30eb3..c4ca3e82ce42856c3b2216af52e795ee17f1bd16
April 29, 2020 16:44https://github.com/angular/angular/pull/36845#event-3285496984
https://github.com/kyliau
kyliauhttps://github.com/kyliau
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Apr 29, 2020https://github.com/angular/angular/pull/36845#event-3285497694
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
62ba0achttps://github.com/angular/angular/commit/62ba0acfb501c280dfd7cbcb06dccb28d41774a4
Apr 29, 2020https://github.com/angular/angular/pull/36845#event-3286565900
AndrewKushnirhttps://github.com/AndrewKushnir
Apr 29, 2020 https://github.com/angular/angular/pull/36845#ref-commit-15e1bfc
https://github.com/AndrewKushnir
test(language-service): do not invalidate @angular/core (https://github.com/angular/angular/commit/15e1bfc026fff0a71d3e6705b527d47aed771ca7
#36845https://github.com/angular/angular/pull/36845
)https://github.com/angular/angular/commit/15e1bfc026fff0a71d3e6705b527d47aed771ca7
15e1bfchttps://github.com/angular/angular/commit/15e1bfc026fff0a71d3e6705b527d47aed771ca7
#36783https://github.com/angular/angular/pull/36783
angular/vscode-ng-language-service#713https://github.com/angular/vscode-ng-language-service/issues/713
#36845https://github.com/angular/angular/pull/36845
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
May 30, 2020https://github.com/angular/angular/pull/36845#issuecomment-636351783
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/36845
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
May 30, 2020https://github.com/angular/angular/pull/36845#event-3389858173
profanishttps://github.com/profanis
Sep 5, 2020 https://github.com/angular/angular/pull/36845#ref-commit-1b810d8
https://github.com/profanis
test(language-service): do not invalidate @angular/core (https://github.com/profanis/angular/commit/1b810d88504852a954ef021a9992ca8084e1b539
angular#36845https://github.com/angular/angular/pull/36845
)https://github.com/profanis/angular/commit/1b810d88504852a954ef021a9992ca8084e1b539
1b810d8https://github.com/profanis/angular/commit/1b810d88504852a954ef021a9992ca8084e1b539
angular#36783https://github.com/angular/angular/pull/36783
angular/vscode-ng-language-service#713https://github.com/angular/vscode-ng-language-service/issues/713
angular#36845https://github.com/angular/angular/pull/36845
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36845
https://github.com/ivanwonder
ivanwonder https://github.com/ivanwonder
https://github.com/angular/angular/pull/36845/files/693269eeb825cc1a3d3a022655b3e364edb30eb3
https://github.com/ayazhafiz
ayazhafiz https://github.com/ayazhafiz
https://github.com/angular/angular/pull/36845/files/68b06436711e9f134681e9a2eeedd5695388e91d
Please reload this pagehttps://github.com/angular/angular/pull/36845
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: language-service https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20language-service%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
needsTriage https://github.com/angular/angular/milestone/83
Angular Language Service 0.901 missing symbols from core.d.ts https://github.com/angular/vscode-ng-language-service/issues/713
Please reload this pagehttps://github.com/angular/angular/pull/36845
https://github.com/kyliau
https://github.com/googlebot
https://github.com/AndrewKushnir
https://github.com/ivanwonder
https://github.com/ayazhafiz
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.