| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:4938da01-f3fc-a65d-1c14-094ea954c627 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | D162:785A9:1E15AA7:261F55C:6B0160EC |
| html-safe-nonce | 488eff003d9a14ef2ddef1b6bc6f01b4c43d06c4e10033c933910bdf31c6e45c |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTYyOjc4NUE5OjFFMTVBQTc6MjYxRjU1Qzo2QjAxNjBFQyIsInZpc2l0b3JfaWQiOiI4Njc4NzAzOTE0MTcxODUwOTg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 9a6a55bc6d1a145918950e8452de9aac7363ef89c57ba9fee92cc46b34e53527 |
| hovercard-subject-tag | pull_request:410130404 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///pull_requests/show/files |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/36834/files |
| twitter:image | https://avatars.githubusercontent.com/u/15655?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/15655?s=400&v=4 |
| og:image:alt | Merge-assistance: this PR has already been approved as #36745. This is a cherry-pick to 9.1.x. |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/36834/files#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36834%2Ffiles |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36834%2Ffiles |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/36834/files |
| Reload | https://github.com/angular/angular/pull/36834/files |
| Reload | https://github.com/angular/angular/pull/36834/files |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| Sign up for GitHub
| https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| terms of service | https://docs.github.com/terms |
| privacy statement | https://docs.github.com/privacy |
| Sign in | https://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose |
| petebacondarwin | https://github.com/petebacondarwin |
| angular:9.1.x | https://github.com/angular/angular/tree/9.1.x |
| petebacondarwin:i18n-localize-refactorings-patch | https://github.com/petebacondarwin/angular/tree/i18n-localize-refactorings-patch |
|
Conversation
2
| https://github.com/angular/angular/pull/36834 |
|
Commits
5
| https://github.com/angular/angular/pull/36834/commits |
|
Checks
0
| https://github.com/angular/angular/pull/36834/checks |
|
Files changed
| https://github.com/angular/angular/pull/36834/files |
| Please reload this page | https://github.com/angular/angular/pull/36834/files |
|
Patch version of #36745
| https://github.com/angular/angular/pull/36834/files#top |
|
Show all changes
5 commits
| https://github.com/angular/angular/pull/36834/files |
|
a1f0a74
refactor(localize): move `source_file_utils.ts` up
petebacondarwin Nov 18, 2019
| https://github.com/angular/angular/pull/36834/commits/a1f0a744ce6b69666e600a38feea12efc9d21901 |
|
b165e76
refactor(localize): tighten up recognition of simple JSON translations
petebacondarwin Apr 19, 2020
| https://github.com/angular/angular/pull/36834/commits/b165e761f836d629fe2e7547712a2a27dd320d4e |
|
e8f65e6
test(localize): tidy up translation parser tests
petebacondarwin Apr 20, 2020
| https://github.com/angular/angular/pull/36834/commits/e8f65e6d5bbfb0a6e4333cc398c859609babadc7 |
|
38e1982
refactor(localize): consolidate message/translation metadata
petebacondarwin Apr 20, 2020
| https://github.com/angular/angular/pull/36834/commits/38e198231acc7da03a094defd671c5fad6b9cd1b |
|
3809633
refactor(localize): remove unused code
petebacondarwin Apr 20, 2020
| https://github.com/angular/angular/pull/36834/commits/3809633fb1417ba2f18cbfc44fab6051adcc7c32 |
|
Clear filters
| https://github.com/angular/angular/pull/36834/files |
| Please reload this page | https://github.com/angular/angular/pull/36834/files |
| Please reload this page | https://github.com/angular/angular/pull/36834/files |
|
private.ts
| https://github.com/angular/angular/pull/36834/files#diff-e795a5ad0f0cb88fb6da4a1c951601dc16bf146638244e796433dba216ae9f74 |
|
source_file_utils.ts
| https://github.com/angular/angular/pull/36834/files#diff-d67c3cdb37d3b18e922590fb2ff471a06bd8ebaac56ce8236087d4c3db7aa6df |
|
main.ts
| https://github.com/angular/angular/pull/36834/files#diff-ede332f7cc7c76eb3f0aa9a092ee0af9e3b3f7a9930e33e9b7720ccf84dbc6ad |
|
es2015_translate_plugin.ts
| https://github.com/angular/angular/pull/36834/files#diff-a5404bb1d5049b7a0d9b55d4372d69f84a7221ce75cd7d82cc2ae178e7dbc465 |
|
es5_translate_plugin.ts
| https://github.com/angular/angular/pull/36834/files#diff-4ad13a5c57d6ea1e1ad601a63483ad8e31138ddac74a7c812f39cd8b696b4d3f |
|
locale_plugin.ts
| https://github.com/angular/angular/pull/36834/files#diff-9fa80e59d2654ecfaf9c16e06303851379a7ce8e6e3f6715da19a2d09e0fb2f6 |
|
source_file_translation_handler.ts
| https://github.com/angular/angular/pull/36834/files#diff-f1f32c37018eecb3df88b3ab5694486a0bea02685a3b345675a6c3754d94c64f |
|
message_renderer.ts
| https://github.com/angular/angular/pull/36834/files#diff-d7a94dd89e8a7e69af60adf58987a8de992a2eda669c7da5727b7ad6fa630d6a |
|
simple_json_translation_parser.ts
| https://github.com/angular/angular/pull/36834/files#diff-4fbb7af9cb7d2736bf6f3e5466f00c9470d4c57045b2ee747381a90211641c38 |
|
source_file_utils_spec.ts
| https://github.com/angular/angular/pull/36834/files#diff-587fb366f6f11fa7880dca144fd1d400cda19992bad230d8277ebc9964011e9e |
|
simple_json_spec.ts
| https://github.com/angular/angular/pull/36834/files#diff-11e6c0252e83b04eb7af06f455a0fa77119a8ede505017e7d31e21bb7b62bd89 |
|
xliff1_translation_parser_spec.ts
| https://github.com/angular/angular/pull/36834/files#diff-03086ea5fe8c9ecbb2ac5b6aa1f6b916e8a610144483f27f5b3cb9177e13b5e3 |
|
xliff2_translation_parser_spec.ts
| https://github.com/angular/angular/pull/36834/files#diff-76759e92750295d92973489531545cb187f1138ada04180dbd407f681f0898b2 |
|
xtb_translation_parser_spec.ts
| https://github.com/angular/angular/pull/36834/files#diff-bf622ca19afea71e12e30fc6642556cd2eb2b6da215c629c7f3d76062e72f5bf |
|
messages.ts
| https://github.com/angular/angular/pull/36834/files#diff-958f77d8a9e405eae75d5ddb1b6e33c038a13e4800ae780872e9b2a3c2dd6635 |
|
translations.ts
| https://github.com/angular/angular/pull/36834/files#diff-460d663bd0c710c5c7462159887a9f9c6bb6903d53f995f59d9ac58403cde6ca |
|
messages_spec.ts
| https://github.com/angular/angular/pull/36834/files#diff-a84eb88f4a970e822c8184252567ccf296e65850c1de333d074fb57ee5416063 |
| packages/localize/private.ts | https://github.com/angular/angular/pull/36834/files#diff-e795a5ad0f0cb88fb6da4a1c951601dc16bf146638244e796433dba216ae9f74 |
|
View file
| https://github.com/petebacondarwin/angular/blob/3809633fb1417ba2f18cbfc44fab6051adcc7c32/packages/localize/private.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/36834/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/36834/files#diff-e795a5ad0f0cb88fb6da4a1c951601dc16bf146638244e796433dba216ae9f74 |
| ...anslate/source_files/source_file_utils.ts → ...calize/src/tools/src/source_file_utils.ts | https://github.com/angular/angular/pull/36834/files#diff-d67c3cdb37d3b18e922590fb2ff471a06bd8ebaac56ce8236087d4c3db7aa6df |
|
View file
| https://github.com/petebacondarwin/angular/blob/3809633fb1417ba2f18cbfc44fab6051adcc7c32/packages/localize/src/tools/src/source_file_utils.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/36834/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/36834/files#diff-d67c3cdb37d3b18e922590fb2ff471a06bd8ebaac56ce8236087d4c3db7aa6df |
|
| https://github.com/angular/angular/pull/36834/files#diff-d67c3cdb37d3b18e922590fb2ff471a06bd8ebaac56ce8236087d4c3db7aa6df |
|
| https://github.com/angular/angular/pull/36834/files#diff-d67c3cdb37d3b18e922590fb2ff471a06bd8ebaac56ce8236087d4c3db7aa6df |
| packages/localize/src/tools/src/translate/main.ts | https://github.com/angular/angular/pull/36834/files#diff-ede332f7cc7c76eb3f0aa9a092ee0af9e3b3f7a9930e33e9b7720ccf84dbc6ad |
|
View file
| https://github.com/petebacondarwin/angular/blob/3809633fb1417ba2f18cbfc44fab6051adcc7c32/packages/localize/src/tools/src/translate/main.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/36834/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/36834/files#diff-ede332f7cc7c76eb3f0aa9a092ee0af9e3b3f7a9930e33e9b7720ccf84dbc6ad |
|
| https://github.com/angular/angular/pull/36834/files#diff-ede332f7cc7c76eb3f0aa9a092ee0af9e3b3f7a9930e33e9b7720ccf84dbc6ad |
| packages/localize/src/tools/src/translate/source_files/es2015_translate_plugin.ts | https://github.com/angular/angular/pull/36834/files#diff-a5404bb1d5049b7a0d9b55d4372d69f84a7221ce75cd7d82cc2ae178e7dbc465 |
|
View file
| https://github.com/petebacondarwin/angular/blob/3809633fb1417ba2f18cbfc44fab6051adcc7c32/packages/localize/src/tools/src/translate/source_files/es2015_translate_plugin.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/36834/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/36834/files#diff-a5404bb1d5049b7a0d9b55d4372d69f84a7221ce75cd7d82cc2ae178e7dbc465 |
|
| https://github.com/angular/angular/pull/36834/files#diff-a5404bb1d5049b7a0d9b55d4372d69f84a7221ce75cd7d82cc2ae178e7dbc465 |
| packages/localize/src/tools/src/translate/source_files/es5_translate_plugin.ts | https://github.com/angular/angular/pull/36834/files#diff-4ad13a5c57d6ea1e1ad601a63483ad8e31138ddac74a7c812f39cd8b696b4d3f |
|
View file
| https://github.com/petebacondarwin/angular/blob/3809633fb1417ba2f18cbfc44fab6051adcc7c32/packages/localize/src/tools/src/translate/source_files/es5_translate_plugin.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/36834/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/36834/files#diff-4ad13a5c57d6ea1e1ad601a63483ad8e31138ddac74a7c812f39cd8b696b4d3f |
|
| https://github.com/angular/angular/pull/36834/files#diff-4ad13a5c57d6ea1e1ad601a63483ad8e31138ddac74a7c812f39cd8b696b4d3f |
| packages/localize/src/tools/src/translate/source_files/locale_plugin.ts | https://github.com/angular/angular/pull/36834/files#diff-9fa80e59d2654ecfaf9c16e06303851379a7ce8e6e3f6715da19a2d09e0fb2f6 |
|
View file
| https://github.com/petebacondarwin/angular/blob/3809633fb1417ba2f18cbfc44fab6051adcc7c32/packages/localize/src/tools/src/translate/source_files/locale_plugin.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/36834/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/36834/files#diff-9fa80e59d2654ecfaf9c16e06303851379a7ce8e6e3f6715da19a2d09e0fb2f6 |
|
| https://github.com/angular/angular/pull/36834/files#diff-9fa80e59d2654ecfaf9c16e06303851379a7ce8e6e3f6715da19a2d09e0fb2f6 |
| packages/localize/src/tools/src/translate/source_files/source_file_translation_handler.ts | https://github.com/angular/angular/pull/36834/files#diff-f1f32c37018eecb3df88b3ab5694486a0bea02685a3b345675a6c3754d94c64f |
|
View file
| https://github.com/petebacondarwin/angular/blob/3809633fb1417ba2f18cbfc44fab6051adcc7c32/packages/localize/src/tools/src/translate/source_files/source_file_translation_handler.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/36834/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/36834/files#diff-f1f32c37018eecb3df88b3ab5694486a0bea02685a3b345675a6c3754d94c64f |
|
| https://github.com/angular/angular/pull/36834/files#diff-f1f32c37018eecb3df88b3ab5694486a0bea02685a3b345675a6c3754d94c64f |
| ...alize/src/tools/src/translate/translation_files/message_serialization/message_renderer.ts | https://github.com/angular/angular/pull/36834/files#diff-d7a94dd89e8a7e69af60adf58987a8de992a2eda669c7da5727b7ad6fa630d6a |
|
View file
| https://github.com/petebacondarwin/angular/blob/3809633fb1417ba2f18cbfc44fab6051adcc7c32/packages/localize/src/tools/src/translate/translation_files/message_serialization/message_renderer.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/36834/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/36834/files#diff-d7a94dd89e8a7e69af60adf58987a8de992a2eda669c7da5727b7ad6fa630d6a |
| ...ols/src/translate/translation_files/translation_parsers/simple_json_translation_parser.ts | https://github.com/angular/angular/pull/36834/files#diff-4fbb7af9cb7d2736bf6f3e5466f00c9470d4c57045b2ee747381a90211641c38 |
|
View file
| https://github.com/petebacondarwin/angular/blob/3809633fb1417ba2f18cbfc44fab6051adcc7c32/packages/localize/src/tools/src/translate/translation_files/translation_parsers/simple_json_translation_parser.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/36834/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/36834/files#diff-4fbb7af9cb7d2736bf6f3e5466f00c9470d4c57045b2ee747381a90211641c38 |
|
| https://github.com/angular/angular/pull/36834/files#diff-4fbb7af9cb7d2736bf6f3e5466f00c9470d4c57045b2ee747381a90211641c38 |
| ...te/source_files/source_file_utils_spec.ts → .../src/tools/test/source_file_utils_spec.ts | https://github.com/angular/angular/pull/36834/files#diff-587fb366f6f11fa7880dca144fd1d400cda19992bad230d8277ebc9964011e9e |
|
View file
| https://github.com/petebacondarwin/angular/blob/3809633fb1417ba2f18cbfc44fab6051adcc7c32/packages/localize/src/tools/test/source_file_utils_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/36834/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/36834/files#diff-587fb366f6f11fa7880dca144fd1d400cda19992bad230d8277ebc9964011e9e |
|
| https://github.com/angular/angular/pull/36834/files#diff-587fb366f6f11fa7880dca144fd1d400cda19992bad230d8277ebc9964011e9e |
| ...calize/src/tools/test/translate/translation_files/translation_parsers/simple_json_spec.ts | https://github.com/angular/angular/pull/36834/files#diff-11e6c0252e83b04eb7af06f455a0fa77119a8ede505017e7d31e21bb7b62bd89 |
|
View file
| https://github.com/petebacondarwin/angular/blob/3809633fb1417ba2f18cbfc44fab6051adcc7c32/packages/localize/src/tools/test/translate/translation_files/translation_parsers/simple_json_spec.ts |
|
Open in desktop
| https://desktop.github.com |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/36834/{{ revealButtonHref }} |
|
| https://github.com/angular/angular/pull/36834/files#diff-11e6c0252e83b04eb7af06f455a0fa77119a8ede505017e7d31e21bb7b62bd89 |
| Please reload this page | https://github.com/angular/angular/pull/36834/files |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |