Title: fix(common): canceled JSONP requests won't throw error with missing callback function by martinsik · Pull Request #36807 · angular/angular · GitHub
Open Graph Title: fix(common): canceled JSONP requests won't throw error with missing callback function by martinsik · Pull Request #36807 · angular/angular
X Title: fix(common): canceled JSONP requests won't throw error with missing callback function by martinsik · Pull Request #36807 · angular/angular
Description: Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Fixes #34818 Unsubscribing from a JSONP request will throw console errors such as Uncaught ReferenceError: ng_jsonp_callback_41 is not defined. This is happening because the callback function is removed right on unsubscription but this doesn't stop the JSONP script from loading. https://stackblitz.com/edit/angular-4zmfjr?file=src/app/app.component.ts What is the new behavior? Unsubscribing from JSONP request won't remove callback handler. Handler is then removed by the handler itself: angular/packages/common/http/src/jsonp.ts Line 107 in 2365bb8 delete this.callbackMap[callback]; Does this PR introduce a breaking change? Yes No
Open Graph Description: Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the change...
X Description: Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the change...
Opengraph URL: https://github.com/angular/angular/pull/36807
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:7e446498-32fc-6b71-9e73-e78170f94088 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BA00:EA06E:10748E5:151C1F7:6B010038 |
| html-safe-nonce | aba41c720c06bc1903197b708ed3696f679a28ab5616262fe611f21a5666b684 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQTAwOkVBMDZFOjEwNzQ4RTU6MTUxQzFGNzo2QjAxMDAzOCIsInZpc2l0b3JfaWQiOiI4MTUzODkyODc1MjAyMDAzMDAxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | ad673f5e37173da3576e7cd536b2a2eadc46fb92e210628f6ece75a081ed5058 |
| hovercard-subject-tag | pull_request:408867994 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/36807/files |
| twitter:image | https://avatars.githubusercontent.com/u/238765?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/238765?s=400&v=4 |
| og:image:alt | Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the change... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links: