| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:8d5079c0-23c9-5f20-091f-6e33cea3ac99 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 872E:38C5CF:14BFB9E:1A7B931:6B01161E |
| html-safe-nonce | 2baf433d00dbe4a98a1880e2d6e8c5e4d93cf1cfe3e72f6a84e638e5ccd0a44d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzJFOjM4QzVDRjoxNEJGQjlFOjFBN0I5MzE6NkIwMTE2MUUiLCJ2aXNpdG9yX2lkIjoiNjQ5MzE3MjA3NzU4NjczNDM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a8e1487f67de0edae9c879f5dd9e02432a011f71a7293a32563e98e3f31241ac |
| hovercard-subject-tag | pull_request:408311578 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/36783/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4141256024d69074f4fa470901495bc0439f93e84b1b287768ad0fc8563dbb5f/angular/angular/pull/36783 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4141256024d69074f4fa470901495bc0439f93e84b1b287768ad0fc8563dbb5f/angular/angular/pull/36783 |
| og:image:alt | After the user edits the file core.d.ts, the language-service will crash.
fix: angular/vscode-ng-language-service#713
PR Checklist
Please check if your PR fulfills the following requirements:
The... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ivanwonder |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/36783#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36783 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36783 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/36783 |
| Reload | https://github.com/angular/angular/pull/36783 |
| Reload | https://github.com/angular/angular/pull/36783 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| ivanwonder | https://github.com/ivanwonder |
| angular:master | https://github.com/angular/angular/tree/master |
| ivanwonder:disable-update-core-module | https://github.com/ivanwonder/angular/tree/disable-update-core-module |
| Conversation | https://github.com/angular/angular/pull/36783 |
| Commits1 (1) | https://github.com/angular/angular/pull/36783/commits |
| Checks | https://github.com/angular/angular/pull/36783/checks |
| Files changed | https://github.com/angular/angular/pull/36783/files |
| fix(language-service): disable update the @angular/core module | https://github.com/angular/angular/pull/36783#top |
| ivanwonder | https://github.com/ivanwonder |
| angular:master | https://github.com/angular/angular/tree/master |
| ivanwonder:disable-update-core-module | https://github.com/ivanwonder/angular/tree/disable-update-core-module |
|
| https://github.com/ivanwonder |
| ivanwonder | https://github.com/ivanwonder |
| Apr 24, 2020 | https://github.com/angular/angular/pull/36783#issue-606016297 |
| angular/vscode-ng-language-service#713 | https://github.com/angular/vscode-ng-language-service/issues/713 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| Please reload this page | https://github.com/angular/angular/pull/36783 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Apr 24, 2020 | https://github.com/angular/angular/pull/36783#event-3267699722 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| kyliau | https://github.com/kyliau |
| April 24, 2020 03:40 | https://github.com/angular/angular/pull/36783#event-3267699818 |
|
| https://github.com/ivanwonder |
| fix(language-service): disable update the @angular/core module | https://github.com/angular/angular/pull/36783/commits/42da9dc7768232209545ed69b68520529e99be3c |
| 42da9dc | https://github.com/angular/angular/pull/36783/commits/42da9dc7768232209545ed69b68520529e99be3c |
| https://github.com/ivanwonder |
| ivanwonder | https://github.com/ivanwonder |
| force-pushed | https://github.com/angular/angular/compare/11a69f83d39120a29ea2c6e08648be9355930984..42da9dc7768232209545ed69b68520529e99be3c |
| 11a69f8 | https://github.com/angular/angular/commit/11a69f83d39120a29ea2c6e08648be9355930984 |
| 42da9dc | https://github.com/angular/angular/commit/42da9dc7768232209545ed69b68520529e99be3c |
|
Compare
| https://github.com/angular/angular/compare/11a69f83d39120a29ea2c6e08648be9355930984..42da9dc7768232209545ed69b68520529e99be3c |
| April 24, 2020 03:59 | https://github.com/angular/angular/pull/36783#event-3267729565 |
| https://github.com/kyliau |
| kyliau | https://github.com/kyliau |
|
Apr 24, 2020
| https://github.com/angular/angular/pull/36783#pullrequestreview-399633275 |
|
View reviewed changes
| https://github.com/angular/angular/pull/36783/files/42da9dc7768232209545ed69b68520529e99be3c |
| kyliau | https://github.com/kyliau |
| https://github.com/angular/angular/pull/36783#pullrequestreview-399633275 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/36783 |
| https://github.com/kyliau |
| kyliau | https://github.com/kyliau |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Apr 24, 2020 | https://github.com/angular/angular/pull/36783#event-3267792206 |
| https://github.com/ivanwonder |
| ivanwonder | https://github.com/ivanwonder |
| Apr 24, 2020 | https://github.com/angular/angular/pull/36783#issuecomment-618825890 |
| @kyliau | https://github.com/kyliau |
| angular/packages/compiler/src/aot/static_reflector.ts | https://github.com/angular/angular/blob/e6161ca307be01eb1142092b53cbd7ddbd33312a/packages/compiler/src/aot/static_reflector.ts#L69 |
| e6161ca | https://github.com/angular/angular/commit/e6161ca307be01eb1142092b53cbd7ddbd33312a |
| angular/packages/compiler/src/aot/static_reflector.ts | https://github.com/angular/angular/blob/e6161ca307be01eb1142092b53cbd7ddbd33312a/packages/compiler/src/aot/static_reflector.ts#L159 |
| e6161ca | https://github.com/angular/angular/commit/e6161ca307be01eb1142092b53cbd7ddbd33312a |
| Please reload this page | https://github.com/angular/angular/pull/36783 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| dd049ca | https://github.com/angular/angular/commit/dd049caf0a261c4a1c779e1567cbcfc7f0fdc3e1 |
| Apr 24, 2020 | https://github.com/angular/angular/pull/36783#event-3270070649 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Apr 24, 2020
| https://github.com/angular/angular/pull/36783#ref-commit-d3a77ea |
|
| https://github.com/ivanwonder |
|
| https://github.com/AndrewKushnir |
| fix(language-service): disable update the | https://github.com/angular/angular/commit/d3a77ea91a3bd1adb1e598d6bc38f6db59bed2c7 |
| @angular/core | https://github.com/angular/angular/commit/d3a77ea91a3bd1adb1e598d6bc38f6db59bed2c7 |
| module ( | https://github.com/angular/angular/commit/d3a77ea91a3bd1adb1e598d6bc38f6db59bed2c7 |
| #36783 | https://github.com/angular/angular/pull/36783 |
| d3a77ea | https://github.com/angular/angular/commit/d3a77ea91a3bd1adb1e598d6bc38f6db59bed2c7 |
| https://github.com/angular/angular/pull/36783 |
| #36783 | https://github.com/angular/angular/pull/36783 |
| https://github.com/ivanwonder |
| ivanwonder | https://github.com/ivanwonder |
| April 25, 2020 02:11 | https://github.com/angular/angular/pull/36783#event-3271484478 |
| https://github.com/kyliau |
| kyliau | https://github.com/kyliau |
|
Apr 28, 2020
| https://github.com/angular/angular/pull/36783#ref-pullrequest-608642814 |
|
test(language-service): do not invalidate @angular/core
#36845
| https://github.com/angular/angular/pull/36845 |
| kyliau | https://github.com/kyliau |
|
Apr 29, 2020
| https://github.com/angular/angular/pull/36783#ref-commit-c4ca3e8 |
| test(language-service): do not invalidate @angular/core | https://github.com/kyliau/angular/commit/c4ca3e82ce42856c3b2216af52e795ee17f1bd16 |
| c4ca3e8 | https://github.com/kyliau/angular/commit/c4ca3e82ce42856c3b2216af52e795ee17f1bd16 |
| angular#36783 | https://github.com/angular/angular/pull/36783 |
| angular/vscode-ng-language-service#713 | https://github.com/angular/vscode-ng-language-service/issues/713 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Apr 29, 2020
| https://github.com/angular/angular/pull/36783#ref-commit-62ba0ac |
|
| https://github.com/AndrewKushnir |
| test(language-service): do not invalidate @angular/core ( | https://github.com/angular/angular/commit/62ba0acfb501c280dfd7cbcb06dccb28d41774a4 |
| #36845 | https://github.com/angular/angular/pull/36845 |
| ) | https://github.com/angular/angular/commit/62ba0acfb501c280dfd7cbcb06dccb28d41774a4 |
| 62ba0ac | https://github.com/angular/angular/commit/62ba0acfb501c280dfd7cbcb06dccb28d41774a4 |
| #36783 | https://github.com/angular/angular/pull/36783 |
| angular/vscode-ng-language-service#713 | https://github.com/angular/vscode-ng-language-service/issues/713 |
| #36845 | https://github.com/angular/angular/pull/36845 |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Apr 29, 2020
| https://github.com/angular/angular/pull/36783#ref-commit-15e1bfc |
|
| https://github.com/AndrewKushnir |
| test(language-service): do not invalidate @angular/core ( | https://github.com/angular/angular/commit/15e1bfc026fff0a71d3e6705b527d47aed771ca7 |
| #36845 | https://github.com/angular/angular/pull/36845 |
| ) | https://github.com/angular/angular/commit/15e1bfc026fff0a71d3e6705b527d47aed771ca7 |
| 15e1bfc | https://github.com/angular/angular/commit/15e1bfc026fff0a71d3e6705b527d47aed771ca7 |
| #36783 | https://github.com/angular/angular/pull/36783 |
| angular/vscode-ng-language-service#713 | https://github.com/angular/vscode-ng-language-service/issues/713 |
| #36845 | https://github.com/angular/angular/pull/36845 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| May 26, 2020 | https://github.com/angular/angular/pull/36783#issuecomment-634124300 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/36783 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| May 26, 2020 | https://github.com/angular/angular/pull/36783#event-3374302466 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36783 |
|
| https://github.com/kyliau |
|
kyliau
| https://github.com/kyliau |
|
| https://github.com/angular/angular/pull/36783/files/42da9dc7768232209545ed69b68520529e99be3c |
| Please reload this page | https://github.com/angular/angular/pull/36783 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
Angular Language Service 0.901 missing symbols from core.d.ts
| https://github.com/angular/vscode-ng-language-service/issues/713 |
| Please reload this page | https://github.com/angular/angular/pull/36783 |
|
| https://github.com/ivanwonder |
|
| https://github.com/kyliau |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |