René's URL Explorer Experiment


Title: test(router): fix router test failing on IE by atscott · Pull Request #36742 · angular/angular · GitHub

Open Graph Title: test(router): fix router test failing on IE by atscott · Pull Request #36742 · angular/angular

X Title: test(router): fix router test failing on IE by atscott · Pull Request #36742 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This was originally fixed in #35976, but one of the window.scrollY assertions was missed. Also updated tests to use toBeGreater/LessThan to improve failure messages.

X Description: This was originally fixed in #35976, but one of the window.scrollY assertions was missed. Also updated tests to use toBeGreater/LessThan to improve failure messages.

Opengraph URL: https://github.com/angular/angular/pull/36742

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:45aa2379-f52c-0e88-3157-8e239cf4f52d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id97AC:882E2:12BC171:18B50C1:6B011556
html-safe-nonceac1530259a155ab4f97c418cbc1951d6bbded973a47a170ee1a376196b0c47e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0FDOjg4MkUyOjEyQkMxNzE6MThCNTBDMTo2QjAxMTU1NiIsInZpc2l0b3JfaWQiOiIyNTEzMDE4MjkxOTA0MTI0MjQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaceceb1ba6b19c8facffea5a8a19699e600ea519fea8855067b632d9a8b10aee78
hovercard-subject-tagpull_request:406787783
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/36742/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/2876c1b695e1414a0c536ba93d0b00dc221577b4774b3ff55818b57da66a7ba4/angular/angular/pull/36742
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2876c1b695e1414a0c536ba93d0b00dc221577b4774b3ff55818b57da66a7ba4/angular/angular/pull/36742
og:image:altThis was originally fixed in #35976, but one of the window.scrollY assertions was missed. Also updated tests to use toBeGreater/LessThan to improve failure messages.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameatscott
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/36742#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36742
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36742
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36742
Reloadhttps://github.com/angular/angular/pull/36742
Reloadhttps://github.com/angular/angular/pull/36742
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:routersaucehttps://github.com/atscott/angular/tree/routersauce
Conversationhttps://github.com/angular/angular/pull/36742
Commits1 (1)https://github.com/angular/angular/pull/36742/commits
Checkshttps://github.com/angular/angular/pull/36742/checks
Files changedhttps://github.com/angular/angular/pull/36742/files
test(router): fix router test failing on IEhttps://github.com/angular/angular/pull/36742#top
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:routersaucehttps://github.com/atscott/angular/tree/routersauce
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 21, 2020https://github.com/angular/angular/pull/36742#issue-604137442
#35976https://github.com/angular/angular/pull/35976
Please reload this pagehttps://github.com/angular/angular/pull/36742
https://github.com/atscott
test(router): fix router test failing on IEhttps://github.com/angular/angular/pull/36742/commits/5bcf860c5301bff2069a9aad80a3023e607ab88e
5bcf860https://github.com/angular/angular/pull/36742/commits/5bcf860c5301bff2069a9aad80a3023e607ab88e
angular#35976https://github.com/angular/angular/pull/35976
https://github.com/atscott
atscotthttps://github.com/atscott
gregmagolanhttps://github.com/gregmagolan
April 21, 2020 17:02https://github.com/angular/angular/pull/36742#event-3257018670
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Apr 21, 2020https://github.com/angular/angular/pull/36742#event-3257018932
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
gkalpakhttps://github.com/gkalpak
April 21, 2020 17:02https://github.com/angular/angular/pull/36742#event-3257019235
https://github.com/atscott
atscotthttps://github.com/atscott
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Apr 21, 2020https://github.com/angular/angular/pull/36742#event-3257019962
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Apr 21, 2020https://github.com/angular/angular/pull/36742#event-3257020085
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
Apr 22, 2020 https://github.com/angular/angular/pull/36742#pullrequestreview-398609205
View reviewed changes https://github.com/angular/angular/pull/36742/files/5bcf860c5301bff2069a9aad80a3023e607ab88e
gregmagolanhttps://github.com/gregmagolan
https://github.com/angular/angular/pull/36742#pullrequestreview-398609205
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36742
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Apr 22, 2020 https://github.com/angular/angular/pull/36742#pullrequestreview-398613084
View reviewed changes https://github.com/angular/angular/pull/36742/files/5bcf860c5301bff2069a9aad80a3023e607ab88e
https://github.com/atscott
atscotthttps://github.com/atscott
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
Apr 22, 2020https://github.com/angular/angular/pull/36742#event-3262572964
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Apr 22, 2020https://github.com/angular/angular/pull/36742#event-3262573039
https://github.com/atscott
atscotthttps://github.com/atscott
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Apr 22, 2020https://github.com/angular/angular/pull/36742#event-3262573183
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 22, 2020https://github.com/angular/angular/pull/36742#issuecomment-618058076
Please reload this pagehttps://github.com/angular/angular/pull/36742
matskohttps://github.com/matsko
Apr 23, 2020 https://github.com/angular/angular/pull/36742#ref-commit-7743c43
https://github.com/atscott
https://github.com/matsko
test(router): fix router test failing on IE (https://github.com/angular/angular/commit/7743c43529fd04c530c9ef6c34830304c39f1540
#36742https://github.com/angular/angular/pull/36742
)https://github.com/angular/angular/commit/7743c43529fd04c530c9ef6c34830304c39f1540
7743c43https://github.com/angular/angular/commit/7743c43529fd04c530c9ef6c34830304c39f1540
#35976https://github.com/angular/angular/pull/35976
#36742https://github.com/angular/angular/pull/36742
https://github.com/matsko
matskohttps://github.com/matsko
152293dhttps://github.com/angular/angular/commit/152293d3cf4a262dab470a6c6005fc1a01f7e168
Apr 23, 2020https://github.com/angular/angular/pull/36742#event-3265753854
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
May 24, 2020https://github.com/angular/angular/pull/36742#issuecomment-633253906
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/36742
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
May 24, 2020https://github.com/angular/angular/pull/36742#event-3368082414
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36742
https://github.com/gregmagolan
gregmagolan https://github.com/gregmagolan
https://github.com/angular/angular/pull/36742/files/5bcf860c5301bff2069a9aad80a3023e607ab88e
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/36742/files/5bcf860c5301bff2069a9aad80a3023e607ab88e
Please reload this pagehttps://github.com/angular/angular/pull/36742
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
merge: caretaker note https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22merge%3A%20caretaker%20note%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/36742
https://github.com/atscott
https://github.com/gregmagolan
https://github.com/gkalpak
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.