René's URL Explorer Experiment


Title: Revert "fix(router): pass correct component to canDeactivate checks when using two or more sibling router-outlets (#36302)" by matsko · Pull Request #36697 · angular/angular · GitHub

Open Graph Title: Revert "fix(router): pass correct component to canDeactivate checks when using two or more sibling router-outlets (#36302)" by matsko · Pull Request #36697 · angular/angular

X Title: Revert "fix(router): pass correct component to canDeactivate checks when using two or more sibling router-outlets (#36302)" by matsko · Pull Request #36697 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This reverts commit 80e6c07.

X Description: This reverts commit 80e6c07.

Opengraph URL: https://github.com/angular/angular/pull/36697

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:af5c3dc1-32bd-a950-197f-0108de9504e4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB5C2:21BD98:7E1328:9F3F41:6B011D0A
html-safe-nonce0186ebf6d83605b546c8efefe18bcd4b0103b9c00537329944a1a74b32825570
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNUMyOjIxQkQ5ODo3RTEzMjg6OUYzRjQxOjZCMDExRDBBIiwidmlzaXRvcl9pZCI6Ijg4MzAzNjg5NjMyNjQzMjI4MjYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac06eadfc52e11cb32819999263e55469f98aa36ff6412b750b57cfdf8a6aa32e5
hovercard-subject-tagpull_request:405341552
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/36697/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/08906243667285d671f006f427b9127405cb9ecfbd7749564793f87d90a32131/angular/angular/pull/36697
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/08906243667285d671f006f427b9127405cb9ecfbd7749564793f87d90a32131/angular/angular/pull/36697
og:image:altThis reverts commit 80e6c07.
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamematsko
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/36697#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36697
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36697
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36697
Reloadhttps://github.com/angular/angular/pull/36697
Reloadhttps://github.com/angular/angular/pull/36697
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
matskohttps://github.com/matsko
angular:masterhttps://github.com/angular/angular/tree/master
matsko:revert_router_prhttps://github.com/matsko/angular/tree/revert_router_pr
Conversationhttps://github.com/angular/angular/pull/36697
Commits1 (1)https://github.com/angular/angular/pull/36697/commits
Checkshttps://github.com/angular/angular/pull/36697/checks
Files changedhttps://github.com/angular/angular/pull/36697/files
Revert "fix(router): pass correct component to canDeactivate checks when using two or more sibling router-outlets (#36302)"https://github.com/angular/angular/pull/36697#top
matskohttps://github.com/matsko
angular:masterhttps://github.com/angular/angular/tree/master
matsko:revert_router_prhttps://github.com/matsko/angular/tree/revert_router_pr
https://github.com/matsko
matskohttps://github.com/matsko
Apr 17, 2020https://github.com/angular/angular/pull/36697#issue-602234845
80e6c07https://github.com/angular/angular/commit/80e6c07d89d74d71956fb1299c54f5353e255370
Please reload this pagehttps://github.com/angular/angular/pull/36697
https://github.com/matsko
matskohttps://github.com/matsko
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Apr 17, 2020https://github.com/angular/angular/pull/36697#event-3245990630
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Apr 17, 2020https://github.com/angular/angular/pull/36697#event-3245990758
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
atscotthttps://github.com/atscott
April 17, 2020 21:09https://github.com/angular/angular/pull/36697#event-3245990911
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 17, 2020 https://github.com/angular/angular/pull/36697#pullrequestreview-395774691
View reviewed changes https://github.com/angular/angular/pull/36697/files
https://github.com/matsko
Revert "fix(router): pass correct component to canDeactivate checks w…https://github.com/angular/angular/pull/36697/commits/78560a3ff1ebb43e8dd48298665ffde86279ac24
78560a3https://github.com/angular/angular/pull/36697/commits/78560a3ff1ebb43e8dd48298665ffde86279ac24
angular#36302https://github.com/angular/angular/pull/36302
80e6c07https://github.com/matsko/angular/commit/80e6c07d89d74d71956fb1299c54f5353e255370
https://github.com/matsko
matskohttps://github.com/matsko
force-pushedhttps://github.com/angular/angular/compare/3847422b6856b4a436d8b2421a92b04280562afd..78560a3ff1ebb43e8dd48298665ffde86279ac24
3847422https://github.com/angular/angular/commit/3847422b6856b4a436d8b2421a92b04280562afd
78560a3https://github.com/angular/angular/commit/78560a3ff1ebb43e8dd48298665ffde86279ac24
Compare https://github.com/angular/angular/compare/3847422b6856b4a436d8b2421a92b04280562afd..78560a3ff1ebb43e8dd48298665ffde86279ac24
April 17, 2020 21:15https://github.com/angular/angular/pull/36697#event-3246004917
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 17, 2020https://github.com/angular/angular/pull/36697#issuecomment-615490397
Please reload this pagehttps://github.com/angular/angular/pull/36697
https://github.com/atscott
atscotthttps://github.com/atscott
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
Apr 17, 2020https://github.com/angular/angular/pull/36697#event-3246250665
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Apr 17, 2020https://github.com/angular/angular/pull/36697#event-3246250780
https://github.com/atscott
atscotthttps://github.com/atscott
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Apr 17, 2020https://github.com/angular/angular/pull/36697#event-3246250975
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 17, 2020https://github.com/angular/angular/pull/36697#issuecomment-615501735
Presubmithttps://test.corp.google.com/ui#id=OCL:307112237:BASE:307112258:1587157856539:98de220d
Please reload this pagehttps://github.com/angular/angular/pull/36697
test(router): add canDeactivate test for forChild route #36699 https://github.com/angular/angular/pull/36699
fix(router): Pass correct component to canDeactivate checks when using two sibling router-outlets #36302 https://github.com/angular/angular/pull/36302
https://github.com/matsko
matskohttps://github.com/matsko
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Apr 20, 2020https://github.com/angular/angular/pull/36697#event-3252859887
https://github.com/matsko
matskohttps://github.com/matsko
b5e92b9https://github.com/angular/angular/commit/b5e92b9a5d815139e0f2277fc637f5e982076fe9
Apr 20, 2020https://github.com/angular/angular/pull/36697#event-3252861708
matskohttps://github.com/matsko
Apr 20, 2020 https://github.com/angular/angular/pull/36697#ref-commit-722d939
https://github.com/matsko
Revert "fix(router): pass correct component to canDeactivate checks w…https://github.com/angular/angular/commit/722d9397b0fc992e4f937e7fd0c2544f582043da
722d939https://github.com/angular/angular/commit/722d9397b0fc992e4f937e7fd0c2544f582043da
#36302https://github.com/angular/angular/pull/36302
#36697https://github.com/angular/angular/pull/36697
80e6c07https://github.com/angular/angular/commit/80e6c07d89d74d71956fb1299c54f5353e255370
#36697https://github.com/angular/angular/pull/36697
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
May 21, 2020https://github.com/angular/angular/pull/36697#issuecomment-632179925
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/36697
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
May 21, 2020https://github.com/angular/angular/pull/36697#event-3361297473
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36697
https://github.com/atscott
atscott https://github.com/atscott
https://github.com/angular/angular/pull/36697/files/3847422b6856b4a436d8b2421a92b04280562afd
Please reload this pagehttps://github.com/angular/angular/pull/36697
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/36697
https://github.com/matsko
https://github.com/atscott
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.