René's URL Explorer Experiment


Title: ci: add codeowner group for migrations by devversion · Pull Request #36661 · angular/angular · GitHub

Open Graph Title: ci: add codeowner group for migrations by devversion · Pull Request #36661 · angular/angular

X Title: ci: add codeowner group for migrations by devversion · Pull Request #36661 · angular/angular

Description: Please see individual commits. The PR quickly evolved into something larger. When I tested the new codeowner group for migrations (which we decided to create based on a recent FW meeting), I noticed that: Reviews for fw-compiler are sometimes not sent if ngcc files have been touched. We need to refactor our pullapprove verification script so that we can fix (1) and that we can use simpler conditions.

Open Graph Description: Please see individual commits. The PR quickly evolved into something larger. When I tested the new codeowner group for migrations (which we decided to create based on a recent FW meeting), I notice...

X Description: Please see individual commits. The PR quickly evolved into something larger. When I tested the new codeowner group for migrations (which we decided to create based on a recent FW meeting), I notice...

Opengraph URL: https://github.com/angular/angular/pull/36661

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:9e8a270d-9bb4-2bf5-68ed-385448efab2b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8A4E:13C1CF:5041BF:6AE91A:6B017A4A
html-safe-nonce6953c57ae4f1be3e8cb068cbcabe5230c2d628294c7903f9cd2e5863d75c8c6d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QTRFOjEzQzFDRjo1MDQxQkY6NkFFOTFBOjZCMDE3QTRBIiwidmlzaXRvcl9pZCI6Ijg5MDQxMjY4MTQ1OTU2NzY3NDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac15498a6bdbfd4357cd878361766ec50a80774d35d09efe891cde9b17d18238a4
hovercard-subject-tagpull_request:404328225
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/36661/files
twitter:imagehttps://avatars.githubusercontent.com/u/4987015?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4987015?s=400&v=4
og:image:altPlease see individual commits. The PR quickly evolved into something larger. When I tested the new codeowner group for migrations (which we decided to create based on a recent FW meeting), I notice...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/36661/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36661%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36661%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36661/files
Reloadhttps://github.com/angular/angular/pull/36661/files
Reloadhttps://github.com/angular/angular/pull/36661/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
devversionhttps://github.com/devversion
angular:masterhttps://github.com/angular/angular/tree/master
devversion:ci/codeowner-group-for-migrationshttps://github.com/devversion/angular/tree/ci/codeowner-group-for-migrations
Conversation 12 https://github.com/angular/angular/pull/36661
Commits 5 https://github.com/angular/angular/pull/36661/commits
Checks 0 https://github.com/angular/angular/pull/36661/checks
Files changed 8 https://github.com/angular/angular/pull/36661/files
ci: add codeowner group for migrations https://github.com/angular/angular/pull/36661/files#top
Show all changes 5 commits https://github.com/angular/angular/pull/36661/files
a16c002 feat(dev-infra): pullapprove verify should handle `files` in conditions devversion Apr 16, 2020 https://github.com/angular/angular/pull/36661/commits/a16c0028ce11473af3aae34b9efbb7fdd2fe7999
e0df844 ci: add codeowner group for migrations devversion Apr 16, 2020 https://github.com/angular/angular/pull/36661/commits/e0df844dcdd03156c0e1921a2c7ddf10cea02b52
4cfb042 ci: fix pullapprove incorrectly skipping fw-compiler as owner devversion Apr 16, 2020 https://github.com/angular/angular/pull/36661/commits/4cfb042592d9d34b8c1b86bcc4578692b5fd9130
1fc76ea fixup! feat(dev-infra): pullapprove verify should handle `files` in c… devversion Apr 17, 2020 https://github.com/angular/angular/pull/36661/commits/1fc76eafa6697c464e46671b97fe97fa5a50e539
66adde1 fixup! feat(dev-infra): pullapprove verify should handle `files` in c… devversion Apr 20, 2020 https://github.com/angular/angular/pull/36661/commits/66adde1287b49bdc79e56d05a1dafa0d6e3be098
Clear filters https://github.com/angular/angular/pull/36661/files
Please reload this pagehttps://github.com/angular/angular/pull/36661/files
Please reload this pagehttps://github.com/angular/angular/pull/36661/files
.pullapprove.yml https://github.com/angular/angular/pull/36661/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
BUILD.bazel https://github.com/angular/angular/pull/36661/files#diff-53303df746c984f797ea52b46c1062341715fdedbe2aa34f4f673c2452d46c1f
cli.ts https://github.com/angular/angular/pull/36661/files#diff-25a5ac33bb8411b5580b94b3d172cd9ac5ffdad6a6f5e50d733c41e6bd1c50dd
condition_evaluator.ts https://github.com/angular/angular/pull/36661/files#diff-af3176c4a8ee43f94cef9b8028d6a06c2822e8740934e0f0284c7bd559f5069f
group.ts https://github.com/angular/angular/pull/36661/files#diff-f77a5807b23539cd614d6ae2e6d1104c24da40bbcc64b341c9caad4bbd0706a1
logging.ts https://github.com/angular/angular/pull/36661/files#diff-52ad4a7a1d1c6ab2c95a04eebbb83e3f8577c20de5bd9c380661ce1e4e1ee126
parse-yaml.ts https://github.com/angular/angular/pull/36661/files#diff-34bc66069b94d3b4c9050dec0e6a041a44c3ac3304bfd6a0ff64155221c7bb03
verify.ts https://github.com/angular/angular/pull/36661/files#diff-5813a0c38beaf270d2cff49ffa8271593385c147f61d00c9deaaf96fc283d3e9
.pullapprove.ymlhttps://github.com/angular/angular/pull/36661/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
View file https://github.com/devversion/angular/blob/66adde1287b49bdc79e56d05a1dafa0d6e3be098/.pullapprove.yml
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36661/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36661/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
https://github.com/angular/angular/pull/36661/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
https://github.com/angular/angular/pull/36661/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
https://github.com/angular/angular/pull/36661/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
devversionhttps://github.com/devversion
Apr 16, 2020https://github.com/angular/angular/pull/36661/files#r409866465
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@alxhubhttps://github.com/alxhub
@crisbetohttps://github.com/crisbeto
@karahttps://github.com/kara
Please reload this pagehttps://github.com/angular/angular/pull/36661/files
https://github.com/angular/angular/pull/36661/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
https://github.com/angular/angular/pull/36661/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
https://github.com/angular/angular/pull/36661/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
https://github.com/angular/angular/pull/36661/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936
dev-infra/pullapprove/BUILD.bazelhttps://github.com/angular/angular/pull/36661/files#diff-53303df746c984f797ea52b46c1062341715fdedbe2aa34f4f673c2452d46c1f
View file https://github.com/devversion/angular/blob/66adde1287b49bdc79e56d05a1dafa0d6e3be098/dev-infra/pullapprove/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36661/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36661/files#diff-53303df746c984f797ea52b46c1062341715fdedbe2aa34f4f673c2452d46c1f
https://github.com/angular/angular/pull/36661/files#diff-53303df746c984f797ea52b46c1062341715fdedbe2aa34f4f673c2452d46c1f
dev-infra/pullapprove/cli.tshttps://github.com/angular/angular/pull/36661/files#diff-25a5ac33bb8411b5580b94b3d172cd9ac5ffdad6a6f5e50d733c41e6bd1c50dd
View file https://github.com/devversion/angular/blob/66adde1287b49bdc79e56d05a1dafa0d6e3be098/dev-infra/pullapprove/cli.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36661/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36661/files#diff-25a5ac33bb8411b5580b94b3d172cd9ac5ffdad6a6f5e50d733c41e6bd1c50dd
https://github.com/angular/angular/pull/36661/files#diff-25a5ac33bb8411b5580b94b3d172cd9ac5ffdad6a6f5e50d733c41e6bd1c50dd
dev-infra/pullapprove/condition_evaluator.tshttps://github.com/angular/angular/pull/36661/files#diff-af3176c4a8ee43f94cef9b8028d6a06c2822e8740934e0f0284c7bd559f5069f
View file https://github.com/devversion/angular/blob/66adde1287b49bdc79e56d05a1dafa0d6e3be098/dev-infra/pullapprove/condition_evaluator.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36661/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular/pull/36661/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.