René's URL Explorer Experiment


Title: fix(ngcc): use annotateForClosureCompiler option by DavidANeil · Pull Request #36652 · angular/angular · GitHub

Open Graph Title: fix(ngcc): use annotateForClosureCompiler option by DavidANeil · Pull Request #36652 · angular/angular

X Title: fix(ngcc): use annotateForClosureCompiler option by DavidANeil · Pull Request #36652 · angular/angular

Description: Adds @nocollapse to static properties added by ngcc iff annotateForClosureCompiler is true. Resolves #36618. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: #36618 What is the new behavior? When ngcc is invoked with a tsconfig that contains the option "annotateForClosureCompiler": true then ngcc will output closure compatible javascript. Does this PR introduce a breaking change? No

Open Graph Description: Adds @nocollapse to static properties added by ngcc iff annotateForClosureCompiler is true. Resolves #36618. PR Checklist Please check if your PR fulfills the following requirements: The commit m...

X Description: Adds @nocollapse to static properties added by ngcc iff annotateForClosureCompiler is true. Resolves #36618. PR Checklist Please check if your PR fulfills the following requirements: The commit m...

Opengraph URL: https://github.com/angular/angular/pull/36652

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ecb51364-1355-8510-ec1d-bc6c3527e45d
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8422:19E4BB:24F4F56:2F20A9E:6B018EA9
html-safe-nonce550e3f65868a0a6ad4e7a03d8b453af91dd730a8d90a2b2b129811855bdb1d4c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDIyOjE5RTRCQjoyNEY0RjU2OjJGMjBBOUU6NkIwMThFQTkiLCJ2aXNpdG9yX2lkIjoiMjQ1MTE3Mjg3MTY3MDY5NzY0MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd1d03859d5463a57bcef869345772be8516e5de25b978d67086803a719f73cc7
hovercard-subject-tagpull_request:404185408
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/36652/files
twitter:imagehttps://avatars.githubusercontent.com/u/19960231?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/19960231?s=400&v=4
og:image:altAdds @nocollapse to static properties added by ngcc iff annotateForClosureCompiler is true. Resolves #36618. PR Checklist Please check if your PR fulfills the following requirements: The commit m...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/36652/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36652%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36652%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36652/files
Reloadhttps://github.com/angular/angular/pull/36652/files
Reloadhttps://github.com/angular/angular/pull/36652/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests143 (143)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
DavidANeilhttps://github.com/DavidANeil
angular:masterhttps://github.com/angular/angular/tree/master
lucidsoftware:davidneil-ngcc-closure-compathttps://github.com/lucidsoftware/angular/tree/davidneil-ngcc-closure-compat
Conversation 14 https://github.com/angular/angular/pull/36652
Commits 1 https://github.com/angular/angular/pull/36652/commits
Checks 0 https://github.com/angular/angular/pull/36652/checks
Files changed https://github.com/angular/angular/pull/36652/files
Please reload this pagehttps://github.com/angular/angular/pull/36652/files
fix(ngcc): use annotateForClosureCompiler option https://github.com/angular/angular/pull/36652/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/36652/files
fe84683 fix(ngcc): use annotateForClosureCompiler option May 22, 2020 https://github.com/angular/angular/pull/36652/commits/fe84683ae3097c59db3d37fee4e2a39ba2c67c50
Clear filters https://github.com/angular/angular/pull/36652/files
Please reload this pagehttps://github.com/angular/angular/pull/36652/files
Please reload this pagehttps://github.com/angular/angular/pull/36652/files
decoration_analyzer.ts https://github.com/angular/angular/pull/36652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
transformer.ts https://github.com/angular/angular/pull/36652/files#diff-65f61d8d76fba850ad89ea5a1c2058af1a66f3e3904104ea2b05d5a0fffef7ae
renderer.ts https://github.com/angular/angular/pull/36652/files#diff-722bf18677f8fe787cdd375de1f33493d424aa2c400d7ed8f07356dfddad2c7f
ngcc_spec.ts https://github.com/angular/angular/pull/36652/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
translator.ts https://github.com/angular/angular/pull/36652/files#diff-1c770726b9f739f37845a0a834ee3d5423873df910c0dd60bf537dee6d82c440
packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.tshttps://github.com/angular/angular/pull/36652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
View file https://github.com/lucidsoftware/angular/blob/fe84683ae3097c59db3d37fee4e2a39ba2c67c50/packages/compiler-cli/ngcc/src/analysis/decoration_analyzer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/36652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
https://github.com/angular/angular/pull/36652/files#diff-05f578fb87d52034f577816e2947eb548b539febf8a7ac4a6b14203c4b926674
packages/compiler-cli/ngcc/src/packages/transformer.tshttps://github.com/angular/angular/pull/36652/files#diff-65f61d8d76fba850ad89ea5a1c2058af1a66f3e3904104ea2b05d5a0fffef7ae
View file https://github.com/lucidsoftware/angular/blob/fe84683ae3097c59db3d37fee4e2a39ba2c67c50/packages/compiler-cli/ngcc/src/packages/transformer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36652/files#diff-65f61d8d76fba850ad89ea5a1c2058af1a66f3e3904104ea2b05d5a0fffef7ae
https://github.com/angular/angular/pull/36652/files#diff-65f61d8d76fba850ad89ea5a1c2058af1a66f3e3904104ea2b05d5a0fffef7ae
packages/compiler-cli/ngcc/src/rendering/renderer.tshttps://github.com/angular/angular/pull/36652/files#diff-722bf18677f8fe787cdd375de1f33493d424aa2c400d7ed8f07356dfddad2c7f
View file https://github.com/lucidsoftware/angular/blob/fe84683ae3097c59db3d37fee4e2a39ba2c67c50/packages/compiler-cli/ngcc/src/rendering/renderer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36652/files#diff-722bf18677f8fe787cdd375de1f33493d424aa2c400d7ed8f07356dfddad2c7f
https://github.com/angular/angular/pull/36652/files#diff-722bf18677f8fe787cdd375de1f33493d424aa2c400d7ed8f07356dfddad2c7f
https://github.com/angular/angular/pull/36652/files#diff-722bf18677f8fe787cdd375de1f33493d424aa2c400d7ed8f07356dfddad2c7f
https://github.com/angular/angular/pull/36652/files#diff-722bf18677f8fe787cdd375de1f33493d424aa2c400d7ed8f07356dfddad2c7f
https://github.com/angular/angular/pull/36652/files#diff-722bf18677f8fe787cdd375de1f33493d424aa2c400d7ed8f07356dfddad2c7f
https://github.com/angular/angular/pull/36652/files#diff-722bf18677f8fe787cdd375de1f33493d424aa2c400d7ed8f07356dfddad2c7f
https://github.com/angular/angular/pull/36652/files#diff-722bf18677f8fe787cdd375de1f33493d424aa2c400d7ed8f07356dfddad2c7f
https://github.com/angular/angular/pull/36652/files#diff-722bf18677f8fe787cdd375de1f33493d424aa2c400d7ed8f07356dfddad2c7f
packages/compiler-cli/ngcc/test/integration/ngcc_spec.tshttps://github.com/angular/angular/pull/36652/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
View file https://github.com/lucidsoftware/angular/blob/fe84683ae3097c59db3d37fee4e2a39ba2c67c50/packages/compiler-cli/ngcc/test/integration/ngcc_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36652/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
https://github.com/angular/angular/pull/36652/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
packages/compiler-cli/src/ngtsc/translator/src/translator.tshttps://github.com/angular/angular/pull/36652/files#diff-1c770726b9f739f37845a0a834ee3d5423873df910c0dd60bf537dee6d82c440
View file https://github.com/lucidsoftware/angular/blob/fe84683ae3097c59db3d37fee4e2a39ba2c67c50/packages/compiler-cli/src/ngtsc/translator/src/translator.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36652/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36652/files#diff-1c770726b9f739f37845a0a834ee3d5423873df910c0dd60bf537dee6d82c440
https://github.com/angular/angular/pull/36652/files#diff-1c770726b9f739f37845a0a834ee3d5423873df910c0dd60bf537dee6d82c440
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.