René's URL Explorer Experiment


Title: refactor(common): remove WrappedValue from AsyncPipe by atscott · Pull Request #36633 · angular/angular · GitHub

Open Graph Title: refactor(common): remove WrappedValue from AsyncPipe by atscott · Pull Request #36633 · angular/angular

X Title: refactor(common): remove WrappedValue from AsyncPipe by atscott · Pull Request #36633 · angular/angular

Description: global presubmit AsyncPipe only uses WrappedValue when the latest value from the Promise or Observable is different from the previous one. This is already enough to trigger change detection so the WrappedValue is not necessary. Fixes #29927 BREAKING CHANGE: This change could result in ExpressionChangedAfterItHasBeenChecked errors that were not detected before. The error could previously have gone undetected because two WrappedValues are considered "equal" in all cases for the purposes of the check, even if their respective unwrapped values are not.

Open Graph Description: global presubmit AsyncPipe only uses WrappedValue when the latest value from the Promise or Observable is different from the previous one. This is already enough to trigger change detection so the ...

X Description: global presubmit AsyncPipe only uses WrappedValue when the latest value from the Promise or Observable is different from the previous one. This is already enough to trigger change detection so the ...

Opengraph URL: https://github.com/angular/angular/pull/36633

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:083f7b48-13ac-198a-e7a1-b6e4b291975f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBEE6:1C6C3E:1AE90FB:236DE61:6B014BCB
html-safe-nonce6e6b358f5fd4c8881cdab066915b8b58ee8bc548f165cc0a118ee867a90c09cd
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRUU2OjFDNkMzRToxQUU5MEZCOjIzNkRFNjE6NkIwMTRCQ0IiLCJ2aXNpdG9yX2lkIjoiODkwMDQ1NzUxNjY2MDUwOTY0MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac78f889a3d7011c123240ac7e65791cb1a37573b8814abcd68638dc1904d0655f
hovercard-subject-tagpull_request:403498220
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/36633/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altglobal presubmit AsyncPipe only uses WrappedValue when the latest value from the Promise or Observable is different from the previous one. This is already enough to trigger change detection so the ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/36633/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36633%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36633%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36633/files
Reloadhttps://github.com/angular/angular/pull/36633/files
Reloadhttps://github.com/angular/angular/pull/36633/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:asyncpipehttps://github.com/atscott/angular/tree/asyncpipe
Conversation 8 https://github.com/angular/angular/pull/36633
Commits 1 https://github.com/angular/angular/pull/36633/commits
Checks 0 https://github.com/angular/angular/pull/36633/checks
Files changed https://github.com/angular/angular/pull/36633/files
Please reload this pagehttps://github.com/angular/angular/pull/36633/files
refactor(common): remove WrappedValue from AsyncPipe https://github.com/angular/angular/pull/36633/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/36633/files
4ad18f1 refactor(common): remove WrappedValue from AsyncPipe atscott Apr 15, 2020 https://github.com/angular/angular/pull/36633/commits/4ad18f1efdaf2f782c1e4aa656da7e142bd1fcc3
Clear filters https://github.com/angular/angular/pull/36633/files
Please reload this pagehttps://github.com/angular/angular/pull/36633/files
Please reload this pagehttps://github.com/angular/angular/pull/36633/files
async_pipe.ts https://github.com/angular/angular/pull/36633/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
async_pipe_spec.ts https://github.com/angular/angular/pull/36633/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
packages/common/src/pipes/async_pipe.tshttps://github.com/angular/angular/pull/36633/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
View file https://github.com/atscott/angular/blob/4ad18f1efdaf2f782c1e4aa656da7e142bd1fcc3/packages/common/src/pipes/async_pipe.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36633/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36633/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/36633/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/36633/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/36633/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/36633/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/36633/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
https://github.com/angular/angular/pull/36633/files#diff-7b2eb9c78f797db12472634292dfe2668c2adc76ca4f61f97a174b80aa94b73b
packages/common/test/pipes/async_pipe_spec.tshttps://github.com/angular/angular/pull/36633/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
View file https://github.com/atscott/angular/blob/4ad18f1efdaf2f782c1e4aa656da7e142bd1fcc3/packages/common/test/pipes/async_pipe_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36633/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36633/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
https://github.com/angular/angular/pull/36633/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
https://github.com/angular/angular/pull/36633/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
https://github.com/angular/angular/pull/36633/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
https://github.com/angular/angular/pull/36633/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
https://github.com/angular/angular/pull/36633/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
https://github.com/angular/angular/pull/36633/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
https://github.com/angular/angular/pull/36633/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
https://github.com/angular/angular/pull/36633/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
https://github.com/angular/angular/pull/36633/files#diff-791a50ea261d7d9eee1047aab29505cdf7ec19b59ee4828c5adebe13632ea87f
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.