René's URL Explorer Experiment


Title: fix(ngcc): recognize enum declarations emitted in JavaScript by JoostK · Pull Request #36550 · angular/angular · GitHub

Open Graph Title: fix(ngcc): recognize enum declarations emitted in JavaScript by JoostK · Pull Request #36550 · angular/angular

X Title: fix(ngcc): recognize enum declarations emitted in JavaScript by JoostK · Pull Request #36550 · angular/angular

Description: An enum declaration in TypeScript code will be emitted into JavaScript as a regular variable declaration, with the enum members being declared inside an IIFE. For ngcc to support interpreting such variable declarations as enum declarations with its members, ngcc needs to recognize the enum declaration emit structure and extract all member from the statements in the IIFE. This commit extends the ConcreteDeclaration structure in the ReflectionHost abstraction to be able to capture the enum members on a variable declaration, as a substitute for the original ts.EnumDeclaration as it existed in TypeScript code. The static interpreter has been extended to handle the extracted enum members as it would have done for ts.EnumDeclaration. Fixes #35584 Resolves FW-2069

Open Graph Description: An enum declaration in TypeScript code will be emitted into JavaScript as a regular variable declaration, with the enum members being declared inside an IIFE. For ngcc to support interpreting such ...

X Description: An enum declaration in TypeScript code will be emitted into JavaScript as a regular variable declaration, with the enum members being declared inside an IIFE. For ngcc to support interpreting such ...

Opengraph URL: https://github.com/angular/angular/pull/36550

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:cb90f93b-ba80-df0a-b26b-1918bf8f4e07
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8450:293FF:FF43:1427F:6B017A2F
html-safe-nonce04f5167fa00e3d2307e24a1d2566e59c95edd9c04362068bbad4fece20746592
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDUwOjI5M0ZGOkZGNDM6MTQyN0Y6NkIwMTdBMkYiLCJ2aXNpdG9yX2lkIjoiMTg0MzM2Njc4NjYxNjA5NzMyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac90690ec17d8f087585a1a6c734d3163f9b9d72e6b2a387bf01583ef3a9769a3d
hovercard-subject-tagpull_request:401677761
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/36550/files
twitter:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
og:image:altAn enum declaration in TypeScript code will be emitted into JavaScript as a regular variable declaration, with the enum members being declared inside an IIFE. For ngcc to support interpreting such ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/36550/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36550%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36550%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36550/files
Reloadhttps://github.com/angular/angular/pull/36550/files
Reloadhttps://github.com/angular/angular/pull/36550/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngcc/enumshttps://github.com/JoostK/angular/tree/ngcc/enums
Conversation 22 https://github.com/angular/angular/pull/36550
Commits 1 https://github.com/angular/angular/pull/36550/commits
Checks 0 https://github.com/angular/angular/pull/36550/checks
Files changed https://github.com/angular/angular/pull/36550/files
Please reload this pagehttps://github.com/angular/angular/pull/36550/files
fix(ngcc): recognize enum declarations emitted in JavaScript https://github.com/angular/angular/pull/36550/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/36550/files
1fb0270 fix(ngcc): recognize enum declarations emitted in JavaScript JoostK Apr 9, 2020 https://github.com/angular/angular/pull/36550/commits/1fb02700533940d1c35c7230d5f3728f64ab7db9
Clear filters https://github.com/angular/angular/pull/36550/files
Please reload this pagehttps://github.com/angular/angular/pull/36550/files
Please reload this pagehttps://github.com/angular/angular/pull/36550/files
module_with_providers_analyzer.ts https://github.com/angular/angular/pull/36550/files#diff-e311ab2eec15fac4970a699c3e42177f799861d7eb08df5d5d0873fc76e21fb0
commonjs_host.ts https://github.com/angular/angular/pull/36550/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e
esm2015_host.ts https://github.com/angular/angular/pull/36550/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
esm5_host.ts https://github.com/angular/angular/pull/36550/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
umd_host.ts https://github.com/angular/angular/pull/36550/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce
utils.ts https://github.com/angular/angular/pull/36550/files#diff-563780bb2d7422a7965e8668519d6e8109aa62d7977afd85c1d31142f45bc28a
commonjs_host_spec.ts https://github.com/angular/angular/pull/36550/files#diff-0db82dee3e42c4dd42541af6804480af5c328f5b679cf2d9f33972527eca27c5
esm2015_host_spec.ts https://github.com/angular/angular/pull/36550/files#diff-18452185ddea0470affbb7aeb782082f03c1950adf928cf5a5c12ed88045f427
esm5_host_spec.ts https://github.com/angular/angular/pull/36550/files#diff-42557bc6689586acf48908cc8f6488ebcb7bd0239e54fe478ed2b8f008eb58b6
umd_host_spec.ts https://github.com/angular/angular/pull/36550/files#diff-284ab9d6a8ea565f9239b8ba018bd21140c2739accdf565dc7e7a8cae08cd893
ngcc_spec.ts https://github.com/angular/angular/pull/36550/files#diff-d709786f58ef391ef6039b5db9baebdc63ba5bfb81ed83cd41303ed03572cd39
interpreter.ts https://github.com/angular/angular/pull/36550/files#diff-98cea8a12b382bb5d7c5d5d599a879b253adf3baa865dbc533fec578538980b9
result.ts https://github.com/angular/angular/pull/36550/files#diff-634c80cf63a92b18037f87ca955ce4157e71b4394376ebcbd3f5760bab983e62
evaluator_spec.ts https://github.com/angular/angular/pull/36550/files#diff-c6c2f00ba140770ed45ec68adb15c6d80246277144625ef7793843e98063a829
host.ts https://github.com/angular/angular/pull/36550/files#diff-e7f1562798d174a4ababbfbf02ea86bd4c83efa846959878d56db221cc3dd389
typescript.ts https://github.com/angular/angular/pull/36550/files#diff-f64171de3bc6bd3aca1ecb9a6f9711ee7b5e5e87d8c01bb4759aca4831baa71d
ts_host_spec.ts https://github.com/angular/angular/pull/36550/files#diff-10d58e544cc23fe91b826fb10f0bf4ef335a1cb9d51360fadeec9e1688a5082a
packages/compiler-cli/ngcc/src/analysis/module_with_providers_analyzer.tshttps://github.com/angular/angular/pull/36550/files#diff-e311ab2eec15fac4970a699c3e42177f799861d7eb08df5d5d0873fc76e21fb0
View file https://github.com/JoostK/angular/blob/1fb02700533940d1c35c7230d5f3728f64ab7db9/packages/compiler-cli/ngcc/src/analysis/module_with_providers_analyzer.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36550/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36550/files#diff-e311ab2eec15fac4970a699c3e42177f799861d7eb08df5d5d0873fc76e21fb0
https://github.com/angular/angular/pull/36550/files#diff-e311ab2eec15fac4970a699c3e42177f799861d7eb08df5d5d0873fc76e21fb0
packages/compiler-cli/ngcc/src/host/commonjs_host.tshttps://github.com/angular/angular/pull/36550/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e
View file https://github.com/JoostK/angular/blob/1fb02700533940d1c35c7230d5f3728f64ab7db9/packages/compiler-cli/ngcc/src/host/commonjs_host.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36550/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36550/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e
https://github.com/angular/angular/pull/36550/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e
https://github.com/angular/angular/pull/36550/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e
https://github.com/angular/angular/pull/36550/files#diff-39b1d4e5eef7a09fe5e7d016596c2e5faca423bd2a3a6b394da7f755d537712e
packages/compiler-cli/ngcc/src/host/esm2015_host.tshttps://github.com/angular/angular/pull/36550/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
View file https://github.com/JoostK/angular/blob/1fb02700533940d1c35c7230d5f3728f64ab7db9/packages/compiler-cli/ngcc/src/host/esm2015_host.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36550/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36550/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
https://github.com/angular/angular/pull/36550/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
https://github.com/angular/angular/pull/36550/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
https://github.com/angular/angular/pull/36550/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
https://github.com/angular/angular/pull/36550/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
Please reload this pagehttps://github.com/angular/angular/pull/36550/files
https://github.com/angular/angular/pull/36550/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
packages/compiler-cli/ngcc/src/host/esm5_host.tshttps://github.com/angular/angular/pull/36550/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
View file https://github.com/JoostK/angular/blob/1fb02700533940d1c35c7230d5f3728f64ab7db9/packages/compiler-cli/ngcc/src/host/esm5_host.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36550/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36550/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/36550/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
https://github.com/angular/angular/pull/36550/files#diff-c5c2b1303426d47925e9a05fa2124db9edf2fd284f81ab1a85676f54f18107a0
packages/compiler-cli/ngcc/src/host/umd_host.tshttps://github.com/angular/angular/pull/36550/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce
View file https://github.com/JoostK/angular/blob/1fb02700533940d1c35c7230d5f3728f64ab7db9/packages/compiler-cli/ngcc/src/host/umd_host.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36550/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36550/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce
https://github.com/angular/angular/pull/36550/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce
https://github.com/angular/angular/pull/36550/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce
https://github.com/angular/angular/pull/36550/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce
https://github.com/angular/angular/pull/36550/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce
https://github.com/angular/angular/pull/36550/files#diff-5d0863b117d9dd32f96881acfdd6ae2a16b1090835527627e3df661d0a3df0ce
packages/compiler-cli/ngcc/src/host/utils.tshttps://github.com/angular/angular/pull/36550/files#diff-563780bb2d7422a7965e8668519d6e8109aa62d7977afd85c1d31142f45bc28a
View file https://github.com/JoostK/angular/blob/1fb02700533940d1c35c7230d5f3728f64ab7db9/packages/compiler-cli/ngcc/src/host/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36550/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular/pull/36550/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.