René's URL Explorer Experiment


Title: fix(ngcc): recognize enum declarations emitted in JavaScript by JoostK · Pull Request #36550 · angular/angular · GitHub

Open Graph Title: fix(ngcc): recognize enum declarations emitted in JavaScript by JoostK · Pull Request #36550 · angular/angular

X Title: fix(ngcc): recognize enum declarations emitted in JavaScript by JoostK · Pull Request #36550 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: An enum declaration in TypeScript code will be emitted into JavaScript as a regular variable declaration, with the enum members being declared inside an IIFE. For ngcc to support interpreting such ...

X Description: An enum declaration in TypeScript code will be emitted into JavaScript as a regular variable declaration, with the enum members being declared inside an IIFE. For ngcc to support interpreting such ...

Opengraph URL: https://github.com/angular/angular/pull/36550

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:3f96aac8-0cad-6f1d-b319-ba0d7e9cc9ea
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAA2E:1DCB8C:1228A66:1802E57:6B011621
html-safe-noncee626b06ae77c7e264315a3d84989de3cc3edeb47867809e060e7608fc7d0623f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTJFOjFEQ0I4QzoxMjI4QTY2OjE4MDJFNTc6NkIwMTE2MjEiLCJ2aXNpdG9yX2lkIjoiODU3MjIyMjgxNDM4NjQ2MDE5MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacf42af132709c474f70e99225de9be9a5f301934321f383d9de306a54605f92a1
hovercard-subject-tagpull_request:401677761
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/36550/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a937fc4e510270bea997740acd4fdb8cbc3a45a3d8e373a0b2e2f2f81100e87f/angular/angular/pull/36550
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a937fc4e510270bea997740acd4fdb8cbc3a45a3d8e373a0b2e2f2f81100e87f/angular/angular/pull/36550
og:image:altAn enum declaration in TypeScript code will be emitted into JavaScript as a regular variable declaration, with the enum members being declared inside an IIFE. For ngcc to support interpreting such ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJoostK
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/36550#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36550
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36550
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36550
Reloadhttps://github.com/angular/angular/pull/36550
Reloadhttps://github.com/angular/angular/pull/36550
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngcc/enumshttps://github.com/JoostK/angular/tree/ngcc/enums
Conversationhttps://github.com/angular/angular/pull/36550
Commits1 (1)https://github.com/angular/angular/pull/36550/commits
Checkshttps://github.com/angular/angular/pull/36550/checks
Files changedhttps://github.com/angular/angular/pull/36550/files
fix(ngcc): recognize enum declarations emitted in JavaScripthttps://github.com/angular/angular/pull/36550#top
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ngcc/enumshttps://github.com/JoostK/angular/tree/ngcc/enums
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Apr 9, 2020https://github.com/angular/angular/pull/36550#issue-597593389
Please reload this pagehttps://github.com/angular/angular/pull/36550
#35584https://github.com/angular/angular/issues/35584
Please reload this pagehttps://github.com/angular/angular/pull/36550
https://github.com/JoostK
JoostKhttps://github.com/JoostK
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
freq1: low https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
severity3: broken https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Apr 9, 2020https://github.com/angular/angular/pull/36550#event-3220202485
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Apr 9, 2020https://github.com/angular/angular/pull/36550#event-3220202534
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Apr 9, 2020https://github.com/angular/angular/pull/36550#event-3220202562
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/eb461a398f35aab5c06fdc46b1ff589eb1826bc6..41edc95309bbe0f539a8f5a284dd662233a1cad2
eb461a3https://github.com/angular/angular/commit/eb461a398f35aab5c06fdc46b1ff589eb1826bc6
41edc95https://github.com/angular/angular/commit/41edc95309bbe0f539a8f5a284dd662233a1cad2
Compare https://github.com/angular/angular/compare/eb461a398f35aab5c06fdc46b1ff589eb1826bc6..41edc95309bbe0f539a8f5a284dd662233a1cad2
April 10, 2020 08:41https://github.com/angular/angular/pull/36550#event-3221218757
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Apr 10, 2020 https://github.com/angular/angular/pull/36550#ref-issue-568363922
ES6 template literal expressions not working past v9 #35584 https://github.com/angular/angular/issues/35584
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/41edc95309bbe0f539a8f5a284dd662233a1cad2..81a5ec1478e06a41ce1619d0e26fb33ab213377e
41edc95https://github.com/angular/angular/commit/41edc95309bbe0f539a8f5a284dd662233a1cad2
81a5ec1https://github.com/angular/angular/commit/81a5ec1478e06a41ce1619d0e26fb33ab213377e
Compare https://github.com/angular/angular/compare/41edc95309bbe0f539a8f5a284dd662233a1cad2..81a5ec1478e06a41ce1619d0e26fb33ab213377e
April 11, 2020 18:37https://github.com/angular/angular/pull/36550#event-3224362293
https://github.com/JoostK
JoostKhttps://github.com/JoostK
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
state: WIP https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22
Apr 11, 2020https://github.com/angular/angular/pull/36550#event-3224396960
https://github.com/JoostK
JoostKhttps://github.com/JoostK
April 11, 2020 19:16https://github.com/angular/angular/pull/36550#event-3224397108
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
alxhubhttps://github.com/alxhub
April 11, 2020 19:16https://github.com/angular/angular/pull/36550#event-3224397228
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/81a5ec1478e06a41ce1619d0e26fb33ab213377e..c44d7ef25e0cef2619120ae454e57cce7e419aad
81a5ec1https://github.com/angular/angular/commit/81a5ec1478e06a41ce1619d0e26fb33ab213377e
c44d7efhttps://github.com/angular/angular/commit/c44d7ef25e0cef2619120ae454e57cce7e419aad
Compare https://github.com/angular/angular/compare/81a5ec1478e06a41ce1619d0e26fb33ab213377e..c44d7ef25e0cef2619120ae454e57cce7e419aad
April 12, 2020 12:41https://github.com/angular/angular/pull/36550#event-3225048271
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Apr 13, 2020 https://github.com/angular/angular/pull/36550#pullrequestreview-392062722
View reviewed changes https://github.com/angular/angular/pull/36550/files
petebacondarwinhttps://github.com/petebacondarwin
https://github.com/angular/angular/pull/36550#pullrequestreview-392062722
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
packages/compiler-cli/ngcc/src/host/esm2015_host.tshttps://github.com/angular/angular/pull/36550/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
petebacondarwinhttps://github.com/petebacondarwin
Apr 13, 2020https://github.com/angular/angular/pull/36550#discussion_r407410672
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
JoostKhttps://github.com/JoostK
Apr 13, 2020https://github.com/angular/angular/pull/36550#discussion_r407422895
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
packages/compiler-cli/ngcc/src/host/esm2015_host.tshttps://github.com/angular/angular/pull/36550/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
Please reload this pagehttps://github.com/angular/angular/pull/36550
packages/compiler-cli/ngcc/src/host/esm2015_host.tshttps://github.com/angular/angular/pull/36550/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
petebacondarwinhttps://github.com/petebacondarwin
Apr 13, 2020https://github.com/angular/angular/pull/36550#discussion_r407412911
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
JoostKhttps://github.com/JoostK
Apr 13, 2020https://github.com/angular/angular/pull/36550#discussion_r407424892
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
petebacondarwinhttps://github.com/petebacondarwin
Apr 13, 2020https://github.com/angular/angular/pull/36550#discussion_r407430648
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
petebacondarwinhttps://github.com/petebacondarwin
Apr 13, 2020https://github.com/angular/angular/pull/36550#discussion_r407433304
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
packages/compiler-cli/ngcc/src/host/esm2015_host.tshttps://github.com/angular/angular/pull/36550/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
petebacondarwinhttps://github.com/petebacondarwin
Apr 13, 2020https://github.com/angular/angular/pull/36550#discussion_r407417577
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
JoostKhttps://github.com/JoostK
Apr 13, 2020https://github.com/angular/angular/pull/36550#discussion_r407425087
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
https://github.com/JoostK
JoostKhttps://github.com/JoostK
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Apr 14, 2020https://github.com/angular/angular/pull/36550#event-3232798991
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/c44d7ef25e0cef2619120ae454e57cce7e419aad..b50e0e7f45d5b8c4b99a93c7d04838512b706c4d
c44d7efhttps://github.com/angular/angular/commit/c44d7ef25e0cef2619120ae454e57cce7e419aad
b50e0e7https://github.com/angular/angular/commit/b50e0e7f45d5b8c4b99a93c7d04838512b706c4d
Compare https://github.com/angular/angular/compare/c44d7ef25e0cef2619120ae454e57cce7e419aad..b50e0e7f45d5b8c4b99a93c7d04838512b706c4d
April 16, 2020 19:15https://github.com/angular/angular/pull/36550#event-3241415332
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Apr 16, 2020 https://github.com/angular/angular/pull/36550#pullrequestreview-394969460
View reviewed changes https://github.com/angular/angular/pull/36550/files
petebacondarwinhttps://github.com/petebacondarwin
https://github.com/angular/angular/pull/36550#pullrequestreview-394969460
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
packages/compiler-cli/ngcc/src/host/esm2015_host.tshttps://github.com/angular/angular/pull/36550/files#diff-9ec2061b5bc59d13752b38f53ce3a85b98da447f17dbb80c98f9526724f29a04
petebacondarwinhttps://github.com/petebacondarwin
Apr 16, 2020https://github.com/angular/angular/pull/36550#discussion_r409824401
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/b50e0e7f45d5b8c4b99a93c7d04838512b706c4d..6199af850553f777ad35b4afacfd0165535b433c
b50e0e7https://github.com/angular/angular/commit/b50e0e7f45d5b8c4b99a93c7d04838512b706c4d
6199af8https://github.com/angular/angular/commit/6199af850553f777ad35b4afacfd0165535b433c
Compare https://github.com/angular/angular/compare/b50e0e7f45d5b8c4b99a93c7d04838512b706c4d..6199af850553f777ad35b4afacfd0165535b433c
April 17, 2020 18:37https://github.com/angular/angular/pull/36550#event-3245547495
https://github.com/JoostK
JoostKhttps://github.com/JoostK
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Apr 17, 2020https://github.com/angular/angular/pull/36550#event-3245714146
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Apr 17, 2020 https://github.com/angular/angular/pull/36550#pullrequestreview-395814419
View reviewed changes https://github.com/angular/angular/pull/36550/files
packages/compiler-cli/src/ngtsc/reflection/src/host.tshttps://github.com/angular/angular/pull/36550/files#diff-e7f1562798d174a4ababbfbf02ea86bd4c83efa846959878d56db221cc3dd389
alxhubhttps://github.com/alxhub
Apr 17, 2020https://github.com/angular/angular/pull/36550#discussion_r410504850
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/6199af850553f777ad35b4afacfd0165535b433c..ec705312ea35089d5ae55aa95ecfd5f4c851879d
6199af8https://github.com/angular/angular/commit/6199af850553f777ad35b4afacfd0165535b433c
ec70531https://github.com/angular/angular/commit/ec705312ea35089d5ae55aa95ecfd5f4c851879d
Compare https://github.com/angular/angular/compare/6199af850553f777ad35b4afacfd0165535b433c..ec705312ea35089d5ae55aa95ecfd5f4c851879d
April 26, 2020 20:22https://github.com/angular/angular/pull/36550#event-3273344718
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Apr 28, 2020 https://github.com/angular/angular/pull/36550#pullrequestreview-402073028
View reviewed changes https://github.com/angular/angular/pull/36550/files
alxhubhttps://github.com/alxhub
https://github.com/angular/angular/pull/36550#pullrequestreview-402073028
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Apr 28, 2020https://github.com/angular/angular/pull/36550#issuecomment-620762152
Presubmithttp://test/OCL:308854806:BASE:308854843:1588096471736:89d90dec
Please reload this pagehttps://github.com/angular/angular/pull/36550
https://github.com/JoostK
JoostKhttps://github.com/JoostK
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Apr 28, 2020https://github.com/angular/angular/pull/36550#event-3281728511
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Apr 28, 2020https://github.com/angular/angular/pull/36550#issuecomment-620798395
https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png
Please reload this pagehttps://github.com/angular/angular/pull/36550
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Apr 28, 2020 https://github.com/angular/angular/pull/36550#pullrequestreview-402158376
View reviewed changes https://github.com/angular/angular/pull/36550/files
packages/compiler-cli/src/ngtsc/partial_evaluator/src/interpreter.tshttps://github.com/angular/angular/pull/36550/files#diff-98cea8a12b382bb5d7c5d5d599a879b253adf3baa865dbc533fec578538980b9
alxhubhttps://github.com/alxhub
Apr 28, 2020https://github.com/angular/angular/pull/36550#discussion_r416878103
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36550
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/0eb574efd96ab230ec9d3bb659634227c79df03c..0ab5b9c891f7e8c368891a3655a2422f8f92b154
0eb574ehttps://github.com/angular/angular/commit/0eb574efd96ab230ec9d3bb659634227c79df03c
0ab5b9chttps://github.com/angular/angular/commit/0ab5b9c891f7e8c368891a3655a2422f8f92b154
Compare https://github.com/angular/angular/compare/0eb574efd96ab230ec9d3bb659634227c79df03c..0ab5b9c891f7e8c368891a3655a2422f8f92b154
April 28, 2020 19:54https://github.com/angular/angular/pull/36550#event-3281887182
https://github.com/JoostK
fix(ngcc): recognize enum declarations emitted in JavaScripthttps://github.com/angular/angular/pull/36550/commits/1fb02700533940d1c35c7230d5f3728f64ab7db9
1fb0270https://github.com/angular/angular/pull/36550/commits/1fb02700533940d1c35c7230d5f3728f64ab7db9
angular#35584https://github.com/angular/angular/issues/35584
https://github.com/JoostK
JoostKhttps://github.com/JoostK
force-pushedhttps://github.com/angular/angular/compare/0ab5b9c891f7e8c368891a3655a2422f8f92b154..1fb02700533940d1c35c7230d5f3728f64ab7db9
0ab5b9chttps://github.com/angular/angular/commit/0ab5b9c891f7e8c368891a3655a2422f8f92b154
1fb0270https://github.com/angular/angular/commit/1fb02700533940d1c35c7230d5f3728f64ab7db9
Compare https://github.com/angular/angular/compare/0ab5b9c891f7e8c368891a3655a2422f8f92b154..1fb02700533940d1c35c7230d5f3728f64ab7db9
April 28, 2020 20:16https://github.com/angular/angular/pull/36550#event-3281965759
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Apr 28, 2020https://github.com/angular/angular/pull/36550#issuecomment-620873837
@JoostKhttps://github.com/JoostK
@alxhubhttps://github.com/alxhub
Please reload this pagehttps://github.com/angular/angular/pull/36550
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Apr 28, 2020https://github.com/angular/angular/pull/36550#event-3282264335
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Apr 28, 2020https://github.com/angular/angular/pull/36550#issuecomment-620874910
@AndrewKushnirhttps://github.com/AndrewKushnir
Please reload this pagehttps://github.com/angular/angular/pull/36550
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Apr 28, 2020https://github.com/angular/angular/pull/36550#event-3282278527
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Apr 28, 2020https://github.com/angular/angular/pull/36550#issuecomment-620876301
@JoostKhttps://github.com/JoostK
g3 presubmithttp://test/OCL:308903090:BASE:308903122:1588110947139:aa840389
Please reload this pagehttps://github.com/angular/angular/pull/36550
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Apr 28, 2020https://github.com/angular/angular/pull/36550#event-3282428793
AndrewKushnirhttps://github.com/AndrewKushnir
Apr 28, 2020 https://github.com/angular/angular/pull/36550#ref-commit-c440165
https://github.com/JoostK
https://github.com/AndrewKushnir
fix(ngcc): recognize enum declarations emitted in JavaScript (https://github.com/angular/angular/commit/c440165384893775083798a6f649893b0f687f52
#36550https://github.com/angular/angular/pull/36550
)https://github.com/angular/angular/commit/c440165384893775083798a6f649893b0f687f52
c440165https://github.com/angular/angular/commit/c440165384893775083798a6f649893b0f687f52
#35584https://github.com/angular/angular/issues/35584
#36550https://github.com/angular/angular/pull/36550
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
89c5890https://github.com/angular/angular/commit/89c589085d89205223c440f003dbea43c6523928
Apr 28, 2020https://github.com/angular/angular/pull/36550#event-3282433731
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
May 29, 2020https://github.com/angular/angular/pull/36550#issuecomment-636057260
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/36550
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
May 29, 2020https://github.com/angular/angular/pull/36550#event-3387866268
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36550
https://github.com/alxhub
alxhub https://github.com/alxhub
https://github.com/angular/angular/pull/36550/files/0eb574efd96ab230ec9d3bb659634227c79df03c
https://github.com/petebacondarwin
petebacondarwin https://github.com/petebacondarwin
https://github.com/angular/angular/pull/36550/files/b50e0e7f45d5b8c4b99a93c7d04838512b706c4d
Please reload this pagehttps://github.com/angular/angular/pull/36550
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
freq1: low https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
ES6 template literal expressions not working past v9 https://github.com/angular/angular/issues/35584
Please reload this pagehttps://github.com/angular/angular/pull/36550
https://github.com/JoostK
https://github.com/alxhub
https://github.com/AndrewKushnir
https://github.com/petebacondarwin
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.