René's URL Explorer Experiment


Title: fix(ngcc): handle entry-points within container folders by petebacondarwin · Pull Request #36305 · angular/angular · GitHub

Open Graph Title: fix(ngcc): handle entry-points within container folders by petebacondarwin · Pull Request #36305 · angular/angular

X Title: fix(ngcc): handle entry-points within container folders by petebacondarwin · Pull Request #36305 · angular/angular

Description: The previous optimizations in #35756 to the DirectoryWalkerEntryPointFinder were over zealous with regard to packages that have entry-points stored in "container" directories in the package, where the container directory was not an entry-point itself. Now we will also walk such "container" folders as long as they do not contain .js files, which we regard as an indicator that the directory will not contain entry-points. Fixes #36216 PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: N/A What is the new behavior? Does this PR introduce a breaking change? Yes No Other information

Open Graph Description: The previous optimizations in #35756 to the DirectoryWalkerEntryPointFinder were over zealous with regard to packages that have entry-points stored in "container" directories in the packa...

X Description: The previous optimizations in #35756 to the DirectoryWalkerEntryPointFinder were over zealous with regard to packages that have entry-points stored in "container" directories in t...

Opengraph URL: https://github.com/angular/angular/pull/36305

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d1ec4792-76cb-d077-2427-370a3114a88e
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8766:E9D16:11A44F2:1656EB0:6B01542D
html-safe-noncef8d7efb5a895c14a6a280b14282ef076f6c5b622ac683e91644e10855ee32c6a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NzY2OkU5RDE2OjExQTQ0RjI6MTY1NkVCMDo2QjAxNTQyRCIsInZpc2l0b3JfaWQiOiI1NDQ0MDEzMjkwMjAyMTU4MTI1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac529aa2928c28047ad4c8d127969a2ac2f3afe5d708bed0a25569cc259bc8a599
hovercard-subject-tagpull_request:395277340
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/36305/files
twitter:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
og:image:altThe previous optimizations in #35756 to the DirectoryWalkerEntryPointFinder were over zealous with regard to packages that have entry-points stored in "container" directories in the packa...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/36305/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36305%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36305%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36305/files
Reloadhttps://github.com/angular/angular/pull/36305/files
Reloadhttps://github.com/angular/angular/pull/36305/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-handle-containing-foldershttps://github.com/petebacondarwin/angular/tree/ngcc-handle-containing-folders
Conversation 32 https://github.com/angular/angular/pull/36305
Commits 5 https://github.com/angular/angular/pull/36305/commits
Checks 0 https://github.com/angular/angular/pull/36305/checks
Files changed https://github.com/angular/angular/pull/36305/files
Please reload this pagehttps://github.com/angular/angular/pull/36305/files
fix(ngcc): handle entry-points within container folders https://github.com/angular/angular/pull/36305/files#top
Show all changes 5 commits https://github.com/angular/angular/pull/36305/files
94df9ce refactor(ngcc): rename INVALID_ENTRY_POINT to INCOMPATIBLE_ENTRY_POINT petebacondarwin Mar 30, 2020 https://github.com/angular/angular/pull/36305/commits/94df9ce56081f487128eb5a99587b9a5cc8c0dde
00a7eb9 refactor(ngcc): simplify `DirectoryWalkerEntryPointFinder` petebacondarwin Mar 29, 2020 https://github.com/angular/angular/pull/36305/commits/00a7eb9d3aae1ac1c29b890fcf6bb058c9721390
c9a3958 fixup! refactor(ngcc): simplify `DirectoryWalkerEntryPointFinder` petebacondarwin Mar 30, 2020 https://github.com/angular/angular/pull/36305/commits/c9a395871237809864b045a6b14051389d4f4183
87fe1dd fix(ngcc): handle entry-points within container folders petebacondarwin Mar 30, 2020 https://github.com/angular/angular/pull/36305/commits/87fe1dd05e23fe3e6aef32443baf75a2a9e17370
7f2122d fixup! fix(ngcc): handle entry-points within container folders petebacondarwin Mar 30, 2020 https://github.com/angular/angular/pull/36305/commits/7f2122de3fe9f54b8a41221a8692a77718ec4383
Clear filters https://github.com/angular/angular/pull/36305/files
Please reload this pagehttps://github.com/angular/angular/pull/36305/files
Please reload this pagehttps://github.com/angular/angular/pull/36305/files
directory_walker_entry_point_finder.ts https://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
targeted_entry_point_finder.ts https://github.com/angular/angular/pull/36305/files#diff-f0abcf7561a5551f36a812d4716222998f9941759c7a0bd28b1138c826a9821f
utils.ts https://github.com/angular/angular/pull/36305/files#diff-8a2b9790f9ba81c1b77aec17cbdcbc754ddbdd6bbb94198f636c751fd62b390b
entry_point.ts https://github.com/angular/angular/pull/36305/files#diff-e7a58b815a502d44590d88e8b3c7417ab24415b0d6536d2b6ee89e8ab18c50ed
entry_point_manifest.ts https://github.com/angular/angular/pull/36305/files#diff-618a24987acee04ae931228b156a71673a8f6796ce47b061d0c268fc06c44623
directory_walker_entry_point_finder_spec.ts https://github.com/angular/angular/pull/36305/files#diff-033689fa7f7079b56eea5ddf520a3c7d0310191e37e01c805a1127637ac8b89b
entry_point_spec.ts https://github.com/angular/angular/pull/36305/files#diff-61caab25f6f0870b1dab7dea7ad90f758923790772ff003aa1838f83456910b6
new_entry_point_file_writer_spec.ts https://github.com/angular/angular/pull/36305/files#diff-09955394d04815008132233d64558b85abb162775347ab4387140f31ecd456c2
packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.tshttps://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
View file https://github.com/petebacondarwin/angular/blob/7f2122de3fe9f54b8a41221a8692a77718ec4383/packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36305/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
https://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
gkalpakhttps://github.com/gkalpak
Mar 30, 2020https://github.com/angular/angular/pull/36305/files#r400233707
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36305/files
petebacondarwinhttps://github.com/petebacondarwin
Mar 30, 2020https://github.com/angular/angular/pull/36305/files#r400245617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@alan-agius4https://github.com/alan-agius4
Please reload this pagehttps://github.com/angular/angular/pull/36305/files
packages/compiler-cli/ngcc/src/entry_point_finder/targeted_entry_point_finder.tshttps://github.com/angular/angular/pull/36305/files#diff-f0abcf7561a5551f36a812d4716222998f9941759c7a0bd28b1138c826a9821f
View file https://github.com/petebacondarwin/angular/blob/7f2122de3fe9f54b8a41221a8692a77718ec4383/packages/compiler-cli/ngcc/src/entry_point_finder/targeted_entry_point_finder.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36305/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36305/files#diff-f0abcf7561a5551f36a812d4716222998f9941759c7a0bd28b1138c826a9821f
https://github.com/angular/angular/pull/36305/files#diff-f0abcf7561a5551f36a812d4716222998f9941759c7a0bd28b1138c826a9821f
https://github.com/angular/angular/pull/36305/files#diff-f0abcf7561a5551f36a812d4716222998f9941759c7a0bd28b1138c826a9821f
https://github.com/angular/angular/pull/36305/files#diff-f0abcf7561a5551f36a812d4716222998f9941759c7a0bd28b1138c826a9821f
packages/compiler-cli/ngcc/src/entry_point_finder/utils.tshttps://github.com/angular/angular/pull/36305/files#diff-8a2b9790f9ba81c1b77aec17cbdcbc754ddbdd6bbb94198f636c751fd62b390b
View file https://github.com/petebacondarwin/angular/blob/7f2122de3fe9f54b8a41221a8692a77718ec4383/packages/compiler-cli/ngcc/src/entry_point_finder/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36305/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36305/files#diff-8a2b9790f9ba81c1b77aec17cbdcbc754ddbdd6bbb94198f636c751fd62b390b
packages/compiler-cli/ngcc/src/packages/entry_point.tshttps://github.com/angular/angular/pull/36305/files#diff-e7a58b815a502d44590d88e8b3c7417ab24415b0d6536d2b6ee89e8ab18c50ed
View file https://github.com/petebacondarwin/angular/blob/7f2122de3fe9f54b8a41221a8692a77718ec4383/packages/compiler-cli/ngcc/src/packages/entry_point.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36305/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36305/files#diff-e7a58b815a502d44590d88e8b3c7417ab24415b0d6536d2b6ee89e8ab18c50ed
https://github.com/angular/angular/pull/36305/files#diff-e7a58b815a502d44590d88e8b3c7417ab24415b0d6536d2b6ee89e8ab18c50ed
https://github.com/angular/angular/pull/36305/files#diff-e7a58b815a502d44590d88e8b3c7417ab24415b0d6536d2b6ee89e8ab18c50ed
https://github.com/angular/angular/pull/36305/files#diff-e7a58b815a502d44590d88e8b3c7417ab24415b0d6536d2b6ee89e8ab18c50ed
https://github.com/angular/angular/pull/36305/files#diff-e7a58b815a502d44590d88e8b3c7417ab24415b0d6536d2b6ee89e8ab18c50ed
packages/compiler-cli/ngcc/src/packages/entry_point_manifest.tshttps://github.com/angular/angular/pull/36305/files#diff-618a24987acee04ae931228b156a71673a8f6796ce47b061d0c268fc06c44623
View file https://github.com/petebacondarwin/angular/blob/7f2122de3fe9f54b8a41221a8692a77718ec4383/packages/compiler-cli/ngcc/src/packages/entry_point_manifest.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36305/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36305/files#diff-618a24987acee04ae931228b156a71673a8f6796ce47b061d0c268fc06c44623
https://github.com/angular/angular/pull/36305/files#diff-618a24987acee04ae931228b156a71673a8f6796ce47b061d0c268fc06c44623
https://github.com/angular/angular/pull/36305/files#diff-618a24987acee04ae931228b156a71673a8f6796ce47b061d0c268fc06c44623
https://github.com/angular/angular/pull/36305/files#diff-618a24987acee04ae931228b156a71673a8f6796ce47b061d0c268fc06c44623
Please reload this pagehttps://github.com/angular/angular/pull/36305/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.