René's URL Explorer Experiment


Title: fix(ngcc): handle entry-points within container folders by petebacondarwin · Pull Request #36305 · angular/angular · GitHub

Open Graph Title: fix(ngcc): handle entry-points within container folders by petebacondarwin · Pull Request #36305 · angular/angular

X Title: fix(ngcc): handle entry-points within container folders by petebacondarwin · Pull Request #36305 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: The previous optimizations in #35756 to the DirectoryWalkerEntryPointFinder were over zealous with regard to packages that have entry-points stored in "container" directories in the packa...

X Description: The previous optimizations in #35756 to the DirectoryWalkerEntryPointFinder were over zealous with regard to packages that have entry-points stored in "container" directories in t...

Opengraph URL: https://github.com/angular/angular/pull/36305

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:d62732c8-306e-da6f-6d7e-35f130c2f403
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id80CA:A71F9:C99E3E:FD5D2B:6B013729
html-safe-nonce84b5a4c73b6c31ef7638fe4a855a0cc81c4908047ea3806a0edaedc9bb8f5336
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MENBOkE3MUY5OkM5OUUzRTpGRDVEMkI6NkIwMTM3MjkiLCJ2aXNpdG9yX2lkIjoiNDU2OTU2MDc4NzcwOTkzMzM1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacff97e16e79962115ff950b8d75d322564074aa0b278f0cf1fe02195db10cc871
hovercard-subject-tagpull_request:395277340
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/36305/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/ad27a50685af238ac8736e398597d125eba90ca7a42f2d0bfe71e7724694d446/angular/angular/pull/36305
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ad27a50685af238ac8736e398597d125eba90ca7a42f2d0bfe71e7724694d446/angular/angular/pull/36305
og:image:altThe previous optimizations in #35756 to the DirectoryWalkerEntryPointFinder were over zealous with regard to packages that have entry-points stored in "container" directories in the packa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/36305#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36305
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36305
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36305
Reloadhttps://github.com/angular/angular/pull/36305
Reloadhttps://github.com/angular/angular/pull/36305
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-handle-containing-foldershttps://github.com/petebacondarwin/angular/tree/ngcc-handle-containing-folders
Conversationhttps://github.com/angular/angular/pull/36305
Commits5 (5)https://github.com/angular/angular/pull/36305/commits
Checkshttps://github.com/angular/angular/pull/36305/checks
Files changedhttps://github.com/angular/angular/pull/36305/files
fix(ngcc): handle entry-points within container foldershttps://github.com/angular/angular/pull/36305#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-handle-containing-foldershttps://github.com/petebacondarwin/angular/tree/ngcc-handle-containing-folders
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Mar 29, 2020https://github.com/angular/angular/pull/36305#issue-589826845
#35756https://github.com/angular/angular/pull/35756
#36216https://github.com/angular/angular/issues/36216
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
comp: ngcc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
Mar 29, 2020https://github.com/angular/angular/pull/36305#event-3176056109
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
JoostKhttps://github.com/JoostK
alan-agius4https://github.com/alan-agius4
gkalpakhttps://github.com/gkalpak
March 29, 2020 16:14https://github.com/angular/angular/pull/36305#event-3176056120
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Mar 29, 2020https://github.com/angular/angular/pull/36305#event-3176056197
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Mar 29, 2020https://github.com/angular/angular/pull/36305#event-3176056219
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Mar 29, 2020 https://github.com/angular/angular/pull/36305#pullrequestreview-383429631
View reviewed changes https://github.com/angular/angular/pull/36305/files
packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.tshttps://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/90ddc0a54bc79b70e229e20036db6da242a854b5..c6ec6d057db5b6ac9f69ea4fb9ed037b34226f5f
90ddc0ahttps://github.com/angular/angular/commit/90ddc0a54bc79b70e229e20036db6da242a854b5
c6ec6d0https://github.com/angular/angular/commit/c6ec6d057db5b6ac9f69ea4fb9ed037b34226f5f
Compare https://github.com/angular/angular/compare/90ddc0a54bc79b70e229e20036db6da242a854b5..c6ec6d057db5b6ac9f69ea4fb9ed037b34226f5f
March 29, 2020 17:55https://github.com/angular/angular/pull/36305#event-3176147462
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Mar 29, 2020 https://github.com/angular/angular/pull/36305#ref-issue-585547277
Error NG6002: Upgraded LIB to NG9 #36185 https://github.com/angular/angular/issues/36185
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/9403b2f581d2719b401c72881dc1ed9d2fe9701c..5a6be66def4d36b092b43fca8b9118c1a0d0f3d6
9403b2fhttps://github.com/angular/angular/commit/9403b2f581d2719b401c72881dc1ed9d2fe9701c
5a6be66https://github.com/angular/angular/commit/5a6be66def4d36b092b43fca8b9118c1a0d0f3d6
Compare https://github.com/angular/angular/compare/9403b2f581d2719b401c72881dc1ed9d2fe9701c..5a6be66def4d36b092b43fca8b9118c1a0d0f3d6
March 29, 2020 20:21https://github.com/angular/angular/pull/36305#event-3176280583
https://github.com/vthinkxie
vthinkxiehttps://github.com/vthinkxie
Mar 30, 2020 https://github.com/angular/angular/pull/36305#ref-issue-585276520
9.0.0-beta.2 Fails to compile NG-ZORRO/ng-zorro-antd#4917 https://github.com/NG-ZORRO/ng-zorro-antd/issues/4917
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Mar 30, 2020 https://github.com/angular/angular/pull/36305#pullrequestreview-383605739
View reviewed changes https://github.com/angular/angular/pull/36305/files
packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.tshttps://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Mar 30, 2020 https://github.com/angular/angular/pull/36305#pullrequestreview-383606770
View reviewed changes https://github.com/angular/angular/pull/36305/files
alan-agius4https://github.com/alan-agius4
https://github.com/angular/angular/pull/36305#pullrequestreview-383606770
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Mar 30, 2020https://github.com/angular/angular/pull/36305#issuecomment-605842140
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Mar 30, 2020https://github.com/angular/angular/pull/36305#issuecomment-605843583
@petebacondarwinhttps://github.com/petebacondarwin
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Mar 30, 2020 https://github.com/angular/angular/pull/36305#pullrequestreview-383611648
View reviewed changes https://github.com/angular/angular/pull/36305/files
packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.tshttps://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Mar 30, 2020 https://github.com/angular/angular/pull/36305#pullrequestreview-383611695
View reviewed changes https://github.com/angular/angular/pull/36305/files
packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.tshttps://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
Mar 30, 2020 https://github.com/angular/angular/pull/36305#pullrequestreview-383611877
View reviewed changes https://github.com/angular/angular/pull/36305/files
packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.tshttps://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Mar 30, 2020https://github.com/angular/angular/pull/36305#event-3177857309
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/eb736aea107b241d4e49500e100bc376204e5ed0..8bfe8fc1bf2bef0cca93823660553a6c11955f3a
eb736aehttps://github.com/angular/angular/commit/eb736aea107b241d4e49500e100bc376204e5ed0
8bfe8fchttps://github.com/angular/angular/commit/8bfe8fc1bf2bef0cca93823660553a6c11955f3a
Compare https://github.com/angular/angular/compare/eb736aea107b241d4e49500e100bc376204e5ed0..8bfe8fc1bf2bef0cca93823660553a6c11955f3a
March 30, 2020 14:10https://github.com/angular/angular/pull/36305#event-3178826026
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Mar 30, 2020 https://github.com/angular/angular/pull/36305#pullrequestreview-383823597
View reviewed changes https://github.com/angular/angular/pull/36305/files
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/36305#pullrequestreview-383823597
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36305
packages/compiler-cli/ngcc/src/entry_point_finder/utils.tshttps://github.com/angular/angular/pull/36305/files#diff-8a2b9790f9ba81c1b77aec17cbdcbc754ddbdd6bbb94198f636c751fd62b390b
Please reload this pagehttps://github.com/angular/angular/pull/36305
packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.tshttps://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
Please reload this pagehttps://github.com/angular/angular/pull/36305
packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.tshttps://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
Please reload this pagehttps://github.com/angular/angular/pull/36305
packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.tshttps://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
Please reload this pagehttps://github.com/angular/angular/pull/36305
packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.tshttps://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
Please reload this pagehttps://github.com/angular/angular/pull/36305
packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.tshttps://github.com/angular/angular/pull/36305/files#diff-1af7c7fe3df4a2e38a754bed518ceaeeaddaaf4d716c6e3e04a0a623d3cd31c5
gkalpakhttps://github.com/gkalpak
Mar 30, 2020https://github.com/angular/angular/pull/36305#discussion_r400233707
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36305
petebacondarwinhttps://github.com/petebacondarwin
Mar 30, 2020https://github.com/angular/angular/pull/36305#discussion_r400245617
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@alan-agius4https://github.com/alan-agius4
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/8bfe8fc1bf2bef0cca93823660553a6c11955f3a..929ba8706b4651508a0bf691930837a7f4c8dad8
8bfe8fchttps://github.com/angular/angular/commit/8bfe8fc1bf2bef0cca93823660553a6c11955f3a
929ba87https://github.com/angular/angular/commit/929ba8706b4651508a0bf691930837a7f4c8dad8
Compare https://github.com/angular/angular/compare/8bfe8fc1bf2bef0cca93823660553a6c11955f3a..929ba8706b4651508a0bf691930837a7f4c8dad8
March 30, 2020 15:37https://github.com/angular/angular/pull/36305#event-3179242525
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Mar 30, 2020https://github.com/angular/angular/pull/36305#event-3179267736
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
gkalpakhttps://github.com/gkalpak
March 30, 2020 15:42https://github.com/angular/angular/pull/36305#event-3179267914
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Mar 30, 2020https://github.com/angular/angular/pull/36305#event-3179420252
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
Mar 30, 2020https://github.com/angular/angular/pull/36305#issuecomment-606098447
https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png
https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png
https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png
Please reload this pagehttps://github.com/angular/angular/pull/36305
petebacondarwinhttps://github.com/petebacondarwin
March 30, 2020 20:32https://github.com/angular/angular/pull/36305#commits-pushed-94df9ce
https://github.com/petebacondarwin
refactor(ngcc): rename INVALID_ENTRY_POINT to INCOMPATIBLE_ENTRY_POINThttps://github.com/angular/angular/pull/36305/commits/94df9ce56081f487128eb5a99587b9a5cc8c0dde
94df9cehttps://github.com/angular/angular/pull/36305/commits/94df9ce56081f487128eb5a99587b9a5cc8c0dde
https://github.com/petebacondarwin
refactor(ngcc): simplify DirectoryWalkerEntryPointFinderhttps://github.com/angular/angular/pull/36305/commits/00a7eb9d3aae1ac1c29b890fcf6bb058c9721390
00a7eb9https://github.com/angular/angular/pull/36305/commits/00a7eb9d3aae1ac1c29b890fcf6bb058c9721390
https://github.com/petebacondarwin
fixup! refactor(ngcc): simplify DirectoryWalkerEntryPointFinderhttps://github.com/angular/angular/pull/36305/commits/c9a395871237809864b045a6b14051389d4f4183
c9a3958https://github.com/angular/angular/pull/36305/commits/c9a395871237809864b045a6b14051389d4f4183
https://github.com/petebacondarwin
fix(ngcc): handle entry-points within container foldershttps://github.com/angular/angular/pull/36305/commits/87fe1dd05e23fe3e6aef32443baf75a2a9e17370
87fe1ddhttps://github.com/angular/angular/pull/36305/commits/87fe1dd05e23fe3e6aef32443baf75a2a9e17370
angular#35756https://github.com/angular/angular/pull/35756
angular#36216https://github.com/angular/angular/issues/36216
https://github.com/petebacondarwin
fixup! fix(ngcc): handle entry-points within container foldershttps://github.com/angular/angular/pull/36305/commits/7f2122de3fe9f54b8a41221a8692a77718ec4383
7f2122dhttps://github.com/angular/angular/pull/36305/commits/7f2122de3fe9f54b8a41221a8692a77718ec4383
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/929ba8706b4651508a0bf691930837a7f4c8dad8..7f2122de3fe9f54b8a41221a8692a77718ec4383
929ba87https://github.com/angular/angular/commit/929ba8706b4651508a0bf691930837a7f4c8dad8
7f2122dhttps://github.com/angular/angular/commit/7f2122de3fe9f54b8a41221a8692a77718ec4383
Compare https://github.com/angular/angular/compare/929ba8706b4651508a0bf691930837a7f4c8dad8..7f2122de3fe9f54b8a41221a8692a77718ec4383
March 30, 2020 19:32https://github.com/angular/angular/pull/36305#event-3180159570
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
JoostKhttps://github.com/JoostK
March 31, 2020 10:15https://github.com/angular/angular/pull/36305#event-3182570680
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Mar 31, 2020 https://github.com/angular/angular/pull/36305#pullrequestreview-385137711
View reviewed changes https://github.com/angular/angular/pull/36305/files/7f2122de3fe9f54b8a41221a8692a77718ec4383
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Apr 1, 2020https://github.com/angular/angular/pull/36305#issuecomment-607273383
Please reload this pagehttps://github.com/angular/angular/pull/36305
alxhubhttps://github.com/alxhub
Apr 1, 2020 https://github.com/angular/angular/pull/36305#ref-commit-de594ca
https://github.com/petebacondarwin
https://github.com/alxhub
refactor(ngcc): rename INVALID_ENTRY_POINT to INCOMPATIBLE_ENTRY_POINT (https://github.com/angular/angular/commit/de594ca22171484f2ed00bf755160f70853c13fd
de594cahttps://github.com/angular/angular/commit/de594ca22171484f2ed00bf755160f70853c13fd
#36305https://github.com/angular/angular/pull/36305
#36305https://github.com/angular/angular/pull/36305
alxhubhttps://github.com/alxhub
Apr 1, 2020 https://github.com/angular/angular/pull/36305#ref-commit-29dcb5b
https://github.com/petebacondarwin
https://github.com/alxhub
refactor(ngcc): simplifyhttps://github.com/angular/angular/commit/29dcb5bf6891a60be698ee99835a864d281a2006
DirectoryWalkerEntryPointFinderhttps://github.com/angular/angular/commit/29dcb5bf6891a60be698ee99835a864d281a2006
(https://github.com/angular/angular/commit/29dcb5bf6891a60be698ee99835a864d281a2006
#36305https://github.com/angular/angular/pull/36305
)https://github.com/angular/angular/commit/29dcb5bf6891a60be698ee99835a864d281a2006
29dcb5bhttps://github.com/angular/angular/commit/29dcb5bf6891a60be698ee99835a864d281a2006
#36305https://github.com/angular/angular/pull/36305
alxhubhttps://github.com/alxhub
Apr 1, 2020 https://github.com/angular/angular/pull/36305#ref-commit-392ef93
https://github.com/petebacondarwin
https://github.com/alxhub
fix(ngcc): handle entry-points within container folders (https://github.com/angular/angular/commit/392ef93c2b8b454b0706711648b465ac48385b8b
#36305https://github.com/angular/angular/pull/36305
)https://github.com/angular/angular/commit/392ef93c2b8b454b0706711648b465ac48385b8b
392ef93https://github.com/angular/angular/commit/392ef93c2b8b454b0706711648b465ac48385b8b
#35756https://github.com/angular/angular/pull/35756
#36216https://github.com/angular/angular/issues/36216
#36305https://github.com/angular/angular/pull/36305
https://github.com/alxhub
alxhubhttps://github.com/alxhub
7e62aa0https://github.com/angular/angular/commit/7e62aa0c6e611c78703a5cd04cebb12e13087577
Apr 1, 2020https://github.com/angular/angular/pull/36305#event-3189536802
alxhubhttps://github.com/alxhub
Apr 1, 2020 https://github.com/angular/angular/pull/36305#ref-commit-372b910
https://github.com/petebacondarwin
https://github.com/alxhub
refactor(ngcc): simplifyhttps://github.com/angular/angular/commit/372b9101e26caf463813d688e2a62f463f8846e9
DirectoryWalkerEntryPointFinderhttps://github.com/angular/angular/commit/372b9101e26caf463813d688e2a62f463f8846e9
(https://github.com/angular/angular/commit/372b9101e26caf463813d688e2a62f463f8846e9
#36305https://github.com/angular/angular/pull/36305
)https://github.com/angular/angular/commit/372b9101e26caf463813d688e2a62f463f8846e9
372b910https://github.com/angular/angular/commit/372b9101e26caf463813d688e2a62f463f8846e9
#36305https://github.com/angular/angular/pull/36305
alxhubhttps://github.com/alxhub
Apr 1, 2020 https://github.com/angular/angular/pull/36305#ref-commit-38ad1d9
https://github.com/petebacondarwin
https://github.com/alxhub
fix(ngcc): handle entry-points within container folders (https://github.com/angular/angular/commit/38ad1d97abef2db0a99079cdd4d2391d96009597
#36305https://github.com/angular/angular/pull/36305
)https://github.com/angular/angular/commit/38ad1d97abef2db0a99079cdd4d2391d96009597
38ad1d9https://github.com/angular/angular/commit/38ad1d97abef2db0a99079cdd4d2391d96009597
#35756https://github.com/angular/angular/pull/35756
#36216https://github.com/angular/angular/issues/36216
#36305https://github.com/angular/angular/pull/36305
https://github.com/boskiv
boskivhttps://github.com/boskiv
Apr 3, 2020https://github.com/angular/angular/pull/36305#issuecomment-608204897
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Apr 3, 2020https://github.com/angular/angular/pull/36305#issuecomment-608267623
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Apr 3, 2020 https://github.com/angular/angular/pull/36305#ref-issue-593639832
IVY Error NG6002: Appears in the NgModule.imports of AppModule #36424 https://github.com/angular/angular/issues/36424
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
April 6, 2020 07:45https://github.com/angular/angular/pull/36305#event-3204051003
https://github.com/LexDX
LexDXhttps://github.com/LexDX
Apr 10, 2020 https://github.com/angular/angular/pull/36305#ref-issue-579097958
ngcc unable to process DevExtreme modules since Angular 9.0.6 DevExpress/devextreme-angular#1047 https://github.com/DevExpress/devextreme-angular/issues/1047
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
May 7, 2020https://github.com/angular/angular/pull/36305#issuecomment-625347085
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
May 7, 2020https://github.com/angular/angular/pull/36305#event-3313599202
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36305
https://github.com/alan-agius4
alan-agius4 https://github.com/alan-agius4
https://github.com/angular/angular/pull/36305/files/eb736aea107b241d4e49500e100bc376204e5ed0
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/36305/files/7f2122de3fe9f54b8a41221a8692a77718ec4383
Please reload this pagehttps://github.com/angular/angular/pull/36305
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Error NG6003 after upgrade from 9.0.5 to 9.0.6 https://github.com/angular/angular/issues/36216
Please reload this pagehttps://github.com/angular/angular/pull/36305
https://github.com/petebacondarwin
https://github.com/alan-agius4
https://github.com/boskiv
https://github.com/gkalpak
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.