René's URL Explorer Experiment


Title: fix(router): Pass correct component to canDeactivate checks when using two sibling router-outlets by martinsik · Pull Request #36302 · angular/angular · GitHub

Open Graph Title: fix(router): Pass correct component to canDeactivate checks when using two sibling router-outlets by martinsik · Pull Request #36302 · angular/angular

X Title: fix(router): Pass correct component to canDeactivate checks when using two sibling router-outlets by martinsik · Pull Request #36302 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: #34614 There's an edge case where if I use two (or more) sibling s in two (or more) child routes where their parent route doesn't have a component then preactivation will trigger all canDeactivate checks with the same component because it will use wrong OutletContext. { path: 'a', children: [ { path: 'b1', component: BlankCmp, canDeactivate: ['RecordingDeactivate'], }, { path: 'b2', canDeactivate: ['RecordingDeactivate'], component: SimpleCmp, outlet: 'aux', }, ], }, { path: 'c', component: BlankCmp, }, Navigating from '/a/(b1//aux:b2)' to '/c' will call both canDeactivate guards with BlankCmp. Replication steps are described in #34614. Updated demo for Angular 9: https://stackblitz.com/edit/angular-named-outlet-enygni?file=app/app.component.html What is the new behavior? canDeactivate check is called with correct component. Does this PR introduce a breaking change? Yes No Other information This fix will pass extra parameter to deactivateRouteAndItsChildren that is used in case a route is without a component because there's probably no other way to determine the correct OutletContext beforehand. The child routers are iterated inside deactivateRouteAndItsChildren where it can access only child OutletContexts. However, in this case the router-outlets are siblings.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/36302

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:d6651b56-73df-596b-e8ff-612e28388dd7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE89E:2679E9:1BB43DB:24E9CBE:6B0163C5
html-safe-nonce6e0b6efed14f54fc265aa53c98039471c2c2ab5d3b80e92458cb5d8fa737cc29
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFODlFOjI2NzlFOToxQkI0M0RCOjI0RTlDQkU6NkIwMTYzQzUiLCJ2aXNpdG9yX2lkIjoiNTY0MzI3NDYwNDIyODIwNzU1NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacde4ed91656afbba45e13a284c8c4566974ed76f44d3a3ddc4bf4bbec68f83a4e
hovercard-subject-tagpull_request:395228856
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/36302/files
twitter:imagehttps://avatars.githubusercontent.com/u/238765?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/238765?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/36302/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36302%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36302%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36302/files
Reloadhttps://github.com/angular/angular/pull/36302/files
Reloadhttps://github.com/angular/angular/pull/36302/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
martinsikhttps://github.com/martinsik
angular:masterhttps://github.com/angular/angular/tree/master
martinsik:issue-34614https://github.com/martinsik/angular/tree/issue-34614
Conversation 25 https://github.com/angular/angular/pull/36302
Commits 1 https://github.com/angular/angular/pull/36302/commits
Checks 0 https://github.com/angular/angular/pull/36302/checks
Files changed https://github.com/angular/angular/pull/36302/files
Please reload this pagehttps://github.com/angular/angular/pull/36302/files
fix(router): Pass correct component to canDeactivate checks when using two sibling router-outlets https://github.com/angular/angular/pull/36302/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/36302/files
65775d1 fix(router): pass correct component to canDeactivate checks when usin… martinsik Mar 29, 2020 https://github.com/angular/angular/pull/36302/commits/65775d1f1b702a8f2c81df4217476871117a413f
Clear filters https://github.com/angular/angular/pull/36302/files
Please reload this pagehttps://github.com/angular/angular/pull/36302/files
Please reload this pagehttps://github.com/angular/angular/pull/36302/files
preactivation.ts https://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
integration.spec.ts https://github.com/angular/angular/pull/36302/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
packages/router/src/utils/preactivation.tshttps://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
View file https://github.com/martinsik/angular/blob/65775d1f1b702a8f2c81df4217476871117a413f/packages/router/src/utils/preactivation.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36302/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
https://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
https://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
https://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
https://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
https://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
https://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
https://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
Please reload this pagehttps://github.com/angular/angular/pull/36302/files
https://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
packages/router/test/integration.spec.tshttps://github.com/angular/angular/pull/36302/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
View file https://github.com/martinsik/angular/blob/65775d1f1b702a8f2c81df4217476871117a413f/packages/router/test/integration.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36302/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36302/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com/angular/angular/pull/36302/files#diff-c89e4eb845a28c0d2385a4460f9d27259558686f192bdb0fe61953e057be803e
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.