René's URL Explorer Experiment


Title: fix(router): Pass correct component to canDeactivate checks when using two sibling router-outlets by martinsik · Pull Request #36302 · angular/angular · GitHub

Open Graph Title: fix(router): Pass correct component to canDeactivate checks when using two sibling router-outlets by martinsik · Pull Request #36302 · angular/angular

X Title: fix(router): Pass correct component to canDeactivate checks when using two sibling router-outlets by martinsik · Pull Request #36302 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/36302

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:2b017530-1331-3939-40be-811a8e670ba6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEC62:95C88:1209D45:17E7596:6B011601
html-safe-nonce100e2ea44860a0f3c84ddd6f39b76b47161cd9b40ba5be0e828dd8ff4c5672bc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQzYyOjk1Qzg4OjEyMDlENDU6MTdFNzU5Njo2QjAxMTYwMSIsInZpc2l0b3JfaWQiOiIxNDkxMzQ2MDcwMTI1NDgzNTIxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca1336af246e2ee94932ba1c7a2f4625f4eb4c39eaa2b3ddd7fe5af631008eb67
hovercard-subject-tagpull_request:395228856
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/36302/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6273a6ad0be3ca3d5176c12306c9640e29bc2a0ea8e44232672e39b9e65cb2df/angular/angular/pull/36302
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6273a6ad0be3ca3d5176c12306c9640e29bc2a0ea8e44232672e39b9e65cb2df/angular/angular/pull/36302
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemartinsik
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/36302#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36302
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36302
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36302
Reloadhttps://github.com/angular/angular/pull/36302
Reloadhttps://github.com/angular/angular/pull/36302
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
martinsikhttps://github.com/martinsik
angular:masterhttps://github.com/angular/angular/tree/master
martinsik:issue-34614https://github.com/martinsik/angular/tree/issue-34614
Conversationhttps://github.com/angular/angular/pull/36302
Commits1 (1)https://github.com/angular/angular/pull/36302/commits
Checkshttps://github.com/angular/angular/pull/36302/checks
Files changedhttps://github.com/angular/angular/pull/36302/files
fix(router): Pass correct component to canDeactivate checks when using two sibling router-outletshttps://github.com/angular/angular/pull/36302#top
martinsikhttps://github.com/martinsik
angular:masterhttps://github.com/angular/angular/tree/master
martinsik:issue-34614https://github.com/martinsik/angular/tree/issue-34614
https://github.com/martinsik
martinsikhttps://github.com/martinsik
Mar 29, 2020https://github.com/angular/angular/pull/36302#issue-589761034
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
#34614https://github.com/angular/angular/issues/34614
#34614https://github.com/angular/angular/issues/34614
https://stackblitz.com/edit/angular-named-outlet-enygni?file=app%2Fapp.component.htmlhttps://stackblitz.com/edit/angular-named-outlet-enygni?file=app%2Fapp.component.html
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Mar 29, 2020https://github.com/angular/angular/pull/36302#event-3175765518
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
atscotthttps://github.com/atscott
March 29, 2020 10:23https://github.com/angular/angular/pull/36302#event-3175765565
https://github.com/martinsik
martinsikhttps://github.com/martinsik
force-pushedhttps://github.com/angular/angular/compare/692292c779e432f224f98743d618bf09eba8943f..37ea3972ee76bd9d7e0a3f633978419c36793c1d
692292chttps://github.com/angular/angular/commit/692292c779e432f224f98743d618bf09eba8943f
37ea397https://github.com/angular/angular/commit/37ea3972ee76bd9d7e0a3f633978419c36793c1d
Compare https://github.com/angular/angular/compare/692292c779e432f224f98743d618bf09eba8943f..37ea3972ee76bd9d7e0a3f633978419c36793c1d
March 29, 2020 10:49https://github.com/angular/angular/pull/36302#event-3175784000
https://github.com/martinsik
martinsikhttps://github.com/martinsik
Mar 30, 2020https://github.com/angular/angular/pull/36302#issuecomment-605854801
It expects 226144 byteshttps://github.com/angular/angular/blob/master/integration/_payload-limits.json#L52
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/atscott
atscotthttps://github.com/atscott
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
Mar 30, 2020https://github.com/angular/angular/pull/36302#event-3179745175
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Mar 30, 2020https://github.com/angular/angular/pull/36302#event-3179745358
https://github.com/atscott
atscotthttps://github.com/atscott
Mar 30, 2020 https://github.com/angular/angular/pull/36302#pullrequestreview-384201147
View reviewed changes https://github.com/angular/angular/pull/36302/files
packages/router/src/utils/preactivation.tshttps://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/atscott
atscotthttps://github.com/atscott
Mar 30, 2020https://github.com/angular/angular/pull/36302#issuecomment-606229783
presubmithttps://test.corp.google.com/ui#id=OCL:303769901:BASE:303769920:1585589261595:7ff7eed0
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/atscott
atscotthttps://github.com/atscott
Mar 30, 2020https://github.com/angular/angular/pull/36302#issuecomment-606282574
global presubmithttps://test.corp.google.com/ui#id=OCL:303769901:BASE:303737378:1585602789022:d3bbf01d
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/atscott
atscotthttps://github.com/atscott
Mar 30, 2020https://github.com/angular/angular/pull/36302#issuecomment-606289523
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/atscott
atscotthttps://github.com/atscott
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Mar 31, 2020https://github.com/angular/angular/pull/36302#event-3185358091
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
karahttps://github.com/kara
April 2, 2020 08:53https://github.com/angular/angular/pull/36302#event-3191207659
https://github.com/martinsik
martinsikhttps://github.com/martinsik
force-pushedhttps://github.com/angular/angular/compare/225d5bffef801923055f5a4593e9f9ed3b6413fe..f505eaa3f2703feb8987a766a25ef1b61a5cbd6e
225d5bfhttps://github.com/angular/angular/commit/225d5bffef801923055f5a4593e9f9ed3b6413fe
f505eaahttps://github.com/angular/angular/commit/f505eaa3f2703feb8987a766a25ef1b61a5cbd6e
Compare https://github.com/angular/angular/compare/225d5bffef801923055f5a4593e9f9ed3b6413fe..f505eaa3f2703feb8987a766a25ef1b61a5cbd6e
April 2, 2020 10:14https://github.com/angular/angular/pull/36302#event-3191505394
https://github.com/martinsik
martinsikhttps://github.com/martinsik
Apr 2, 2020https://github.com/angular/angular/pull/36302#issuecomment-607801059
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 2, 2020https://github.com/angular/angular/pull/36302#issuecomment-607939996
Please reload this pagehttps://github.com/angular/angular/pull/36302
@martinsikhttps://github.com/martinsik
c5c57f6https://github.com/angular/angular/commit/c5c57f673745e9b66a771c49e778a7d2e8d8c56a
presubmitshttps://test.corp.google.com/ui#id=OCL:303769901:BASE:304413808:1585844134741:a8d25d5c
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/atscott
atscotthttps://github.com/atscott
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Apr 2, 2020https://github.com/angular/angular/pull/36302#event-3192927872
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 2, 2020 https://github.com/angular/angular/pull/36302#pullrequestreview-386596832
View reviewed changes https://github.com/angular/angular/pull/36302/files
atscotthttps://github.com/atscott
https://github.com/angular/angular/pull/36302#pullrequestreview-386596832
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36302
packages/router/src/utils/preactivation.tshttps://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
Please reload this pagehttps://github.com/angular/angular/pull/36302
packages/router/src/utils/preactivation.tshttps://github.com/angular/angular/pull/36302/files#diff-31e1de19f2a52e002a10281344216addd2810114083bb01f3c8497bed828b723
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/martinsik
martinsikhttps://github.com/martinsik
force-pushedhttps://github.com/angular/angular/compare/f505eaa3f2703feb8987a766a25ef1b61a5cbd6e..04f43ce35f1b482e150a87b8e94f2e09e8090ce3
f505eaahttps://github.com/angular/angular/commit/f505eaa3f2703feb8987a766a25ef1b61a5cbd6e
04f43cehttps://github.com/angular/angular/commit/04f43ce35f1b482e150a87b8e94f2e09e8090ce3
Compare https://github.com/angular/angular/compare/f505eaa3f2703feb8987a766a25ef1b61a5cbd6e..04f43ce35f1b482e150a87b8e94f2e09e8090ce3
April 3, 2020 08:45https://github.com/angular/angular/pull/36302#event-3195441120
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 3, 2020 https://github.com/angular/angular/pull/36302#pullrequestreview-387350488
View reviewed changes https://github.com/angular/angular/pull/36302/files
https://github.com/atscott
atscotthttps://github.com/atscott
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Apr 3, 2020https://github.com/angular/angular/pull/36302#event-3196964436
https://github.com/kara
karahttps://github.com/kara
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Apr 3, 2020https://github.com/angular/angular/pull/36302#event-3197422641
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 3, 2020https://github.com/angular/angular/pull/36302#issuecomment-608578098
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/kara
karahttps://github.com/kara
Apr 3, 2020 https://github.com/angular/angular/pull/36302#pullrequestreview-387466599
View reviewed changes https://github.com/angular/angular/pull/36302/files
karahttps://github.com/kara
https://github.com/angular/angular/pull/36302#pullrequestreview-387466599
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/atscott
atscotthttps://github.com/atscott
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Apr 3, 2020https://github.com/angular/angular/pull/36302#event-3197467267
https://github.com/atscott
atscotthttps://github.com/atscott
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
target: major https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22
Apr 9, 2020https://github.com/angular/angular/pull/36302#event-3219043164
atscotthttps://github.com/atscott
Apr 9, 2020 https://github.com/angular/angular/pull/36302#ref-commit-8e7f903
https://github.com/martinsik
https://github.com/atscott
fix(router): pass correct component to canDeactivate checks when usin…https://github.com/angular/angular/commit/8e7f9033a36a105026f8599da2dc9fd6f0d06b0f
8e7f903https://github.com/angular/angular/commit/8e7f9033a36a105026f8599da2dc9fd6f0d06b0f
#36302https://github.com/angular/angular/pull/36302
#34614https://github.com/angular/angular/issues/34614
#36302https://github.com/angular/angular/pull/36302
https://github.com/atscott
atscotthttps://github.com/atscott
80e6c07https://github.com/angular/angular/commit/80e6c07d89d74d71956fb1299c54f5353e255370
Apr 9, 2020https://github.com/angular/angular/pull/36302#event-3219207411
matskohttps://github.com/matsko
Apr 17, 2020 https://github.com/angular/angular/pull/36302#ref-commit-78560a3
https://github.com/matsko
Revert "fix(router): pass correct component to canDeactivate checks w…https://github.com/matsko/angular/commit/78560a3ff1ebb43e8dd48298665ffde86279ac24
78560a3https://github.com/matsko/angular/commit/78560a3ff1ebb43e8dd48298665ffde86279ac24
angular#36302https://github.com/angular/angular/pull/36302
80e6c07https://github.com/matsko/angular/commit/80e6c07d89d74d71956fb1299c54f5353e255370
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 17, 2020 https://github.com/angular/angular/pull/36302#ref-pullrequest-602281447
test(router): add canDeactivate test for forChild route #36699 https://github.com/angular/angular/pull/36699
https://github.com/atscott
atscotthttps://github.com/atscott
Apr 17, 2020https://github.com/angular/angular/pull/36302#issuecomment-615504847
@martinsikhttps://github.com/martinsik
#36697https://github.com/angular/angular/pull/36697
#36699https://github.com/angular/angular/pull/36699
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/martinsik
martinsikhttps://github.com/martinsik
Apr 18, 2020https://github.com/angular/angular/pull/36302#issuecomment-615840410
@atscotthttps://github.com/atscott
Please reload this pagehttps://github.com/angular/angular/pull/36302
matskohttps://github.com/matsko
Apr 20, 2020 https://github.com/angular/angular/pull/36302#ref-commit-b5e92b9
https://github.com/matsko
Revert "fix(router): pass correct component to canDeactivate checks w…https://github.com/angular/angular/commit/b5e92b9a5d815139e0f2277fc637f5e982076fe9
https://github.com/angular/angular/commit/b5e92b9a5d815139e0f2277fc637f5e982076fe9#comments
b5e92b9https://github.com/angular/angular/commit/b5e92b9a5d815139e0f2277fc637f5e982076fe9
#36302https://github.com/angular/angular/pull/36302
#36697https://github.com/angular/angular/pull/36697
80e6c07https://github.com/angular/angular/commit/80e6c07d89d74d71956fb1299c54f5353e255370
#36697https://github.com/angular/angular/pull/36697
matskohttps://github.com/matsko
Apr 20, 2020 https://github.com/angular/angular/pull/36302#ref-commit-722d939
https://github.com/matsko
Revert "fix(router): pass correct component to canDeactivate checks w…https://github.com/angular/angular/commit/722d9397b0fc992e4f937e7fd0c2544f582043da
722d939https://github.com/angular/angular/commit/722d9397b0fc992e4f937e7fd0c2544f582043da
#36302https://github.com/angular/angular/pull/36302
#36697https://github.com/angular/angular/pull/36697
80e6c07https://github.com/angular/angular/commit/80e6c07d89d74d71956fb1299c54f5353e255370
#36697https://github.com/angular/angular/pull/36697
https://github.com/matsko
matskohttps://github.com/matsko
Apr 20, 2020https://github.com/angular/angular/pull/36302#event-3252915048
https://github.com/matsko
matskohttps://github.com/matsko
Apr 20, 2020https://github.com/angular/angular/pull/36302#issuecomment-616717053
@martinsikhttps://github.com/martinsik
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/matsko
matskohttps://github.com/matsko
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Apr 20, 2020https://github.com/angular/angular/pull/36302#event-3253459933
https://github.com/mike-co
mike-cohttps://github.com/mike-co
Apr 21, 2020 https://github.com/angular/angular/pull/36302#ref-issue-603937432
canDeactivate passes wrong component as first argument angular/router#447 https://github.com/angular/router/issues/447
https://github.com/martinsik
martinsikhttps://github.com/martinsik
Apr 22, 2020https://github.com/angular/angular/pull/36302#issuecomment-617970052
#36699https://github.com/angular/angular/pull/36699
Please reload this pagehttps://github.com/angular/angular/pull/36302
atscotthttps://github.com/atscott
Apr 22, 2020 https://github.com/angular/angular/pull/36302#ref-commit-d583a05
https://github.com/atscott
test(router): add canDeactivate test for forChild routehttps://github.com/atscott/angular/commit/d583a05a68efcaa2bc2f2588651d69eace370c82
d583a05https://github.com/atscott/angular/commit/d583a05a68efcaa2bc2f2588651d69eace370c82
angular#36302https://github.com/angular/angular/pull/36302
matskohttps://github.com/matsko
Apr 23, 2020 https://github.com/angular/angular/pull/36302#ref-commit-ceb61d1
https://github.com/atscott
https://github.com/matsko
test(router): add canDeactivate test for forChild route (https://github.com/angular/angular/commit/ceb61d10c186b941c6a2b0fb1ad11ff4c49d2161
#36699https://github.com/angular/angular/pull/36699
)https://github.com/angular/angular/commit/ceb61d10c186b941c6a2b0fb1ad11ff4c49d2161
ceb61d1https://github.com/angular/angular/commit/ceb61d10c186b941c6a2b0fb1ad11ff4c49d2161
#36302https://github.com/angular/angular/pull/36302
#36699https://github.com/angular/angular/pull/36699
matskohttps://github.com/matsko
Apr 23, 2020 https://github.com/angular/angular/pull/36302#ref-commit-54883cb
https://github.com/atscott
https://github.com/matsko
test(router): add canDeactivate test for forChild route (https://github.com/angular/angular/commit/54883cb4771a88ccc8c92e9e84c17ab8a267f9f2
#36699https://github.com/angular/angular/pull/36699
)https://github.com/angular/angular/commit/54883cb4771a88ccc8c92e9e84c17ab8a267f9f2
54883cbhttps://github.com/angular/angular/commit/54883cb4771a88ccc8c92e9e84c17ab8a267f9f2
#36302https://github.com/angular/angular/pull/36302
#36699https://github.com/angular/angular/pull/36699
https://github.com/atscott
atscotthttps://github.com/atscott
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Jun 15, 2020https://github.com/angular/angular/pull/36302#event-3446614602
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Apr 17, 2021https://github.com/angular/angular/pull/36302#issuecomment-821816571
@martinsikhttps://github.com/martinsik
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
May 7, 2021https://github.com/angular/angular/pull/36302#issuecomment-834511508
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
May 7, 2021https://github.com/angular/angular/pull/36302#event-4702730520
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jun 7, 2021https://github.com/angular/angular/pull/36302#issuecomment-856083477
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Jun 7, 2021https://github.com/angular/angular/pull/36302#event-4853149691
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36302
https://github.com/atscott
atscott https://github.com/atscott
https://github.com/angular/angular/pull/36302/files/04f43ce35f1b482e150a87b8e94f2e09e8090ce3
https://github.com/kara
kara https://github.com/kara
https://github.com/angular/angular/pull/36302/files/04f43ce35f1b482e150a87b8e94f2e09e8090ce3
Please reload this pagehttps://github.com/angular/angular/pull/36302
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
area: router https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Please reload this pagehttps://github.com/angular/angular/pull/36302
https://github.com/martinsik
https://github.com/atscott
https://github.com/matsko
https://github.com/petebacondarwin
https://github.com/kara
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.