René's URL Explorer Experiment


Title: fix(ngcc): do not spawn more processes than intended in parallel mode by gkalpak · Pull Request #36280 · angular/angular · GitHub

Open Graph Title: fix(ngcc): do not spawn more processes than intended in parallel mode by gkalpak · Pull Request #36280 · angular/angular

X Title: fix(ngcc): do not spawn more processes than intended in parallel mode by gkalpak · Pull Request #36280 · angular/angular

Description: When running in parallel mode, ngcc spawns multiple worker processed to process the various entry-points. The number of max allowed processes is determined by the number of CPU cores available to the OS. There is also currently an upper limit of 8. The number of active workers is in turn inferred by the number of task assignments. In the past, counting the entries of ClusterMaster#taskAssignments was enough, because worker processes were spawned eagerly at the beginning and corresponding entries were created in taskAssignments. Since #35719 however, worker processes are spawned lazily on an as needed basis. Because there is some delay between spawning a process and inserting it into taskAssignments, there is a short period of time when taskAssignment.size does not actually represent the number of spawned processes. This can result in spawning more than ClusterMaster#workerCount processes. An example of this can be seen in #36278, where the debug logs indicate 9 worker processes had been spawned (All 9 workers are currently busy) despite the hard limit of 8. This commit fixes this by using cluster.workers to compute the number of spawned worker processes. cluster.workers is updated synchronously with cluster.fork() and thus reflects the number of spawned workers accurately at all times.

Open Graph Description: When running in parallel mode, ngcc spawns multiple worker processed to process the various entry-points. The number of max allowed processes is determined by the number of CPU cores available to t...

X Description: When running in parallel mode, ngcc spawns multiple worker processed to process the various entry-points. The number of max allowed processes is determined by the number of CPU cores available to t...

Opengraph URL: https://github.com/angular/angular/pull/36280

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6f46ca17-dc18-468a-ed3c-7706a36424fe
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE654:3D97C8:150AF36:1C011D3:6B01326E
html-safe-nonce9b3753b740256de0c0bbb8941f4ef0881a7ff10f12f8fa76856e5a1e23f63481
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjU0OjNEOTdDODoxNTBBRjM2OjFDMDExRDM6NkIwMTMyNkUiLCJ2aXNpdG9yX2lkIjoiMTE3NTE3MzkzMzgyNjEyNjQ0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmace57f2380494b7e42985b88c28f9f9a8ed08edaa1db31d46cd847a1ad26b0c12e
hovercard-subject-tagpull_request:394892645
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/36280/files
twitter:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/8604205?s=400&v=4
og:image:altWhen running in parallel mode, ngcc spawns multiple worker processed to process the various entry-points. The number of max allowed processes is determined by the number of CPU cores available to t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetcanary-1
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/36280/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36280%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36280%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36280/files
Reloadhttps://github.com/angular/angular/pull/36280/files
Reloadhttps://github.com/angular/angular/pull/36280/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-ngcc-max-worker-counthttps://github.com/gkalpak/angular/tree/fix-ngcc-max-worker-count
Conversation 4 https://github.com/angular/angular/pull/36280
Commits 1 https://github.com/angular/angular/pull/36280/commits
Checks 0 https://github.com/angular/angular/pull/36280/checks
Files changed https://github.com/angular/angular/pull/36280/files
Please reload this pagehttps://github.com/angular/angular/pull/36280/files
fix(ngcc): do not spawn more processes than intended in parallel mode https://github.com/angular/angular/pull/36280/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/36280/files
e99c9b8 fix(ngcc): do not spawn more processes than intended in parallel mode gkalpak Mar 27, 2020 https://github.com/angular/angular/pull/36280/commits/e99c9b83580316c772e3f06ba1abfd544b511185
Clear filters https://github.com/angular/angular/pull/36280/files
Please reload this pagehttps://github.com/angular/angular/pull/36280/files
Please reload this pagehttps://github.com/angular/angular/pull/36280/files
packages/compiler-cli/ngcc/src/execution/cluster/master.tshttps://github.com/angular/angular/pull/36280/files#diff-73c3dc49cd84b817689ff35582539304e7402dce1c32837cfecde3df83417de0
View file https://github.com/gkalpak/angular/blob/e99c9b83580316c772e3f06ba1abfd544b511185/packages/compiler-cli/ngcc/src/execution/cluster/master.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36280/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36280/files#diff-73c3dc49cd84b817689ff35582539304e7402dce1c32837cfecde3df83417de0
https://github.com/angular/angular/pull/36280/files#diff-73c3dc49cd84b817689ff35582539304e7402dce1c32837cfecde3df83417de0
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.