Title: fix(ngcc): do not spawn more processes than intended in parallel mode by gkalpak · Pull Request #36280 · angular/angular · GitHub
Open Graph Title: fix(ngcc): do not spawn more processes than intended in parallel mode by gkalpak · Pull Request #36280 · angular/angular
X Title: fix(ngcc): do not spawn more processes than intended in parallel mode by gkalpak · Pull Request #36280 · angular/angular
Description: When running in parallel mode, ngcc spawns multiple worker processed to process the various entry-points. The number of max allowed processes is determined by the number of CPU cores available to the OS. There is also currently an upper limit of 8. The number of active workers is in turn inferred by the number of task assignments. In the past, counting the entries of ClusterMaster#taskAssignments was enough, because worker processes were spawned eagerly at the beginning and corresponding entries were created in taskAssignments. Since #35719 however, worker processes are spawned lazily on an as needed basis. Because there is some delay between spawning a process and inserting it into taskAssignments, there is a short period of time when taskAssignment.size does not actually represent the number of spawned processes. This can result in spawning more than ClusterMaster#workerCount processes. An example of this can be seen in #36278, where the debug logs indicate 9 worker processes had been spawned (All 9 workers are currently busy) despite the hard limit of 8. This commit fixes this by using cluster.workers to compute the number of spawned worker processes. cluster.workers is updated synchronously with cluster.fork() and thus reflects the number of spawned workers accurately at all times.
Open Graph Description: When running in parallel mode, ngcc spawns multiple worker processed to process the various entry-points. The number of max allowed processes is determined by the number of CPU cores available to t...
X Description: When running in parallel mode, ngcc spawns multiple worker processed to process the various entry-points. The number of max allowed processes is determined by the number of CPU cores available to t...
Opengraph URL: https://github.com/angular/angular/pull/36280
X: @github
Domain: github.com
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:6f46ca17-dc18-468a-ed3c-7706a36424fe |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E654:3D97C8:150AF36:1C011D3:6B01326E |
| html-safe-nonce | 9b3753b740256de0c0bbb8941f4ef0881a7ff10f12f8fa76856e5a1e23f63481 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNjU0OjNEOTdDODoxNTBBRjM2OjFDMDExRDM6NkIwMTMyNkUiLCJ2aXNpdG9yX2lkIjoiMTE3NTE3MzkzMzgyNjEyNjQ0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e57f2380494b7e42985b88c28f9f9a8ed08edaa1db31d46cd847a1ad26b0c12e |
| hovercard-subject-tag | pull_request:394892645 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/36280/files |
| twitter:image | https://avatars.githubusercontent.com/u/8604205?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8604205?s=400&v=4 |
| og:image:alt | When running in parallel mode, ngcc spawns multiple worker processed to process the various entry-points. The number of max allowed processes is determined by the number of CPU cores available to t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width