René's URL Explorer Experiment


Title: fix(core): run `APP_INITIALIZER`s before accessing `LOCALE_ID` token in Ivy TestBed by AndrewKushnir · Pull Request #36237 · angular/angular · GitHub

Open Graph Title: fix(core): run `APP_INITIALIZER`s before accessing `LOCALE_ID` token in Ivy TestBed by AndrewKushnir · Pull Request #36237 · angular/angular

X Title: fix(core): run `APP_INITIALIZER`s before accessing `LOCALE_ID` token in Ivy TestBed by AndrewKushnir · Pull Request #36237 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Prior to this commit, Ivy TestBed was accessing locale ID before APP_INITIALIZER functions were called. This execution order is not consistent with the app bootstrap logic in the application_ref.ts...

X Description: Prior to this commit, Ivy TestBed was accessing locale ID before APP_INITIALIZER functions were called. This execution order is not consistent with the app bootstrap logic in the application_ref.ts...

Opengraph URL: https://github.com/angular/angular/pull/36237

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:534302ee-2879-b212-40f9-7952aaa994ad
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBD52:FC5BE:12BE9B4:18EAD4A:6B012376
html-safe-noncee1606d8627341460e589127344cf549875b76539d4b689d20df104807338d2e6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDUyOkZDNUJFOjEyQkU5QjQ6MThFQUQ0QTo2QjAxMjM3NiIsInZpc2l0b3JfaWQiOiIyMTIxNTc2MzA4MjgxNTE2OTE5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac35e4f83b3d8f2dee84671bfbfa36f2b0590cdc66ab298d17d145a30972a72c4d
hovercard-subject-tagpull_request:393321576
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/36237/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/020c860d97fedc1e17ec594dc84d3b92049a9854facecfe4713bf624f879f519/angular/angular/pull/36237
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/020c860d97fedc1e17ec594dc84d3b92049a9854facecfe4713bf624f879f519/angular/angular/pull/36237
og:image:altPrior to this commit, Ivy TestBed was accessing locale ID before APP_INITIALIZER functions were called. This execution order is not consistent with the app bootstrap logic in the application_ref.ts...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameAndrewKushnir
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/36237#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36237
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36237
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36237
Reloadhttps://github.com/angular/angular/pull/36237
Reloadhttps://github.com/angular/angular/pull/36237
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:FW-2021_locale_id_in_test_bedhttps://github.com/AndrewKushnir/angular/tree/FW-2021_locale_id_in_test_bed
Conversationhttps://github.com/angular/angular/pull/36237
Commits1 (1)https://github.com/angular/angular/pull/36237/commits
Checkshttps://github.com/angular/angular/pull/36237/checks
Files changedhttps://github.com/angular/angular/pull/36237/files
fix(core): run APP_INITIALIZERs before accessing LOCALE_ID token in Ivy TestBedhttps://github.com/angular/angular/pull/36237#top
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:FW-2021_locale_id_in_test_bedhttps://github.com/AndrewKushnir/angular/tree/FW-2021_locale_id_in_test_bed
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Mar 25, 2020https://github.com/angular/angular/pull/36237#issue-587360990
#34830https://github.com/angular/angular/pull/34830
#36230https://github.com/angular/angular/issues/36230
Please reload this pagehttps://github.com/angular/angular/pull/36237
https://github.com/AndrewKushnir
fix(core): run APP_INITIALIZERs before accessing LOCALE_ID token …https://github.com/angular/angular/pull/36237/commits/359c56bc332a0849b5f7a7c0e6c03ba6977469ca
359c56bhttps://github.com/angular/angular/pull/36237/commits/359c56bc332a0849b5f7a7c0e6c03ba6977469ca
angular#36230https://github.com/angular/angular/issues/36230
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
area: testing https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
comp: ivy https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
Mar 25, 2020https://github.com/angular/angular/pull/36237#event-3162033090
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
petebacondarwinhttps://github.com/petebacondarwin
March 25, 2020 00:28https://github.com/angular/angular/pull/36237#event-3162033103
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Mar 25, 2020https://github.com/angular/angular/pull/36237#event-3162033157
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Mar 25, 2020https://github.com/angular/angular/pull/36237#event-3162033218
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Mar 25, 2020https://github.com/angular/angular/pull/36237#issuecomment-603580429
Please reload this pagehttps://github.com/angular/angular/pull/36237
Blueprint Presubmithttp://test/OCL:302785529:BASE:302785561:1585097583202:ffcdc0b8
Global Presubmithttps://test.corp.google.com/OCL:302785529:BASE:302797345:1585102671184:5a375ae
Please reload this pagehttps://github.com/angular/angular/pull/36237
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
March 25, 2020 00:53https://github.com/angular/angular/pull/36237#event-3162075423
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Mar 25, 2020 https://github.com/angular/angular/pull/36237#pullrequestreview-381047627
View reviewed changes https://github.com/angular/angular/pull/36237/files/359c56bc332a0849b5f7a7c0e6c03ba6977469ca
petebacondarwinhttps://github.com/petebacondarwin
https://github.com/angular/angular/pull/36237#pullrequestreview-381047627
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
angular/packages/core/src/application_ref.tshttps://github.com/angular/angular/blob/e342ffd855ffeb8af7067b42307ffa320d82177e/packages/core/src/application_ref.ts#L327-L337
e342ffdhttps://github.com/angular/angular/commit/e342ffd855ffeb8af7067b42307ffa320d82177e
Please reload this pagehttps://github.com/angular/angular/pull/36237
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Mar 26, 2020https://github.com/angular/angular/pull/36237#issuecomment-604183182
@petebacondarwinhttps://github.com/petebacondarwin
angular/packages/core/testing/src/test_bed.tshttps://github.com/angular/angular/blob/fc3e5cb6d3ef61aaa13bd9788b9b1c7b97af94fe/packages/core/testing/src/test_bed.ts#L413
fc3e5cbhttps://github.com/angular/angular/commit/fc3e5cb6d3ef61aaa13bd9788b9b1c7b97af94fe
Please reload this pagehttps://github.com/angular/angular/pull/36237
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Mar 26, 2020https://github.com/angular/angular/pull/36237#issuecomment-604183287
Please reload this pagehttps://github.com/angular/angular/pull/36237
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Mar 26, 2020https://github.com/angular/angular/pull/36237#event-3166389949
alxhubhttps://github.com/alxhub
Mar 27, 2020 https://github.com/angular/angular/pull/36237#ref-commit-5c28af0
https://github.com/AndrewKushnir
https://github.com/alxhub
fix(core): run APP_INITIALIZERs before accessing LOCALE_ID token …https://github.com/angular/angular/commit/5c28af0e74ba96800c5f151ae772b3b13f9fc228
5c28af0https://github.com/angular/angular/commit/5c28af0e74ba96800c5f151ae772b3b13f9fc228
#36237https://github.com/angular/angular/pull/36237
#36230https://github.com/angular/angular/issues/36230
#36237https://github.com/angular/angular/pull/36237
https://github.com/alxhub
alxhubhttps://github.com/alxhub
1649743https://github.com/angular/angular/commit/16497438d6656c044c4974cbbe4ed32a9127f392
Mar 27, 2020https://github.com/angular/angular/pull/36237#event-3173529191
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Apr 27, 2020https://github.com/angular/angular/pull/36237#issuecomment-620080873
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/36237
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Apr 27, 2020https://github.com/angular/angular/pull/36237#event-3276503829
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36237
https://github.com/petebacondarwin
petebacondarwin https://github.com/petebacondarwin
https://github.com/angular/angular/pull/36237/files/359c56bc332a0849b5f7a7c0e6c03ba6977469ca
Please reload this pagehttps://github.com/angular/angular/pull/36237
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: core https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
area: testing https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
LOCALE_ID accessed in tests before APP_INITIALIZER runs (with Ivy) https://github.com/angular/angular/issues/36230
Please reload this pagehttps://github.com/angular/angular/pull/36237
https://github.com/AndrewKushnir
https://github.com/petebacondarwin
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.