| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:534302ee-2879-b212-40f9-7952aaa994ad |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BD52:FC5BE:12BE9B4:18EAD4A:6B012376 |
| html-safe-nonce | e1606d8627341460e589127344cf549875b76539d4b689d20df104807338d2e6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRDUyOkZDNUJFOjEyQkU5QjQ6MThFQUQ0QTo2QjAxMjM3NiIsInZpc2l0b3JfaWQiOiIyMTIxNTc2MzA4MjgxNTE2OTE5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 35e4f83b3d8f2dee84671bfbfa36f2b0590cdc66ab298d17d145a30972a72c4d |
| hovercard-subject-tag | pull_request:393321576 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/36237/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/020c860d97fedc1e17ec594dc84d3b92049a9854facecfe4713bf624f879f519/angular/angular/pull/36237 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/020c860d97fedc1e17ec594dc84d3b92049a9854facecfe4713bf624f879f519/angular/angular/pull/36237 |
| og:image:alt | Prior to this commit, Ivy TestBed was accessing locale ID before APP_INITIALIZER functions were called. This execution order is not consistent with the app bootstrap logic in the application_ref.ts... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | AndrewKushnir |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/36237#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36237 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36237 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/36237 |
| Reload | https://github.com/angular/angular/pull/36237 |
| Reload | https://github.com/angular/angular/pull/36237 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| AndrewKushnir | https://github.com/AndrewKushnir |
| angular:master | https://github.com/angular/angular/tree/master |
| AndrewKushnir:FW-2021_locale_id_in_test_bed | https://github.com/AndrewKushnir/angular/tree/FW-2021_locale_id_in_test_bed |
| Conversation | https://github.com/angular/angular/pull/36237 |
| Commits1 (1) | https://github.com/angular/angular/pull/36237/commits |
| Checks | https://github.com/angular/angular/pull/36237/checks |
| Files changed | https://github.com/angular/angular/pull/36237/files |
| fix(core): run APP_INITIALIZERs before accessing LOCALE_ID token in Ivy TestBed | https://github.com/angular/angular/pull/36237#top |
| AndrewKushnir | https://github.com/AndrewKushnir |
| angular:master | https://github.com/angular/angular/tree/master |
| AndrewKushnir:FW-2021_locale_id_in_test_bed | https://github.com/AndrewKushnir/angular/tree/FW-2021_locale_id_in_test_bed |
|
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Mar 25, 2020 | https://github.com/angular/angular/pull/36237#issue-587360990 |
| #34830 | https://github.com/angular/angular/pull/34830 |
| #36230 | https://github.com/angular/angular/issues/36230 |
| Please reload this page | https://github.com/angular/angular/pull/36237 |
|
| https://github.com/AndrewKushnir |
| fix(core): run APP_INITIALIZERs before accessing LOCALE_ID token … | https://github.com/angular/angular/pull/36237/commits/359c56bc332a0849b5f7a7c0e6c03ba6977469ca |
| 359c56b | https://github.com/angular/angular/pull/36237/commits/359c56bc332a0849b5f7a7c0e6c03ba6977469ca |
| angular#36230 | https://github.com/angular/angular/issues/36230 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
area: testing
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
comp: ivy
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22 |
| Mar 25, 2020 | https://github.com/angular/angular/pull/36237#event-3162033090 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| petebacondarwin | https://github.com/petebacondarwin |
| March 25, 2020 00:28 | https://github.com/angular/angular/pull/36237#event-3162033103 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Mar 25, 2020 | https://github.com/angular/angular/pull/36237#event-3162033157 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 25, 2020 | https://github.com/angular/angular/pull/36237#event-3162033218 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Mar 25, 2020 | https://github.com/angular/angular/pull/36237#issuecomment-603580429 |
| Please reload this page | https://github.com/angular/angular/pull/36237 |
| Blueprint Presubmit | http://test/OCL:302785529:BASE:302785561:1585097583202:ffcdc0b8 |
| Global Presubmit | https://test.corp.google.com/OCL:302785529:BASE:302797345:1585102671184:5a375ae |
| Please reload this page | https://github.com/angular/angular/pull/36237 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| March 25, 2020 00:53 | https://github.com/angular/angular/pull/36237#event-3162075423 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
Mar 25, 2020
| https://github.com/angular/angular/pull/36237#pullrequestreview-381047627 |
|
View reviewed changes
| https://github.com/angular/angular/pull/36237/files/359c56bc332a0849b5f7a7c0e6c03ba6977469ca |
| petebacondarwin | https://github.com/petebacondarwin |
| https://github.com/angular/angular/pull/36237#pullrequestreview-381047627 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| angular/packages/core/src/application_ref.ts | https://github.com/angular/angular/blob/e342ffd855ffeb8af7067b42307ffa320d82177e/packages/core/src/application_ref.ts#L327-L337 |
| e342ffd | https://github.com/angular/angular/commit/e342ffd855ffeb8af7067b42307ffa320d82177e |
| Please reload this page | https://github.com/angular/angular/pull/36237 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Mar 26, 2020 | https://github.com/angular/angular/pull/36237#issuecomment-604183182 |
| @petebacondarwin | https://github.com/petebacondarwin |
| angular/packages/core/testing/src/test_bed.ts | https://github.com/angular/angular/blob/fc3e5cb6d3ef61aaa13bd9788b9b1c7b97af94fe/packages/core/testing/src/test_bed.ts#L413 |
| fc3e5cb | https://github.com/angular/angular/commit/fc3e5cb6d3ef61aaa13bd9788b9b1c7b97af94fe |
| Please reload this page | https://github.com/angular/angular/pull/36237 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Mar 26, 2020 | https://github.com/angular/angular/pull/36237#issuecomment-604183287 |
| Please reload this page | https://github.com/angular/angular/pull/36237 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Mar 26, 2020 | https://github.com/angular/angular/pull/36237#event-3166389949 |
| alxhub | https://github.com/alxhub |
|
Mar 27, 2020
| https://github.com/angular/angular/pull/36237#ref-commit-5c28af0 |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/alxhub |
| fix(core): run APP_INITIALIZERs before accessing LOCALE_ID token … | https://github.com/angular/angular/commit/5c28af0e74ba96800c5f151ae772b3b13f9fc228 |
| 5c28af0 | https://github.com/angular/angular/commit/5c28af0e74ba96800c5f151ae772b3b13f9fc228 |
| #36237 | https://github.com/angular/angular/pull/36237 |
| #36230 | https://github.com/angular/angular/issues/36230 |
| #36237 | https://github.com/angular/angular/pull/36237 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| 1649743 | https://github.com/angular/angular/commit/16497438d6656c044c4974cbbe4ed32a9127f392 |
| Mar 27, 2020 | https://github.com/angular/angular/pull/36237#event-3173529191 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Apr 27, 2020 | https://github.com/angular/angular/pull/36237#issuecomment-620080873 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/36237 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Apr 27, 2020 | https://github.com/angular/angular/pull/36237#event-3276503829 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36237 |
|
| https://github.com/petebacondarwin |
|
petebacondarwin
| https://github.com/petebacondarwin |
|
| https://github.com/angular/angular/pull/36237/files/359c56bc332a0849b5f7a7c0e6c03ba6977469ca |
| Please reload this page | https://github.com/angular/angular/pull/36237 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: core
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22 |
|
area: testing
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
type: bug/fix
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
LOCALE_ID accessed in tests before APP_INITIALIZER runs (with Ivy)
| https://github.com/angular/angular/issues/36230 |
| Please reload this page | https://github.com/angular/angular/pull/36237 |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/petebacondarwin |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |