| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:04945844-311f-2553-bc07-3b723da1de63 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 807C:2E3FEE:1B57955:22A0A1A:6B014F75 |
| html-safe-nonce | 39ba78a26d2649e88f3004c731a36610b69dfeed0633ec58e776dabff17ea6e5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDdDOjJFM0ZFRToxQjU3OTU1OjIyQTBBMUE6NkIwMTRGNzUiLCJ2aXNpdG9yX2lkIjoiMzk2NzQyNzAxMDEyODU5Njg1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9e801f35fc84fd83ae33d75b87af8ae50c38b27536b3e452f4d8ad54d4f6aa6e |
| hovercard-subject-tag | pull_request:392993771 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/36227/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/c42592f8472061a1a370fc44caa4b68bc4f3bf5cbb01631c6987cf1325e0f9b5/angular/angular/pull/36227 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c42592f8472061a1a370fc44caa4b68bc4f3bf5cbb01631c6987cf1325e0f9b5/angular/angular/pull/36227 |
| og:image:alt | Previously, it was not possible to enable a form control after it was disabled.
This commit fixes this by making sure that the form is enabled and that
setDisabledState is called with false.
Closes... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sonukapoor |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/36227#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36227 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36227 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/36227 |
| Reload | https://github.com/angular/angular/pull/36227 |
| Reload | https://github.com/angular/angular/pull/36227 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| sonukapoor | https://github.com/sonukapoor |
| angular:master | https://github.com/angular/angular/tree/master |
| sonukapoor:form-toggle-enable-disable-fix | https://github.com/sonukapoor/angular/tree/form-toggle-enable-disable-fix |
| Conversation | https://github.com/angular/angular/pull/36227 |
| Commits1 (1) | https://github.com/angular/angular/pull/36227/commits |
| Checks | https://github.com/angular/angular/pull/36227/checks |
| Files changed | https://github.com/angular/angular/pull/36227/files |
| fix(forms): fix enabling form control after it was disabled | https://github.com/angular/angular/pull/36227#top |
| sonukapoor | https://github.com/sonukapoor |
| angular:master | https://github.com/angular/angular/tree/master |
| sonukapoor:form-toggle-enable-disable-fix | https://github.com/sonukapoor/angular/tree/form-toggle-enable-disable-fix |
|
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| Mar 24, 2020 | https://github.com/angular/angular/pull/36227#issue-586963413 |
| #35565 | https://github.com/angular/angular/issues/35565 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| #35565 | https://github.com/angular/angular/issues/35565 |
| Please reload this page | https://github.com/angular/angular/pull/36227 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 24, 2020 | https://github.com/angular/angular/pull/36227#event-3159674945 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| AndrewKushnir | https://github.com/AndrewKushnir |
| March 24, 2020 13:33 | https://github.com/angular/angular/pull/36227#event-3159675177 |
|
| https://github.com/sonukapoor |
| fix(forms): fix enabling form control after it was disabled | https://github.com/angular/angular/pull/36227/commits/7f07bf2b184f8f6bde6402edb64510bb89455c75 |
| 7f07bf2 | https://github.com/angular/angular/pull/36227/commits/7f07bf2b184f8f6bde6402edb64510bb89455c75 |
| angular#35565 | https://github.com/angular/angular/issues/35565 |
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| force-pushed | https://github.com/angular/angular/compare/2a539c88775fa0554a80a3c8d3989245e851847f..7f07bf2b184f8f6bde6402edb64510bb89455c75 |
| 2a539c8 | https://github.com/angular/angular/commit/2a539c88775fa0554a80a3c8d3989245e851847f |
| 7f07bf2 | https://github.com/angular/angular/commit/7f07bf2b184f8f6bde6402edb64510bb89455c75 |
|
Compare
| https://github.com/angular/angular/compare/2a539c88775fa0554a80a3c8d3989245e851847f..7f07bf2b184f8f6bde6402edb64510bb89455c75 |
| March 24, 2020 14:10 | https://github.com/angular/angular/pull/36227#event-3159837133 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
| Mar 24, 2020 | https://github.com/angular/angular/pull/36227#issuecomment-603303789 |
| #35311 | https://github.com/angular/angular/pull/35311 |
| #20310 | https://github.com/angular/angular/pull/20310 |
| Please reload this page | https://github.com/angular/angular/pull/36227 |
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| Mar 24, 2020 | https://github.com/angular/angular/pull/36227#issuecomment-603335315 |
| #35311 | https://github.com/angular/angular/pull/35311 |
| #20310 | https://github.com/angular/angular/pull/20310 |
| Please reload this page | https://github.com/angular/angular/pull/36227 |
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| Mar 24, 2020 | https://github.com/angular/angular/pull/36227#event-3160410394 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Apr 24, 2020 | https://github.com/angular/angular/pull/36227#issuecomment-619102722 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/36227 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Apr 24, 2020 | https://github.com/angular/angular/pull/36227#event-3270077366 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36227 |
|
| https://github.com/AndrewKushnir |
|
AndrewKushnir
| https://github.com/AndrewKushnir |
| Please reload this page | https://github.com/angular/angular/pull/36227 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
A new FormControl instance can disable an input, but it can't enable it
| https://github.com/angular/angular/issues/35565 |
| Please reload this page | https://github.com/angular/angular/pull/36227 |
|
| https://github.com/sonukapoor |
|
| https://github.com/JoostK |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |