René's URL Explorer Experiment


Title: fix(elements): correctly handle `SimpleChange#firstChange` for pre-existing inputs and setting inputs to `undefined` by gkalpak · Pull Request #36140 · angular/angular · GitHub

Open Graph Title: fix(elements): correctly handle `SimpleChange#firstChange` for pre-existing inputs and setting inputs to `undefined` by gkalpak · Pull Request #36140 · angular/angular

X Title: fix(elements): correctly handle `SimpleChange#firstChange` for pre-existing inputs and setting inputs to `undefined` by gkalpak · Pull Request #36140 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This PR contains the following fixes (see individual commit messages for details): Correctly set SimpleChange#firstChange for pre-existing inputs. Correctly handle setting inputs to undefined. Ji...

X Description: This PR contains the following fixes (see individual commit messages for details): Correctly set SimpleChange#firstChange for pre-existing inputs. Correctly handle setting inputs to undefined. Ji...

Opengraph URL: https://github.com/angular/angular/pull/36140

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:11265196-73a3-5130-4681-a48c9529dff3
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCC38:1EC9BC:B4EE6C:E7EC1D:6B00FA19
html-safe-nonce7cb0e13c3d30c5c12d326c8af500bf788fc8a94a90f6bc688724d7b1bafb5e62
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQzM4OjFFQzlCQzpCNEVFNkM6RTdFQzFEOjZCMDBGQTE5IiwidmlzaXRvcl9pZCI6IjYxODgyMTgyNzY2MjgxOTk5NjEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd4eacbe600f2a6dc64e14feee80af1dcf81076deb35552b5170de97c359b2c3f
hovercard-subject-tagpull_request:390967606
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/36140/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/63ecbf7296901804a0aca90383d5d95d01317eee05cbbd8513c85d521aa1d16c/angular/angular/pull/36140
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/63ecbf7296901804a0aca90383d5d95d01317eee05cbbd8513c85d521aa1d16c/angular/angular/pull/36140
og:image:altThis PR contains the following fixes (see individual commit messages for details): Correctly set SimpleChange#firstChange for pre-existing inputs. Correctly handle setting inputs to undefined. Ji...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegkalpak
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/36140#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36140
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36140
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36140
Reloadhttps://github.com/angular/angular/pull/36140
Reloadhttps://github.com/angular/angular/pull/36140
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-elements-firstChangehttps://github.com/gkalpak/angular/tree/fix-elements-firstChange
Conversationhttps://github.com/angular/angular/pull/36140
Commits2 (2)https://github.com/angular/angular/pull/36140/commits
Checkshttps://github.com/angular/angular/pull/36140/checks
Files changedhttps://github.com/angular/angular/pull/36140/files
fix(elements): correctly handle SimpleChange#firstChange for pre-existing inputs and setting inputs to undefinedhttps://github.com/angular/angular/pull/36140#top
gkalpakhttps://github.com/gkalpak
angular:masterhttps://github.com/angular/angular/tree/master
gkalpak:fix-elements-firstChangehttps://github.com/gkalpak/angular/tree/fix-elements-firstChange
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Mar 19, 2020https://github.com/angular/angular/pull/36140#issue-584368304
Please reload this pagehttps://github.com/angular/angular/pull/36140
FW-2007https://angular-team.atlassian.net/browse/FW-2007
#36130https://github.com/angular/angular/issues/36130
Please reload this pagehttps://github.com/angular/angular/pull/36140
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
area: elements https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
Mar 19, 2020https://github.com/angular/angular/pull/36140#event-3145279469
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Mar 19, 2020https://github.com/angular/angular/pull/36140#event-3145279630
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Mar 19, 2020https://github.com/angular/angular/pull/36140#event-3145279693
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/b832e6238ef5f603cf187ae4feca23dedead9d89..835df426fd63423a1d064c0644a941c5a7926de8
b832e62https://github.com/angular/angular/commit/b832e6238ef5f603cf187ae4feca23dedead9d89
835df42https://github.com/angular/angular/commit/835df426fd63423a1d064c0644a941c5a7926de8
Compare https://github.com/angular/angular/compare/b832e6238ef5f603cf187ae4feca23dedead9d89..835df426fd63423a1d064c0644a941c5a7926de8
March 19, 2020 12:15https://github.com/angular/angular/pull/36140#event-3145289857
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Mar 19, 2020 https://github.com/angular/angular/pull/36140#pullrequestreview-377665901
View reviewed changes https://github.com/angular/angular/pull/36140/files
packages/elements/test/component-factory-strategy_spec.tshttps://github.com/angular/angular/pull/36140/files#diff-6d1310555f071b36cc7d0d0252cd276db348308ab47a339aed82ba149e3fd1ce
gkalpakhttps://github.com/gkalpak
Mar 19, 2020https://github.com/angular/angular/pull/36140#discussion_r394984305
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
7151eaehttps://github.com/angular/angular/commit/7151eae36de08b6ab7318d90f679612f5b89e005
Please reload this pagehttps://github.com/angular/angular/pull/36140
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Mar 19, 2020 https://github.com/angular/angular/pull/36140#ref-issue-583970446
firstChange not set properly in ngOnChanges for pre-bound properties #36130 https://github.com/angular/angular/issues/36130
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Mar 19, 2020https://github.com/angular/angular/pull/36140#issuecomment-601149247
https://pr36140-835df42.ngbuilds.io/https://pr36140-835df42.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/36140
gkalpakhttps://github.com/gkalpak
March 19, 2020 14:44https://github.com/angular/angular/pull/36140#commits-pushed-30d980f
https://github.com/gkalpak
fix(elements): correctly set SimpleChange#firstChange for pre-exist…https://github.com/angular/angular/pull/36140/commits/30d980fecd8cb3a6dd3ae81cf40a8468c665fa24
30d980fhttps://github.com/angular/angular/pull/36140/commits/30d980fecd8cb3a6dd3ae81cf40a8468c665fa24
https://angular-team.atlassian.net/browse/FW-2007https://angular-team.atlassian.net/browse/FW-2007
angular#36130https://github.com/angular/angular/issues/36130
https://github.com/gkalpak
fix(elements): correctly handle setting inputs to undefinedhttps://github.com/angular/angular/pull/36140/commits/475911ea92bec829c9c9feb642cf3b086786a12d
475911ehttps://github.com/angular/angular/pull/36140/commits/475911ea92bec829c9c9feb642cf3b086786a12d
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
force-pushedhttps://github.com/angular/angular/compare/835df426fd63423a1d064c0644a941c5a7926de8..475911ea92bec829c9c9feb642cf3b086786a12d
835df42https://github.com/angular/angular/commit/835df426fd63423a1d064c0644a941c5a7926de8
475911ehttps://github.com/angular/angular/commit/475911ea92bec829c9c9feb642cf3b086786a12d
Compare https://github.com/angular/angular/compare/835df426fd63423a1d064c0644a941c5a7926de8..475911ea92bec829c9c9feb642cf3b086786a12d
March 19, 2020 12:45https://github.com/angular/angular/pull/36140#event-3145383096
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
March 19, 2020 12:45https://github.com/angular/angular/pull/36140#event-3145383162
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
andrewseguinhttps://github.com/andrewseguin
March 19, 2020 12:45https://github.com/angular/angular/pull/36140#event-3145383481
https://github.com/mary-poppins
mary-poppinshttps://github.com/mary-poppins
Mar 19, 2020https://github.com/angular/angular/pull/36140#issuecomment-601161245
475911ehttps://github.com/angular/angular/commit/475911ea92bec829c9c9feb642cf3b086786a12d
https://pr36140-475911e.ngbuilds.io/https://pr36140-475911e.ngbuilds.io/
Please reload this pagehttps://github.com/angular/angular/pull/36140
https://github.com/andrewseguin
andrewseguinhttps://github.com/andrewseguin
Mar 20, 2020 https://github.com/angular/angular/pull/36140#pullrequestreview-378688165
View reviewed changes https://github.com/angular/angular/pull/36140/files/475911ea92bec829c9c9feb642cf3b086786a12d
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Mar 23, 2020https://github.com/angular/angular/pull/36140#issuecomment-602785304
presubmithttp://test/OCL:302481473:BASE:302481549:1584988902494:997fe0
Please reload this pagehttps://github.com/angular/angular/pull/36140
mheveryhttps://github.com/mhevery
Mar 24, 2020 https://github.com/angular/angular/pull/36140#ref-commit-447a600
https://github.com/gkalpak
https://github.com/mhevery
fix(elements): correctly set SimpleChange#firstChange for pre-exist…https://github.com/angular/angular/commit/447a60047763c56adcfa382b911addac79a936f7
447a600https://github.com/angular/angular/commit/447a60047763c56adcfa382b911addac79a936f7
#36140https://github.com/angular/angular/pull/36140
https://angular-team.atlassian.net/browse/FW-2007https://angular-team.atlassian.net/browse/FW-2007
#36130https://github.com/angular/angular/issues/36130
#36140https://github.com/angular/angular/pull/36140
mheveryhttps://github.com/mhevery
Mar 24, 2020 https://github.com/angular/angular/pull/36140#ref-commit-e066bdd
https://github.com/gkalpak
https://github.com/mhevery
fix(elements): correctly handle setting inputs tohttps://github.com/angular/angular/commit/e066bddfe92452bb59e87cbd8a07c52d95c5f547
undefinedhttps://github.com/angular/angular/commit/e066bddfe92452bb59e87cbd8a07c52d95c5f547
(https://github.com/angular/angular/commit/e066bddfe92452bb59e87cbd8a07c52d95c5f547
#36140https://github.com/angular/angular/pull/36140
)https://github.com/angular/angular/commit/e066bddfe92452bb59e87cbd8a07c52d95c5f547
e066bddhttps://github.com/angular/angular/commit/e066bddfe92452bb59e87cbd8a07c52d95c5f547
#36140https://github.com/angular/angular/pull/36140
https://github.com/mhevery
mheveryhttps://github.com/mhevery
b14ac96https://github.com/angular/angular/commit/b14ac967501c494dec04a749a0b4ac29201f3626
Mar 24, 2020https://github.com/angular/angular/pull/36140#event-3160786650
mheveryhttps://github.com/mhevery
Mar 24, 2020 https://github.com/angular/angular/pull/36140#ref-commit-9ba46d9
https://github.com/gkalpak
https://github.com/mhevery
fix(elements): correctly handle setting inputs tohttps://github.com/angular/angular/commit/9ba46d9f880bc561ad941f812532484f055c209c
undefinedhttps://github.com/angular/angular/commit/9ba46d9f880bc561ad941f812532484f055c209c
(https://github.com/angular/angular/commit/9ba46d9f880bc561ad941f812532484f055c209c
#36140https://github.com/angular/angular/pull/36140
)https://github.com/angular/angular/commit/9ba46d9f880bc561ad941f812532484f055c209c
9ba46d9https://github.com/angular/angular/commit/9ba46d9f880bc561ad941f812532484f055c209c
#36140https://github.com/angular/angular/pull/36140
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
March 24, 2020 17:37https://github.com/angular/angular/pull/36140#event-3160824394
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Apr 24, 2020https://github.com/angular/angular/pull/36140#issuecomment-619102895
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/36140
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Apr 24, 2020https://github.com/angular/angular/pull/36140#event-3270078347
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36140
https://github.com/andrewseguin
andrewseguin https://github.com/andrewseguin
https://github.com/angular/angular/pull/36140/files/475911ea92bec829c9c9feb642cf3b086786a12d
Please reload this pagehttps://github.com/angular/angular/pull/36140
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: elements https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
firstChange not set properly in ngOnChanges for pre-bound properties https://github.com/angular/angular/issues/36130
Please reload this pagehttps://github.com/angular/angular/pull/36140
https://github.com/gkalpak
https://github.com/mary-poppins
https://github.com/mhevery
https://github.com/andrewseguin
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.