René's URL Explorer Experiment


Title: fix(common): let `KeyValuePipe` accept type unions with `null` by JoostK · Pull Request #36093 · angular/angular · GitHub

Open Graph Title: fix(common): let `KeyValuePipe` accept type unions with `null` by JoostK · Pull Request #36093 · angular/angular

X Title: fix(common): let `KeyValuePipe` accept type unions with `null` by JoostK · Pull Request #36093 · angular/angular

Description: KeyValuePipe currently accepts null values as well as Maps and a few others. However, due to the way in which TS overloads work, a type of T|null will not be accepted by KeyValuePipe's signatures, even though both T and null individually would be. To make this work, each signature that accepts some type T has been duplicated with a second one below it that accepts a T|null and includes null in its return type. Fixes #35743

Open Graph Description: KeyValuePipe currently accepts null values as well as Maps and a few others. However, due to the way in which TS overloads work, a type of T|null will not be accepted by KeyValuePipe's signatur...

X Description: KeyValuePipe currently accepts null values as well as Maps and a few others. However, due to the way in which TS overloads work, a type of T|null will not be accepted by KeyValuePipe's sign...

Opengraph URL: https://github.com/angular/angular/pull/36093

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:76234b0c-bbf2-d642-e674-6b0c8ed664bd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB616:2AAD2E:C7ABAA:10BD06B:6B00FD15
html-safe-noncebdbd0d0f156701e362c4e671e1f9b15c68755408f193ee3d64f4d0c73c91a5a2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNjE2OjJBQUQyRTpDN0FCQUE6MTBCRDA2Qjo2QjAwRkQxNSIsInZpc2l0b3JfaWQiOiIxNzM5NDQ4OTM2MTk3ODQ4MzQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac606e78064c402c944b73e834b2ced82fd808b4d5104dea369648063a5878bb8c
hovercard-subject-tagpull_request:389512317
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/36093/files
twitter:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/123679?s=400&v=4
og:image:altKeyValuePipe currently accepts null values as well as Maps and a few others. However, due to the way in which TS overloads work, a type of T|null will not be accepted by KeyValuePipe's signatur...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/36093/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36093%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36093%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36093/files
Reloadhttps://github.com/angular/angular/pull/36093/files
Reloadhttps://github.com/angular/angular/pull/36093/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JoostKhttps://github.com/JoostK
angular:masterhttps://github.com/angular/angular/tree/master
JoostK:ttc-keyvaluepipehttps://github.com/JoostK/angular/tree/ttc-keyvaluepipe
Conversation 3 https://github.com/angular/angular/pull/36093
Commits 1 https://github.com/angular/angular/pull/36093/commits
Checks 0 https://github.com/angular/angular/pull/36093/checks
Files changed https://github.com/angular/angular/pull/36093/files
Please reload this pagehttps://github.com/angular/angular/pull/36093/files
fix(common): let KeyValuePipe accept type unions with null https://github.com/angular/angular/pull/36093/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/36093/files
839520c fix(common): let `KeyValuePipe` accept type unions with `null` JoostK Mar 16, 2020 https://github.com/angular/angular/pull/36093/commits/839520cf14acf177876dc2ae3b60431b20988ada
Clear filters https://github.com/angular/angular/pull/36093/files
Please reload this pagehttps://github.com/angular/angular/pull/36093/files
Please reload this pagehttps://github.com/angular/angular/pull/36093/files
common.d.ts https://github.com/angular/angular/pull/36093/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
keyvalue_pipe.ts https://github.com/angular/angular/pull/36093/files#diff-817bcaebd57d2fa003be7194dcf9faa5ab0a65b26cc714b0741e2e429138c8c2
keyvalue_pipe_spec.ts https://github.com/angular/angular/pull/36093/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
goldens/public-api/common/common.d.tshttps://github.com/angular/angular/pull/36093/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
View file https://github.com/JoostK/angular/blob/839520cf14acf177876dc2ae3b60431b20988ada/goldens/public-api/common/common.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36093/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36093/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
https://github.com/angular/angular/pull/36093/files#diff-67bed716787a3922dacce8f315db1a915e56e6da522a6e7d7932919a6a26abce
packages/common/src/pipes/keyvalue_pipe.tshttps://github.com/angular/angular/pull/36093/files#diff-817bcaebd57d2fa003be7194dcf9faa5ab0a65b26cc714b0741e2e429138c8c2
View file https://github.com/JoostK/angular/blob/839520cf14acf177876dc2ae3b60431b20988ada/packages/common/src/pipes/keyvalue_pipe.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36093/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36093/files#diff-817bcaebd57d2fa003be7194dcf9faa5ab0a65b26cc714b0741e2e429138c8c2
https://github.com/angular/angular/pull/36093/files#diff-817bcaebd57d2fa003be7194dcf9faa5ab0a65b26cc714b0741e2e429138c8c2
packages/common/test/pipes/keyvalue_pipe_spec.tshttps://github.com/angular/angular/pull/36093/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
View file https://github.com/JoostK/angular/blob/839520cf14acf177876dc2ae3b60431b20988ada/packages/common/test/pipes/keyvalue_pipe_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36093/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36093/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
https://github.com/angular/angular/pull/36093/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
https://github.com/angular/angular/pull/36093/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
https://github.com/angular/angular/pull/36093/files#diff-255889adc3092c2587e827b299dc285eedd680a82eb69598f49fe9d1fb90ec08
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.