René's URL Explorer Experiment


Title: fix(zone.js): zone.js patch jest should handle done correctly by JiaLiPassion · Pull Request #36022 · angular/angular · GitHub

Open Graph Title: fix(zone.js): zone.js patch jest should handle done correctly by JiaLiPassion · Pull Request #36022 · angular/angular

X Title: fix(zone.js): zone.js patch jest should handle done correctly by JiaLiPassion · Pull Request #36022 · angular/angular

Description: zone.js support jest test.each() methods, but it introduces a bug, which is the done() function will not be handled correctly. it('should work with done', done => { // done will be undefined. }); The reason is the logic of monkey patching test method is different from jasmine patch // jasmine patch return testBody.length === 0 ? () => testProxyZone.run(testBody, null) : done => testProxyZone.run(testBody, null, [done]); // jest patch return function(...args) { return testProxyZone.run(testBody, null, args); }; the purpose of this change is to handle the following cases. test.each([1, 2])('test.each', (arg1, arg2) => { expect(arg1).toBe(1); expect(arg2).toBe(2); }); so in jest, it is a little complex, because the testBody's parameter may be bigger than 1, so the logic in jasmine return testBody.length === 0 ? () => testProxyZone.run(testBody, null) : done => testProxyZone.run(testBody, null, [done]); will not work for test.each in jest. So in this PR, I created a dynamic Function to return the correct length of paramters (which is required by jest core), to handle normal test with or without done. each with parameters with or without done. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: The issue is found at jest-preset-angular repo here, thymikee/jest-preset-angular#356

Open Graph Description: zone.js support jest test.each() methods, but it introduces a bug, which is the done() function will not be handled correctly. it('should work with done', done => { // done will be und...

X Description: zone.js support jest test.each() methods, but it introduces a bug, which is the done() function will not be handled correctly. it('should work with done', done => { // done...

Opengraph URL: https://github.com/angular/angular/pull/36022

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:39269c55-f395-cdd4-1eba-62b4ff1c0dc7
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBFA6:1D86C4:1ECEEC9:27155A9:6B0165D6
html-safe-nonce6804c7fa1dbe6d91b5537d76f20699b49a77fb6c41ab14b7234408a52bdc8f9e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRkE2OjFEODZDNDoxRUNFRUM5OjI3MTU1QTk6NkIwMTY1RDYiLCJ2aXNpdG9yX2lkIjoiMzM3NTMxNDU4OTU0NDcwMzQ0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacaa66ce5ae72a1b9d309d65f8fd2d236ed86e9d02ad7b8e6db7c5cf6bea8d37f5
hovercard-subject-tagpull_request:386803937
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/36022/files
twitter:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
og:image:altzone.js support jest test.each() methods, but it introduces a bug, which is the done() function will not be handled correctly. it('should work with done', done => { // done will be und...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/36022/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36022%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F36022%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/36022/files
Reloadhttps://github.com/angular/angular/pull/36022/files
Reloadhttps://github.com/angular/angular/pull/36022/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JiaLiPassionhttps://github.com/JiaLiPassion
angular:masterhttps://github.com/angular/angular/tree/master
JiaLiPassion:jest-fixhttps://github.com/JiaLiPassion/angular/tree/jest-fix
Conversation 12 https://github.com/angular/angular/pull/36022
Commits 1 https://github.com/angular/angular/pull/36022/commits
Checks 0 https://github.com/angular/angular/pull/36022/checks
Files changed https://github.com/angular/angular/pull/36022/files
Please reload this pagehttps://github.com/angular/angular/pull/36022/files
fix(zone.js): zone.js patch jest should handle done correctly https://github.com/angular/angular/pull/36022/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/36022/files
b47cc77 fix(zone.js): zone.js patch jest should handle done correctly JiaLiPassion Mar 11, 2020 https://github.com/angular/angular/pull/36022/commits/b47cc77910d2ede13f26dc1a709037b01d85ad62
Clear filters https://github.com/angular/angular/pull/36022/files
Please reload this pagehttps://github.com/angular/angular/pull/36022/files
Please reload this pagehttps://github.com/angular/angular/pull/36022/files
jest.ts https://github.com/angular/angular/pull/36022/files#diff-becb2c1abd8a5ec11d68b8738dd15729ac4e27463b4da882b2770db715fbc640
jest.spec.js https://github.com/angular/angular/pull/36022/files#diff-7c50625806ea7bf591f2ce4395aa6226ea279f6448b59bea8504746b7de9308c
packages/zone.js/lib/jest/jest.tshttps://github.com/angular/angular/pull/36022/files#diff-becb2c1abd8a5ec11d68b8738dd15729ac4e27463b4da882b2770db715fbc640
View file https://github.com/JiaLiPassion/angular/blob/b47cc77910d2ede13f26dc1a709037b01d85ad62/packages/zone.js/lib/jest/jest.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36022/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36022/files#diff-becb2c1abd8a5ec11d68b8738dd15729ac4e27463b4da882b2770db715fbc640
https://github.com/angular/angular/pull/36022/files#diff-becb2c1abd8a5ec11d68b8738dd15729ac4e27463b4da882b2770db715fbc640
https://github.com/angular/angular/pull/36022/files#diff-becb2c1abd8a5ec11d68b8738dd15729ac4e27463b4da882b2770db715fbc640
packages/zone.js/test/jest/jest.spec.jshttps://github.com/angular/angular/pull/36022/files#diff-7c50625806ea7bf591f2ce4395aa6226ea279f6448b59bea8504746b7de9308c
View file https://github.com/JiaLiPassion/angular/blob/b47cc77910d2ede13f26dc1a709037b01d85ad62/packages/zone.js/test/jest/jest.spec.js
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/36022/{{ revealButtonHref }}
https://github.com/angular/angular/pull/36022/files#diff-7c50625806ea7bf591f2ce4395aa6226ea279f6448b59bea8504746b7de9308c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.