René's URL Explorer Experiment


Title: fix(zone.js): zone.js patches rxjs should check null for unsubscribe by JiaLiPassion · Pull Request #35990 · angular/angular · GitHub

Open Graph Title: fix(zone.js): zone.js patches rxjs should check null for unsubscribe by JiaLiPassion · Pull Request #35990 · angular/angular

X Title: fix(zone.js): zone.js patches rxjs should check null for unsubscribe by JiaLiPassion · Pull Request #35990 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Close #31687, #31684 Zone.js patches rxjs _subscribe and _unsubscribe methods, but zone.js doesn't do null check, so in some operator such as retryWhen, the _unsubscribe will be set to null, an...

X Description: Close #31687, #31684 Zone.js patches rxjs _subscribe and _unsubscribe methods, but zone.js doesn't do null check, so in some operator such as retryWhen, the _unsubscribe will be set to null...

Opengraph URL: https://github.com/angular/angular/pull/35990

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:f695c992-0d6c-2cfe-7c11-5ad9a98f62ac
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8ED0:14700E:1B30D20:2274CF8:6B014F76
html-safe-nonce6ef78ba2e882d85e1ef687a84001d84ea5c65311aea6bcebbf6e2e1493658f26
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RUQwOjE0NzAwRToxQjMwRDIwOjIyNzRDRjg6NkIwMTRGNzYiLCJ2aXNpdG9yX2lkIjoiNjI4ODAxMjA2MDc5NDExMzkxMSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac2e11aa4851042a57fad3d9061e300b94b2aba2506600a04a4bd5d68609326385
hovercard-subject-tagpull_request:386111256
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/35990/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/a85adb05a74551db6a2dba4fe852d08a3679deb63e9fed0be65b5b8ed78d09d9/angular/angular/pull/35990
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a85adb05a74551db6a2dba4fe852d08a3679deb63e9fed0be65b5b8ed78d09d9/angular/angular/pull/35990
og:image:altClose #31687, #31684 Zone.js patches rxjs _subscribe and _unsubscribe methods, but zone.js doesn't do null check, so in some operator such as retryWhen, the _unsubscribe will be set to null, an...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJiaLiPassion
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/35990#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35990
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35990
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35990
Reloadhttps://github.com/angular/angular/pull/35990
Reloadhttps://github.com/angular/angular/pull/35990
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
JiaLiPassionhttps://github.com/JiaLiPassion
angular:masterhttps://github.com/angular/angular/tree/master
JiaLiPassion:zone-rxjs-patch-null-checkhttps://github.com/JiaLiPassion/angular/tree/zone-rxjs-patch-null-check
Conversationhttps://github.com/angular/angular/pull/35990
Commits1 (1)https://github.com/angular/angular/pull/35990/commits
Checkshttps://github.com/angular/angular/pull/35990/checks
Files changedhttps://github.com/angular/angular/pull/35990/files
fix(zone.js): zone.js patches rxjs should check null for unsubscribehttps://github.com/angular/angular/pull/35990#top
JiaLiPassionhttps://github.com/JiaLiPassion
angular:masterhttps://github.com/angular/angular/tree/master
JiaLiPassion:zone-rxjs-patch-null-checkhttps://github.com/JiaLiPassion/angular/tree/zone-rxjs-patch-null-check
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
Mar 10, 2020https://github.com/angular/angular/pull/35990#issue-578552581
#31687https://github.com/angular/angular/issues/31687
#31684https://github.com/angular/angular/issues/31684
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Please reload this pagehttps://github.com/angular/angular/pull/35990
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
area: zones https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Mar 10, 2020https://github.com/angular/angular/pull/35990#event-3114528469
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
mheveryhttps://github.com/mhevery
March 10, 2020 12:43https://github.com/angular/angular/pull/35990#event-3114528481
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Mar 10, 2020https://github.com/angular/angular/pull/35990#event-3114528571
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Mar 10, 2020https://github.com/angular/angular/pull/35990#event-3114528671
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Mar 10, 2020 https://github.com/angular/angular/pull/35990#pullrequestreview-372233533
View reviewed changes https://github.com/angular/angular/pull/35990/files
packages/zone.js/test/rxjs/rxjs.Observable.retry.spec.tshttps://github.com/angular/angular/pull/35990/files#diff-69e1557a226c2259a52f8397865d03ed47844782f88fd9f117973c59d96b66b7
Please reload this pagehttps://github.com/angular/angular/pull/35990
packages/zone.js/lib/rxjs/rxjs.tshttps://github.com/angular/angular/pull/35990/files#diff-f215f9172f4c8e66b910321246e3dee315fddefd32b4d286cfe8d4e039bdcd9a
Please reload this pagehttps://github.com/angular/angular/pull/35990
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
force-pushedhttps://github.com/angular/angular/compare/3acdd4ee659897769cd6f00159e8f7c26535090d..d505a693844c5534c6e275f3a748288010864a84
3acdd4ehttps://github.com/angular/angular/commit/3acdd4ee659897769cd6f00159e8f7c26535090d
d505a69https://github.com/angular/angular/commit/d505a693844c5534c6e275f3a748288010864a84
Compare https://github.com/angular/angular/compare/3acdd4ee659897769cd6f00159e8f7c26535090d..d505a693844c5534c6e275f3a748288010864a84
March 10, 2020 19:29https://github.com/angular/angular/pull/35990#event-3116141982
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
mheveryhttps://github.com/mhevery
March 10, 2020 19:29https://github.com/angular/angular/pull/35990#event-3116142075
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
force-pushedhttps://github.com/angular/angular/compare/746c068e6772bd890e6e043a0004ff5dbdb7c025..b4d65b6864230adee070e0724d4ac0eeba454d02
746c068https://github.com/angular/angular/commit/746c068e6772bd890e6e043a0004ff5dbdb7c025
b4d65b6https://github.com/angular/angular/commit/b4d65b6864230adee070e0724d4ac0eeba454d02
Compare https://github.com/angular/angular/compare/746c068e6772bd890e6e043a0004ff5dbdb7c025..b4d65b6864230adee070e0724d4ac0eeba454d02
March 11, 2020 00:15https://github.com/angular/angular/pull/35990#event-3116887597
https://github.com/mhevery
mheveryhttps://github.com/mhevery
Mar 11, 2020 https://github.com/angular/angular/pull/35990#pullrequestreview-373186621
View reviewed changes https://github.com/angular/angular/pull/35990/files
mheveryhttps://github.com/mhevery
https://github.com/angular/angular/pull/35990#pullrequestreview-373186621
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/35990
packages/zone.js/test/rxjs/rxjs.Observable.retry.spec.tshttps://github.com/angular/angular/pull/35990/files#diff-69e1557a226c2259a52f8397865d03ed47844782f88fd9f117973c59d96b66b7
Please reload this pagehttps://github.com/angular/angular/pull/35990
packages/zone.js/test/rxjs/rxjs.Observable.retry.spec.tshttps://github.com/angular/angular/pull/35990/files#diff-69e1557a226c2259a52f8397865d03ed47844782f88fd9f117973c59d96b66b7
Please reload this pagehttps://github.com/angular/angular/pull/35990
https://github.com/mhevery
mheveryhttps://github.com/mhevery
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
Mar 11, 2020https://github.com/angular/angular/pull/35990#event-3120875739
https://github.com/JiaLiPassion
fix(zone.js): zone.js patches rxjs should check null for unsubscribehttps://github.com/angular/angular/pull/35990/commits/e0e7859e0e4345c4b3cef3e05df014fbd5aa90fc
e0e7859https://github.com/angular/angular/pull/35990/commits/e0e7859e0e4345c4b3cef3e05df014fbd5aa90fc
angular#31687https://github.com/angular/angular/issues/31687
angular#31684https://github.com/angular/angular/issues/31684
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
force-pushedhttps://github.com/angular/angular/compare/b4d65b6864230adee070e0724d4ac0eeba454d02..e0e7859e0e4345c4b3cef3e05df014fbd5aa90fc
b4d65b6https://github.com/angular/angular/commit/b4d65b6864230adee070e0724d4ac0eeba454d02
e0e7859https://github.com/angular/angular/commit/e0e7859e0e4345c4b3cef3e05df014fbd5aa90fc
Compare https://github.com/angular/angular/compare/b4d65b6864230adee070e0724d4ac0eeba454d02..e0e7859e0e4345c4b3cef3e05df014fbd5aa90fc
March 11, 2020 23:52https://github.com/angular/angular/pull/35990#event-3120938187
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
action: cleanup https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22
Mar 11, 2020https://github.com/angular/angular/pull/35990#event-3120940550
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Mar 12, 2020https://github.com/angular/angular/pull/35990#event-3123755928
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Mar 12, 2020 https://github.com/angular/angular/pull/35990#ref-pullrequest-580175147
TEST ONLY: Combined ZoneJS changes for g3 testing #36043 https://github.com/angular/angular/pull/36043
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
action: presubmit https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20presubmit%22
Mar 16, 2020https://github.com/angular/angular/pull/35990#event-3133856943
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Mar 16, 2020https://github.com/angular/angular/pull/35990#issuecomment-599616813
#36043https://github.com/angular/angular/pull/36043
which was successfulhttps://test.corp.google.com/ui#id=OCL:300603599:BASE:301077666:1584325797358:d8800cfc&include_skipped=true
Please reload this pagehttps://github.com/angular/angular/pull/35990
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
3fa8952https://github.com/angular/angular/commit/3fa895298d9c98a42f1ce1b3619359083580ccc2
Mar 16, 2020https://github.com/angular/angular/pull/35990#event-3133875994
AndrewKushnirhttps://github.com/AndrewKushnir
Mar 16, 2020 https://github.com/angular/angular/pull/35990#ref-commit-1342668
https://github.com/JiaLiPassion
https://github.com/AndrewKushnir
fix(zone.js): zone.js patches rxjs should check null for unsubscribe (https://github.com/angular/angular/commit/1342668fd163c2cfda79a1e0bd841b5ae85cd5ec
#…https://github.com/angular/angular/pull/35990
1342668https://github.com/angular/angular/commit/1342668fd163c2cfda79a1e0bd841b5ae85cd5ec
…35990https://github.com/angular/angular/pull/35990
#31687https://github.com/angular/angular/issues/31687
#31684https://github.com/angular/angular/issues/31684
#35990https://github.com/angular/angular/pull/35990
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Apr 16, 2020https://github.com/angular/angular/pull/35990#issuecomment-614745668
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/35990
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Apr 16, 2020https://github.com/angular/angular/pull/35990#event-3240672661
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35990
https://github.com/mhevery
mhevery https://github.com/mhevery
https://github.com/angular/angular/pull/35990/files/b4d65b6864230adee070e0724d4ac0eeba454d02
Please reload this pagehttps://github.com/angular/angular/pull/35990
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
area: zones https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
needsTriage https://github.com/angular/angular/milestone/83
Patch-rxjs: _unsubscribe function can be null https://github.com/angular/angular/issues/31687
Please reload this pagehttps://github.com/angular/angular/pull/35990
https://github.com/JiaLiPassion
https://github.com/AndrewKushnir
https://github.com/mhevery
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.