René's URL Explorer Experiment


Title: fix(core): Refresh transplanted views at insertion point only by atscott · Pull Request #35968 · angular/angular · GitHub

Open Graph Title: fix(core): Refresh transplanted views at insertion point only by atscott · Pull Request #35968 · angular/angular

X Title: fix(core): Refresh transplanted views at insertion point only by atscott · Pull Request #35968 · angular/angular

Description: Only refresh transplanted views at the insertion location in Ivy. This change fixes several issues: Transplanted views refreshed twice if both insertion and declaration are dirty. This could be an error if the insertion component changes result in data not being available to the transplanted view because it is slated to be removed. CheckAlways transplanted views not refreshed if shielded by non-dirty OnPush (fixes #35400) Transplanted views still refreshed when insertion tree is detached (fixes #21324)

Open Graph Description: Only refresh transplanted views at the insertion location in Ivy. This change fixes several issues: Transplanted views refreshed twice if both insertion and declaration are dirty. This could be an...

X Description: Only refresh transplanted views at the insertion location in Ivy. This change fixes several issues: Transplanted views refreshed twice if both insertion and declaration are dirty. This could be an...

Opengraph URL: https://github.com/angular/angular/pull/35968

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:15d2fcce-fd5d-5853-cf4d-0f546e777957
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCF96:2E7EBB:D44534:10CEF39:6B010016
html-safe-nonce3aeef7e389a711f00d64a84aaa29058d36efe828466e7bb1d7478144a35c0789
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjk2OjJFN0VCQjpENDQ1MzQ6MTBDRUYzOTo2QjAxMDAxNiIsInZpc2l0b3JfaWQiOiI3NDQ5NzEyNzQ4MTE0MDg0MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac8773e15bb5627ed9a5254be31db0393adc8c363fb3d37515ea987fd1971eaa93
hovercard-subject-tagpull_request:385750814
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/35968/files
twitter:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/479713?s=400&v=4
og:image:altOnly refresh transplanted views at the insertion location in Ivy. This change fixes several issues: Transplanted views refreshed twice if both insertion and declaration are dirty. This could be an...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/35968/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35968%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35968%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35968/files
Reloadhttps://github.com/angular/angular/pull/35968/files
Reloadhttps://github.com/angular/angular/pull/35968/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
atscotthttps://github.com/atscott
angular:masterhttps://github.com/angular/angular/tree/master
atscott:containsdirtyproposalhttps://github.com/atscott/angular/tree/containsdirtyproposal
Conversation 59 https://github.com/angular/angular/pull/35968
Commits 1 https://github.com/angular/angular/pull/35968/commits
Checks 0 https://github.com/angular/angular/pull/35968/checks
Files changed https://github.com/angular/angular/pull/35968/files
Please reload this pagehttps://github.com/angular/angular/pull/35968/files
fix(core): Refresh transplanted views at insertion point only https://github.com/angular/angular/pull/35968/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/35968/files
086a25e fix(core): Refresh transplanted views at insertion point only atscott Jan 13, 2020 https://github.com/angular/angular/pull/35968/commits/086a25eea57f2dec617e660466b8d4f3df956c98
Clear filters https://github.com/angular/angular/pull/35968/files
Please reload this pagehttps://github.com/angular/angular/pull/35968/files
Please reload this pagehttps://github.com/angular/angular/pull/35968/files
aio-payloads.json https://github.com/angular/angular/pull/35968/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
integration-payloads.json https://github.com/angular/angular/pull/35968/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
shared.ts https://github.com/angular/angular/pull/35968/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
container.ts https://github.com/angular/angular/pull/35968/files#diff-4fea8e1524a8efd3ba9a8de4b50558c9d827054c28263888c14fa16dc1356354
view.ts https://github.com/angular/angular/pull/35968/files#diff-e3883f6ed24076a85a3db2f6e1ad69ebef265d4a30af8575dd6acfa963c36282
node_manipulation.ts https://github.com/angular/angular/pull/35968/files#diff-79892420ae2137fbd923532484f7415474066714db2d4d342192d4cf3984cf18
view_utils.ts https://github.com/angular/angular/pull/35968/files#diff-cb59aa044ff1cf5591731ba2620da9ef9f03fc473673fdd803dc961d4b880718
change_detection_spec.ts https://github.com/angular/angular/pull/35968/files#diff-25d932b0d3748a7363626694f5f47c899c0d2de76ce0b209db4a3403ebad182e
change_detection_transplanted_view_spec.ts https://github.com/angular/angular/pull/35968/files#diff-dd202e7c7b81c4f3486687ac3794d5bdbfe136c51abaf446c47b295ce4c69bcf
bundle.golden_symbols.json https://github.com/angular/angular/pull/35968/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
bundle.golden_symbols.json https://github.com/angular/angular/pull/35968/files#diff-b45ad5203dc5e93dba1c03c72c197220625be52c2bac940397a5b62179ec49dd
bundle.golden_symbols.json https://github.com/angular/angular/pull/35968/files#diff-c8a15946b2828a34229ac187045402b1ea37f0cb736063560a2a20f2744c23fc
goldens/size-tracking/aio-payloads.jsonhttps://github.com/angular/angular/pull/35968/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
View file https://github.com/atscott/angular/blob/086a25eea57f2dec617e660466b8d4f3df956c98/goldens/size-tracking/aio-payloads.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35968/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35968/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
https://github.com/angular/angular/pull/35968/files#diff-e2b56a8887060da860385c929e59d0f78a3acd9c6bdf5106253e105368281858
goldens/size-tracking/integration-payloads.jsonhttps://github.com/angular/angular/pull/35968/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
View file https://github.com/atscott/angular/blob/086a25eea57f2dec617e660466b8d4f3df956c98/goldens/size-tracking/integration-payloads.json
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35968/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35968/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/35968/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/35968/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/35968/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/35968/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/35968/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
https://github.com/angular/angular/pull/35968/files#diff-17036a5c93c1cb84bf295788071edcc333ed9961cfab07ca1db46f555d49c32f
packages/core/src/render3/instructions/shared.tshttps://github.com/angular/angular/pull/35968/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
View file https://github.com/atscott/angular/blob/086a25eea57f2dec617e660466b8d4f3df956c98/packages/core/src/render3/instructions/shared.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35968/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35968/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/35968/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/35968/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
Please reload this pagehttps://github.com/angular/angular/pull/35968/files
https://github.com/angular/angular/pull/35968/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/35968/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/35968/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/35968/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/35968/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/35968/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
packages/core/src/render3/interfaces/container.tshttps://github.com/angular/angular/pull/35968/files#diff-4fea8e1524a8efd3ba9a8de4b50558c9d827054c28263888c14fa16dc1356354
View file https://github.com/atscott/angular/blob/086a25eea57f2dec617e660466b8d4f3df956c98/packages/core/src/render3/interfaces/container.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35968/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35968/files#diff-4fea8e1524a8efd3ba9a8de4b50558c9d827054c28263888c14fa16dc1356354
https://github.com/angular/angular/pull/35968/files#diff-4fea8e1524a8efd3ba9a8de4b50558c9d827054c28263888c14fa16dc1356354
https://github.com/angular/angular/pull/35968/files#diff-4fea8e1524a8efd3ba9a8de4b50558c9d827054c28263888c14fa16dc1356354
https://github.com/angular/angular/pull/35968/files#diff-4fea8e1524a8efd3ba9a8de4b50558c9d827054c28263888c14fa16dc1356354
Please reload this pagehttps://github.com/angular/angular/pull/35968/files
https://github.com/angular/angular/pull/35968/files#diff-4fea8e1524a8efd3ba9a8de4b50558c9d827054c28263888c14fa16dc1356354
Please reload this pagehttps://github.com/angular/angular/pull/35968/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.