| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:69a98e95-1577-32a8-7d2d-7bb2e3d54a02 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8886:3CBB3E:979B55:C042E4:6B0128F5 |
| html-safe-nonce | 030e1af03b9d195c678990abf4b837bf62e4cd812052c588fb69ba3432aa043e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4ODg2OjNDQkIzRTo5NzlCNTU6QzA0MkU0OjZCMDEyOEY1IiwidmlzaXRvcl9pZCI6IjM3NDE3NzUxNjIxNzgwODcxNTciLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 814bbe2ccec49527e0034465aa6fc74fb662bc368a8e7d30922f24c44898b6a5 |
| hovercard-subject-tag | pull_request:385160348 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/35933/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/07a77f8bde2560f77d44d48346c6ada5bcaf12545dfbf565f27671da00c83c16/angular/angular/pull/35933 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/07a77f8bde2560f77d44d48346c6ada5bcaf12545dfbf565f27671da00c83c16/angular/angular/pull/35933 |
| og:image:alt | ngcc has its own pull-approve group |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | petebacondarwin |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/35933#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35933 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35933 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/35933 |
| Reload | https://github.com/angular/angular/pull/35933 |
| Reload | https://github.com/angular/angular/pull/35933 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| petebacondarwin | https://github.com/petebacondarwin |
| angular:master | https://github.com/angular/angular/tree/master |
| petebacondarwin:dev-infra-exclude-ngcc-from-compiler-pull-approve | https://github.com/petebacondarwin/angular/tree/dev-infra-exclude-ngcc-from-compiler-pull-approve |
| Conversation | https://github.com/angular/angular/pull/35933 |
| Commits1 (1) | https://github.com/angular/angular/pull/35933/commits |
| Checks | https://github.com/angular/angular/pull/35933/checks |
| Files changed | https://github.com/angular/angular/pull/35933/files |
| ci: exclude ngcc directory from fw-compiler pull-approve rule | https://github.com/angular/angular/pull/35933#top |
| petebacondarwin | https://github.com/petebacondarwin |
| angular:master | https://github.com/angular/angular/tree/master |
| petebacondarwin:dev-infra-exclude-ngcc-from-compiler-pull-approve | https://github.com/petebacondarwin/angular/tree/dev-infra-exclude-ngcc-from-compiler-pull-approve |
|
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Mar 7, 2020 | https://github.com/angular/angular/pull/35933#issue-577357290 |
| Please reload this page | https://github.com/angular/angular/pull/35933 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 7, 2020 | https://github.com/angular/angular/pull/35933#event-3107812408 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| IgorMinar | https://github.com/IgorMinar |
| March 7, 2020 16:24 | https://github.com/angular/angular/pull/35933#event-3107812532 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
area: build & ci
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22 |
|
area: dev-infra
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20dev-infra%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Mar 7, 2020 | https://github.com/angular/angular/pull/35933#event-3107812737 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Mar 7, 2020 | https://github.com/angular/angular/pull/35933#event-3107812748 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
Mar 9, 2020
| https://github.com/angular/angular/pull/35933#pullrequestreview-371319195 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35933/files |
| IgorMinar | https://github.com/IgorMinar |
| https://github.com/angular/angular/pull/35933#pullrequestreview-371319195 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35933 |
| .pullapprove.yml | https://github.com/angular/angular/pull/35933/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936 |
| IgorMinar | https://github.com/IgorMinar |
| Mar 9, 2020 | https://github.com/angular/angular/pull/35933#discussion_r389794070 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| https://docs.pullapprove.com/config/conditions/ | https://docs.pullapprove.com/config/conditions/ |
| @josephperrott | https://github.com/josephperrott |
| Please reload this page | https://github.com/angular/angular/pull/35933 |
| josephperrott | https://github.com/josephperrott |
| Mar 9, 2020 | https://github.com/angular/angular/pull/35933#discussion_r389846999 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35933 |
| josephperrott | https://github.com/josephperrott |
| Apr 6, 2020 | https://github.com/angular/angular/pull/35933#discussion_r404315435 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35933 |
| https://github.com/IgorMinar |
| IgorMinar | https://github.com/IgorMinar |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Mar 9, 2020 | https://github.com/angular/angular/pull/35933#event-3111336603 |
| https://github.com/josephperrott |
| josephperrott | https://github.com/josephperrott |
|
Mar 20, 2020
| https://github.com/angular/angular/pull/35933#ref-pullrequest-585097278 |
|
feat(dev-infra): handle excluding files via globs in pullapprove
#36162
| https://github.com/angular/angular/pull/36162 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
action: cleanup
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20cleanup%22 |
| Mar 29, 2020 | https://github.com/angular/angular/pull/35933#event-3175873971 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| josephperrott | https://github.com/josephperrott |
| March 29, 2020 12:56 | https://github.com/angular/angular/pull/35933#event-3175874090 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| Apr 6, 2020 | https://github.com/angular/angular/pull/35933#issuecomment-609629997 |
| @josephperrott | https://github.com/josephperrott |
| Please reload this page | https://github.com/angular/angular/pull/35933 |
| https://github.com/josephperrott |
| josephperrott | https://github.com/josephperrott |
| Apr 6, 2020 | https://github.com/angular/angular/pull/35933#issuecomment-609816806 |
| Please reload this page | https://github.com/angular/angular/pull/35933 |
| https://github.com/josephperrott |
| josephperrott | https://github.com/josephperrott |
|
Apr 6, 2020
| https://github.com/angular/angular/pull/35933#pullrequestreview-388528351 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35933/files |
| .pullapprove.yml | https://github.com/angular/angular/pull/35933/files#diff-981dd1021e0edb4b966932afe0916e629be19a596b9963223e0048cc37ea4936 |
| josephperrott | https://github.com/josephperrott |
| Apr 6, 2020 | https://github.com/angular/angular/pull/35933#discussion_r404315435 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35933 |
|
| https://github.com/petebacondarwin |
| ci: exclude ngcc directory from fw-compiler pull-approve rule | https://github.com/angular/angular/pull/35933/commits/a705a0eaf005f84e92f97278660fe90e3d4f3b20 |
| a705a0e | https://github.com/angular/angular/pull/35933/commits/a705a0eaf005f84e92f97278660fe90e3d4f3b20 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| force-pushed | https://github.com/angular/angular/compare/6d1bc3291260e03caf7fb9d274d883f05b62694a..a705a0eaf005f84e92f97278660fe90e3d4f3b20 |
| 6d1bc32 | https://github.com/angular/angular/commit/6d1bc3291260e03caf7fb9d274d883f05b62694a |
| a705a0e | https://github.com/angular/angular/commit/a705a0eaf005f84e92f97278660fe90e3d4f3b20 |
|
Compare
| https://github.com/angular/angular/compare/6d1bc3291260e03caf7fb9d274d883f05b62694a..a705a0eaf005f84e92f97278660fe90e3d4f3b20 |
| April 6, 2020 19:30 | https://github.com/angular/angular/pull/35933#event-3206900464 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| josephperrott | https://github.com/josephperrott |
| April 6, 2020 19:31 | https://github.com/angular/angular/pull/35933#event-3206901438 |
| https://github.com/josephperrott |
| josephperrott | https://github.com/josephperrott |
|
Apr 6, 2020
| https://github.com/angular/angular/pull/35933#pullrequestreview-388554419 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35933/files/a705a0eaf005f84e92f97278660fe90e3d4f3b20 |
| josephperrott | https://github.com/josephperrott |
| https://github.com/angular/angular/pull/35933#pullrequestreview-388554419 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35933 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Apr 6, 2020 | https://github.com/angular/angular/pull/35933#event-3206924575 |
| kara | https://github.com/kara |
|
Apr 6, 2020
| https://github.com/angular/angular/pull/35933#ref-commit-e515c91 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/kara |
| ci: exclude ngcc directory from fw-compiler pull-approve rule ( | https://github.com/angular/angular/commit/e515c913d9b6052f23d7cc6a9ad16719ef365539 |
| #35933 | https://github.com/angular/angular/pull/35933 |
| ) | https://github.com/angular/angular/commit/e515c913d9b6052f23d7cc6a9ad16719ef365539 |
| e515c91 | https://github.com/angular/angular/commit/e515c913d9b6052f23d7cc6a9ad16719ef365539 |
| #35933 | https://github.com/angular/angular/pull/35933 |
| https://github.com/kara |
| kara | https://github.com/kara |
| 4c7f89f | https://github.com/angular/angular/commit/4c7f89ff6d35f1ca639b54b7d08c26042dd9b8b7 |
| Apr 6, 2020 | https://github.com/angular/angular/pull/35933#event-3207059462 |
| https://github.com/petebacondarwin |
| petebacondarwin | https://github.com/petebacondarwin |
| April 6, 2020 20:19 | https://github.com/angular/angular/pull/35933#event-3207070521 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| May 7, 2020 | https://github.com/angular/angular/pull/35933#issuecomment-625347491 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/35933 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| May 7, 2020 | https://github.com/angular/angular/pull/35933#event-3313601448 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35933 |
|
| https://github.com/josephperrott |
|
josephperrott
| https://github.com/josephperrott |
|
| https://github.com/angular/angular/pull/35933/files/a705a0eaf005f84e92f97278660fe90e3d4f3b20 |
|
| https://github.com/IgorMinar |
|
IgorMinar
| https://github.com/IgorMinar |
|
| https://github.com/angular/angular/pull/35933/files/6d1bc3291260e03caf7fb9d274d883f05b62694a |
| Please reload this page | https://github.com/angular/angular/pull/35933 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: build & ci
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22 |
|
area: dev-infra
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20dev-infra%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/35933 |
|
| https://github.com/petebacondarwin |
|
| https://github.com/josephperrott |
|
| https://github.com/IgorMinar |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |