René's URL Explorer Experiment


Title: feat(zone.js): add a zone config to allow user disable wrapping uncaught promise rejection by JiaLiPassion · Pull Request #35873 · angular/angular · GitHub

Open Graph Title: feat(zone.js): add a zone config to allow user disable wrapping uncaught promise rejection by JiaLiPassion · Pull Request #35873 · angular/angular

X Title: feat(zone.js): add a zone config to allow user disable wrapping uncaught promise rejection by JiaLiPassion · Pull Request #35873 · angular/angular

Description: Close #27840. By default, zone.js wrap uncaught promise error and wrap it to a new Error object with some additional information includes the value of the error and the stack trace. Consider the following example: Zone.current .fork({ name: 'promise-error', onHandleError: (delegate: ZoneDelegate, current: Zone, target: Zone, error: any): boolean => { console.log('caught an error', error); delegate.handleError(target, error); return false; } }).run(() => { const originalError = new Error('testError'); Promise.reject(originalError); }); The promise-error zone catches a wrapped Error object whose reject property equals to the originalError, and the message will be Uncaught (in promise): testError.... You can disable this wrapping behavior by defining a global configuraiton __zone_symbol__DISABLE_WRAPPING_UNCAUGHT_PROMISE_REJECTION = true; before importing zone.js. PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? Issue Number: #28740 This PR was original submitted here #31443, and it was reverted as it is a breaking change, and in this new PR, I changed the logic and keep the original behavior and use a configuration to let user change the behavior.

Open Graph Description: Close #27840. By default, zone.js wrap uncaught promise error and wrap it to a new Error object with some additional information includes the value of the error and the stack trace. Consider the fo...

X Description: Close #27840. By default, zone.js wrap uncaught promise error and wrap it to a new Error object with some additional information includes the value of the error and the stack trace. Consider the fo...

Opengraph URL: https://github.com/angular/angular/pull/35873

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f1b6f153-1a76-0a69-85cb-7da144eeff95
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id96BE:363D8E:1FEDC08:288A9EE:6B0154D0
html-safe-nonce846fad1d5d7ddc420f02a6e7b2c9a16feef9a5cdcb031bffe9ce1451a1208f79
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NkJFOjM2M0Q4RToxRkVEQzA4OjI4OEE5RUU6NkIwMTU0RDAiLCJ2aXNpdG9yX2lkIjoiMTg1NjUwMzAxNzEwNTM0Nzc5MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdda397d536888240dbebe2eaa5b31cf570c8c633f4ea9a3a820c9f08efd5093b
hovercard-subject-tagpull_request:384330778
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/35873/files
twitter:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1442575?s=400&v=4
og:image:altClose #27840. By default, zone.js wrap uncaught promise error and wrap it to a new Error object with some additional information includes the value of the error and the stack trace. Consider the fo...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/35873/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35873%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35873%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35873/files
Reloadhttps://github.com/angular/angular/pull/35873/files
Reloadhttps://github.com/angular/angular/pull/35873/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
JiaLiPassionhttps://github.com/JiaLiPassion
angular:masterhttps://github.com/angular/angular/tree/master
JiaLiPassion:uncaught-promise-unwraphttps://github.com/JiaLiPassion/angular/tree/uncaught-promise-unwrap
Conversation 21 https://github.com/angular/angular/pull/35873
Commits 1 https://github.com/angular/angular/pull/35873/commits
Checks 0 https://github.com/angular/angular/pull/35873/checks
Files changed https://github.com/angular/angular/pull/35873/files
Please reload this pagehttps://github.com/angular/angular/pull/35873/files
feat(zone.js): add a zone config to allow user disable wrapping uncaught promise rejection https://github.com/angular/angular/pull/35873/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/35873/files
96f648c feat(zone.js): add a zone config to allow user disable wrapping uncau… JiaLiPassion Mar 9, 2020 https://github.com/angular/angular/pull/35873/commits/96f648c86bc65ed9a1bafe13b7fc97b7b762b29a
Clear filters https://github.com/angular/angular/pull/35873/files
Please reload this pagehttps://github.com/angular/angular/pull/35873/files
Please reload this pagehttps://github.com/angular/angular/pull/35873/files
promise.ts https://github.com/angular/angular/pull/35873/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
zone.configurations.api.ts https://github.com/angular/angular/pull/35873/files#diff-65d4e647b7b7524e5a2aa12407ab2a184f4a73afdb6a16f9e7d1d75c386f8128
BUILD.bazel https://github.com/angular/angular/pull/35873/files#diff-1ea6b34a2575d481fe3aa741f4a8c170942edf18d03f276e24f3eb27c90e1b7d
browser_disable_wrap_uncaught_promise_rejection_entry_point.ts https://github.com/angular/angular/pull/35873/files#diff-102cdac49e92e2ae9eddcb9cd57dd64bf78e91ed3f59b87778f1eb8b619412d7
browser_disable_wrap_uncaught_promise_rejection_setup.ts https://github.com/angular/angular/pull/35873/files#diff-d015915d140210c77276f3092cffc038fdb7acf116c6f62b67d5e9e5030bb781
promise-disable-wrap-uncaught-promise-rejection.spec.ts https://github.com/angular/angular/pull/35873/files#diff-58eb7f1d733ee90276a2e4f202138e1158add39431378a9f778a98347ca7f3e0
packages/zone.js/lib/common/promise.tshttps://github.com/angular/angular/pull/35873/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
View file https://github.com/JiaLiPassion/angular/blob/96f648c86bc65ed9a1bafe13b7fc97b7b762b29a/packages/zone.js/lib/common/promise.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35873/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35873/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/35873/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/35873/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/35873/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/35873/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
https://github.com/angular/angular/pull/35873/files#diff-7455db24439cd3e7e648c74b7a6813fbc7c6bed47debb21f5bcc18aee2b86e40
packages/zone.js/lib/zone.configurations.api.tshttps://github.com/angular/angular/pull/35873/files#diff-65d4e647b7b7524e5a2aa12407ab2a184f4a73afdb6a16f9e7d1d75c386f8128
View file https://github.com/JiaLiPassion/angular/blob/96f648c86bc65ed9a1bafe13b7fc97b7b762b29a/packages/zone.js/lib/zone.configurations.api.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35873/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35873/files#diff-65d4e647b7b7524e5a2aa12407ab2a184f4a73afdb6a16f9e7d1d75c386f8128
https://github.com/angular/angular/pull/35873/files#diff-65d4e647b7b7524e5a2aa12407ab2a184f4a73afdb6a16f9e7d1d75c386f8128
packages/zone.js/test/BUILD.bazelhttps://github.com/angular/angular/pull/35873/files#diff-1ea6b34a2575d481fe3aa741f4a8c170942edf18d03f276e24f3eb27c90e1b7d
View file https://github.com/JiaLiPassion/angular/blob/96f648c86bc65ed9a1bafe13b7fc97b7b762b29a/packages/zone.js/test/BUILD.bazel
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35873/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35873/files#diff-1ea6b34a2575d481fe3aa741f4a8c170942edf18d03f276e24f3eb27c90e1b7d
https://github.com/angular/angular/pull/35873/files#diff-1ea6b34a2575d481fe3aa741f4a8c170942edf18d03f276e24f3eb27c90e1b7d
https://github.com/angular/angular/pull/35873/files#diff-1ea6b34a2575d481fe3aa741f4a8c170942edf18d03f276e24f3eb27c90e1b7d
https://github.com/angular/angular/pull/35873/files#diff-1ea6b34a2575d481fe3aa741f4a8c170942edf18d03f276e24f3eb27c90e1b7d
https://github.com/angular/angular/pull/35873/files#diff-1ea6b34a2575d481fe3aa741f4a8c170942edf18d03f276e24f3eb27c90e1b7d
packages/zone.js/test/browser_disable_wrap_uncaught_promise_rejection_entry_point.tshttps://github.com/angular/angular/pull/35873/files#diff-102cdac49e92e2ae9eddcb9cd57dd64bf78e91ed3f59b87778f1eb8b619412d7
View file https://github.com/JiaLiPassion/angular/blob/96f648c86bc65ed9a1bafe13b7fc97b7b762b29a/packages/zone.js/test/browser_disable_wrap_uncaught_promise_rejection_entry_point.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35873/{{ revealButtonHref }}
packages/zone.js/test/browser_disable_wrap_uncaught_promise_rejection_setup.tshttps://github.com/angular/angular/pull/35873/files#diff-d015915d140210c77276f3092cffc038fdb7acf116c6f62b67d5e9e5030bb781
View file https://github.com/JiaLiPassion/angular/blob/96f648c86bc65ed9a1bafe13b7fc97b7b762b29a/packages/zone.js/test/browser_disable_wrap_uncaught_promise_rejection_setup.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35873/{{ revealButtonHref }}
packages/zone.js/test/common/promise-disable-wrap-uncaught-promise-rejection.spec.tshttps://github.com/angular/angular/pull/35873/files#diff-58eb7f1d733ee90276a2e4f202138e1158add39431378a9f778a98347ca7f3e0
View file https://github.com/JiaLiPassion/angular/blob/96f648c86bc65ed9a1bafe13b7fc97b7b762b29a/packages/zone.js/test/common/promise-disable-wrap-uncaught-promise-rejection.spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35873/{{ revealButtonHref }}
Please reload this pagehttps://github.com/angular/angular/pull/35873/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.