| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:b26544f6-8635-444b-ca70-958d02730187 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B4EE:7A60E:E082BF:1224AD0:6B00FA16 |
| html-safe-nonce | d05da25210764ef53ea5608d523d73b1a5b6dc2155501263412b9f1dfefe4418 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEVFOjdBNjBFOkUwODJCRjoxMjI0QUQwOjZCMDBGQTE2IiwidmlzaXRvcl9pZCI6IjEyNzM1NTUxNDYxOTgwMjI2NzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | e6c2054ad0f6dd4cec50a407ddeba6bac389644a101a7342ff58f8a1335b7814 |
| hovercard-subject-tag | pull_request:384202108 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/35870/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f7d0543cae8768536a8fa934e5acaf0fa20c7991f69f6acf1b51d1b45748cee4/angular/angular/pull/35870 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f7d0543cae8768536a8fa934e5acaf0fa20c7991f69f6acf1b51d1b45748cee4/angular/angular/pull/35870 |
| og:image:alt | Previously, there was a chance that the SW will never register
when there is a long-running task or recurring timeout. This commit
fixes this, by first trying to wait for the app to stabilize, howe... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sonukapoor |
| hostname | github.com |
| expected-hostname | github.com |
| None | e208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7dafd017fb7809a839c443dba08622af38e63c09 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/35870#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35870 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35870 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/35870 |
| Reload | https://github.com/angular/angular/pull/35870 |
| Reload | https://github.com/angular/angular/pull/35870 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues835 (835) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| sonukapoor | https://github.com/sonukapoor |
| angular:master | https://github.com/angular/angular/tree/master |
| sonukapoor:sw-stable-with-delay | https://github.com/sonukapoor/angular/tree/sw-stable-with-delay |
| Conversation | https://github.com/angular/angular/pull/35870 |
| Commits6 (6) | https://github.com/angular/angular/pull/35870/commits |
| Checks | https://github.com/angular/angular/pull/35870/checks |
| Files changed | https://github.com/angular/angular/pull/35870/files |
| feat(service-worker): change default SW strategy behavior | https://github.com/angular/angular/pull/35870#top |
| sonukapoor | https://github.com/sonukapoor |
| angular:master | https://github.com/angular/angular/tree/master |
| sonukapoor:sw-stable-with-delay | https://github.com/sonukapoor/angular/tree/sw-stable-with-delay |
|
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| Mar 5, 2020 | https://github.com/angular/angular/pull/35870#issue-576162281 |
| #34464 | https://github.com/angular/angular/issues/34464 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| #34464 | https://github.com/angular/angular/issues/34464 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 5, 2020 | https://github.com/angular/angular/pull/35870#event-3100656520 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| alxhub | https://github.com/alxhub |
| March 5, 2020 10:48 | https://github.com/angular/angular/pull/35870#event-3100656686 |
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| Mar 5, 2020 | https://github.com/angular/angular/pull/35870#issuecomment-595177548 |
| @alxhub | https://github.com/alxhub |
| @gkalpak | https://github.com/gkalpak |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| force-pushed | https://github.com/angular/angular/compare/21e583d20d5aa247014fcc92da037e1a708ba307..0749d3537c3962cf919942695f87c180f5bc94fc |
| 21e583d | https://github.com/angular/angular/commit/21e583d20d5aa247014fcc92da037e1a708ba307 |
| 0749d35 | https://github.com/angular/angular/commit/0749d3537c3962cf919942695f87c180f5bc94fc |
|
Compare
| https://github.com/angular/angular/compare/21e583d20d5aa247014fcc92da037e1a708ba307..0749d3537c3962cf919942695f87c180f5bc94fc |
| March 5, 2020 12:19 | https://github.com/angular/angular/pull/35870#event-3100956541 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 5, 2020 | https://github.com/angular/angular/pull/35870#event-3101153922 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| alxhub | https://github.com/alxhub |
| March 5, 2020 13:22 | https://github.com/angular/angular/pull/35870#event-3101166821 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
area: service-worker
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
feature
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Afeature |
| Mar 5, 2020 | https://github.com/angular/angular/pull/35870#event-3101167641 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Mar 5, 2020 | https://github.com/angular/angular/pull/35870#event-3101167780 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
aio: preview
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22aio%3A%20preview%22 |
| Mar 5, 2020 | https://github.com/angular/angular/pull/35870#event-3101168308 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Mar 5, 2020 | https://github.com/angular/angular/pull/35870#issuecomment-595226517 |
| https://pr35870-21e583d.ngbuilds.io/ | https://pr35870-21e583d.ngbuilds.io/ |
| https://pr35870-0749d35.ngbuilds.io/ | https://pr35870-0749d35.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
| Mar 5, 2020 | https://github.com/angular/angular/pull/35870#event-3101169061 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 5, 2020 | https://github.com/angular/angular/pull/35870#issuecomment-595228345 |
| @sonukapoor | https://github.com/sonukapoor |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| Mar 5, 2020 | https://github.com/angular/angular/pull/35870#issuecomment-595229660 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| @gkalpak | https://github.com/gkalpak |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Mar 5, 2020
| https://github.com/angular/angular/pull/35870#pullrequestreview-369564624 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35870/files |
| gkalpak | https://github.com/gkalpak |
| https://github.com/angular/angular/pull/35870#pullrequestreview-369564624 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| packages/service-worker/src/module.ts | https://github.com/angular/angular/pull/35870/files#diff-b9675a8381c614be173b58c7a24eacbbf4cd0e545a7498455f775a3f9cd2be09 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| packages/service-worker/src/module.ts | https://github.com/angular/angular/pull/35870/files#diff-b9675a8381c614be173b58c7a24eacbbf4cd0e545a7498455f775a3f9cd2be09 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| packages/service-worker/src/module.ts | https://github.com/angular/angular/pull/35870/files#diff-b9675a8381c614be173b58c7a24eacbbf4cd0e545a7498455f775a3f9cd2be09 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| packages/service-worker/src/module.ts | https://github.com/angular/angular/pull/35870/files#diff-b9675a8381c614be173b58c7a24eacbbf4cd0e545a7498455f775a3f9cd2be09 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 5, 2020 | https://github.com/angular/angular/pull/35870#issuecomment-595257202 |
| @gkalpak | https://github.com/gkalpak |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| Mar 6, 2020 | https://github.com/angular/angular/pull/35870#issuecomment-595574631 |
| @gkalpak | https://github.com/gkalpak |
| #35891 | https://github.com/angular/angular/issues/35891 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| force-pushed | https://github.com/angular/angular/compare/0749d3537c3962cf919942695f87c180f5bc94fc..5d6531f3415031b3451e8b88bffd1dd0020a4577 |
| 0749d35 | https://github.com/angular/angular/commit/0749d3537c3962cf919942695f87c180f5bc94fc |
| 5d6531f | https://github.com/angular/angular/commit/5d6531f3415031b3451e8b88bffd1dd0020a4577 |
|
Compare
| https://github.com/angular/angular/compare/0749d3537c3962cf919942695f87c180f5bc94fc..5d6531f3415031b3451e8b88bffd1dd0020a4577 |
| March 6, 2020 03:18 | https://github.com/angular/angular/pull/35870#event-3103840453 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Mar 6, 2020 | https://github.com/angular/angular/pull/35870#issuecomment-595581627 |
| https://pr35870-5d6531f.ngbuilds.io/ | https://pr35870-5d6531f.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| force-pushed | https://github.com/angular/angular/compare/6be81b05d11ec702d83ba9578c859e8cb1b20f55..4b8b57af61d9c90d572f3c0be3dd543e4c547f93 |
| 6be81b0 | https://github.com/angular/angular/commit/6be81b05d11ec702d83ba9578c859e8cb1b20f55 |
| 4b8b57a | https://github.com/angular/angular/commit/4b8b57af61d9c90d572f3c0be3dd543e4c547f93 |
|
Compare
| https://github.com/angular/angular/compare/6be81b05d11ec702d83ba9578c859e8cb1b20f55..4b8b57af61d9c90d572f3c0be3dd543e4c547f93 |
| March 6, 2020 03:42 | https://github.com/angular/angular/pull/35870#event-3103880575 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Mar 6, 2020 | https://github.com/angular/angular/pull/35870#issuecomment-595587101 |
| https://pr35870-4b8b57a.ngbuilds.io/ | https://pr35870-4b8b57a.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| gkalpak | https://github.com/gkalpak |
| March 6, 2020 12:12 | https://github.com/angular/angular/pull/35870#event-3105124525 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Mar 6, 2020
| https://github.com/angular/angular/pull/35870#pullrequestreview-370355115 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35870/files |
| packages/service-worker/src/module.ts | https://github.com/angular/angular/pull/35870/files#diff-b9675a8381c614be173b58c7a24eacbbf4cd0e545a7498455f775a3f9cd2be09 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| packages/service-worker/src/module.ts | https://github.com/angular/angular/pull/35870/files#diff-b9675a8381c614be173b58c7a24eacbbf4cd0e545a7498455f775a3f9cd2be09 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| packages/service-worker/src/module.ts | https://github.com/angular/angular/pull/35870/files#diff-b9675a8381c614be173b58c7a24eacbbf4cd0e545a7498455f775a3f9cd2be09 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| packages/service-worker/src/module.ts | https://github.com/angular/angular/pull/35870/files#diff-b9675a8381c614be173b58c7a24eacbbf4cd0e545a7498455f775a3f9cd2be09 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| packages/service-worker/src/module.ts | https://github.com/angular/angular/pull/35870/files#diff-b9675a8381c614be173b58c7a24eacbbf4cd0e545a7498455f775a3f9cd2be09 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| packages/service-worker/src/module.ts | https://github.com/angular/angular/pull/35870/files#diff-b9675a8381c614be173b58c7a24eacbbf4cd0e545a7498455f775a3f9cd2be09 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| packages/service-worker/src/module.ts | https://github.com/angular/angular/pull/35870/files#diff-b9675a8381c614be173b58c7a24eacbbf4cd0e545a7498455f775a3f9cd2be09 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| packages/service-worker/src/module.ts | https://github.com/angular/angular/pull/35870/files#diff-b9675a8381c614be173b58c7a24eacbbf4cd0e545a7498455f775a3f9cd2be09 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| packages/service-worker/src/module.ts | https://github.com/angular/angular/pull/35870/files#diff-b9675a8381c614be173b58c7a24eacbbf4cd0e545a7498455f775a3f9cd2be09 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| packages/service-worker/test/module_spec.ts | https://github.com/angular/angular/pull/35870/files#diff-cf08c4be416b06236b8488a2fc8ef8e9f028dde8d528bbbdece3622444019afe |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Mar 6, 2020 | https://github.com/angular/angular/pull/35870#event-3105594712 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/afcdf518683a6f63fb39bf03e58d76cc88f8666b..50115ca143ad4f0a27235f36ba03787613b66674 |
| afcdf51 | https://github.com/angular/angular/commit/afcdf518683a6f63fb39bf03e58d76cc88f8666b |
| 50115ca | https://github.com/angular/angular/commit/50115ca143ad4f0a27235f36ba03787613b66674 |
|
Compare
| https://github.com/angular/angular/compare/afcdf518683a6f63fb39bf03e58d76cc88f8666b..50115ca143ad4f0a27235f36ba03787613b66674 |
| March 24, 2020 20:52 | https://github.com/angular/angular/pull/35870#event-3161520950 |
| https://github.com/googlebot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35870 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Mar 24, 2020 | https://github.com/angular/angular/pull/35870#event-3161521399 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
state: WIP
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20WIP%22 |
| Mar 24, 2020 | https://github.com/angular/angular/pull/35870#event-3161522778 |
| https://github.com/gkalpak |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35870 |
| https://github.com/googlebot |
| Sign in to view | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35870 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
cla: no
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20no%22 |
| Mar 24, 2020 | https://github.com/angular/angular/pull/35870#event-3161524471 |
| sonukapoor | https://github.com/sonukapoor |
| March 24, 2020 22:54 | https://github.com/angular/angular/pull/35870#commits-pushed-cbe5da4 |
|
| https://github.com/sonukapoor |
|
| https://github.com/gkalpak |
| feat(service-worker): support timeout in registerWhenStable SW regi… | https://github.com/angular/angular/pull/35870/commits/cbe5da4dc141ccc19c60d7771f3f277b2e37701b |
| cbe5da4 | https://github.com/angular/angular/pull/35870/commits/cbe5da4dc141ccc19c60d7771f3f277b2e37701b |
| angular#34464 | https://github.com/angular/angular/issues/34464 |
| https://angular.io/api/core/ApplicationRef#is-stable-examples | https://angular.io/api/core/ApplicationRef#is-stable-examples |
|
| https://github.com/gkalpak |
| fixup! feat(service-worker): support timeout in registerWhenStable … | https://github.com/angular/angular/pull/35870/commits/80520469277056df933dc3f4f868842dd82ddaad |
| 8052046 | https://github.com/angular/angular/pull/35870/commits/80520469277056df933dc3f4f868842dd82ddaad |
|
| https://github.com/sonukapoor |
|
| https://github.com/gkalpak |
| fix(service-worker): by default register the SW after 30s even the ap… | https://github.com/angular/angular/pull/35870/commits/45eba0891b0bfaf473ddd38c039d6b7d153e1110 |
| 45eba08 | https://github.com/angular/angular/pull/35870/commits/45eba0891b0bfaf473ddd38c039d6b7d153e1110 |
| angular#34464 | https://github.com/angular/angular/issues/34464 |
|
| https://github.com/gkalpak |
| fixup! fix(service-worker): by default register the SW after 30s even… | https://github.com/angular/angular/pull/35870/commits/98099166bd03827dd70c9ecc6f1cad241e2086f7 |
| 9809916 | https://github.com/angular/angular/pull/35870/commits/98099166bd03827dd70c9ecc6f1cad241e2086f7 |
|
| https://github.com/sonukapoor |
|
| https://github.com/gkalpak |
| fix(service-worker): prevent SW registration strategies from affectin… | https://github.com/angular/angular/pull/35870/commits/d9d897510b6954fb5aca5de39f84ad4ca1af1bcc |
| d9d8975 | https://github.com/angular/angular/pull/35870/commits/d9d897510b6954fb5aca5de39f84ad4ca1af1bcc |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/50115ca143ad4f0a27235f36ba03787613b66674..5bf2fe219486bb9c69be82df185935d8f215eb9e |
| 50115ca | https://github.com/angular/angular/commit/50115ca143ad4f0a27235f36ba03787613b66674 |
| 5bf2fe2 | https://github.com/angular/angular/commit/5bf2fe219486bb9c69be82df185935d8f215eb9e |
|
Compare
| https://github.com/angular/angular/compare/50115ca143ad4f0a27235f36ba03787613b66674..5bf2fe219486bb9c69be82df185935d8f215eb9e |
| March 24, 2020 20:55 | https://github.com/angular/angular/pull/35870#event-3161529266 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Mar 24, 2020 | https://github.com/angular/angular/pull/35870#issuecomment-603501839 |
| @sonukapoor | https://github.com/sonukapoor |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| Mar 24, 2020 | https://github.com/angular/angular/pull/35870#issuecomment-603504991 |
| @sonukapoor | https://github.com/sonukapoor |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Mar 24, 2020 | https://github.com/angular/angular/pull/35870#issuecomment-603506218 |
| https://pr35870-5bf2fe2.ngbuilds.io/ | https://pr35870-5bf2fe2.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
|
| https://github.com/gkalpak |
| fixup! fix(service-worker): prevent SW registration strategies from a… | https://github.com/angular/angular/pull/35870/commits/22bf4cf2147804bc25ca511e253e462904f62883 |
| 22bf4cf | https://github.com/angular/angular/pull/35870/commits/22bf4cf2147804bc25ca511e253e462904f62883 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/5bf2fe219486bb9c69be82df185935d8f215eb9e..22bf4cf2147804bc25ca511e253e462904f62883 |
| 5bf2fe2 | https://github.com/angular/angular/commit/5bf2fe219486bb9c69be82df185935d8f215eb9e |
| 22bf4cf | https://github.com/angular/angular/commit/22bf4cf2147804bc25ca511e253e462904f62883 |
|
Compare
| https://github.com/angular/angular/compare/5bf2fe219486bb9c69be82df185935d8f215eb9e..22bf4cf2147804bc25ca511e253e462904f62883 |
| March 24, 2020 21:25 | https://github.com/angular/angular/pull/35870#event-3161624385 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Mar 24, 2020
| https://github.com/angular/angular/pull/35870#pullrequestreview-380709356 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35870/files/22bf4cf2147804bc25ca511e253e462904f62883 |
| gkalpak | https://github.com/gkalpak |
| https://github.com/angular/angular/pull/35870#pullrequestreview-380709356 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @sonukapoor | https://github.com/sonukapoor |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
| Mar 24, 2020 | https://github.com/angular/angular/pull/35870#event-3161629375 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Mar 24, 2020 | https://github.com/angular/angular/pull/35870#issuecomment-603517432 |
| 22bf4cf | https://github.com/angular/angular/commit/22bf4cf2147804bc25ca511e253e462904f62883 |
| https://pr35870-22bf4cf.ngbuilds.io/ | https://pr35870-22bf4cf.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| 00efacf | https://github.com/angular/angular/commit/00efacf561e8e935dcfbf48bab153aab3247df9d |
| Mar 27, 2020 | https://github.com/angular/angular/pull/35870#event-3173432075 |
| alxhub | https://github.com/alxhub |
|
Mar 27, 2020
| https://github.com/angular/angular/pull/35870#ref-commit-29e8a64 |
|
| https://github.com/sonukapoor |
|
| https://github.com/alxhub |
| fix(service-worker): by default register the SW after 30s even the ap… | https://github.com/angular/angular/commit/29e8a64cf02fa9b80d38c30091e0b730403c54c8 |
| 29e8a64 | https://github.com/angular/angular/commit/29e8a64cf02fa9b80d38c30091e0b730403c54c8 |
| #35870 | https://github.com/angular/angular/pull/35870 |
| #34464 | https://github.com/angular/angular/issues/34464 |
| #35870 | https://github.com/angular/angular/pull/35870 |
| alxhub | https://github.com/alxhub |
|
Mar 27, 2020
| https://github.com/angular/angular/pull/35870#ref-commit-2d7c95f |
|
| https://github.com/sonukapoor |
|
| https://github.com/alxhub |
| fix(service-worker): prevent SW registration strategies from affectin… | https://github.com/angular/angular/commit/2d7c95fb701b4a8263b18c662c4e6993223229c3 |
| 2d7c95f | https://github.com/angular/angular/commit/2d7c95fb701b4a8263b18c662c4e6993223229c3 |
| #35870 | https://github.com/angular/angular/pull/35870 |
| #35870 | https://github.com/angular/angular/pull/35870 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Apr 27, 2020 | https://github.com/angular/angular/pull/35870#issuecomment-620080755 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Apr 27, 2020 | https://github.com/angular/angular/pull/35870#event-3276502805 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35870 |
|
| https://github.com/gkalpak |
|
gkalpak
| https://github.com/gkalpak |
|
| https://github.com/angular/angular/pull/35870/files/22bf4cf2147804bc25ca511e253e462904f62883 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: service-worker
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
feature
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3Afeature |
|
target: major
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20major%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
feat(service-worker): improve default SwRegistrationStrategy
| https://github.com/angular/angular/issues/34464 |
| Please reload this page | https://github.com/angular/angular/pull/35870 |
|
| https://github.com/sonukapoor |
|
| https://github.com/mary-poppins |
|
| https://github.com/gkalpak |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |