René's URL Explorer Experiment


Title: perf(ngcc): spawn workers eagerly by alan-agius4 · Pull Request #35719 · angular/angular · GitHub

Open Graph Title: perf(ngcc): spawn workers eagerly by alan-agius4 · Pull Request #35719 · angular/angular

X Title: perf(ngcc): spawn workers eagerly by alan-agius4 · Pull Request #35719 · angular/angular

Description: With this change we spawn workers eagerly based on the amount of work that needs to be done and changed the behaviour in analyzeEntryPoints, to only create tasks for non-processed formats. Before this change we spawned the maximum of workers possible. However, in some cases there are less tasks than the max number of workers which resulted in created unnecessary workers Reference: #35717

Open Graph Description: With this change we spawn workers eagerly based on the amount of work that needs to be done and changed the behaviour in analyzeEntryPoints, to only create tasks for non-processed formats. Before t...

X Description: With this change we spawn workers eagerly based on the amount of work that needs to be done and changed the behaviour in analyzeEntryPoints, to only create tasks for non-processed formats. Before t...

Opengraph URL: https://github.com/angular/angular/pull/35719

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:44eb94c7-9872-1e14-0fc3-aa00d29e7269
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9A82:2F9718:1F90476:2A53F3F:6B018794
html-safe-nonce448a76c2d7214b50e2847c2cb528103f2e984093599e6acd0e303dbd77a5b4db
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QTgyOjJGOTcxODoxRjkwNDc2OjJBNTNGM0Y6NkIwMTg3OTQiLCJ2aXNpdG9yX2lkIjoiNzM2NjQxMzQ1MTg2Mzg4NTcxNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac600175747d5f371f650764c567c9894f21954032de11d8cf3e30481b393697c9
hovercard-subject-tagpull_request:380843771
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/35719/files
twitter:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/17563226?s=400&v=4
og:image:altWith this change we spawn workers eagerly based on the amount of work that needs to be done and changed the behaviour in analyzeEntryPoints, to only create tasks for non-processed formats. Before t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/35719/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35719%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35719%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35719/files
Reloadhttps://github.com/angular/angular/pull/35719/files
Reloadhttps://github.com/angular/angular/pull/35719/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
alan-agius4https://github.com/alan-agius4
angular:masterhttps://github.com/angular/angular/tree/master
Conversation 15 https://github.com/angular/angular/pull/35719
Commits 2 https://github.com/angular/angular/pull/35719/commits
Checks 0 https://github.com/angular/angular/pull/35719/checks
Files changed https://github.com/angular/angular/pull/35719/files
Please reload this pagehttps://github.com/angular/angular/pull/35719/files
perf(ngcc): spawn workers eagerly https://github.com/angular/angular/pull/35719/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/35719/files
03733b7 perf(ngcc): spawn workers lazily alan-agius4 Feb 28, 2020 https://github.com/angular/angular/pull/35719/commits/03733b7a76d18149fc31f99c71c463e52a69bb5c
9577589 perf(ngcc): only create tasks for non-processed formats alan-agius4 Feb 28, 2020 https://github.com/angular/angular/pull/35719/commits/9577589fa437ee31f6d1d4c41e4813daa3855eaf
Clear filters https://github.com/angular/angular/pull/35719/files
Please reload this pagehttps://github.com/angular/angular/pull/35719/files
Please reload this pagehttps://github.com/angular/angular/pull/35719/files
api.ts https://github.com/angular/angular/pull/35719/files#diff-3afc74cde069f02b867121db347f54006fff69519f9b1745b72a4c00a6d5ea32
master.ts https://github.com/angular/angular/pull/35719/files#diff-73c3dc49cd84b817689ff35582539304e7402dce1c32837cfecde3df83417de0
main.ts https://github.com/angular/angular/pull/35719/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be
worker_spec.ts https://github.com/angular/angular/pull/35719/files#diff-4f2ab1f40a23565b5460b6810e449bbef4c8f2b42ac8c780e28b22934a1a6b28
packages/compiler-cli/ngcc/src/execution/api.tshttps://github.com/angular/angular/pull/35719/files#diff-3afc74cde069f02b867121db347f54006fff69519f9b1745b72a4c00a6d5ea32
View file https://github.com/angular/angular/blob/9577589fa437ee31f6d1d4c41e4813daa3855eaf/packages/compiler-cli/ngcc/src/execution/api.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35719/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35719/files#diff-3afc74cde069f02b867121db347f54006fff69519f9b1745b72a4c00a6d5ea32
https://github.com/angular/angular/pull/35719/files#diff-3afc74cde069f02b867121db347f54006fff69519f9b1745b72a4c00a6d5ea32
https://github.com/angular/angular/pull/35719/files#diff-3afc74cde069f02b867121db347f54006fff69519f9b1745b72a4c00a6d5ea32
packages/compiler-cli/ngcc/src/execution/cluster/master.tshttps://github.com/angular/angular/pull/35719/files#diff-73c3dc49cd84b817689ff35582539304e7402dce1c32837cfecde3df83417de0
View file https://github.com/angular/angular/blob/9577589fa437ee31f6d1d4c41e4813daa3855eaf/packages/compiler-cli/ngcc/src/execution/cluster/master.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35719/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35719/files#diff-73c3dc49cd84b817689ff35582539304e7402dce1c32837cfecde3df83417de0
https://github.com/angular/angular/pull/35719/files#diff-73c3dc49cd84b817689ff35582539304e7402dce1c32837cfecde3df83417de0
https://github.com/angular/angular/pull/35719/files#diff-73c3dc49cd84b817689ff35582539304e7402dce1c32837cfecde3df83417de0
https://github.com/angular/angular/pull/35719/files#diff-73c3dc49cd84b817689ff35582539304e7402dce1c32837cfecde3df83417de0
https://github.com/angular/angular/pull/35719/files#diff-73c3dc49cd84b817689ff35582539304e7402dce1c32837cfecde3df83417de0
packages/compiler-cli/ngcc/src/main.tshttps://github.com/angular/angular/pull/35719/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be
View file https://github.com/angular/angular/blob/9577589fa437ee31f6d1d4c41e4813daa3855eaf/packages/compiler-cli/ngcc/src/main.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35719/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35719/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be
Please reload this pagehttps://github.com/angular/angular/pull/35719/files
https://github.com/angular/angular/pull/35719/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be
https://github.com/angular/angular/pull/35719/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be
Please reload this pagehttps://github.com/angular/angular/pull/35719/files
https://github.com/angular/angular/pull/35719/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be
https://github.com/angular/angular/pull/35719/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be
https://github.com/angular/angular/pull/35719/files#diff-75ccb9d1ac3b7ae04e2108aa0e157036641f2cbbc88e09b315075a669f2d22be
packages/compiler-cli/ngcc/test/execution/cluster/worker_spec.tshttps://github.com/angular/angular/pull/35719/files#diff-4f2ab1f40a23565b5460b6810e449bbef4c8f2b42ac8c780e28b22934a1a6b28
View file https://github.com/angular/angular/blob/9577589fa437ee31f6d1d4c41e4813daa3855eaf/packages/compiler-cli/ngcc/test/execution/cluster/worker_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35719/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35719/files#diff-4f2ab1f40a23565b5460b6810e449bbef4c8f2b42ac8c780e28b22934a1a6b28
https://github.com/angular/angular/pull/35719/files#diff-4f2ab1f40a23565b5460b6810e449bbef4c8f2b42ac8c780e28b22934a1a6b28
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.