René's URL Explorer Experiment


Title: fix(ngcc): allow deep-import warnings to be ignored by petebacondarwin · Pull Request #35683 · angular/angular · GitHub

Open Graph Title: fix(ngcc): allow deep-import warnings to be ignored by petebacondarwin · Pull Request #35683 · angular/angular

X Title: fix(ngcc): allow deep-import warnings to be ignored by petebacondarwin · Pull Request #35683 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: This commit adds a new ngcc configuration, ignorableDeepImportMatchers for packages. This is a list of regular expressions matching deep imports that can be safely ignored from that package. Deep i...

X Description: This commit adds a new ngcc configuration, ignorableDeepImportMatchers for packages. This is a list of regular expressions matching deep imports that can be safely ignored from that package. Deep i...

Opengraph URL: https://github.com/angular/angular/pull/35683

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:26712524-54d8-59b5-8089-f1d433058833
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF06:A20F9:1935E4D:2161D89:6B014342
html-safe-nonce8c8e4b4b31a3d8d4dfd187d224af96d37bed1cd10a5ebbd09d53991ae735b51a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjA2OkEyMEY5OjE5MzVFNEQ6MjE2MUQ4OTo2QjAxNDM0MiIsInZpc2l0b3JfaWQiOiIxODE3MzQ3MjA0NzIyMDE3MDkwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6fee8ece9690072d542fd7d3df9a37fcacadeda60d2c2bfd83038de3533d1d11
hovercard-subject-tagpull_request:380087314
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/35683/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/c294f0c8642010a033b69703262183e62164a2a27e0a37f07eff34aa2c0ab259/angular/angular/pull/35683
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c294f0c8642010a033b69703262183e62164a2a27e0a37f07eff34aa2c0ab259/angular/angular/pull/35683
og:image:altThis commit adds a new ngcc configuration, ignorableDeepImportMatchers for packages. This is a list of regular expressions matching deep imports that can be safely ignored from that package. Deep i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/35683#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35683
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35683
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35683
Reloadhttps://github.com/angular/angular/pull/35683
Reloadhttps://github.com/angular/angular/pull/35683
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-hide-unnecessary-deep-import-warningshttps://github.com/petebacondarwin/angular/tree/ngcc-hide-unnecessary-deep-import-warnings
Conversationhttps://github.com/angular/angular/pull/35683
Commits1 (1)https://github.com/angular/angular/pull/35683/commits
Checkshttps://github.com/angular/angular/pull/35683/checks
Files changedhttps://github.com/angular/angular/pull/35683/files
fix(ngcc): allow deep-import warnings to be ignoredhttps://github.com/angular/angular/pull/35683#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-hide-unnecessary-deep-import-warningshttps://github.com/petebacondarwin/angular/tree/ngcc-hide-unnecessary-deep-import-warnings
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Feb 26, 2020https://github.com/angular/angular/pull/35683#issue-571165401
#35615https://github.com/angular/angular/issues/35615
Please reload this pagehttps://github.com/angular/angular/pull/35683
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
comp: ngcc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
Feb 26, 2020https://github.com/angular/angular/pull/35683#event-3072678621
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Feb 26, 2020https://github.com/angular/angular/pull/35683#event-3072678762
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Feb 26, 2020https://github.com/angular/angular/pull/35683#event-3072678902
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
karahttps://github.com/kara
February 26, 2020 08:51https://github.com/angular/angular/pull/35683#event-3072679050
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
JoostKhttps://github.com/JoostK
gkalpakhttps://github.com/gkalpak
karahttps://github.com/kara
February 26, 2020 08:53https://github.com/angular/angular/pull/35683#event-3072686573
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/c05731dcd0a95343bbc3720863d04e8d2dff2480..25c01691087e9a20bb5ee1a3bb652cc8f9db2824
c05731dhttps://github.com/angular/angular/commit/c05731dcd0a95343bbc3720863d04e8d2dff2480
25c0169https://github.com/angular/angular/commit/25c01691087e9a20bb5ee1a3bb652cc8f9db2824
Compare https://github.com/angular/angular/compare/c05731dcd0a95343bbc3720863d04e8d2dff2480..25c01691087e9a20bb5ee1a3bb652cc8f9db2824
February 26, 2020 08:55https://github.com/angular/angular/pull/35683#event-3072692818
https://github.com/petebacondarwin
fix(ngcc): allow deep-import warnings to be ignoredhttps://github.com/angular/angular/pull/35683/commits/c7e1539187c2a91decf76902fb21a862d0598510
c7e1539https://github.com/angular/angular/pull/35683/commits/c7e1539187c2a91decf76902fb21a862d0598510
angular#35615https://github.com/angular/angular/issues/35615
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/25c01691087e9a20bb5ee1a3bb652cc8f9db2824..c7e1539187c2a91decf76902fb21a862d0598510
25c0169https://github.com/angular/angular/commit/25c01691087e9a20bb5ee1a3bb652cc8f9db2824
c7e1539https://github.com/angular/angular/commit/c7e1539187c2a91decf76902fb21a862d0598510
Compare https://github.com/angular/angular/compare/25c01691087e9a20bb5ee1a3bb652cc8f9db2824..c7e1539187c2a91decf76902fb21a862d0598510
February 26, 2020 09:26https://github.com/angular/angular/pull/35683#event-3072828497
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Feb 26, 2020https://github.com/angular/angular/pull/35683#issuecomment-591401984
https://github.com/petebacondarwin/angular-issue-35615/commit/acdc35733362a2c5e01477b8874753b245c0c4achttps://github.com/petebacondarwin/angular-issue-35615/commit/acdc35733362a2c5e01477b8874753b245c0c4ac
Please reload this pagehttps://github.com/angular/angular/pull/35683
https://github.com/alxhub
alxhubhttps://github.com/alxhub
Feb 26, 2020 https://github.com/angular/angular/pull/35683#pullrequestreview-365102123
View reviewed changes https://github.com/angular/angular/pull/35683/files/c7e1539187c2a91decf76902fb21a862d0598510
packages/compiler-cli/ngcc/src/packages/configuration.tshttps://github.com/angular/angular/pull/35683/files/c7e1539187c2a91decf76902fb21a862d0598510#diff-cbae8b8edac9f8c18e87784e762ae2f5c985c6046773d4654b9bf552f0198883
Please reload this pagehttps://github.com/angular/angular/pull/35683
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Feb 26, 2020https://github.com/angular/angular/pull/35683#event-3074998876
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Feb 26, 2020 https://github.com/angular/angular/pull/35683#pullrequestreview-365160183
View reviewed changes https://github.com/angular/angular/pull/35683/files/c7e1539187c2a91decf76902fb21a862d0598510
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
gkalpakhttps://github.com/gkalpak
February 27, 2020 14:19https://github.com/angular/angular/pull/35683#event-3078079663
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Feb 27, 2020 https://github.com/angular/angular/pull/35683#pullrequestreview-365761918
View reviewed changes https://github.com/angular/angular/pull/35683/files/c7e1539187c2a91decf76902fb21a862d0598510
atscotthttps://github.com/atscott
Feb 27, 2020 https://github.com/angular/angular/pull/35683#ref-commit-9064f4e
https://github.com/petebacondarwin
https://github.com/atscott
fix(ngcc): allow deep-import warnings to be ignored (https://github.com/angular/angular/commit/9064f4ecdb03e42bb830fa51da8a88b0a1035b38
#35683https://github.com/angular/angular/pull/35683
)https://github.com/angular/angular/commit/9064f4ecdb03e42bb830fa51da8a88b0a1035b38
9064f4ehttps://github.com/angular/angular/commit/9064f4ecdb03e42bb830fa51da8a88b0a1035b38
#35615https://github.com/angular/angular/issues/35615
#35683https://github.com/angular/angular/pull/35683
https://github.com/atscott
atscotthttps://github.com/atscott
20b0c80https://github.com/angular/angular/commit/20b0c80b0b37b005cd1964b4f2a5c832c77e1fa9
Feb 27, 2020https://github.com/angular/angular/pull/35683#event-3079044675
https://github.com/stevethemacguy
stevethemacguyhttps://github.com/stevethemacguy
Feb 27, 2020https://github.com/angular/angular/pull/35683#issuecomment-592221745
@petebacondarwinhttps://github.com/petebacondarwin
Please reload this pagehttps://github.com/angular/angular/pull/35683
https://github.com/stevethemacguy
stevethemacguyhttps://github.com/stevethemacguy
Feb 28, 2020 https://github.com/angular/angular/pull/35683#ref-issue-569023690
Entry point 'xxx' contains deep imports into 'yyy' #35615 https://github.com/angular/angular/issues/35615
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Feb 28, 2020https://github.com/angular/angular/pull/35683#issuecomment-592434035
Please reload this pagehttps://github.com/angular/angular/pull/35683
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
February 28, 2020 12:04https://github.com/angular/angular/pull/35683#event-3081699327
https://github.com/t-ho
t-hohttps://github.com/t-ho
Mar 19, 2020 https://github.com/angular/angular/pull/35683#ref-issue-584491481
Entry point 'ngx-gravatar' contains deep imports t-ho/ngx-gravatar#13 https://github.com/t-ho/ngx-gravatar/issues/13
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 30, 2020https://github.com/angular/angular/pull/35683#issuecomment-606092020
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/35683
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 30, 2020https://github.com/angular/angular/pull/35683#event-3179373770
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35683
https://github.com/JoostK
JoostK https://github.com/JoostK
https://github.com/angular/angular/pull/35683/files/c7e1539187c2a91decf76902fb21a862d0598510
https://github.com/alxhub
alxhub https://github.com/alxhub
https://github.com/angular/angular/pull/35683/files/c7e1539187c2a91decf76902fb21a862d0598510
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/35683/files/c7e1539187c2a91decf76902fb21a862d0598510
Please reload this pagehttps://github.com/angular/angular/pull/35683
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Entry point 'xxx' contains deep imports into 'yyy' https://github.com/angular/angular/issues/35615
Please reload this pagehttps://github.com/angular/angular/pull/35683
https://github.com/petebacondarwin
https://github.com/stevethemacguy
https://github.com/JoostK
https://github.com/alxhub
https://github.com/gkalpak
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.