René's URL Explorer Experiment


Title: fix(ngcc): capture path-mapped entry-points that start with same string by petebacondarwin · Pull Request #35592 · angular/angular · GitHub

Open Graph Title: fix(ngcc): capture path-mapped entry-points that start with same string by petebacondarwin · Pull Request #35592 · angular/angular

X Title: fix(ngcc): capture path-mapped entry-points that start with same string by petebacondarwin · Pull Request #35592 · angular/angular

Description: Previously if there were two path-mapped libraries that are in different directories but the path of one started with same string as the path of the other, we would incorrectly return the shorter path - e.g. dist/my-lib and dist/my-lib-second. This was because the list of basePaths was searched in ascending alphabetic order and we were using startsWith() to match the path. Now the basePaths are searched in reverse alphabetic order so the longer path will be matched correctly. // FW-1873 Fixes #35536

Open Graph Description: Previously if there were two path-mapped libraries that are in different directories but the path of one started with same string as the path of the other, we would incorrectly return the shorter p...

X Description: Previously if there were two path-mapped libraries that are in different directories but the path of one started with same string as the path of the other, we would incorrectly return the shorter p...

Opengraph URL: https://github.com/angular/angular/pull/35592

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:031884e1-4a0a-f50f-2aa3-8a7e6e2eae18
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC1CC:14F601:1334117:1881D95:6B010EDC
html-safe-noncee0a6f17ca0856b6ed880909f406cccf9b2bac659f2ecc22972c9b03da84e7aa2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUNDOjE0RjYwMToxMzM0MTE3OjE4ODFEOTU6NkIwMTBFREMiLCJ2aXNpdG9yX2lkIjoiNDgxNDI4ODA5NzI1MDQ0NzA2OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7cf7e0a5a914ba7bf38893035b8f862c8c16bf7ee04b5bb77d87b4b2d5b3d794
hovercard-subject-tagpull_request:377948743
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/35592/files
twitter:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/15655?s=400&v=4
og:image:altPreviously if there were two path-mapped libraries that are in different directories but the path of one started with same string as the path of the other, we would incorrectly return the shorter p...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/35592/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35592%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35592%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35592/files
Reloadhttps://github.com/angular/angular/pull/35592/files
Reloadhttps://github.com/angular/angular/pull/35592/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-fw-1873-path-mapped-libshttps://github.com/petebacondarwin/angular/tree/ngcc-fw-1873-path-mapped-libs
Conversation 10 https://github.com/angular/angular/pull/35592
Commits 2 https://github.com/angular/angular/pull/35592/commits
Checks 0 https://github.com/angular/angular/pull/35592/checks
Files changed https://github.com/angular/angular/pull/35592/files
Please reload this pagehttps://github.com/angular/angular/pull/35592/files
fix(ngcc): capture path-mapped entry-points that start with same string https://github.com/angular/angular/pull/35592/files#top
Show all changes 2 commits https://github.com/angular/angular/pull/35592/files
77488ff fix(ngcc): capture path-mapped entry-points that start with same string petebacondarwin Feb 20, 2020 https://github.com/angular/angular/pull/35592/commits/77488ffd8d6c468e14f3c2c48f9f4c2bd8c5d0d8
aa48cfc fixup! fix(ngcc): capture path-mapped entry-points that start with sa… petebacondarwin Feb 23, 2020 https://github.com/angular/angular/pull/35592/commits/aa48cfcc335b4f08049217869ca04a3be263ddf6
Clear filters https://github.com/angular/angular/pull/35592/files
Please reload this pagehttps://github.com/angular/angular/pull/35592/files
Please reload this pagehttps://github.com/angular/angular/pull/35592/files
utils.ts https://github.com/angular/angular/pull/35592/files#diff-8a2b9790f9ba81c1b77aec17cbdcbc754ddbdd6bbb94198f636c751fd62b390b
directory_walker_entry_point_finder_spec.ts https://github.com/angular/angular/pull/35592/files#diff-033689fa7f7079b56eea5ddf520a3c7d0310191e37e01c805a1127637ac8b89b
targeted_entry_point_finder_spec.ts https://github.com/angular/angular/pull/35592/files#diff-cf7877e88ca1c2c5983d9199a5286fe02a4693796121b77944e7b2c5969c3b68
packages/compiler-cli/ngcc/src/entry_point_finder/utils.tshttps://github.com/angular/angular/pull/35592/files#diff-8a2b9790f9ba81c1b77aec17cbdcbc754ddbdd6bbb94198f636c751fd62b390b
View file https://github.com/petebacondarwin/angular/blob/aa48cfcc335b4f08049217869ca04a3be263ddf6/packages/compiler-cli/ngcc/src/entry_point_finder/utils.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35592/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35592/files#diff-8a2b9790f9ba81c1b77aec17cbdcbc754ddbdd6bbb94198f636c751fd62b390b
https://github.com/angular/angular/pull/35592/files#diff-8a2b9790f9ba81c1b77aec17cbdcbc754ddbdd6bbb94198f636c751fd62b390b
https://github.com/angular/angular/pull/35592/files#diff-8a2b9790f9ba81c1b77aec17cbdcbc754ddbdd6bbb94198f636c751fd62b390b
https://github.com/angular/angular/pull/35592/files#diff-8a2b9790f9ba81c1b77aec17cbdcbc754ddbdd6bbb94198f636c751fd62b390b
gkalpakhttps://github.com/gkalpak
Feb 24, 2020https://github.com/angular/angular/pull/35592/files#r383250537
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/35592/files
...ges/compiler-cli/ngcc/test/entry_point_finder/directory_walker_entry_point_finder_spec.tshttps://github.com/angular/angular/pull/35592/files#diff-033689fa7f7079b56eea5ddf520a3c7d0310191e37e01c805a1127637ac8b89b
View file https://github.com/petebacondarwin/angular/blob/aa48cfcc335b4f08049217869ca04a3be263ddf6/packages/compiler-cli/ngcc/test/entry_point_finder/directory_walker_entry_point_finder_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35592/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35592/files#diff-033689fa7f7079b56eea5ddf520a3c7d0310191e37e01c805a1127637ac8b89b
https://github.com/angular/angular/pull/35592/files#diff-033689fa7f7079b56eea5ddf520a3c7d0310191e37e01c805a1127637ac8b89b
packages/compiler-cli/ngcc/test/entry_point_finder/targeted_entry_point_finder_spec.tshttps://github.com/angular/angular/pull/35592/files#diff-cf7877e88ca1c2c5983d9199a5286fe02a4693796121b77944e7b2c5969c3b68
View file https://github.com/petebacondarwin/angular/blob/aa48cfcc335b4f08049217869ca04a3be263ddf6/packages/compiler-cli/ngcc/test/entry_point_finder/targeted_entry_point_finder_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35592/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35592/files#diff-cf7877e88ca1c2c5983d9199a5286fe02a4693796121b77944e7b2c5969c3b68
https://github.com/angular/angular/pull/35592/files#diff-cf7877e88ca1c2c5983d9199a5286fe02a4693796121b77944e7b2c5969c3b68
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.