René's URL Explorer Experiment


Title: fix(ngcc): capture path-mapped entry-points that start with same string by petebacondarwin · Pull Request #35592 · angular/angular · GitHub

Open Graph Title: fix(ngcc): capture path-mapped entry-points that start with same string by petebacondarwin · Pull Request #35592 · angular/angular

X Title: fix(ngcc): capture path-mapped entry-points that start with same string by petebacondarwin · Pull Request #35592 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: Previously if there were two path-mapped libraries that are in different directories but the path of one started with same string as the path of the other, we would incorrectly return the shorter p...

X Description: Previously if there were two path-mapped libraries that are in different directories but the path of one started with same string as the path of the other, we would incorrectly return the shorter p...

Opengraph URL: https://github.com/angular/angular/pull/35592

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:79edfe8e-e55b-cc3e-a236-d0a80a7e46e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAF32:1EC9BC:E39F6A:1231D0E:6B010A26
html-safe-nonce96a0a640f3a23e173c62ca120fcf3dc3515097e06793985c5dee02067a6b0be6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjMyOjFFQzlCQzpFMzlGNkE6MTIzMUQwRTo2QjAxMEEyNiIsInZpc2l0b3JfaWQiOiI2MDQ3MDYwMjM3OTYwMTUzNjM4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac880016645dfe57dcd92cbc8a395a3d685e9dfa218f2c30234d379e9d998ee4b0
hovercard-subject-tagpull_request:377948743
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/35592/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3ae4182ee8aca1723f47af4fc48e5a7ff56ab10d89002000d5c70cb2b78c4aa4/angular/angular/pull/35592
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3ae4182ee8aca1723f47af4fc48e5a7ff56ab10d89002000d5c70cb2b78c4aa4/angular/angular/pull/35592
og:image:altPreviously if there were two path-mapped libraries that are in different directories but the path of one started with same string as the path of the other, we would incorrectly return the shorter p...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepetebacondarwin
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/35592#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35592
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35592
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35592
Reloadhttps://github.com/angular/angular/pull/35592
Reloadhttps://github.com/angular/angular/pull/35592
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-fw-1873-path-mapped-libshttps://github.com/petebacondarwin/angular/tree/ngcc-fw-1873-path-mapped-libs
Conversationhttps://github.com/angular/angular/pull/35592
Commits2 (2)https://github.com/angular/angular/pull/35592/commits
Checkshttps://github.com/angular/angular/pull/35592/checks
Files changedhttps://github.com/angular/angular/pull/35592/files
fix(ngcc): capture path-mapped entry-points that start with same stringhttps://github.com/angular/angular/pull/35592#top
petebacondarwinhttps://github.com/petebacondarwin
angular:masterhttps://github.com/angular/angular/tree/master
petebacondarwin:ngcc-fw-1873-path-mapped-libshttps://github.com/petebacondarwin/angular/tree/ngcc-fw-1873-path-mapped-libs
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Feb 20, 2020https://github.com/angular/angular/pull/35592#issue-568538928
#35536https://github.com/angular/angular/issues/35536
Please reload this pagehttps://github.com/angular/angular/pull/35592
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
comp: ngcc https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
Feb 20, 2020https://github.com/angular/angular/pull/35592#event-3057984102
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Feb 20, 2020https://github.com/angular/angular/pull/35592#event-3057984217
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Feb 20, 2020https://github.com/angular/angular/pull/35592#event-3057984325
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
JoostKhttps://github.com/JoostK
February 20, 2020 20:05https://github.com/angular/angular/pull/35592#event-3057984439
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Feb 20, 2020 https://github.com/angular/angular/pull/35592#ref-issue-567224296
Error NG6002, caused by enableIvy with libraries of a specific naming scheme #35536 https://github.com/angular/angular/issues/35536
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Feb 21, 2020 https://github.com/angular/angular/pull/35592#pullrequestreview-362634287
View reviewed changes https://github.com/angular/angular/pull/35592/files
packages/compiler-cli/ngcc/src/entry_point_finder/utils.tshttps://github.com/angular/angular/pull/35592/files#diff-8a2b9790f9ba81c1b77aec17cbdcbc754ddbdd6bbb94198f636c751fd62b390b
gkalpakhttps://github.com/gkalpak
Feb 21, 2020https://github.com/angular/angular/pull/35592#discussion_r382585700
Please reload this pagehttps://github.com/angular/angular/pull/35592
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/35592
petebacondarwinhttps://github.com/petebacondarwin
Feb 22, 2020https://github.com/angular/angular/pull/35592#discussion_r382924794
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/35592
petebacondarwinhttps://github.com/petebacondarwin
February 23, 2020 14:27https://github.com/angular/angular/pull/35592#commits-pushed-77488ff
https://github.com/petebacondarwin
fix(ngcc): capture path-mapped entry-points that start with same stringhttps://github.com/angular/angular/pull/35592/commits/77488ffd8d6c468e14f3c2c48f9f4c2bd8c5d0d8
77488ffhttps://github.com/angular/angular/pull/35592/commits/77488ffd8d6c468e14f3c2c48f9f4c2bd8c5d0d8
angular#35536https://github.com/angular/angular/issues/35536
https://github.com/petebacondarwin
fixup! fix(ngcc): capture path-mapped entry-points that start with sa…https://github.com/angular/angular/pull/35592/commits/aa48cfcc335b4f08049217869ca04a3be263ddf6
aa48cfchttps://github.com/angular/angular/pull/35592/commits/aa48cfcc335b4f08049217869ca04a3be263ddf6
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
force-pushedhttps://github.com/angular/angular/compare/4a3328103c931cd5acf8e2dfce3a28057a2fc353..aa48cfcc335b4f08049217869ca04a3be263ddf6
4a33281https://github.com/angular/angular/commit/4a3328103c931cd5acf8e2dfce3a28057a2fc353
aa48cfchttps://github.com/angular/angular/commit/aa48cfcc335b4f08049217869ca04a3be263ddf6
Compare https://github.com/angular/angular/compare/4a3328103c931cd5acf8e2dfce3a28057a2fc353..aa48cfcc335b4f08049217869ca04a3be263ddf6
February 23, 2020 14:27https://github.com/angular/angular/pull/35592#event-3063456571
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
gkalpakhttps://github.com/gkalpak
February 23, 2020 14:29https://github.com/angular/angular/pull/35592#event-3063457349
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Feb 23, 2020https://github.com/angular/angular/pull/35592#issuecomment-590074501
@gkalpakhttps://github.com/gkalpak
Please reload this pagehttps://github.com/angular/angular/pull/35592
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
Feb 24, 2020 https://github.com/angular/angular/pull/35592#pullrequestreview-363370649
View reviewed changes https://github.com/angular/angular/pull/35592/files/aa48cfcc335b4f08049217869ca04a3be263ddf6
gkalpakhttps://github.com/gkalpak
https://github.com/angular/angular/pull/35592#pullrequestreview-363370649
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/35592
packages/compiler-cli/ngcc/src/entry_point_finder/utils.tshttps://github.com/angular/angular/pull/35592/files/77488ffd8d6c468e14f3c2c48f9f4c2bd8c5d0d8..aa48cfcc335b4f08049217869ca04a3be263ddf6#diff-8a2b9790f9ba81c1b77aec17cbdcbc754ddbdd6bbb94198f636c751fd62b390b
gkalpakhttps://github.com/gkalpak
Feb 24, 2020https://github.com/angular/angular/pull/35592#discussion_r383250537
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/angular/angular/pull/35592
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
Feb 24, 2020https://github.com/angular/angular/pull/35592#event-3065388114
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Feb 24, 2020 https://github.com/angular/angular/pull/35592#pullrequestreview-363552998
View reviewed changes https://github.com/angular/angular/pull/35592/files/aa48cfcc335b4f08049217869ca04a3be263ddf6
mheveryhttps://github.com/mhevery
Feb 24, 2020 https://github.com/angular/angular/pull/35592#ref-commit-d83f62d
https://github.com/petebacondarwin
https://github.com/mhevery
fix(ngcc): capture path-mapped entry-points that start with same stri…https://github.com/angular/angular/commit/d83f62d30afbd0328bd377d8d8983ced1f58fd3a
d83f62dhttps://github.com/angular/angular/commit/d83f62d30afbd0328bd377d8d8983ced1f58fd3a
#35592https://github.com/angular/angular/pull/35592
#35536https://github.com/angular/angular/issues/35536
#35592https://github.com/angular/angular/pull/35592
https://github.com/mhevery
mheveryhttps://github.com/mhevery
71b5970https://github.com/angular/angular/commit/71b5970450fcbf72ee5b09be7ea9f6318167e727
Feb 24, 2020https://github.com/angular/angular/pull/35592#event-3066224815
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
February 24, 2020 17:22https://github.com/angular/angular/pull/35592#event-3066259727
https://github.com/fkolar
fkolarhttps://github.com/fkolar
Mar 21, 2020https://github.com/angular/angular/pull/35592#issuecomment-602068047
@petebacondarwinhttps://github.com/petebacondarwin
Please reload this pagehttps://github.com/angular/angular/pull/35592
https://github.com/fkolar
fkolarhttps://github.com/fkolar
Mar 21, 2020https://github.com/angular/angular/pull/35592#issuecomment-602069099
#35536https://github.com/angular/angular/issues/35536
Please reload this pagehttps://github.com/angular/angular/pull/35592
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
Mar 21, 2020https://github.com/angular/angular/pull/35592#issuecomment-602074186
https://github.com/angular/angular/blob/master/CHANGELOG.md#903-2020-02-27https://github.com/angular/angular/blob/master/CHANGELOG.md#903-2020-02-27
@fkolarhttps://github.com/fkolar
Please reload this pagehttps://github.com/angular/angular/pull/35592
https://github.com/fkolar
fkolarhttps://github.com/fkolar
Mar 21, 2020https://github.com/angular/angular/pull/35592#issuecomment-602074371
Please reload this pagehttps://github.com/angular/angular/pull/35592
fkolarhttps://github.com/fkolar
Mar 21, 2020 https://github.com/angular/angular/pull/35592#ref-commit-61b1a78
https://github.com/fkolar
build(ng9): Material App workinghttps://github.com/ngx-metaui/rules/commit/61b1a78bd8cef9fd6ca8acf637b3523ee39c611f
61b1a78https://github.com/ngx-metaui/rules/commit/61b1a78bd8cef9fd6ca8acf637b3523ee39c611f
angular/angular#35592https://github.com/angular/angular/pull/35592
fkolarhttps://github.com/fkolar
Apr 5, 2020 https://github.com/angular/angular/pull/35592#ref-commit-11611c5
https://github.com/fkolar
build(ng9): Material App workinghttps://github.com/ngx-metaui/rules/commit/11611c5ccd98b1c15757c1fdd45ba63ffc72242f
11611c5https://github.com/ngx-metaui/rules/commit/11611c5ccd98b1c15757c1fdd45ba63ffc72242f
angular/angular#35592https://github.com/angular/angular/pull/35592
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Apr 21, 2020https://github.com/angular/angular/pull/35592#issuecomment-617267459
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/35592
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Apr 21, 2020https://github.com/angular/angular/pull/35592#event-3256853542
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35592
https://github.com/JoostK
JoostK https://github.com/JoostK
https://github.com/angular/angular/pull/35592/files/aa48cfcc335b4f08049217869ca04a3be263ddf6
https://github.com/gkalpak
gkalpak https://github.com/gkalpak
https://github.com/angular/angular/pull/35592/files/aa48cfcc335b4f08049217869ca04a3be263ddf6
Please reload this pagehttps://github.com/angular/angular/pull/35592
action: merge https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
type: bug/fix https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriage https://github.com/angular/angular/milestone/83
Error NG6002, caused by enableIvy with libraries of a specific naming scheme https://github.com/angular/angular/issues/35536
Please reload this pagehttps://github.com/angular/angular/pull/35592
https://github.com/petebacondarwin
https://github.com/fkolar
https://github.com/JoostK
https://github.com/gkalpak
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.