René's URL Explorer Experiment


Title: fix(core): handle synthetic props in Directive host bindings correctly by AndrewKushnir · Pull Request #35568 · angular/angular · GitHub

Open Graph Title: fix(core): handle synthetic props in Directive host bindings correctly by AndrewKushnir · Pull Request #35568 · angular/angular

X Title: fix(core): handle synthetic props in Directive host bindings correctly by AndrewKushnir · Pull Request #35568 · angular/angular

Description: Prior to this change, animations-related runtime logic assumed that the @HostBinding and @HostListener with synthetic (animations) props are used for Components only. However having @HostBinding and @HostListener with synthetic props on Directives is supported by View Engine. This commit updates the logic to select correct renderer to execute instructions (current renderer for Directives and sub-component renderer for Components). This PR resolves #35501. PR Type What kind of change does this PR introduce? Bugfix Does this PR introduce a breaking change? Yes No

Open Graph Description: Prior to this change, animations-related runtime logic assumed that the @HostBinding and @HostListener with synthetic (animations) props are used for Components only. However having @HostBinding an...

X Description: Prior to this change, animations-related runtime logic assumed that the @HostBinding and @HostListener with synthetic (animations) props are used for Components only. However having @HostBinding an...

Opengraph URL: https://github.com/angular/angular/pull/35568

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:03a01251-610a-f083-3cc2-5ef8054f6e55
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAC7A:6DC60:C1114D:F25254:6B0131EE
html-safe-noncecd74d3c8e3c366ae162ef7b706c2b9c1ac7818e1fd99f17fed527a66745a875a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzdBOjZEQzYwOkMxMTE0RDpGMjUyNTQ6NkIwMTMxRUUiLCJ2aXNpdG9yX2lkIjoiMjQ2MTkzMTQ5MzE0MTUwODk0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacab0e811889abe662f2f6a04eafde99a78842f0363c504f2602413d09c99cfdd4
hovercard-subject-tagpull_request:377498608
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/35568/files
twitter:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/43554145?s=400&v=4
og:image:altPrior to this change, animations-related runtime logic assumed that the @HostBinding and @HostListener with synthetic (animations) props are used for Components only. However having @HostBinding an...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/35568/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35568%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35568%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35568/files
Reloadhttps://github.com/angular/angular/pull/35568/files
Reloadhttps://github.com/angular/angular/pull/35568/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
AndrewKushnirhttps://github.com/AndrewKushnir
angular:masterhttps://github.com/angular/angular/tree/master
AndrewKushnir:FW-1872_host_binding_synthetic_prophttps://github.com/AndrewKushnir/angular/tree/FW-1872_host_binding_synthetic_prop
Conversation 33 https://github.com/angular/angular/pull/35568
Commits 3 https://github.com/angular/angular/pull/35568/commits
Checks 0 https://github.com/angular/angular/pull/35568/checks
Files changed https://github.com/angular/angular/pull/35568/files
Please reload this pagehttps://github.com/angular/angular/pull/35568/files
fix(core): handle synthetic props in Directive host bindings correctly https://github.com/angular/angular/pull/35568/files#top
Show all changes 3 commits https://github.com/angular/angular/pull/35568/files
ea47536 fix(core): handle synthetic props in Directive host bindings correctly AndrewKushnir Feb 19, 2020 https://github.com/angular/angular/pull/35568/commits/ea4753635c2fa482dd308bdf614f5832e028aef9
a717165 fixup! fix(core): handle synthetic props in Directive host bindings c… AndrewKushnir Apr 15, 2020 https://github.com/angular/angular/pull/35568/commits/a717165b23d4fb9bf22b70253f16c2320bb4c914
11dcfed fixup! fix(core): handle synthetic props in Directive host bindings c… AndrewKushnir Apr 22, 2020 https://github.com/angular/angular/pull/35568/commits/11dcfed492b457af7be4e384672bc242723a209d
Clear filters https://github.com/angular/angular/pull/35568/files
Please reload this pagehttps://github.com/angular/angular/pull/35568/files
Please reload this pagehttps://github.com/angular/angular/pull/35568/files
host_property.ts https://github.com/angular/angular/pull/35568/files#diff-f358f6580dff252c9b91e0cf6ad8ab9035c9b4efde9b3634a9184ef99a61a43c
listener.ts https://github.com/angular/angular/pull/35568/files#diff-d5a023aec96443a37045bf1048d5d07c2568ff71f324724a7413f28ec8190d99
shared.ts https://github.com/angular/angular/pull/35568/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
styling.ts https://github.com/angular/angular/pull/35568/files#diff-b0d727f540309e17ae10ef12435fe423b8826cdff6b5582aebc0e652283d77d7
state.ts https://github.com/angular/angular/pull/35568/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
host_binding_spec.ts https://github.com/angular/angular/pull/35568/files#diff-cff4f8f61100863f485e3d4726035b3e97408f956f3aaae818656e032dd015fb
bundle.golden_symbols.json https://github.com/angular/angular/pull/35568/files#diff-682c41ab8c9c211b98fdfd11a6864d3911267eaf1b4c9c39b94bac0f6e712661
bundle.golden_symbols.json https://github.com/angular/angular/pull/35568/files#diff-b45ad5203dc5e93dba1c03c72c197220625be52c2bac940397a5b62179ec49dd
bundle.golden_symbols.json https://github.com/angular/angular/pull/35568/files#diff-c8a15946b2828a34229ac187045402b1ea37f0cb736063560a2a20f2744c23fc
packages/core/src/render3/instructions/host_property.tshttps://github.com/angular/angular/pull/35568/files#diff-f358f6580dff252c9b91e0cf6ad8ab9035c9b4efde9b3634a9184ef99a61a43c
View file https://github.com/AndrewKushnir/angular/blob/11dcfed492b457af7be4e384672bc242723a209d/packages/core/src/render3/instructions/host_property.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35568/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35568/files#diff-f358f6580dff252c9b91e0cf6ad8ab9035c9b4efde9b3634a9184ef99a61a43c
https://github.com/angular/angular/pull/35568/files#diff-f358f6580dff252c9b91e0cf6ad8ab9035c9b4efde9b3634a9184ef99a61a43c
https://github.com/angular/angular/pull/35568/files#diff-f358f6580dff252c9b91e0cf6ad8ab9035c9b4efde9b3634a9184ef99a61a43c
https://github.com/angular/angular/pull/35568/files#diff-f358f6580dff252c9b91e0cf6ad8ab9035c9b4efde9b3634a9184ef99a61a43c
https://github.com/angular/angular/pull/35568/files#diff-f358f6580dff252c9b91e0cf6ad8ab9035c9b4efde9b3634a9184ef99a61a43c
Please reload this pagehttps://github.com/angular/angular/pull/35568/files
https://github.com/angular/angular/pull/35568/files#diff-f358f6580dff252c9b91e0cf6ad8ab9035c9b4efde9b3634a9184ef99a61a43c
packages/core/src/render3/instructions/listener.tshttps://github.com/angular/angular/pull/35568/files#diff-d5a023aec96443a37045bf1048d5d07c2568ff71f324724a7413f28ec8190d99
View file https://github.com/AndrewKushnir/angular/blob/11dcfed492b457af7be4e384672bc242723a209d/packages/core/src/render3/instructions/listener.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35568/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35568/files#diff-d5a023aec96443a37045bf1048d5d07c2568ff71f324724a7413f28ec8190d99
https://github.com/angular/angular/pull/35568/files#diff-d5a023aec96443a37045bf1048d5d07c2568ff71f324724a7413f28ec8190d99
https://github.com/angular/angular/pull/35568/files#diff-d5a023aec96443a37045bf1048d5d07c2568ff71f324724a7413f28ec8190d99
https://github.com/angular/angular/pull/35568/files#diff-d5a023aec96443a37045bf1048d5d07c2568ff71f324724a7413f28ec8190d99
https://github.com/angular/angular/pull/35568/files#diff-d5a023aec96443a37045bf1048d5d07c2568ff71f324724a7413f28ec8190d99
packages/core/src/render3/instructions/shared.tshttps://github.com/angular/angular/pull/35568/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
View file https://github.com/AndrewKushnir/angular/blob/11dcfed492b457af7be4e384672bc242723a209d/packages/core/src/render3/instructions/shared.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35568/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35568/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/35568/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/35568/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
Please reload this pagehttps://github.com/angular/angular/pull/35568/files
https://github.com/angular/angular/pull/35568/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
Please reload this pagehttps://github.com/angular/angular/pull/35568/files
https://github.com/angular/angular/pull/35568/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
https://github.com/angular/angular/pull/35568/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
Please reload this pagehttps://github.com/angular/angular/pull/35568/files
https://github.com/angular/angular/pull/35568/files#diff-92e488b29fcb339dca89bcc326131e4e7482ceac84387f5e5250c3441a9dd326
packages/core/src/render3/instructions/styling.tshttps://github.com/angular/angular/pull/35568/files#diff-b0d727f540309e17ae10ef12435fe423b8826cdff6b5582aebc0e652283d77d7
View file https://github.com/AndrewKushnir/angular/blob/11dcfed492b457af7be4e384672bc242723a209d/packages/core/src/render3/instructions/styling.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35568/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35568/files#diff-b0d727f540309e17ae10ef12435fe423b8826cdff6b5582aebc0e652283d77d7
https://github.com/angular/angular/pull/35568/files#diff-b0d727f540309e17ae10ef12435fe423b8826cdff6b5582aebc0e652283d77d7
https://github.com/angular/angular/pull/35568/files#diff-b0d727f540309e17ae10ef12435fe423b8826cdff6b5582aebc0e652283d77d7
https://github.com/angular/angular/pull/35568/files#diff-b0d727f540309e17ae10ef12435fe423b8826cdff6b5582aebc0e652283d77d7
https://github.com/angular/angular/pull/35568/files#diff-b0d727f540309e17ae10ef12435fe423b8826cdff6b5582aebc0e652283d77d7
https://github.com/angular/angular/pull/35568/files#diff-b0d727f540309e17ae10ef12435fe423b8826cdff6b5582aebc0e652283d77d7
packages/core/src/render3/state.tshttps://github.com/angular/angular/pull/35568/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
View file https://github.com/AndrewKushnir/angular/blob/11dcfed492b457af7be4e384672bc242723a209d/packages/core/src/render3/state.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35568/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35568/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
https://github.com/angular/angular/pull/35568/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
https://github.com/angular/angular/pull/35568/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
https://github.com/angular/angular/pull/35568/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
Please reload this pagehttps://github.com/angular/angular/pull/35568/files
https://github.com/angular/angular/pull/35568/files#diff-944eb46933429dc12ec1d68ccb1069562a3bb2c749a2ceb2ac532ff9863e5edf
Please reload this pagehttps://github.com/angular/angular/pull/35568/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.