Title: build: several minor fixes related to using `puppeteer` by gkalpak · Pull Request #35381 · angular/angular · GitHub
Open Graph Title: build: several minor fixes related to using `puppeteer` by gkalpak · Pull Request #35381 · angular/angular
X Title: build: several minor fixes related to using `puppeteer` by gkalpak · Pull Request #35381 · angular/angular
Description: This PR is a follow-up to #35049 and contains several fixes related to using the browser provided by puppeteer to run tests. It contains the following commits: build: several minor fixes related to using puppeteer This is a follow-up to #35049 with a few minor fixes related to using the browser provided by puppeteer to run tests. Included fixes: Make the webdriver-manager-update.js really portable. (Previously, it needed to be run from the directory that contained the node_modules/ directory. Now, it can be executed from a subdirectory and will correctly resolve dependencies.) Use the puppeteer-based setup in AIO unit and e2e tests to ensure that the downloaded ChromeDriver version matches the browser version used in tests. Use the puppeteer-based setup in the aio_monitoring_stable CI job (as happens with aio_monitoring_next). Use the recommended way of getting the browser port when using puppeteer with lighthouse and avoid hard-coding the remote debugging port (to be able to handle multiple instances running concurrently). build(docs-infra): use puppeteer to get a browser for docs examples tests In #35049, integration and AIO tests were changed to use the browser provided by puppeteer in tests. This commit switches the docs examples tests to use the same setup. IMPLEMENTATION NOTE: The examples are used to create ZIP archives that docs users can download to experiment with. Since we want the downloaded projects to resemble an @angular/cli generated project, we do not want to affect the project's Protractor configuration in order to use puppeteer. To achieve this, a second Protractor configuration is created (which is ignored when creating the ZIP archives) that extends the original one and passes the approperiate arguments to use the browser provided by puppeteer. This new configuration (protractor-puppeteer.conf.js) is used when running the docs examples tests (on CI or locally during development). ci: get rid of the CI_CHROMEDRIVER_VERSION_ARG env var Previously, we needed to manually specify a ChromeDriver version to download on CI that would be compatible with the browser version provided by the docker image used to run the tests. This was kept in the CI_CHROMEDRIVER_VERSION_ARG environment variable. With recent commits, we use the browser provided by puppeteer and can determine the correct ChromeDriver version programmatically. Therefore, we no longer need the CI_CHROMEDRIVER_VERSION_ARG environment variable. NOTE: There is still one place (the bazel-schematics integration project) where a hard-coded ChromeDriver version is necessary. Since I am not sure what is the best way to refactor the tests to not rely on a hard-coded version, I left it as a TODO for a follow-up PR.
Open Graph Description: This PR is a follow-up to #35049 and contains several fixes related to using the browser provided by puppeteer to run tests. It contains the following commits: build: several minor fixes related t...
X Description: This PR is a follow-up to #35049 and contains several fixes related to using the browser provided by puppeteer to run tests. It contains the following commits: build: several minor fixes related t...
Opengraph URL: https://github.com/angular/angular/pull/35381
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:04f03727-ff8e-6838-bf4f-53cfd7e53e8f |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C448:108C63:121A8C2:19E0475:6A5A1B5C |
| html-safe-nonce | 992229fcaf28d850dc9b07161c067e5beea669a23fadf7c7cc5d6865331158a9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDQ4OjEwOEM2MzoxMjFBOEMyOjE5RTA0NzU6NkE1QTFCNUMiLCJ2aXNpdG9yX2lkIjoiODgxODkyNTQ1MjM4OTkxNTQ4NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 62f9e50ed17f0aea6ca7e649d0465c4a70bf6d65121b81ee5c0135bea44355dd |
| hovercard-subject-tag | pull_request:374350028 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/angular/angular/pull/35381/files |
| twitter:image | https://avatars.githubusercontent.com/u/8604205?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/8604205?s=400&v=4 |
| og:image:alt | This PR is a follow-up to #35049 and contains several fixes related to using the browser provided by puppeteer to run tests. It contains the following commits: build: several minor fixes related t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | e31742e80bbd077fd5679c13ed870ce4e0c13803a2fa5beaae557b6769de2c8a |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | c9fcdbf98c619d1561ed843fa01d9766a32b5cd9 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width