| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:3407716b-16af-52a3-df64-bee49bc09359 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B05C:6E606:1C5B658:264F3A8:6A598DD9 |
| html-safe-nonce | 265dc52082f017e7a3b97a056ae9d6727e4503b74e5c885704662e85dcdb23de |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMDVDOjZFNjA2OjFDNUI2NTg6MjY0RjNBODo2QTU5OEREOSIsInZpc2l0b3JfaWQiOiIzMjk2MDM2MjYyMTE4MDAyMTM3IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 3b212a5e22530b3c6706bc6ac6673c6b8f5b2f4fa69f71a3c62a1a82fc129fcc |
| hovercard-subject-tag | pull_request:374350028 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/35381/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/30796a43da22cfee99372b48fe3db8713034b120a66007a1ff68f603e7a3addd/angular/angular/pull/35381 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/30796a43da22cfee99372b48fe3db8713034b120a66007a1ff68f603e7a3addd/angular/angular/pull/35381 |
| og:image:alt | This PR is a follow-up to #35049 and contains several fixes related to using the browser provided by puppeteer to run tests. It contains the following commits:
build: several minor fixes related t... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | a540949572872b935b393b36db38922db390ae71c859537d741b8f3eb7e545b5 |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 624bb50a7497aa346bef8cc3743af408a9ea10ca |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/angular/angular/pull/35381#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35381 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35381 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/35381 |
| Reload | https://github.com/angular/angular/pull/35381 |
| Reload | https://github.com/angular/angular/pull/35381 |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
|
angular
| https://github.com/angular |
| angular | https://github.com/angular/angular |
|
Notifications
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Fork
27.4k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Star
101k
| https://github.com/login?return_to=%2Fangular%2Fangular |
|
Code
| https://github.com/angular/angular |
|
Issues
978
| https://github.com/angular/angular/issues |
|
Pull requests
164
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
| https://github.com/angular/angular/projects |
|
Security and quality
24
| https://github.com/angular/angular/security |
|
Insights
| https://github.com/angular/angular/pulse |
|
Code
| https://github.com/angular/angular |
|
Issues
| https://github.com/angular/angular/issues |
|
Pull requests
| https://github.com/angular/angular/pulls |
|
Discussions
| https://github.com/angular/angular/discussions |
|
Actions
| https://github.com/angular/angular/actions |
|
Projects
| https://github.com/angular/angular/projects |
|
Security and quality
| https://github.com/angular/angular/security |
|
Insights
| https://github.com/angular/angular/pulse |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:ci-aio-puppeteer | https://github.com/gkalpak/angular/tree/ci-aio-puppeteer |
| Conversation | https://github.com/angular/angular/pull/35381 |
| Commits3 (3) | https://github.com/angular/angular/pull/35381/commits |
| Checks | https://github.com/angular/angular/pull/35381/checks |
| Files changed | https://github.com/angular/angular/pull/35381/files |
| build: several minor fixes related to using puppeteer | https://github.com/angular/angular/pull/35381#top |
| gkalpak | https://github.com/gkalpak |
| angular:master | https://github.com/angular/angular/tree/master |
| gkalpak:ci-aio-puppeteer | https://github.com/gkalpak/angular/tree/ci-aio-puppeteer |
|
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Feb 12, 2020 | https://github.com/angular/angular/pull/35381#issue-564050505 |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| #35049 | https://github.com/angular/angular/pull/35049 |
| #35049 | https://github.com/angular/angular/pull/35049 |
| recommended way | https://github.com/GoogleChrome/lighthouse/blame/51df179a0/docs/puppeteer.md#L49 |
| #35049 | https://github.com/angular/angular/pull/35049 |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Feb 12, 2020 | https://github.com/angular/angular/pull/35381#event-3031107488 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Feb 12, 2020 | https://github.com/angular/angular/pull/35381#issuecomment-585246293 |
| https://pr35381-2a973b2.ngbuilds.io/ | https://pr35381-2a973b2.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/2a973b28fe1ab26aac7f7a63961722b3118e3783..ccfcce988fba93514bf107dc30492655f47e7378 |
| 2a973b2 | https://github.com/angular/angular/commit/2a973b28fe1ab26aac7f7a63961722b3118e3783 |
| ccfcce9 | https://github.com/angular/angular/commit/ccfcce988fba93514bf107dc30492655f47e7378 |
|
Compare
| https://github.com/angular/angular/compare/2a973b28fe1ab26aac7f7a63961722b3118e3783..ccfcce988fba93514bf107dc30492655f47e7378 |
| February 12, 2020 17:04 | https://github.com/angular/angular/pull/35381#event-3031663072 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Feb 12, 2020 | https://github.com/angular/angular/pull/35381#issuecomment-585314539 |
| https://pr35381-ccfcce9.ngbuilds.io/ | https://pr35381-ccfcce9.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/ccfcce988fba93514bf107dc30492655f47e7378..6026d09466247391862863b9dd1ff4cefcdbfc45 |
| ccfcce9 | https://github.com/angular/angular/commit/ccfcce988fba93514bf107dc30492655f47e7378 |
| 6026d09 | https://github.com/angular/angular/commit/6026d09466247391862863b9dd1ff4cefcdbfc45 |
|
Compare
| https://github.com/angular/angular/compare/ccfcce988fba93514bf107dc30492655f47e7378..6026d09466247391862863b9dd1ff4cefcdbfc45 |
| February 12, 2020 17:26 | https://github.com/angular/angular/pull/35381#event-3031739803 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Feb 12, 2020 | https://github.com/angular/angular/pull/35381#issuecomment-585323971 |
| https://pr35381-6026d09.ngbuilds.io/ | https://pr35381-6026d09.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/6026d09466247391862863b9dd1ff4cefcdbfc45..6302c41f31fe06049b202819a3d90122599ac90e |
| 6026d09 | https://github.com/angular/angular/commit/6026d09466247391862863b9dd1ff4cefcdbfc45 |
| 6302c41 | https://github.com/angular/angular/commit/6302c41f31fe06049b202819a3d90122599ac90e |
|
Compare
| https://github.com/angular/angular/compare/6026d09466247391862863b9dd1ff4cefcdbfc45..6302c41f31fe06049b202819a3d90122599ac90e |
| February 12, 2020 17:49 | https://github.com/angular/angular/pull/35381#event-3031817103 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Feb 12, 2020 | https://github.com/angular/angular/pull/35381#issuecomment-585335527 |
| https://pr35381-6302c41.ngbuilds.io/ | https://pr35381-6302c41.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| https://github.com/kara |
| kara | https://github.com/kara |
|
area: build & ci
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22 |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#event-3033049430 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#event-3033049563 |
| gkalpak | https://github.com/gkalpak |
| February 13, 2020 16:46 | https://github.com/angular/angular/pull/35381#commits-pushed-f8726c3 |
|
| https://github.com/gkalpak |
| build: several minor fixes related to using puppeteer | https://github.com/angular/angular/pull/35381/commits/f8726c36cc7153be8cd31aca4b611d6aed60b655 |
| f8726c3 | https://github.com/angular/angular/pull/35381/commits/f8726c36cc7153be8cd31aca4b611d6aed60b655 |
| angular#35049 | https://github.com/angular/angular/pull/35049 |
| https://github.com/GoogleChrome/lighthouse/blame/51df179a0/docs/puppeteer.md#L49 | https://github.com/GoogleChrome/lighthouse/blame/51df179a0/docs/puppeteer.md#L49 |
|
| https://github.com/gkalpak |
| build(docs-infra): use puppeteer to get a browser for docs examples… | https://github.com/angular/angular/pull/35381/commits/863b8e54323b053b72847895723b5399b6b50582 |
| 863b8e5 | https://github.com/angular/angular/pull/35381/commits/863b8e54323b053b72847895723b5399b6b50582 |
| angular#35049 | https://github.com/angular/angular/pull/35049 |
|
| https://github.com/gkalpak |
| ci: get rid of the CI_CHROMEDRIVER_VERSION_ARG env var | https://github.com/angular/angular/pull/35381/commits/6dd6ffed99d5b193264365c52f5b170a8229c90e |
| 6dd6ffe | https://github.com/angular/angular/pull/35381/commits/6dd6ffed99d5b193264365c52f5b170a8229c90e |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| force-pushed | https://github.com/angular/angular/compare/6302c41f31fe06049b202819a3d90122599ac90e..6dd6ffed99d5b193264365c52f5b170a8229c90e |
| 6302c41 | https://github.com/angular/angular/commit/6302c41f31fe06049b202819a3d90122599ac90e |
| 6dd6ffe | https://github.com/angular/angular/commit/6dd6ffed99d5b193264365c52f5b170a8229c90e |
|
Compare
| https://github.com/angular/angular/compare/6302c41f31fe06049b202819a3d90122599ac90e..6dd6ffed99d5b193264365c52f5b170a8229c90e |
| February 13, 2020 15:15 | https://github.com/angular/angular/pull/35381#event-3035270414 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#event-3035305676 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
comp: docs-infra
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20docs-infra%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#event-3035312477 |
| https://github.com/mary-poppins |
| mary-poppins | https://github.com/mary-poppins |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#issuecomment-585814331 |
| 6dd6ffe | https://github.com/angular/angular/commit/6dd6ffed99d5b193264365c52f5b170a8229c90e |
| https://pr35381-6dd6ffe.ngbuilds.io/ | https://pr35381-6dd6ffe.ngbuilds.io/ |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| https://github.com/gregmagolan |
| gregmagolan | https://github.com/gregmagolan |
|
Feb 13, 2020
| https://github.com/angular/angular/pull/35381#pullrequestreview-358388503 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35381/files/6dd6ffed99d5b193264365c52f5b170a8229c90e |
| .circleci/env.sh | https://github.com/angular/angular/pull/35381/files/6dd6ffed99d5b193264365c52f5b170a8229c90e#diff-40c1cb3e6417a58d8d42b50a8f1a6e59e8f8a1f835d7737be305c8938e5661b7 |
| gregmagolan | https://github.com/gregmagolan |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#discussion_r378991103 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| gregmagolan | https://github.com/gregmagolan |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#discussion_r378998060 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| https://github.com/gregmagolan |
| gregmagolan | https://github.com/gregmagolan |
|
Feb 13, 2020
| https://github.com/angular/angular/pull/35381#pullrequestreview-358389559 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35381/files/6dd6ffed99d5b193264365c52f5b170a8229c90e |
| aio/karma.conf.js | https://github.com/angular/angular/pull/35381/files/6dd6ffed99d5b193264365c52f5b170a8229c90e#diff-dc7a8b336791eaee217a34e800522ff1d1148b32b2b4ad65e7301206afd27a71 |
| gregmagolan | https://github.com/gregmagolan |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#discussion_r378991888 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| gkalpak | https://github.com/gkalpak |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#discussion_r379000996 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| https://github.com/gregmagolan |
| gregmagolan | https://github.com/gregmagolan |
|
Feb 13, 2020
| https://github.com/angular/angular/pull/35381#pullrequestreview-358389860 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35381/files/6dd6ffed99d5b193264365c52f5b170a8229c90e |
| aio/scripts/audit-web-app.js | https://github.com/angular/angular/pull/35381/files/6dd6ffed99d5b193264365c52f5b170a8229c90e#diff-e551a4b6f098398c13d3c20bfa4673e2bb483b9db9edc6463d226eacd6344c4d |
| gregmagolan | https://github.com/gregmagolan |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#discussion_r378992101 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| https://github.com/gregmagolan |
| gregmagolan | https://github.com/gregmagolan |
|
Feb 13, 2020
| https://github.com/angular/angular/pull/35381#pullrequestreview-358395896 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35381/files/6dd6ffed99d5b193264365c52f5b170a8229c90e |
| scripts/webdriver-manager-update.js | https://github.com/angular/angular/pull/35381/files/6dd6ffed99d5b193264365c52f5b170a8229c90e#diff-89912aef0d8b488b5df910638fd59e3ae13fbd9f74cc0c9bb852282cd1eb94fa |
| gregmagolan | https://github.com/gregmagolan |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#discussion_r378997113 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @josephperrott | https://github.com/josephperrott |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| gregmagolan | https://github.com/gregmagolan |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#discussion_r378997470 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| gkalpak | https://github.com/gkalpak |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#discussion_r379002680 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| gregmagolan | https://github.com/gregmagolan |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#discussion_r379004436 |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| josephperrott | https://github.com/josephperrott |
| Feb 13, 2020 | https://github.com/angular/angular/pull/35381#discussion_r379023718 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| gregmagolan | https://github.com/gregmagolan |
| Feb 14, 2020 | https://github.com/angular/angular/pull/35381#discussion_r379229922 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @josephperrott | https://github.com/josephperrott |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| February 13, 2020 18:46 | https://github.com/angular/angular/pull/35381#event-3036083953 |
| https://github.com/gregmagolan |
| gregmagolan | https://github.com/gregmagolan |
|
Feb 14, 2020
| https://github.com/angular/angular/pull/35381#ref-pullrequest-525597778 |
|
build: npm_integration_test && angular_integration_test
#33927
| https://github.com/angular/angular/pull/33927 |
| https://github.com/gregmagolan |
| gregmagolan | https://github.com/gregmagolan |
| February 16, 2020 17:46 | https://github.com/angular/angular/pull/35381#event-3041717300 |
| https://github.com/gregmagolan |
| gregmagolan | https://github.com/gregmagolan |
|
Feb 16, 2020
| https://github.com/angular/angular/pull/35381#pullrequestreview-359418566 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35381/files/6dd6ffed99d5b193264365c52f5b170a8229c90e |
| gregmagolan | https://github.com/gregmagolan |
| https://github.com/angular/angular/pull/35381#pullrequestreview-359418566 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| #33927 | https://github.com/angular/angular/pull/33927 |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| https://github.com/gregmagolan |
| gregmagolan | https://github.com/gregmagolan |
| Feb 16, 2020 | https://github.com/angular/angular/pull/35381#issuecomment-586733450 |
| #33927 | https://github.com/angular/angular/pull/33927 |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| josephperrott | https://github.com/josephperrott |
| February 17, 2020 12:49 | https://github.com/angular/angular/pull/35381#event-3043590060 |
| https://github.com/josephperrott |
| josephperrott | https://github.com/josephperrott |
|
Feb 18, 2020
| https://github.com/angular/angular/pull/35381#pullrequestreview-360490430 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35381/files/6dd6ffed99d5b193264365c52f5b170a8229c90e |
| josephperrott | https://github.com/josephperrott |
| https://github.com/angular/angular/pull/35381#pullrequestreview-360490430 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| alxhub | https://github.com/alxhub |
|
Feb 18, 2020
| https://github.com/angular/angular/pull/35381#ref-commit-598b3ff |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| build: several minor fixes related to using | https://github.com/angular/angular/commit/598b3ff5d760bbbcf85ea619c77e38c0b1284dce |
| puppeteer | https://github.com/angular/angular/commit/598b3ff5d760bbbcf85ea619c77e38c0b1284dce |
| ( | https://github.com/angular/angular/commit/598b3ff5d760bbbcf85ea619c77e38c0b1284dce |
| #35381 | https://github.com/angular/angular/pull/35381 |
| ) | https://github.com/angular/angular/commit/598b3ff5d760bbbcf85ea619c77e38c0b1284dce |
| 598b3ff | https://github.com/angular/angular/commit/598b3ff5d760bbbcf85ea619c77e38c0b1284dce |
| #35049 | https://github.com/angular/angular/pull/35049 |
| https://github.com/GoogleChrome/lighthouse/blame/51df179a0/docs/puppeteer.md#L49 | https://github.com/GoogleChrome/lighthouse/blame/51df179a0/docs/puppeteer.md#L49 |
| #35381 | https://github.com/angular/angular/pull/35381 |
| alxhub | https://github.com/alxhub |
|
Feb 18, 2020
| https://github.com/angular/angular/pull/35381#ref-commit-cf28373 |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| build(docs-infra): use puppeteer to get a browser for docs examples… | https://github.com/angular/angular/commit/cf283736292ca0321779129dfa716eb181413f7e |
| cf28373 | https://github.com/angular/angular/commit/cf283736292ca0321779129dfa716eb181413f7e |
| #35381 | https://github.com/angular/angular/pull/35381 |
| #35049 | https://github.com/angular/angular/pull/35049 |
| #35381 | https://github.com/angular/angular/pull/35381 |
| alxhub | https://github.com/alxhub |
|
Feb 18, 2020
| https://github.com/angular/angular/pull/35381#ref-commit-83d68b3 |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| ci: get rid of the | https://github.com/angular/angular/commit/83d68b35216c12d46e3bd25f92828722fc0583e4 |
| CI_CHROMEDRIVER_VERSION_ARG | https://github.com/angular/angular/commit/83d68b35216c12d46e3bd25f92828722fc0583e4 |
| env var ( | https://github.com/angular/angular/commit/83d68b35216c12d46e3bd25f92828722fc0583e4 |
| #35381 | https://github.com/angular/angular/pull/35381 |
| ) | https://github.com/angular/angular/commit/83d68b35216c12d46e3bd25f92828722fc0583e4 |
| 83d68b3 | https://github.com/angular/angular/commit/83d68b35216c12d46e3bd25f92828722fc0583e4 |
| #35381 | https://github.com/angular/angular/pull/35381 |
| https://github.com/alxhub |
| alxhub | https://github.com/alxhub |
| ab8199f | https://github.com/angular/angular/commit/ab8199f7c909eaa8937d293ab44405fe263417cd |
| Feb 18, 2020 | https://github.com/angular/angular/pull/35381#event-3048754059 |
| alxhub | https://github.com/alxhub |
|
Feb 18, 2020
| https://github.com/angular/angular/pull/35381#ref-commit-bdfe71a |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| build(docs-infra): use puppeteer to get a browser for docs examples… | https://github.com/angular/angular/commit/bdfe71ae93ef3e49616e427813805bcf555a3368 |
| bdfe71a | https://github.com/angular/angular/commit/bdfe71ae93ef3e49616e427813805bcf555a3368 |
| #35381 | https://github.com/angular/angular/pull/35381 |
| #35049 | https://github.com/angular/angular/pull/35049 |
| #35381 | https://github.com/angular/angular/pull/35381 |
| alxhub | https://github.com/alxhub |
|
Feb 18, 2020
| https://github.com/angular/angular/pull/35381#ref-commit-1939676 |
|
| https://github.com/gkalpak |
|
| https://github.com/alxhub |
| ci: get rid of the | https://github.com/angular/angular/commit/19396769e297667db3f1fc756b298cbfd79eb7ea |
| CI_CHROMEDRIVER_VERSION_ARG | https://github.com/angular/angular/commit/19396769e297667db3f1fc756b298cbfd79eb7ea |
| env var ( | https://github.com/angular/angular/commit/19396769e297667db3f1fc756b298cbfd79eb7ea |
| #35381 | https://github.com/angular/angular/pull/35381 |
| ) | https://github.com/angular/angular/commit/19396769e297667db3f1fc756b298cbfd79eb7ea |
| 1939676 | https://github.com/angular/angular/commit/19396769e297667db3f1fc756b298cbfd79eb7ea |
| #35381 | https://github.com/angular/angular/pull/35381 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
| February 18, 2020 21:03 | https://github.com/angular/angular/pull/35381#event-3048816958 |
| mhevery | https://github.com/mhevery |
|
Feb 24, 2020
| https://github.com/angular/angular/pull/35381#ref-commit-561d402 |
|
| https://github.com/gregmagolan |
|
| https://github.com/mhevery |
| build: remove CI_CHROMEDIRVER_VERSION_ARG from integration/bazel-sche… | https://github.com/angular/angular/commit/561d402c652bf4ca51da9c7559d044b72f1c6295 |
| 561d402 | https://github.com/angular/angular/commit/561d402c652bf4ca51da9c7559d044b72f1c6295 |
| #33927 | https://github.com/angular/angular/pull/33927 |
| @gkalpak | https://github.com/gkalpak |
| #35381 | https://github.com/angular/angular/pull/35381 |
| #33927 | https://github.com/angular/angular/pull/33927 |
| mhevery | https://github.com/mhevery |
|
Feb 24, 2020
| https://github.com/angular/angular/pull/35381#ref-commit-9efd7af |
|
| https://github.com/gregmagolan |
|
| https://github.com/mhevery |
| build: remove CI_CHROMEDIRVER_VERSION_ARG from integration/bazel-sche… | https://github.com/angular/angular/commit/9efd7afd8ad6809dd011b10fec7f2ed7548f6415 |
| 9efd7af | https://github.com/angular/angular/commit/9efd7afd8ad6809dd011b10fec7f2ed7548f6415 |
| #33927 | https://github.com/angular/angular/pull/33927 |
| @gkalpak | https://github.com/gkalpak |
| #35381 | https://github.com/angular/angular/pull/35381 |
| #33927 | https://github.com/angular/angular/pull/33927 |
| https://github.com/gkalpak |
| gkalpak | https://github.com/gkalpak |
|
Mar 11, 2020
| https://github.com/angular/angular/pull/35381#ref-pullrequest-579350508 |
|
build(docs-infra): do not include CI-specific config in docs examples ZIP archives
#36018
| https://github.com/angular/angular/pull/36018 |
| gkalpak | https://github.com/gkalpak |
|
Mar 16, 2020
| https://github.com/angular/angular/pull/35381#ref-commit-fd45beb |
|
| https://github.com/gkalpak |
| build(docs-infra): do not include CI-specific config in docs examples… | https://github.com/gkalpak/angular/commit/fd45beb74542d1ca84702289017300841691ae70 |
| fd45beb | https://github.com/gkalpak/angular/commit/fd45beb74542d1ca84702289017300841691ae70 |
| angular#35381 | https://github.com/angular/angular/pull/35381 |
| https://v9.angular.io/generated/zips/universal/universal.zip | https://v9.angular.io/generated/zips/universal/universal.zip |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 20, 2020 | https://github.com/angular/angular/pull/35381#issuecomment-601779587 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 20, 2020 | https://github.com/angular/angular/pull/35381#event-3149949627 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35381 |
|
| https://github.com/josephperrott |
|
josephperrott
| https://github.com/josephperrott |
|
| https://github.com/angular/angular/pull/35381/files/6dd6ffed99d5b193264365c52f5b170a8229c90e |
|
| https://github.com/gregmagolan |
|
gregmagolan
| https://github.com/gregmagolan |
|
| https://github.com/angular/angular/pull/35381/files/6dd6ffed99d5b193264365c52f5b170a8229c90e |
|
action: merge
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20merge%22 |
|
area: build & ci
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20build%20%26%20ci%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
| Please reload this page | https://github.com/angular/angular/pull/35381 |
|
| https://github.com/gkalpak |
|
| https://github.com/mary-poppins |
|
| https://github.com/gregmagolan |
|
| https://github.com/josephperrott |
|
| https://github.com/kara |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |