René's URL Explorer Experiment


Title: fix(forms): Call setDisabledState in in reactive directives when appropriate by jermowery · Pull Request #35311 · angular/angular · GitHub

Open Graph Title: fix(forms): Call setDisabledState in in reactive directives when appropriate by jermowery · Pull Request #35311 · angular/angular

X Title: fix(forms): Call setDisabledState in in reactive directives when appropriate by jermowery · Pull Request #35311 · angular/angular

Description: When a CVA is added a form and that CVA implements setDisabledState the reactive form directives should call setDisabledState with true when the FormControl is disabled and false when it is enabled. Currently, setDisabledState is only called when the FormControl is disabled. Fixes #35309 PR Checklist Please check if your PR fulfills the following requirements: [ x] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit [ x] Tests for the changes have been added (for bug fixes / features) [ x] Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? [ x] Bugfix Feature Code style update (formatting, local variables) Refactoring (no functional changes, no api changes) Build related changes CI related changes Documentation content changes angular.io application / infrastructure changes Other... Please describe: What is the current behavior? setDisabledState when adding a control to a form is called with true with the FormControl is disabled and not called when the FormControl is enabled. Issue Number: #35309 What is the new behavior? setDisabledState is called when adding a control to a form with false when the FormControl is enabled and true with the FormControl is disabled. Does this PR introduce a breaking change? Yes [x ] No

Open Graph Description: When a CVA is added a form and that CVA implements setDisabledState the reactive form directives should call setDisabledState with true when the FormControl is disabled and false when it is enabled...

X Description: When a CVA is added a form and that CVA implements setDisabledState the reactive form directives should call setDisabledState with true when the FormControl is disabled and false when it is enabled...

Opengraph URL: https://github.com/angular/angular/pull/35311

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:ca2e4144-8802-27a5-3183-81a6e4cf1c1a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDB08:11EACE:1957DF2:21CFF9A:6B015069
html-safe-nonce771f026678a28e020b7a9225d075221ad2854a7b2952dd3afa183ef1fc958b15
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQjA4OjExRUFDRToxOTU3REYyOjIxQ0ZGOUE6NkIwMTUwNjkiLCJ2aXNpdG9yX2lkIjoiNjEyNTk3MDMzNjM1NDc1MDU2OSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca209a6aff3da86f764c20f00252f758e3b088ee75e9e0aa8c7fcc103ca78406e
hovercard-subject-tagpull_request:373334939
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/35311/files
twitter:imagehttps://avatars.githubusercontent.com/u/5343243?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/5343243?s=400&v=4
og:image:altWhen a CVA is added a form and that CVA implements setDisabledState the reactive form directives should call setDisabledState with true when the FormControl is disabled and false when it is enabled...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/35311/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35311%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35311%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35311/files
Reloadhttps://github.com/angular/angular/pull/35311/files
Reloadhttps://github.com/angular/angular/pull/35311/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
jermoweryhttps://github.com/jermowery
angular:masterhttps://github.com/angular/angular/tree/master
Conversation 19 https://github.com/angular/angular/pull/35311
Commits 1 https://github.com/angular/angular/pull/35311/commits
Checks 0 https://github.com/angular/angular/pull/35311/checks
Files changed https://github.com/angular/angular/pull/35311/files
Please reload this pagehttps://github.com/angular/angular/pull/35311/files
fix(forms): Call setDisabledState in in reactive directives when appropriate https://github.com/angular/angular/pull/35311/files#top
Show all changes 1 commit https://github.com/angular/angular/pull/35311/files
12f8f1e fix(forms): Call setDisabledState in in reactive directives when jermowery Feb 10, 2020 https://github.com/angular/angular/pull/35311/commits/12f8f1ede532c7c2968fd35f9e1af2aa286506dc
Clear filters https://github.com/angular/angular/pull/35311/files
Please reload this pagehttps://github.com/angular/angular/pull/35311/files
Please reload this pagehttps://github.com/angular/angular/pull/35311/files
form_control_directive.ts https://github.com/angular/angular/pull/35311/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
form_control_name.ts https://github.com/angular/angular/pull/35311/files#diff-068ee3bbf99e18f72cdf5e0a0d0cd4139c069e8a03fb271c7895c183da04d07e
value_accessor_integration_spec.ts https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
packages/forms/src/directives/reactive_directives/form_control_directive.tshttps://github.com/angular/angular/pull/35311/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
View file https://github.com/angular/angular/blob/12f8f1ede532c7c2968fd35f9e1af2aa286506dc/packages/forms/src/directives/reactive_directives/form_control_directive.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35311/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35311/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
https://github.com/angular/angular/pull/35311/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
https://github.com/angular/angular/pull/35311/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
https://github.com/angular/angular/pull/35311/files#diff-91a9a623b251651f178e957265df4fe43e0670c0dcae193d25ca64101d6425e9
packages/forms/src/directives/reactive_directives/form_control_name.tshttps://github.com/angular/angular/pull/35311/files#diff-068ee3bbf99e18f72cdf5e0a0d0cd4139c069e8a03fb271c7895c183da04d07e
View file https://github.com/angular/angular/blob/12f8f1ede532c7c2968fd35f9e1af2aa286506dc/packages/forms/src/directives/reactive_directives/form_control_name.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35311/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35311/files#diff-068ee3bbf99e18f72cdf5e0a0d0cd4139c069e8a03fb271c7895c183da04d07e
https://github.com/angular/angular/pull/35311/files#diff-068ee3bbf99e18f72cdf5e0a0d0cd4139c069e8a03fb271c7895c183da04d07e
https://github.com/angular/angular/pull/35311/files#diff-068ee3bbf99e18f72cdf5e0a0d0cd4139c069e8a03fb271c7895c183da04d07e
https://github.com/angular/angular/pull/35311/files#diff-068ee3bbf99e18f72cdf5e0a0d0cd4139c069e8a03fb271c7895c183da04d07e
packages/forms/test/value_accessor_integration_spec.tshttps://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
View file https://github.com/angular/angular/blob/12f8f1ede532c7c2968fd35f9e1af2aa286506dc/packages/forms/test/value_accessor_integration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35311/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
Please reload this pagehttps://github.com/angular/angular/pull/35311/files
https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.