| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:96d240fb-29b3-e956-fcaf-b89a6ba7cbc4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C2AE:1CEA6F:1B471EA:23E8C3A:6B014B7A |
| html-safe-nonce | e82fa8e9efb38442dca26046b8127026f164286b22c7132eee6d8d49099c8f6e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkFFOjFDRUE2RjoxQjQ3MUVBOjIzRThDM0E6NkIwMTRCN0EiLCJ2aXNpdG9yX2lkIjoiNjA2ODExMTAxMDg0NDE5OTgwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | edc1fb79e548dd7a56f02e16a87e49400d8a974f986c5c27da41e48d365a5687 |
| hovercard-subject-tag | pull_request:373334939 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/35311/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0a883cc250e92af52c96217e26afa1606091e6a13862be3f13389294282de93f/angular/angular/pull/35311 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0a883cc250e92af52c96217e26afa1606091e6a13862be3f13389294282de93f/angular/angular/pull/35311 |
| og:image:alt | When a CVA is added a form and that CVA implements setDisabledState the
reactive form directives should call setDisabledState with true when the
FormControl is disabled and false when it is enabled... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jermowery |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-cache |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | pull-requests |
| Skip to content | https://github.com/angular/angular/pull/35311#start-of-content |
| https://github.com/ |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35311 |
| GitHubRepository hosting, code review, and collaboration | https://github.com/platform |
| CopilotAI coding agent for tasks, projects, and automated work | https://github.com/features/copilot |
| ActionsCI/CD and automation | https://github.com/features/actions |
| Code QualityQuality analysis, fixes, and enforcement | https://github.com/features/code-quality |
| CodespacesCloud development environments | https://github.com/features/codespaces |
| Code SecurityVulnerability detection and remediation | https://github.com/security/advanced-security/code-security |
| Secret ProtectionSecret scanning and leak prevention | https://github.com/security/advanced-security/secret-protection |
| All Features | https://github.com/features |
| Documentation | https://docs.github.com/en |
| Training | https://learn.github.com/skills |
| Certifications | https://learn.github.com/credentials |
| Build with Copilot | https://github.com/features/ai |
| Customize Copilot | https://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview |
| Integrations | https://github.com/marketplace |
| Trending repos | https://github.com/trending |
| GitHub Sponsors | https://github.com/open-source/sponsors |
| Developer articles | https://github.com/resources/articles |
| ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place. | https://github.blog/changelog/ |
| Enterprises | https://github.com/enterprise |
| Team | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| See all industries | https://github.com/solutions/industry |
| Why GitHub | https://github.com/why-github |
| Customer Stories | https://github.com/customer-stories |
| Business insights | https://github.com/solutions/executive-insights |
| Trust Center | https://github.com/trust-center |
| GitHub Advanced SecurityEnterprise-grade code security | https://github.com/security/advanced-security |
| Copilot for businessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Documentation | https://docs.github.com/en |
| Resource center | https://github.com/resources |
| Blog | https://github.blog/ |
| Events & webinars | https://github.com/resources/events |
| Community Forum | https://github.com/orgs/community/discussions |
| Customer Stories | https://github.com/customer-stories |
| Integrations | https://github.com/marketplace |
| Customer support | https://help.github.com/ |
| Training | https://learn.github.com/skills |
| GitHub Status | https://www.githubstatus.com/ |
| About | https://github.com/about |
| Partners | https://github.com/partners |
| Changelog | https://github.blog/changelog/ |
| GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub. | https://githubuniverse.com/ |
| Pricing | https://github.com/pricing |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35311 |
| Sign up | https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular |
| Reload | https://github.com/angular/angular/pull/35311 |
| Reload | https://github.com/angular/angular/pull/35311 |
| Reload | https://github.com/angular/angular/pull/35311 |
| angular | https://github.com/angular |
| angular | https://github.com/angular/angular |
| Code | https://github.com/angular/angular |
| Issues836 (836) | https://github.com/angular/angular/issues |
| Pull requests141 (141) | https://github.com/angular/angular/pulls |
| Discussions | https://github.com/angular/angular/discussions |
| Actions | https://github.com/angular/angular/actions |
| Projects | https://github.com/angular/angular/projects |
| Security and quality40 (40) | https://github.com/angular/angular/security |
| Insights | https://github.com/angular/angular/insights |
| https://github.com/angular/angular |
| jermowery | https://github.com/jermowery |
| angular:master | https://github.com/angular/angular/tree/master |
| Conversation | https://github.com/angular/angular/pull/35311 |
| Commits1 (1) | https://github.com/angular/angular/pull/35311/commits |
| Checks | https://github.com/angular/angular/pull/35311/checks |
| Files changed | https://github.com/angular/angular/pull/35311/files |
| fix(forms): Call setDisabledState in in reactive directives when appropriate | https://github.com/angular/angular/pull/35311#top |
| jermowery | https://github.com/jermowery |
| angular:master | https://github.com/angular/angular/tree/master |
|
| https://github.com/jermowery |
| jermowery | https://github.com/jermowery |
| Feb 10, 2020 | https://github.com/angular/angular/pull/35311#issue-562805830 |
| #35309 | https://github.com/angular/angular/issues/35309 |
| https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit | https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit |
| #35309 | https://github.com/angular/angular/issues/35309 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/googlebot |
| googlebot | https://github.com/googlebot |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
| Feb 10, 2020 | https://github.com/angular/angular/pull/35311#event-3024231594 |
| https://github.com/apps/pullapprove |
| pullapprove | https://github.com/apps/pullapprove |
| AndrewKushnir | https://github.com/AndrewKushnir |
| February 10, 2020 20:23 | https://github.com/angular/angular/pull/35311#event-3024231708 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Feb 11, 2020
| https://github.com/angular/angular/pull/35311#pullrequestreview-356360908 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35311/files |
| AndrewKushnir | https://github.com/AndrewKushnir |
| https://github.com/angular/angular/pull/35311#pullrequestreview-356360908 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @jermowery | https://github.com/jermowery |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| packages/forms/test/value_accessor_integration_spec.ts | https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| packages/forms/test/value_accessor_integration_spec.ts | https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| packages/forms/test/value_accessor_integration_spec.ts | https://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
area: forms
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
| Feb 11, 2020 | https://github.com/angular/angular/pull/35311#event-3024888147 |
| https://github.com/apps/ngbot |
| ngbot | https://github.com/apps/ngbot |
| needsTriage | https://github.com/angular/angular/milestone/83 |
| Feb 11, 2020 | https://github.com/angular/angular/pull/35311#event-3024888182 |
| https://github.com/jermowery |
| jermowery | https://github.com/jermowery |
| Feb 11, 2020 | https://github.com/angular/angular/pull/35311#issuecomment-584442640 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
|
| https://github.com/jermowery |
| fix(forms): Call setDisabledState in in reactive directives when | https://github.com/angular/angular/pull/35311/commits/12f8f1ede532c7c2968fd35f9e1af2aa286506dc |
| 12f8f1e | https://github.com/angular/angular/pull/35311/commits/12f8f1ede532c7c2968fd35f9e1af2aa286506dc |
| #35309 | https://github.com/angular/angular/issues/35309 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| kara | https://github.com/kara |
| February 11, 2020 02:20 | https://github.com/angular/angular/pull/35311#event-3025039856 |
| https://github.com/jermowery |
| jermowery | https://github.com/jermowery |
| AndrewKushnir | https://github.com/AndrewKushnir |
| kara | https://github.com/kara |
| February 11, 2020 02:22 | https://github.com/angular/angular/pull/35311#event-3025042164 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Feb 11, 2020
| https://github.com/angular/angular/pull/35311#pullrequestreview-356390051 |
|
View reviewed changes
| https://github.com/angular/angular/pull/35311/files/12f8f1ede532c7c2968fd35f9e1af2aa286506dc |
| AndrewKushnir | https://github.com/AndrewKushnir |
| https://github.com/angular/angular/pull/35311#pullrequestreview-356390051 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @jermowery | https://github.com/jermowery |
| @kara | https://github.com/kara |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/jermowery |
| jermowery | https://github.com/jermowery |
| Feb 11, 2020 | https://github.com/angular/angular/pull/35311#issuecomment-584455394 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| kara | https://github.com/kara |
| February 11, 2020 02:34 | https://github.com/angular/angular/pull/35311#event-3025057098 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Mar 24, 2020
| https://github.com/angular/angular/pull/35311#ref-pullrequest-586963413 |
|
fix(forms): fix enabling form control after it was disabled
#36227
| https://github.com/angular/angular/pull/36227 |
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| Mar 29, 2020 | https://github.com/angular/angular/pull/35311#issuecomment-605692167 |
| @jermowery | https://github.com/jermowery |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/jermowery |
| jermowery | https://github.com/jermowery |
| Mar 30, 2020 | https://github.com/angular/angular/pull/35311#issuecomment-606009803 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
| Mar 30, 2020 | https://github.com/angular/angular/pull/35311#event-3179884588 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Jun 9, 2020 | https://github.com/angular/angular/pull/35311#issuecomment-641547892 |
| #18575 | https://github.com/angular/angular/pull/18575 |
| #17806 | https://github.com/angular/angular/issues/17806 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Jun 10, 2020 | https://github.com/angular/angular/pull/35311#issuecomment-641750162 |
| @jermowery | https://github.com/jermowery |
| defined here | https://github.com/angular/angular/blob/d1ea1f4c7f3358b730b0d94e65b00bc28cae279c/packages/forms/src/form_providers.ts#L55-L64 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/jermowery |
| jermowery | https://github.com/jermowery |
| Jun 10, 2020 | https://github.com/angular/angular/pull/35311#issuecomment-641770207 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/sonukapoor |
| sonukapoor | https://github.com/sonukapoor |
| Jun 10, 2020 | https://github.com/angular/angular/pull/35311#issuecomment-641958174 |
| @jermowery | https://github.com/jermowery |
| @AndrewKushnir | https://github.com/AndrewKushnir |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/grosch |
| grosch | https://github.com/grosch |
| Jul 21, 2020 | https://github.com/angular/angular/pull/35311#issuecomment-662148314 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/mohamed-gara |
| mohamed-gara | https://github.com/mohamed-gara |
| Jul 29, 2020 | https://github.com/angular/angular/pull/35311#issuecomment-665442219 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| #20310 | https://github.com/angular/angular/pull/20310 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
|
fix(forms): fix disabled attribute handling
#18575
| https://github.com/angular/angular/pull/18575 |
|
fix(forms): disable radio inputs in template driven forms
#20310
| https://github.com/angular/angular/pull/20310 |
| https://github.com/Jakartoine |
| Jakartoine | https://github.com/Jakartoine |
| Feb 9, 2021 | https://github.com/angular/angular/pull/35311#issuecomment-776066550 |
| @AndrewKushnir | https://github.com/AndrewKushnir |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
| Feb 10, 2021 | https://github.com/angular/angular/pull/35311#issuecomment-776414760 |
| @Jakartoine | https://github.com/Jakartoine |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/Jakartoine |
| Jakartoine | https://github.com/Jakartoine |
| Feb 10, 2021 | https://github.com/angular/angular/pull/35311#issuecomment-776536892 |
| @AndrewKushnir | https://github.com/AndrewKushnir |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/AndrewKushnir |
| AndrewKushnir | https://github.com/AndrewKushnir |
|
Apr 14, 2021
| https://github.com/angular/angular/pull/35311#ref-pullrequest-857543281 |
|
fix(forms): toggle disabled attribute when replacing control
#41609
| https://github.com/angular/angular/pull/41609 |
| https://github.com/JoostK |
| JoostK | https://github.com/JoostK |
|
Sep 18, 2021
| https://github.com/angular/angular/pull/35311#ref-pullrequest-999989764 |
|
fix(forms): not picking up disabled state if group is swapped out and disabled
#43499
| https://github.com/angular/angular/pull/43499 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 24, 2022 | https://github.com/angular/angular/pull/35311#issuecomment-1077791604 |
| automatic conversation locking policy | https://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
| https://github.com/apps/angular-automatic-lock-bot |
| angular-automatic-lock-bot | https://github.com/apps/angular-automatic-lock-bot |
| Mar 24, 2022 | https://github.com/angular/angular/pull/35311#event-6300752004 |
| https://github.co/hiddenchars |
| https://github.com/angular/angular/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35311 |
|
| https://github.com/AndrewKushnir |
|
AndrewKushnir
| https://github.com/AndrewKushnir |
|
| https://github.com/angular/angular/pull/35311/files/12f8f1ede532c7c2968fd35f9e1af2aa286506dc |
|
| https://github.com/kara |
|
kara
| https://github.com/kara |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
|
action: review
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22 |
|
area: forms
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22 |
|
breaking changes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22 |
|
cla: yes
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22 |
|
state: blocked
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22 |
|
target: patch
| https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22 |
|
needsTriage
| https://github.com/angular/angular/milestone/83 |
|
FormControlDirective and FormControlName do not call setDisabledState on ControlValueAcessor instances when the CVA is added and is enabled
| https://github.com/angular/angular/issues/35309 |
| Please reload this page | https://github.com/angular/angular/pull/35311 |
|
| https://github.com/jermowery |
|
| https://github.com/sonukapoor |
|
| https://github.com/AndrewKushnir |
|
| https://github.com/grosch |
|
| https://github.com/mohamed-gara |
|
| https://github.com/Jakartoine |
|
| https://github.com/googlebot |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |