René's URL Explorer Experiment


Title: fix(forms): Call setDisabledState in in reactive directives when appropriate by jermowery · Pull Request #35311 · angular/angular · GitHub

Open Graph Title: fix(forms): Call setDisabledState in in reactive directives when appropriate by jermowery · Pull Request #35311 · angular/angular

X Title: fix(forms): Call setDisabledState in in reactive directives when appropriate by jermowery · Pull Request #35311 · angular/angular

Description: Deliver web apps with confidence 🚀. Contribute to angular/angular development by creating an account on GitHub.

Open Graph Description: When a CVA is added a form and that CVA implements setDisabledState the reactive form directives should call setDisabledState with true when the FormControl is disabled and false when it is enabled...

X Description: When a CVA is added a form and that CVA implements setDisabledState the reactive form directives should call setDisabledState with true when the FormControl is disabled and false when it is enabled...

Opengraph URL: https://github.com/angular/angular/pull/35311

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:96d240fb-29b3-e956-fcaf-b89a6ba7cbc4
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC2AE:1CEA6F:1B471EA:23E8C3A:6B014B7A
html-safe-noncee82fa8e9efb38442dca26046b8127026f164286b22c7132eee6d8d49099c8f6e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkFFOjFDRUE2RjoxQjQ3MUVBOjIzRThDM0E6NkIwMTRCN0EiLCJ2aXNpdG9yX2lkIjoiNjA2ODExMTAxMDg0NDE5OTgwMiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacedc1fb79e548dd7a56f02e16a87e49400d8a974f986c5c27da41e48d365a5687
hovercard-subject-tagpull_request:373334939
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/angular/angular/35311/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/0a883cc250e92af52c96217e26afa1606091e6a13862be3f13389294282de93f/angular/angular/pull/35311
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0a883cc250e92af52c96217e26afa1606091e6a13862be3f13389294282de93f/angular/angular/pull/35311
og:image:altWhen a CVA is added a form and that CVA implements setDisabledState the reactive form directives should call setDisabledState with true when the FormControl is disabled and false when it is enabled...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejermowery
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-cache
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-namepull-requests

Links:

Skip to contenthttps://github.com/angular/angular/pull/35311#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35311
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35311
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35311
Reloadhttps://github.com/angular/angular/pull/35311
Reloadhttps://github.com/angular/angular/pull/35311
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
jermoweryhttps://github.com/jermowery
angular:masterhttps://github.com/angular/angular/tree/master
Conversationhttps://github.com/angular/angular/pull/35311
Commits1 (1)https://github.com/angular/angular/pull/35311/commits
Checkshttps://github.com/angular/angular/pull/35311/checks
Files changedhttps://github.com/angular/angular/pull/35311/files
fix(forms): Call setDisabledState in in reactive directives when appropriatehttps://github.com/angular/angular/pull/35311#top
jermoweryhttps://github.com/jermowery
angular:masterhttps://github.com/angular/angular/tree/master
https://github.com/jermowery
jermoweryhttps://github.com/jermowery
Feb 10, 2020https://github.com/angular/angular/pull/35311#issue-562805830
#35309https://github.com/angular/angular/issues/35309
https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commithttps://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
#35309https://github.com/angular/angular/issues/35309
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/googlebot
googlebothttps://github.com/googlebot
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
Feb 10, 2020https://github.com/angular/angular/pull/35311#event-3024231594
https://github.com/apps/pullapprove
pullapprovehttps://github.com/apps/pullapprove
AndrewKushnirhttps://github.com/AndrewKushnir
February 10, 2020 20:23https://github.com/angular/angular/pull/35311#event-3024231708
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Feb 11, 2020 https://github.com/angular/angular/pull/35311#pullrequestreview-356360908
View reviewed changes https://github.com/angular/angular/pull/35311/files
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/35311#pullrequestreview-356360908
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jermoweryhttps://github.com/jermowery
Please reload this pagehttps://github.com/angular/angular/pull/35311
packages/forms/test/value_accessor_integration_spec.tshttps://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
Please reload this pagehttps://github.com/angular/angular/pull/35311
packages/forms/test/value_accessor_integration_spec.tshttps://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
Please reload this pagehttps://github.com/angular/angular/pull/35311
packages/forms/test/value_accessor_integration_spec.tshttps://github.com/angular/angular/pull/35311/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
area: forms https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
Feb 11, 2020https://github.com/angular/angular/pull/35311#event-3024888147
https://github.com/apps/ngbot
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Feb 11, 2020https://github.com/angular/angular/pull/35311#event-3024888182
https://github.com/jermowery
jermoweryhttps://github.com/jermowery
Feb 11, 2020https://github.com/angular/angular/pull/35311#issuecomment-584442640
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/jermowery
fix(forms): Call setDisabledState in in reactive directives whenhttps://github.com/angular/angular/pull/35311/commits/12f8f1ede532c7c2968fd35f9e1af2aa286506dc
12f8f1ehttps://github.com/angular/angular/pull/35311/commits/12f8f1ede532c7c2968fd35f9e1af2aa286506dc
#35309https://github.com/angular/angular/issues/35309
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
karahttps://github.com/kara
February 11, 2020 02:20https://github.com/angular/angular/pull/35311#event-3025039856
https://github.com/jermowery
jermoweryhttps://github.com/jermowery
AndrewKushnirhttps://github.com/AndrewKushnir
karahttps://github.com/kara
February 11, 2020 02:22https://github.com/angular/angular/pull/35311#event-3025042164
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Feb 11, 2020 https://github.com/angular/angular/pull/35311#pullrequestreview-356390051
View reviewed changes https://github.com/angular/angular/pull/35311/files/12f8f1ede532c7c2968fd35f9e1af2aa286506dc
AndrewKushnirhttps://github.com/AndrewKushnir
https://github.com/angular/angular/pull/35311#pullrequestreview-356390051
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
@jermoweryhttps://github.com/jermowery
@karahttps://github.com/kara
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/jermowery
jermoweryhttps://github.com/jermowery
Feb 11, 2020https://github.com/angular/angular/pull/35311#issuecomment-584455394
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
karahttps://github.com/kara
February 11, 2020 02:34https://github.com/angular/angular/pull/35311#event-3025057098
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Mar 24, 2020 https://github.com/angular/angular/pull/35311#ref-pullrequest-586963413
fix(forms): fix enabling form control after it was disabled #36227 https://github.com/angular/angular/pull/36227
https://github.com/sonukapoor
sonukapoorhttps://github.com/sonukapoor
Mar 29, 2020https://github.com/angular/angular/pull/35311#issuecomment-605692167
@jermoweryhttps://github.com/jermowery
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/jermowery
jermoweryhttps://github.com/jermowery
Mar 30, 2020https://github.com/angular/angular/pull/35311#issuecomment-606009803
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
breaking changes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22
Mar 30, 2020https://github.com/angular/angular/pull/35311#event-3179884588
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 9, 2020https://github.com/angular/angular/pull/35311#issuecomment-641547892
#18575https://github.com/angular/angular/pull/18575
#17806https://github.com/angular/angular/issues/17806
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Jun 10, 2020https://github.com/angular/angular/pull/35311#issuecomment-641750162
@jermoweryhttps://github.com/jermowery
defined herehttps://github.com/angular/angular/blob/d1ea1f4c7f3358b730b0d94e65b00bc28cae279c/packages/forms/src/form_providers.ts#L55-L64
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/jermowery
jermoweryhttps://github.com/jermowery
Jun 10, 2020https://github.com/angular/angular/pull/35311#issuecomment-641770207
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/sonukapoor
sonukapoorhttps://github.com/sonukapoor
Jun 10, 2020https://github.com/angular/angular/pull/35311#issuecomment-641958174
@jermoweryhttps://github.com/jermowery
@AndrewKushnirhttps://github.com/AndrewKushnir
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/grosch
groschhttps://github.com/grosch
Jul 21, 2020https://github.com/angular/angular/pull/35311#issuecomment-662148314
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/mohamed-gara
mohamed-garahttps://github.com/mohamed-gara
Jul 29, 2020https://github.com/angular/angular/pull/35311#issuecomment-665442219
Please reload this pagehttps://github.com/angular/angular/pull/35311
#20310https://github.com/angular/angular/pull/20310
Please reload this pagehttps://github.com/angular/angular/pull/35311
fix(forms): fix disabled attribute handling #18575 https://github.com/angular/angular/pull/18575
fix(forms): disable radio inputs in template driven forms #20310 https://github.com/angular/angular/pull/20310
https://github.com/Jakartoine
Jakartoinehttps://github.com/Jakartoine
Feb 9, 2021https://github.com/angular/angular/pull/35311#issuecomment-776066550
@AndrewKushnirhttps://github.com/AndrewKushnir
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Feb 10, 2021https://github.com/angular/angular/pull/35311#issuecomment-776414760
@Jakartoinehttps://github.com/Jakartoine
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/Jakartoine
Jakartoinehttps://github.com/Jakartoine
Feb 10, 2021https://github.com/angular/angular/pull/35311#issuecomment-776536892
@AndrewKushnirhttps://github.com/AndrewKushnir
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
Apr 14, 2021 https://github.com/angular/angular/pull/35311#ref-pullrequest-857543281
fix(forms): toggle disabled attribute when replacing control #41609 https://github.com/angular/angular/pull/41609
https://github.com/JoostK
JoostKhttps://github.com/JoostK
Sep 18, 2021 https://github.com/angular/angular/pull/35311#ref-pullrequest-999989764
fix(forms): not picking up disabled state if group is swapped out and disabled #43499 https://github.com/angular/angular/pull/43499
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 24, 2022https://github.com/angular/angular/pull/35311#issuecomment-1077791604
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
Mar 24, 2022https://github.com/angular/angular/pull/35311#event-6300752004
https://github.co/hiddenchars
https://github.com/angular/angular/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35311
https://github.com/AndrewKushnir
AndrewKushnir https://github.com/AndrewKushnir
https://github.com/angular/angular/pull/35311/files/12f8f1ede532c7c2968fd35f9e1af2aa286506dc
https://github.com/kara
kara https://github.com/kara
Please reload this pagehttps://github.com/angular/angular/pull/35311
action: review https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22action%3A%20review%22
area: forms https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
breaking changes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22breaking%20changes%22
cla: yes https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22cla%3A%20yes%22
state: blocked https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20blocked%22
target: patch https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22target%3A%20patch%22
needsTriage https://github.com/angular/angular/milestone/83
FormControlDirective and FormControlName do not call setDisabledState on ControlValueAcessor instances when the CVA is added and is enabled https://github.com/angular/angular/issues/35309
Please reload this pagehttps://github.com/angular/angular/pull/35311
https://github.com/jermowery
https://github.com/sonukapoor
https://github.com/AndrewKushnir
https://github.com/grosch
https://github.com/mohamed-gara
https://github.com/Jakartoine
https://github.com/googlebot
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.