René's URL Explorer Experiment


Title: Fix/35119 strict emit type by hmil · Pull Request #35300 · angular/angular · GitHub

Open Graph Title: Fix/35119 strict emit type by hmil · Pull Request #35300 · angular/angular

X Title: Fix/35119 strict emit type by hmil · Pull Request #35300 · angular/angular

Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests for the changes have been added (for bug fixes / features) Docs have been added / updated (for bug fixes / features) PR Type What kind of change does this PR introduce? Bugfix What is the current behavior? Change the type of EventEmitter to make it "more" type safe. Issue Number: #35119 This error is not caught and will cause bugs at runtime: const em = new EventEmitter; em.next(); // <- No value provided will feed `undefined` where `number` is expected What is the new behavior? This error is caught by TypeScript const em = new EventEmitter; em.next(); // <- Expected 1 argument to `next()` but 0 arguments provided However, this valid behavior is still permitted: const em = new EventEmitter(); em.next(); // <- This is OK because we did not specify what em is supposed to emit In this PR, the default template type of EventEmitter is set to EventEmitter. This is a strongly opinionated choice which favors safety. It might break code which expected the previous typing. It's also perfectly valid to keep the previous default of EventEmitter. I find that using is the safest alternative. It's more straightforward: emit() takes as argument exactly the type you specified in the template brackets, including no argument if you specified nothing. is dangerous because the template argument may have been omitted by mistake and the user is unaware that the EventEmitter's data is not type checked. The previous design was loose by default and let you opt-in strictness: defaults to any, allows more specific type to be provided. (noob friendly, but gets in the way of advanced users) The new design is strict by default and lets you opt-out of strictness: defaults to void, but allows any to be specified. (ninja-friendly, but gets in the way of noobs). What to chose depends on who is the primary audience of angular. Either way it's a breaking change. Does this PR introduce a breaking change? Yes No It's no longer possible to have an event emitter type which sometimes accepts arguments and sometimes not. It's either one but not both: const em = new EventEmitter(); em.next(); // OK em.next(something); // Not OK const em2 = new EventEmitter(); em2.next(); // Not OK em2.next(something); // OK In the second example above, em2.next(); should be replaced with em2.next(undefined); Note that if you want to stick to the same API as RxJS, then wait on this PR to know what they chose to do: ReactiveX/rxjs#5307 Other information

Open Graph Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

X Description: PR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...

Opengraph URL: https://github.com/angular/angular/pull/35300

X: @github

direct link

Domain: github.com

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:a141533f-821d-add4-920f-fe7e45645d6c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD656:13C1CF:497719:61B995:6B017775
html-safe-nonce61cc4551b5402f3090c0cc376f1bdab619e52de2701655d8c5821843ffec4b5c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENjU2OjEzQzFDRjo0OTc3MTk6NjFCOTk1OjZCMDE3Nzc1IiwidmlzaXRvcl9pZCI6IjQxMDczMTI4NTgwMDg3NDU4NDUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac68a633a953093038f6b4d5989fe8c47bd3c3cd4d3497039e79ca933425535dd8
hovercard-subject-tagpull_request:373235378
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/angular/angular/pull/35300/files
twitter:imagehttps://avatars.githubusercontent.com/u/1753085?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1753085?s=400&v=4
og:image:altPR Checklist Please check if your PR fulfills the following requirements: The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit Tests f...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/angular/angular/pull/35300/files#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35300%2Ffiles
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fpull%2F35300%2Ffiles
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/pull/35300/files
Reloadhttps://github.com/angular/angular/pull/35300/files
Reloadhttps://github.com/angular/angular/pull/35300/files
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
Sign up for GitHub https://github.com/signup?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fangular%2Fangular%2Fissues%2Fnew%2Fchoose
hmilhttps://github.com/hmil
angular:masterhttps://github.com/angular/angular/tree/master
hmil:fix/35119-strict-emit-typehttps://github.com/hmil/angular/tree/fix/35119-strict-emit-type
Conversation 11 https://github.com/angular/angular/pull/35300
Commits 10 https://github.com/angular/angular/pull/35300/commits
Checks 0 https://github.com/angular/angular/pull/35300/checks
Files changed https://github.com/angular/angular/pull/35300/files
Please reload this pagehttps://github.com/angular/angular/pull/35300/files
Fix/35119 strict emit type https://github.com/angular/angular/pull/35300/files#top
Show all changes 10 commits https://github.com/angular/angular/pull/35300/files
51a0966 feat(core): stricter event emitter type Feb 10, 2020 https://github.com/angular/angular/pull/35300/commits/51a09661b4e16c0073935448e7e1f0f85d4259cb
c4b73c1 test: regenerate golden api hmil Feb 28, 2020 https://github.com/angular/angular/pull/35300/commits/c4b73c1915eb275d11260399d563d157c603295f
91f8c25 fix: test hmil Feb 29, 2020 https://github.com/angular/angular/pull/35300/commits/91f8c25d29e4be93d8b38c7bf562fcac98fa695c
93beb7d fix: more stuff hmil Feb 29, 2020 https://github.com/angular/angular/pull/35300/commits/93beb7d7c9a1aece4ee0c50c52b5b5d341488809
fdec265 feat(core): stricter event emitter type Feb 10, 2020 https://github.com/angular/angular/pull/35300/commits/fdec265cdc17dba5d26b57d346bc6909fb6676ba
953399e fix: regenerate golden Mar 4, 2020 https://github.com/angular/angular/pull/35300/commits/953399eec33fe8b21adcb9e508a2aebd75bd95ac
508a243 fix: tests Mar 4, 2020 https://github.com/angular/angular/pull/35300/commits/508a243366ca568e4cba4370cc852b787425d23d
507d26c fix: more tests Mar 4, 2020 https://github.com/angular/angular/pull/35300/commits/507d26ce856db5642ca0b7c4cd3df1c57dde4eb2
c29fe5e fix: tests Mar 4, 2020 https://github.com/angular/angular/pull/35300/commits/c29fe5e500269d6f81e20a865394900daa619ace
e1e7e7c refactor: regenerate golden Mar 6, 2020 https://github.com/angular/angular/pull/35300/commits/e1e7e7c471ebd30222896f35fcc1f73684985ed2
Clear filters https://github.com/angular/angular/pull/35300/files
Please reload this pagehttps://github.com/angular/angular/pull/35300/files
Please reload this pagehttps://github.com/angular/angular/pull/35300/files
index.ts https://github.com/angular/angular/pull/35300/files#diff-b6b0c6bc38958f93124b63d3cf1066f9d6683b0d8e6557ae93c9f74217ee9a38
event_emitter.ts https://github.com/angular/angular/pull/35300/files#diff-cabfd3a3938669f0dc3d50767ae7d2339a479cb52e12818040a6de97e784ab45
di_spec.ts https://github.com/angular/angular/pull/35300/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
directive_spec.ts https://github.com/angular/angular/pull/35300/files#diff-573d84b132e644ffd34003bee055ee4a593848c91c4666c4a3eda776b4f9792f
listener_spec.ts https://github.com/angular/angular/pull/35300/files#diff-075339f9e4a42539479dccdcf149cc9a3aef6cedbfef8dd63c6419c8f1c73e88
property_binding_spec.ts https://github.com/angular/angular/pull/35300/files#diff-33060b9e120e053163819d9c775c9cc51f2e8bbb8079967f75dae6bd77fe0783
event_emitter_spec.ts https://github.com/angular/angular/pull/35300/files#diff-3c5065e0ebbf65c250d201e0c664c02eb7770f4295cabc21ba53e29d5be534e0
integration_spec.ts https://github.com/angular/angular/pull/35300/files#diff-6c4b76ffae8d7951899be9c4be6c3d7ed2147cca8d29c71a31f31fda563f4fc3
slots_spec.ts https://github.com/angular/angular/pull/35300/files#diff-7f8bd7e41e63268e8feaff88196043c16639c2335de5f2728856370ed6795577
module.ts https://github.com/angular/angular/pull/35300/files#diff-01abd59fc3c9ef7e7951a3339784db25b0c46fdb29ff16dda2c50f16949476b0
ng_form.ts https://github.com/angular/angular/pull/35300/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
ng_model.ts https://github.com/angular/angular/pull/35300/files#diff-4714f02e4014696c01817bc1ee6722de8273f1e462b0f7c8aa38541a246ed3e2
form_group_directive.ts https://github.com/angular/angular/pull/35300/files#diff-9cb5d1b189b18d581fd86d7fe18441182c05ea70c16ed73103041ddfaf0b303d
form_control_spec.ts https://github.com/angular/angular/pull/35300/files#diff-e94f8a568f970a765b8476b3eb23a785d95cc34a10223554b492ab989d848e40
form_group_spec.ts https://github.com/angular/angular/pull/35300/files#diff-c2ef6b8c8640ad612f7d5ccb48922532b3fccc682983581468c8ffd609ea409c
value_accessor_integration_spec.ts https://github.com/angular/angular/pull/35300/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
upgrade_spec.ts https://github.com/angular/angular/pull/35300/files#diff-66f287ea69b8b7077ade04f3399f180351b48cff4b0f24a944cecfdc55a14ac2
downgrade_component_spec.ts https://github.com/angular/angular/pull/35300/files#diff-f7877ae6930f23da87c72aa776f7205cb8b18b4eee8bd7c5d7abbadeabace91b
upgrade_component_spec.ts https://github.com/angular/angular/pull/35300/files#diff-772a6912884e7ac787e2e0ad65f707d63a545d04ee3fbeb7eb659d9ff9e16018
core.d.ts https://github.com/angular/angular/pull/35300/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
forms.d.ts https://github.com/angular/angular/pull/35300/files#diff-2d651ef51425887f75838b5a53b1ec9b3343c3cb4f2b890624958587a27f876c
modules/playground/src/order_management/index.tshttps://github.com/angular/angular/pull/35300/files#diff-b6b0c6bc38958f93124b63d3cf1066f9d6683b0d8e6557ae93c9f74217ee9a38
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/modules/playground/src/order_management/index.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-b6b0c6bc38958f93124b63d3cf1066f9d6683b0d8e6557ae93c9f74217ee9a38
https://github.com/angular/angular/pull/35300/files#diff-b6b0c6bc38958f93124b63d3cf1066f9d6683b0d8e6557ae93c9f74217ee9a38
packages/core/src/event_emitter.tshttps://github.com/angular/angular/pull/35300/files#diff-cabfd3a3938669f0dc3d50767ae7d2339a479cb52e12818040a6de97e784ab45
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/core/src/event_emitter.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-cabfd3a3938669f0dc3d50767ae7d2339a479cb52e12818040a6de97e784ab45
https://github.com/angular/angular/pull/35300/files#diff-cabfd3a3938669f0dc3d50767ae7d2339a479cb52e12818040a6de97e784ab45
https://github.com/angular/angular/pull/35300/files#diff-cabfd3a3938669f0dc3d50767ae7d2339a479cb52e12818040a6de97e784ab45
packages/core/test/acceptance/di_spec.tshttps://github.com/angular/angular/pull/35300/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/core/test/acceptance/di_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
https://github.com/angular/angular/pull/35300/files#diff-ece22a8d8ae1405b0b70f8824055ccc962cd82206fcdc9932dfd754885e31be3
packages/core/test/acceptance/directive_spec.tshttps://github.com/angular/angular/pull/35300/files#diff-573d84b132e644ffd34003bee055ee4a593848c91c4666c4a3eda776b4f9792f
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/core/test/acceptance/directive_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-573d84b132e644ffd34003bee055ee4a593848c91c4666c4a3eda776b4f9792f
https://github.com/angular/angular/pull/35300/files#diff-573d84b132e644ffd34003bee055ee4a593848c91c4666c4a3eda776b4f9792f
https://github.com/angular/angular/pull/35300/files#diff-573d84b132e644ffd34003bee055ee4a593848c91c4666c4a3eda776b4f9792f
https://github.com/angular/angular/pull/35300/files#diff-573d84b132e644ffd34003bee055ee4a593848c91c4666c4a3eda776b4f9792f
packages/core/test/acceptance/listener_spec.tshttps://github.com/angular/angular/pull/35300/files#diff-075339f9e4a42539479dccdcf149cc9a3aef6cedbfef8dd63c6419c8f1c73e88
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/core/test/acceptance/listener_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-075339f9e4a42539479dccdcf149cc9a3aef6cedbfef8dd63c6419c8f1c73e88
https://github.com/angular/angular/pull/35300/files#diff-075339f9e4a42539479dccdcf149cc9a3aef6cedbfef8dd63c6419c8f1c73e88
packages/core/test/acceptance/property_binding_spec.tshttps://github.com/angular/angular/pull/35300/files#diff-33060b9e120e053163819d9c775c9cc51f2e8bbb8079967f75dae6bd77fe0783
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/core/test/acceptance/property_binding_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-33060b9e120e053163819d9c775c9cc51f2e8bbb8079967f75dae6bd77fe0783
https://github.com/angular/angular/pull/35300/files#diff-33060b9e120e053163819d9c775c9cc51f2e8bbb8079967f75dae6bd77fe0783
https://github.com/angular/angular/pull/35300/files#diff-33060b9e120e053163819d9c775c9cc51f2e8bbb8079967f75dae6bd77fe0783
https://github.com/angular/angular/pull/35300/files#diff-33060b9e120e053163819d9c775c9cc51f2e8bbb8079967f75dae6bd77fe0783
packages/core/test/event_emitter_spec.tshttps://github.com/angular/angular/pull/35300/files#diff-3c5065e0ebbf65c250d201e0c664c02eb7770f4295cabc21ba53e29d5be534e0
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/core/test/event_emitter_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-3c5065e0ebbf65c250d201e0c664c02eb7770f4295cabc21ba53e29d5be534e0
https://github.com/angular/angular/pull/35300/files#diff-3c5065e0ebbf65c250d201e0c664c02eb7770f4295cabc21ba53e29d5be534e0
packages/core/test/linker/integration_spec.tshttps://github.com/angular/angular/pull/35300/files#diff-6c4b76ffae8d7951899be9c4be6c3d7ed2147cca8d29c71a31f31fda563f4fc3
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/core/test/linker/integration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-6c4b76ffae8d7951899be9c4be6c3d7ed2147cca8d29c71a31f31fda563f4fc3
https://github.com/angular/angular/pull/35300/files#diff-6c4b76ffae8d7951899be9c4be6c3d7ed2147cca8d29c71a31f31fda563f4fc3
https://github.com/angular/angular/pull/35300/files#diff-6c4b76ffae8d7951899be9c4be6c3d7ed2147cca8d29c71a31f31fda563f4fc3
https://github.com/angular/angular/pull/35300/files#diff-6c4b76ffae8d7951899be9c4be6c3d7ed2147cca8d29c71a31f31fda563f4fc3
https://github.com/angular/angular/pull/35300/files#diff-6c4b76ffae8d7951899be9c4be6c3d7ed2147cca8d29c71a31f31fda563f4fc3
https://github.com/angular/angular/pull/35300/files#diff-6c4b76ffae8d7951899be9c4be6c3d7ed2147cca8d29c71a31f31fda563f4fc3
packages/elements/test/slots_spec.tshttps://github.com/angular/angular/pull/35300/files#diff-7f8bd7e41e63268e8feaff88196043c16639c2335de5f2728856370ed6795577
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/elements/test/slots_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-7f8bd7e41e63268e8feaff88196043c16639c2335de5f2728856370ed6795577
https://github.com/angular/angular/pull/35300/files#diff-7f8bd7e41e63268e8feaff88196043c16639c2335de5f2728856370ed6795577
packages/examples/upgrade/static/ts/full/module.tshttps://github.com/angular/angular/pull/35300/files#diff-01abd59fc3c9ef7e7951a3339784db25b0c46fdb29ff16dda2c50f16949476b0
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/examples/upgrade/static/ts/full/module.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-01abd59fc3c9ef7e7951a3339784db25b0c46fdb29ff16dda2c50f16949476b0
https://github.com/angular/angular/pull/35300/files#diff-01abd59fc3c9ef7e7951a3339784db25b0c46fdb29ff16dda2c50f16949476b0
packages/forms/src/directives/ng_form.tshttps://github.com/angular/angular/pull/35300/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/forms/src/directives/ng_form.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
https://github.com/angular/angular/pull/35300/files#diff-5ef5ad0bd690197e16549a88150273123730c9d3305b94f4177c73420cb14834
packages/forms/src/directives/ng_model.tshttps://github.com/angular/angular/pull/35300/files#diff-4714f02e4014696c01817bc1ee6722de8273f1e462b0f7c8aa38541a246ed3e2
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/forms/src/directives/ng_model.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-4714f02e4014696c01817bc1ee6722de8273f1e462b0f7c8aa38541a246ed3e2
https://github.com/angular/angular/pull/35300/files#diff-4714f02e4014696c01817bc1ee6722de8273f1e462b0f7c8aa38541a246ed3e2
packages/forms/src/directives/reactive_directives/form_group_directive.tshttps://github.com/angular/angular/pull/35300/files#diff-9cb5d1b189b18d581fd86d7fe18441182c05ea70c16ed73103041ddfaf0b303d
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/forms/src/directives/reactive_directives/form_group_directive.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-9cb5d1b189b18d581fd86d7fe18441182c05ea70c16ed73103041ddfaf0b303d
https://github.com/angular/angular/pull/35300/files#diff-9cb5d1b189b18d581fd86d7fe18441182c05ea70c16ed73103041ddfaf0b303d
https://github.com/angular/angular/pull/35300/files#diff-9cb5d1b189b18d581fd86d7fe18441182c05ea70c16ed73103041ddfaf0b303d
https://github.com/angular/angular/pull/35300/files#diff-9cb5d1b189b18d581fd86d7fe18441182c05ea70c16ed73103041ddfaf0b303d
packages/forms/test/form_control_spec.tshttps://github.com/angular/angular/pull/35300/files#diff-e94f8a568f970a765b8476b3eb23a785d95cc34a10223554b492ab989d848e40
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/forms/test/form_control_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-e94f8a568f970a765b8476b3eb23a785d95cc34a10223554b492ab989d848e40
https://github.com/angular/angular/pull/35300/files#diff-e94f8a568f970a765b8476b3eb23a785d95cc34a10223554b492ab989d848e40
packages/forms/test/form_group_spec.tshttps://github.com/angular/angular/pull/35300/files#diff-c2ef6b8c8640ad612f7d5ccb48922532b3fccc682983581468c8ffd609ea409c
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/forms/test/form_group_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-c2ef6b8c8640ad612f7d5ccb48922532b3fccc682983581468c8ffd609ea409c
https://github.com/angular/angular/pull/35300/files#diff-c2ef6b8c8640ad612f7d5ccb48922532b3fccc682983581468c8ffd609ea409c
packages/forms/test/value_accessor_integration_spec.tshttps://github.com/angular/angular/pull/35300/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/forms/test/value_accessor_integration_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
https://github.com/angular/angular/pull/35300/files#diff-dc4eb48bb5a95ea8340536a6f86a90525d878ce93ab5cd4195846e326e317698
packages/upgrade/src/dynamic/test/upgrade_spec.tshttps://github.com/angular/angular/pull/35300/files#diff-66f287ea69b8b7077ade04f3399f180351b48cff4b0f24a944cecfdc55a14ac2
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/upgrade/src/dynamic/test/upgrade_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-66f287ea69b8b7077ade04f3399f180351b48cff4b0f24a944cecfdc55a14ac2
https://github.com/angular/angular/pull/35300/files#diff-66f287ea69b8b7077ade04f3399f180351b48cff4b0f24a944cecfdc55a14ac2
https://github.com/angular/angular/pull/35300/files#diff-66f287ea69b8b7077ade04f3399f180351b48cff4b0f24a944cecfdc55a14ac2
https://github.com/angular/angular/pull/35300/files#diff-66f287ea69b8b7077ade04f3399f180351b48cff4b0f24a944cecfdc55a14ac2
packages/upgrade/static/test/integration/downgrade_component_spec.tshttps://github.com/angular/angular/pull/35300/files#diff-f7877ae6930f23da87c72aa776f7205cb8b18b4eee8bd7c5d7abbadeabace91b
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/upgrade/static/test/integration/downgrade_component_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-f7877ae6930f23da87c72aa776f7205cb8b18b4eee8bd7c5d7abbadeabace91b
https://github.com/angular/angular/pull/35300/files#diff-f7877ae6930f23da87c72aa776f7205cb8b18b4eee8bd7c5d7abbadeabace91b
https://github.com/angular/angular/pull/35300/files#diff-f7877ae6930f23da87c72aa776f7205cb8b18b4eee8bd7c5d7abbadeabace91b
https://github.com/angular/angular/pull/35300/files#diff-f7877ae6930f23da87c72aa776f7205cb8b18b4eee8bd7c5d7abbadeabace91b
packages/upgrade/static/test/integration/upgrade_component_spec.tshttps://github.com/angular/angular/pull/35300/files#diff-772a6912884e7ac787e2e0ad65f707d63a545d04ee3fbeb7eb659d9ff9e16018
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/packages/upgrade/static/test/integration/upgrade_component_spec.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-772a6912884e7ac787e2e0ad65f707d63a545d04ee3fbeb7eb659d9ff9e16018
https://github.com/angular/angular/pull/35300/files#diff-772a6912884e7ac787e2e0ad65f707d63a545d04ee3fbeb7eb659d9ff9e16018
tools/public_api_guard/core/core.d.tshttps://github.com/angular/angular/pull/35300/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/tools/public_api_guard/core/core.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
https://github.com/angular/angular/pull/35300/files#diff-8f388213507c63c8d3b02879f66c9c72dd806fcce074db55ea9dac818f4e8de8
tools/public_api_guard/forms/forms.d.tshttps://github.com/angular/angular/pull/35300/files#diff-2d651ef51425887f75838b5a53b1ec9b3343c3cb4f2b890624958587a27f876c
View file https://github.com/hmil/angular/blob/e1e7e7c471ebd30222896f35fcc1f73684985ed2/tools/public_api_guard/forms/forms.d.ts
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/angular/angular/pull/35300/{{ revealButtonHref }}
https://github.com/angular/angular/pull/35300/files#diff-2d651ef51425887f75838b5a53b1ec9b3343c3cb4f2b890624958587a27f876c
https://github.com/angular/angular/pull/35300/files#diff-2d651ef51425887f75838b5a53b1ec9b3343c3cb4f2b890624958587a27f876c
https://github.com/angular/angular/pull/35300/files#diff-2d651ef51425887f75838b5a53b1ec9b3343c3cb4f2b890624958587a27f876c
https://github.com/angular/angular/pull/35300/files#diff-2d651ef51425887f75838b5a53b1ec9b3343c3cb4f2b890624958587a27f876c
https://github.com/angular/angular/pull/35300/files#diff-2d651ef51425887f75838b5a53b1ec9b3343c3cb4f2b890624958587a27f876c
https://github.com/angular/angular/pull/35300/files#diff-2d651ef51425887f75838b5a53b1ec9b3343c3cb4f2b890624958587a27f876c
https://github.com/angular/angular/pull/35300/files#diff-2d651ef51425887f75838b5a53b1ec9b3343c3cb4f2b890624958587a27f876c
https://github.com/angular/angular/pull/35300/files#diff-2d651ef51425887f75838b5a53b1ec9b3343c3cb4f2b890624958587a27f876c
https://github.com/angular/angular/pull/35300/files#diff-2d651ef51425887f75838b5a53b1ec9b3343c3cb4f2b890624958587a27f876c
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.